From 8febcb4286943d8712673c0f0e60d5c6ccb1bb92 Mon Sep 17 00:00:00 2001 From: "Vitaliy.Bibaev" Date: Fri, 12 Jan 2018 15:50:26 +0300 Subject: [PATCH] Fix wrong month numeration --- .../src/com/intellij/stats/personalization/impl/DayImpl.kt | 4 +++- .../intellij/stats/personalization/AggregatedFactorTest.kt | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/plugins/stats-collector/src/com/intellij/stats/personalization/impl/DayImpl.kt b/plugins/stats-collector/src/com/intellij/stats/personalization/impl/DayImpl.kt index 315710fff28f..89ffc49dd19b 100644 --- a/plugins/stats-collector/src/com/intellij/stats/personalization/impl/DayImpl.kt +++ b/plugins/stats-collector/src/com/intellij/stats/personalization/impl/DayImpl.kt @@ -44,7 +44,9 @@ class DayImpl(date: Date) : Day { val calendar = Calendar.getInstance() calendar.time = date dayOfMonth = calendar.get(Calendar.DAY_OF_MONTH) - month = calendar.get(Calendar.MONTH) + // a month is a zero-based property for some reason + // see details: https://stackoverflow.com/questions/344380/why-is-january-month-0-in-java-calendar + month = calendar.get(Calendar.MONTH) + 1 year = calendar.get(Calendar.YEAR) } diff --git a/plugins/stats-collector/test/com/intellij/stats/personalization/AggregatedFactorTest.kt b/plugins/stats-collector/test/com/intellij/stats/personalization/AggregatedFactorTest.kt index 07d0fddc25a2..8248bfc51f7f 100644 --- a/plugins/stats-collector/test/com/intellij/stats/personalization/AggregatedFactorTest.kt +++ b/plugins/stats-collector/test/com/intellij/stats/personalization/AggregatedFactorTest.kt @@ -11,14 +11,14 @@ import java.util.* */ class AggregatedFactorTest : UsefulTestCase() { private companion object { - val DATE_1 = DateUtil.byDate(Calendar.Builder().setDate(2010, 1, 1).build().time) + val DATE_1 = DateUtil.byDate(Calendar.Builder().setDate(2010, 0, 1).build().time) val DATE_2 = DATE_1.update(1) val DATE_3 = DATE_1.update(2) val DATE_4 = DATE_1.update(3) fun Day.update(count: Int): Day { return Calendar.getInstance().let { - it.set(year, month, dayOfMonth) + it.set(year, month - 1, dayOfMonth) it.add(Calendar.DATE, count) DateUtil.byDate(it.time) } -- 2.32.0