From 5028edd38cc51001aceeea8ffb7736e5feab30c3 Mon Sep 17 00:00:00 2001 From: Pavel Dolgov Date: Fri, 11 Nov 2016 18:48:10 +0300 Subject: [PATCH] Java: Moved text message to the resource bundle in the inspection "Non-accessible type is exposed" (IDEA-162768) --- .../Java9NonAccessibleTypeExposedInspection.java | 12 ++++++++---- .../src/messages/InspectionsBundle.properties | 2 ++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/java19modules/Java9NonAccessibleTypeExposedInspection.java b/java/java-analysis-impl/src/com/intellij/codeInspection/java19modules/Java9NonAccessibleTypeExposedInspection.java index 773d54d39a2d..b46e4b46d0b8 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/java19modules/Java9NonAccessibleTypeExposedInspection.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/java19modules/Java9NonAccessibleTypeExposedInspection.java @@ -17,6 +17,7 @@ package com.intellij.codeInspection.java19modules; import com.intellij.codeInsight.daemon.impl.analysis.JavaModuleGraphUtil; import com.intellij.codeInspection.BaseJavaLocalInspectionTool; +import com.intellij.codeInspection.InspectionsBundle; import com.intellij.codeInspection.ProblemsHolder; import com.intellij.openapi.module.Module; import com.intellij.openapi.roots.ModuleFileIndex; @@ -66,7 +67,6 @@ public class Java9NonAccessibleTypeExposedInspection extends BaseJavaLocalInspec } private static class NonAccessibleTypeExposedVisitor extends JavaElementVisitor { - public static final String CLASS_IS_NOT_EXPORTED = "The class is not exported from the module"; private final ProblemsHolder myHolder; private final ModuleFileIndex myModuleFileIndex; private final Set myExportedPackageNames; @@ -118,12 +118,12 @@ public class Java9NonAccessibleTypeExposedInspection extends BaseJavaLocalInspec if (isInModuleSource(annotationClass) && !isModulePublicApi(annotationClass)) { PsiAnnotationOwner owner = annotation.getOwner(); if (isModulePublicApi(owner)) { - myHolder.registerProblem(referenceElement, CLASS_IS_NOT_EXPORTED); + registerProblem(referenceElement); } if (owner instanceof PsiParameter) { PsiElement parent = ((PsiParameter)owner).getParent(); if (parent instanceof PsiMember && isModulePublicApi((PsiMember)parent)) { - myHolder.registerProblem(referenceElement, CLASS_IS_NOT_EXPORTED); + registerProblem(referenceElement); } } } @@ -161,7 +161,7 @@ public class Java9NonAccessibleTypeExposedInspection extends BaseJavaLocalInspec private void checkType(@Nullable PsiClass psiClass, @NotNull PsiElement typeElement) { if (psiClass != null && !(psiClass instanceof PsiTypeParameter) && isInModuleSource(psiClass) && !isModulePublicApi(psiClass)) { - myHolder.registerProblem(typeElement, CLASS_IS_NOT_EXPORTED); + registerProblem(typeElement); } } @@ -250,5 +250,9 @@ public class Java9NonAccessibleTypeExposedInspection extends BaseJavaLocalInspec } return false; } + + private void registerProblem(PsiElement element) { + myHolder.registerProblem(element, InspectionsBundle.message("inspection.non.accessible.type.exposed.name")); + } } } diff --git a/platform/platform-resources-en/src/messages/InspectionsBundle.properties b/platform/platform-resources-en/src/messages/InspectionsBundle.properties index 3621d0745433..b6a59deb0449 100644 --- a/platform/platform-resources-en/src/messages/InspectionsBundle.properties +++ b/platform/platform-resources-en/src/messages/InspectionsBundle.properties @@ -466,6 +466,8 @@ inspection.compiler.javac.quirks.anno.array.comma.fix=Remove trailing comma inspection.compiler.javac.quirks.qualifier.type.args.problem=Generics in qualifier reference may cause compilation error in some Javac versions (e.g. JDK 5 and JDK 6). inspection.compiler.javac.quirks.qualifier.type.args.fix=Remove generic parameter +inspection.non.accessible.type.exposed.name=The class is not exported from the module + inspection.root.node.title=Inspections # inspection tools list actions: -- 2.32.0