From 3e426bc5d95c3841fb8aa3a41a273936d864a8a2 Mon Sep 17 00:00:00 2001 From: Valentina Kiryushkina Date: Sat, 6 Aug 2016 18:33:10 +0300 Subject: [PATCH] Fix recommendation getting if non-code recommendation was received: we shouldn't get lesson id from task opened in editor --- .../stepic/EduAdaptiveStepicConnector.java | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/python/educational-core/student/src/com/jetbrains/edu/learning/stepic/EduAdaptiveStepicConnector.java b/python/educational-core/student/src/com/jetbrains/edu/learning/stepic/EduAdaptiveStepicConnector.java index 77e4a2a8333e..582f546cea9b 100644 --- a/python/educational-core/student/src/com/jetbrains/edu/learning/stepic/EduAdaptiveStepicConnector.java +++ b/python/educational-core/student/src/com/jetbrains/edu/learning/stepic/EduAdaptiveStepicConnector.java @@ -101,18 +101,12 @@ public class EduAdaptiveStepicConnector { if (step.block.name.equals("code")) { return getTaskFromStep(project, stepId, step.block, realLesson.getName()); } - else { - final StudyEditor editor = StudyUtils.getSelectedStudyEditor(project); - if (editor != null && editor.getTaskFile() != null) { - final StepicUser user = StudyTaskManager.getInstance(project).getUser(); - postRecommendationReaction(project, String.valueOf(editor.getTaskFile().getTask().getLesson().getId()), - String.valueOf(user.getId()), -1); - return getNextRecommendation(project, course); - } - } } - LOG.warn("Got a lesson without code part as a recommendation"); + final StepicUser user = StudyTaskManager.getInstance(project).getUser(); + postRecommendationReaction(project, lessonId, + String.valueOf(user.getId()), -1); + return getNextRecommendation(project, course); } else { LOG.warn("Got unexpected number of lessons: " + lessonContainer.lessons.size()); -- 2.32.0