idea/community.git
4 years agoMerge branch 'feature/ext-point-for-sdk-comparator' of https://github.com/da1z/intell...
Dmitry Trofimov [Tue, 25 Apr 2017 18:47:10 +0000 (20:47 +0200)]
Merge branch 'feature/ext-point-for-sdk-comparator' of https://github.com/da1z/intellij-community

4 years agoDon't check whether SDK home path exists on a local disk if it is a remote one
Dmitry Trofimov [Tue, 25 Apr 2017 18:30:14 +0000 (20:30 +0200)]
Don't check whether SDK home path exists on a local disk if it is a remote one

4 years agoFix possible exception
Dmitry Trofimov [Thu, 13 Apr 2017 14:57:52 +0000 (16:57 +0200)]
Fix possible exception

4 years agoPY-23653 UI freeze fixed on establishing connection for Start SSH session... action
Alexander Koshevoy [Tue, 25 Apr 2017 17:54:42 +0000 (20:54 +0300)]
PY-23653 UI freeze fixed on establishing connection for Start SSH session... action

4 years agoUse Kotlin 1.1.2 release
Dmitry Jemerov [Tue, 25 Apr 2017 17:25:39 +0000 (19:25 +0200)]
Use Kotlin 1.1.2 release

4 years agoIDEA-170592 Choose Content to Paste Dialog (Ctrl+Shift+V) only highlights the first...
Dmitry Batrak [Tue, 25 Apr 2017 17:30:09 +0000 (20:30 +0300)]
IDEA-170592 Choose Content to Paste Dialog (Ctrl+Shift+V) only highlights the first match per line

following IDEA-CR-20578

4 years agoMerge remote-tracking branch 'origin/master' appcode/172.1769
Vladimir.Orlov [Tue, 25 Apr 2017 17:15:04 +0000 (20:15 +0300)]
Merge remote-tracking branch 'origin/master'

4 years agofix tests
Vladimir.Orlov [Tue, 25 Apr 2017 17:13:45 +0000 (20:13 +0300)]
fix tests

4 years agosetSchemes — avoid "equals" call
Vladimir Krivosheev [Tue, 25 Apr 2017 16:57:08 +0000 (18:57 +0200)]
setSchemes — avoid "equals" call

4 years agoallow runWhenProjectIsInitialized to run in available modality (IDEA-171478)
peter [Tue, 25 Apr 2017 16:45:46 +0000 (18:45 +0200)]
allow runWhenProjectIsInitialized to run in available modality (IDEA-171478)

4 years agosupport boxed number comparisons in constant expression evaluation (IDEA-171861)
peter [Tue, 25 Apr 2017 16:45:37 +0000 (18:45 +0200)]
support boxed number comparisons in constant expression evaluation (IDEA-171861)

4 years agocancel previous async editor highlighter update when new one is scheduled
peter [Tue, 25 Apr 2017 16:41:12 +0000 (18:41 +0200)]
cancel previous async editor highlighter update when new one is scheduled

4 years ago1) Initialize default font (prevents isModified=true and other side effects)
Rustam Vishnyakov [Tue, 25 Apr 2017 15:32:13 +0000 (18:32 +0300)]
1) Initialize default font (prevents isModified=true and other side effects)
2) Initialize default values in PersistentFontPreferences (for IDEA-171717)

4 years agoIDEA-CR-20567 final, ServiceManager
Vladimir Krivosheev [Tue, 25 Apr 2017 16:10:17 +0000 (18:10 +0200)]
IDEA-CR-20567 final, ServiceManager

4 years agoEA-82356 - CME: SequenceIterator.next
Dmitry Avdeev [Tue, 25 Apr 2017 15:30:23 +0000 (18:30 +0300)]
EA-82356 - CME: SequenceIterator.next

4 years ago- getChildren is cancellable on write action (IDEA-18765, IDEA-117446)
Maxim.Mossienko [Tue, 25 Apr 2017 15:24:51 +0000 (17:24 +0200)]
- getChildren is cancellable on write action (IDEA-18765, IDEA-117446)
- call ProgressManager.checkCancelled in loops

4 years agomore bullet proof code for storing broken vfs errors when there is a lock contention...
Maxim.Mossienko [Tue, 25 Apr 2017 15:19:08 +0000 (17:19 +0200)]
more bullet proof code for storing broken vfs errors when there is a lock contention (IDEA-171918)

4 years agoproject view: highlight module group nodes in project view if there are files with...
nik [Tue, 25 Apr 2017 15:23:12 +0000 (18:23 +0300)]
project view: highlight module group nodes in project view if there are files with errors under them (IDEA-171965)

Implementation of 'validate' from ProjectViewNode invokes 'update' method which won't call 'postprocess' method because 'isValidating' is true, so calling 'validate' on ModuleGroupNode clears ERROR_ATTRIBUTES key set in AbstractTreeNode.postprocess. So we need to override 'validate' method and don't call 'update' from it (IDEA-171966).

4 years agoIDEA-165800 Can't download dependency's source code
Vladislav.Soroka [Tue, 25 Apr 2017 15:04:50 +0000 (18:04 +0300)]
IDEA-165800 Can't download dependency's source code

4 years agoIDEA-165089 KeymapTest.testLookingForShortcutsInParentFirstAndOnlyThenConsiderBoundAc...
Sergey Malenkov [Tue, 25 Apr 2017 15:11:55 +0000 (18:11 +0300)]
IDEA-165089 KeymapTest.testLookingForShortcutsInParentFirstAndOnlyThenConsiderBoundActions

4 years agoIDEA-165089 Use blue selection for difference with a parent keymap
Sergey Malenkov [Tue, 25 Apr 2017 15:10:51 +0000 (18:10 +0300)]
IDEA-165089 Use blue selection for difference with a parent keymap

4 years agoreplace smart pointers with vFiles during copy (EA-98503 - PIEAE: PsiUtilCore.ensureV...
Anna.Kozlova [Tue, 25 Apr 2017 14:55:49 +0000 (16:55 +0200)]
replace smart pointers with vFiles during copy (EA-98503 - PIEAE: PsiUtilCore.ensureValid)

4 years agocompletion: don't start template if Object was inferred by the parent type
Anna.Kozlova [Tue, 25 Apr 2017 14:27:04 +0000 (16:27 +0200)]
completion: don't start template if Object was inferred by the parent type

4 years agomethod chains completion: use another temp color for lookups appcode/172.1767
Dmitry Batkovich [Tue, 25 Apr 2017 14:55:44 +0000 (17:55 +0300)]
method chains completion: use another temp color for lookups

4 years agoandroid tests: double exclude
Dmitry Avdeev [Tue, 25 Apr 2017 14:51:49 +0000 (17:51 +0300)]
android tests: double exclude

4 years agoIDEA-127499 Decompiler doesn't support switch over enums
Egor.Ushakov [Tue, 25 Apr 2017 14:39:52 +0000 (17:39 +0300)]
IDEA-127499 Decompiler doesn't support switch over enums

4 years agocopyright
Egor.Ushakov [Tue, 25 Apr 2017 13:51:46 +0000 (16:51 +0300)]
copyright

4 years agoImplicitSubclassInspection shows error dialog if setting modifiers is not implemented
Nicolay Mitropolsky [Tue, 25 Apr 2017 14:38:35 +0000 (17:38 +0300)]
ImplicitSubclassInspection shows error dialog if setting modifiers is not implemented

4 years agonotnull
Alexey Kudravtsev [Tue, 25 Apr 2017 14:10:21 +0000 (17:10 +0300)]
notnull

4 years agocleanup
Alexey Kudravtsev [Tue, 25 Apr 2017 14:09:21 +0000 (17:09 +0300)]
cleanup

4 years agopath can be null in case of jdk9
Alexey Kudravtsev [Mon, 24 Apr 2017 17:43:43 +0000 (20:43 +0300)]
path can be null in case of jdk9

4 years agocleanup
Alexey Kudravtsev [Mon, 24 Apr 2017 16:07:54 +0000 (19:07 +0300)]
cleanup

4 years agonotnull
Alexey Kudravtsev [Mon, 24 Apr 2017 11:56:14 +0000 (14:56 +0300)]
notnull

4 years agoisHashBang minor optimisation
Alexey Kudravtsev [Mon, 24 Apr 2017 11:55:30 +0000 (14:55 +0300)]
isHashBang minor optimisation

4 years agoIDEA-171299 IDE is closed even I canceled exit
Gregory.Shrago [Tue, 25 Apr 2017 14:13:30 +0000 (17:13 +0300)]
IDEA-171299 IDE is closed even I canceled exit

4 years agoPY-22505: Introduce ``_DISABLE_BUFFERING`` that user may set for default test run...
Ilya.Kazakevich [Thu, 20 Apr 2017 20:37:02 +0000 (23:37 +0300)]
PY-22505: Introduce ``_DISABLE_BUFFERING`` that user may set for default test run configuration to use as workaround until runners are fixed.

Setting this variable disables buffering. May lead to output mess (i.e. stderr may go to wrong test node) but allows people to use debug console

4 years agoIDEA-171959 Incorrect error popup positioning and revalidation in DialogWrapper
Kirill Kirichenko [Tue, 25 Apr 2017 14:09:51 +0000 (17:09 +0300)]
IDEA-171959 Incorrect error popup positioning and revalidation in DialogWrapper

4 years agoAnt: replace 'ANT' by 'Ant' in plugin messages
nik [Tue, 25 Apr 2017 13:42:38 +0000 (16:42 +0300)]
Ant: replace 'ANT' by 'Ant' in plugin messages

Originally Ant was an acronym (Another Neat Tool) but now it's written everywhere as 'Ant' so it's better to always use this name in our plugin for consistency.

4 years agoinspection settings: don't show meta-languages (such as uast)
Dmitry Batkovich [Tue, 25 Apr 2017 13:37:59 +0000 (16:37 +0300)]
inspection settings: don't show meta-languages (such as uast)

4 years agomethod chain completion: fix exception on completion
Dmitry Batkovich [Tue, 25 Apr 2017 12:42:58 +0000 (15:42 +0300)]
method chain completion: fix exception on completion

4 years agoIDEA-165089 Settings: Keymap refactoring
Sergey Malenkov [Tue, 25 Apr 2017 13:32:15 +0000 (16:32 +0300)]
IDEA-165089 Settings: Keymap refactoring

4 years agoIDEA-165089 an empty implementation of importScheme instead of an abstract one
Sergey Malenkov [Tue, 25 Apr 2017 13:13:53 +0000 (16:13 +0300)]
IDEA-165089 an empty implementation of importScheme instead of an abstract one

4 years agocheck that substitutor was not invalidated as well
Anna.Kozlova [Tue, 25 Apr 2017 13:18:30 +0000 (15:18 +0200)]
check that substitutor was not invalidated as well

4 years agoSOE
Anna.Kozlova [Tue, 25 Apr 2017 12:19:05 +0000 (14:19 +0200)]
SOE

4 years agoDo not use "InspectionToolRegistrar" in "InspectionProfileImpl" directly
Konstantin Kolosovsky [Mon, 24 Apr 2017 14:58:27 +0000 (17:58 +0300)]
Do not use "InspectionToolRegistrar" in "InspectionProfileImpl" directly

Use just "Supplier<List<InspectionToolWrapper>>" instead. Update
corresponding unnecessary "InspectionToolRegistrar" inheritors.

4 years agoDo not use reserved line wrap width for wrapping plain text files
Konstantin Kolosovsky [Sun, 16 Apr 2017 14:35:33 +0000 (17:35 +0300)]
Do not use reserved line wrap width for wrapping plain text files

4 years agoRemove unnecessary "TextLineWrapPositionStrategy"
Konstantin Kolosovsky [Sun, 16 Apr 2017 11:47:43 +0000 (14:47 +0300)]
Remove unnecessary "TextLineWrapPositionStrategy"

It has the same logic as "DefaultLineWrapPositionStrategy".
Corresponding tests moved to "DefaultLineWrapPositionStrategyTest".

4 years agoHide traffic light for commit message if found problems have <= TYPO severities
Konstantin Kolosovsky [Sat, 15 Apr 2017 20:35:07 +0000 (23:35 +0300)]
Hide traffic light for commit message if found problems have <= TYPO severities

4 years agoDisplay shortcut for "Reformat commit message" quick fix
Konstantin Kolosovsky [Sat, 15 Apr 2017 20:12:46 +0000 (23:12 +0300)]
Display shortcut for "Reformat commit message" quick fix

4 years agoFix displaying shortcuts for intention actions
Konstantin Kolosovsky [Sat, 15 Apr 2017 20:09:19 +0000 (23:09 +0300)]
Fix displaying shortcuts for intention actions

Was broken in c776e564701f96c0ba126902daca5fdea8a8acc4

4 years agoUse "KeymapUtil.getActiveKeymapShortcuts()" utility method
Konstantin Kolosovsky [Sat, 15 Apr 2017 16:42:52 +0000 (19:42 +0300)]
Use "KeymapUtil.getActiveKeymapShortcuts()" utility method

4 years agoMove "CommonShortcuts.shortcutsById()" to "KeymapUtil" and rename
Konstantin Kolosovsky [Sat, 15 Apr 2017 15:48:26 +0000 (18:48 +0300)]
Move "CommonShortcuts.shortcutsById()" to "KeymapUtil" and rename

4 years agoAdd "Reformat commit message" action and quick fix
Konstantin Kolosovsky [Sat, 15 Apr 2017 15:23:19 +0000 (18:23 +0300)]
Add "Reformat commit message" action and quick fix

4 years agoAdd "Add blank line", "Wrap line" quick fixes for commit message
Konstantin Kolosovsky [Sat, 15 Apr 2017 11:23:49 +0000 (14:23 +0300)]
Add "Add blank line", "Wrap line" quick fixes for commit message

4 years agoDo not show "more..." link in problem tooltips if inspection has no description
Konstantin Kolosovsky [Fri, 14 Apr 2017 14:34:22 +0000 (17:34 +0300)]
Do not show "more..." link in problem tooltips if inspection has no description

4 years agoFix inspection results highlighting for files with custom inspection profiles
Konstantin Kolosovsky [Fri, 14 Apr 2017 14:21:16 +0000 (17:21 +0300)]
Fix inspection results highlighting for files with custom inspection profiles

4 years agoHide empty "Inspection '<name>' options" intentions for commit message
Konstantin Kolosovsky [Fri, 14 Apr 2017 14:11:06 +0000 (17:11 +0300)]
Hide empty "Inspection '<name>' options" intentions for commit message

4 years agoRun configured commit message inspections and highlight found problems
Konstantin Kolosovsky [Fri, 14 Apr 2017 13:59:32 +0000 (16:59 +0300)]
Run configured commit message inspections and highlight found problems

4 years agoDo not highlight non-default commit message inspections settings
Konstantin Kolosovsky [Fri, 14 Apr 2017 13:00:59 +0000 (16:00 +0300)]
Do not highlight non-default commit message inspections settings

4 years agoAdd commit message spell checking inspection
Konstantin Kolosovsky [Fri, 14 Apr 2017 11:57:29 +0000 (14:57 +0300)]
Add commit message spell checking inspection

We do not want to reference [spellchecker] module primarily not to get
possible cyclic dependencies (references to [spellchecker] module were
explicitly removed in 8b07149a6b8e2e9bcea8bca27aacdae030f32e66). So we
just find default spell checking inspection by name and reuse it.

4 years agoPersist commit message inspections settings
Konstantin Kolosovsky [Fri, 14 Apr 2017 11:21:58 +0000 (14:21 +0300)]
Persist commit message inspections settings

4 years agoRemove old commit message settings
Konstantin Kolosovsky [Thu, 13 Apr 2017 21:49:15 +0000 (00:49 +0300)]
Remove old commit message settings

4 years agoImplement reset/isModified/apply for commit message inspections settings
Konstantin Kolosovsky [Thu, 13 Apr 2017 21:44:09 +0000 (00:44 +0300)]
Implement reset/isModified/apply for commit message inspections settings

4 years agoAdd commit message inspections severity and options management
Konstantin Kolosovsky [Thu, 13 Apr 2017 19:05:45 +0000 (22:05 +0300)]
Add commit message inspections severity and options management

4 years agoAdd commit message inspections list to "Commit Dialog" settings
Konstantin Kolosovsky [Thu, 13 Apr 2017 12:55:30 +0000 (15:55 +0300)]
Add commit message inspections list to "Commit Dialog" settings

4 years agoRemove "Check commit message spelling" setting
Konstantin Kolosovsky [Wed, 12 Apr 2017 15:58:10 +0000 (18:58 +0300)]
Remove "Check commit message spelling" setting

Spellchecking logic and configuration will be added later using commit
message inspections

4 years agoSimplify "CommitMessage.createCommitTextEditor()"
Konstantin Kolosovsky [Wed, 12 Apr 2017 15:45:35 +0000 (18:45 +0300)]
Simplify "CommitMessage.createCommitTextEditor()"

"forceSpellCheckOn" is always false

4 years agoCheck spelling of svn copy/move messages only if configured
Konstantin Kolosovsky [Wed, 12 Apr 2017 15:24:42 +0000 (18:24 +0300)]
Check spelling of svn copy/move messages only if configured

4 years agoMove "Show unversioned files" to separate "Commit Dialog" settings group
Konstantin Kolosovsky [Tue, 28 Mar 2017 16:05:04 +0000 (19:05 +0300)]
Move "Show unversioned files" to separate "Commit Dialog" settings group

4 years agoFixed "SpellCheckingEditorCustomization" not to block other inspections
Konstantin Kolosovsky [Sat, 11 Feb 2017 10:36:53 +0000 (13:36 +0300)]
Fixed "SpellCheckingEditorCustomization" not to block other inspections

Fixed custom "InspectionProfileWrapper" provided by
"SpellCheckingEditorCustomization" not to block other inspections
besides "SpellCheckingInspection"

4 years agovcs: Enabled error stripe in commit message panel
Konstantin Kolosovsky [Fri, 10 Feb 2017 00:32:31 +0000 (03:32 +0300)]
vcs: Enabled error stripe in commit message panel

4 years agoMerge remote-tracking branch 'origin/master'
Dmitry Jemerov [Tue, 25 Apr 2017 13:11:57 +0000 (15:11 +0200)]
Merge remote-tracking branch 'origin/master'

4 years agoRemove references to menu items that haven't existed for many years
Dmitry Jemerov [Tue, 25 Apr 2017 13:10:30 +0000 (15:10 +0200)]
Remove references to menu items that haven't existed for many years

4 years agoIDEA-171900 Find in path popup isn't descriptive enough (poor feedback on search...
Vassiliy.Kudryashov [Tue, 25 Apr 2017 12:58:52 +0000 (15:58 +0300)]
IDEA-171900 Find in path popup isn't descriptive enough (poor feedback on search progress/status)

4 years agobuild tests: don't add dummy classes root when running under JDK 9 (IDEA-CR-20468)
nik [Tue, 25 Apr 2017 12:59:00 +0000 (15:59 +0300)]
build tests: don't add dummy classes root when running under JDK 9 (IDEA-CR-20468)

Previously 'file://null' URL was added to JDK classes roots, it looks strange and may lead to problems.

4 years agochainable stream provider (cloudConfig + readonly sources)
Vladimir Krivosheev [Tue, 25 Apr 2017 12:42:32 +0000 (14:42 +0200)]
chainable stream provider (cloudConfig + readonly sources)

4 years agodo not pass provider if roaming is disabled — move this logic to StateStorageManager...
Vladimir Krivosheev [Tue, 25 Apr 2017 10:43:33 +0000 (12:43 +0200)]
do not pass provider if roaming is disabled — move this logic to StateStorageManager to simplify and unify

4 years agoDefaultProjectStoreTest — use in memory fs to avoid IO
Vladimir Krivosheev [Tue, 25 Apr 2017 10:41:51 +0000 (12:41 +0200)]
DefaultProjectStoreTest — use in memory fs to avoid IO

4 years agoIDEA-170592 Choose Content to Paste Dialog (Ctrl+Shift+V) only highlights the first...
Dmitry Batrak [Tue, 25 Apr 2017 12:31:28 +0000 (15:31 +0300)]
IDEA-170592 Choose Content to Paste Dialog (Ctrl+Shift+V) only highlights the first match per line

4 years agojavac ast indices: do not add a reference to index when qualifier type is not resolved
Dmitry Batkovich [Tue, 25 Apr 2017 12:22:50 +0000 (15:22 +0300)]
javac ast indices: do not add a reference to index when qualifier type is not resolved

4 years agoCleanup (dead code; typo)
Roman Shevchenko [Tue, 25 Apr 2017 12:15:46 +0000 (14:15 +0200)]
Cleanup (dead code; typo)

4 years agojavac ast indices: add additional assertion to catch a memory leak appcode/172.1764 clion/172.1763
Dmitry Batkovich [Tue, 25 Apr 2017 11:59:18 +0000 (14:59 +0300)]
javac ast indices: add additional assertion to catch a memory leak

4 years agojava method chain completion: insert tail iterator access if needed
Dmitry Batkovich [Mon, 24 Apr 2017 16:30:47 +0000 (19:30 +0300)]
java method chain completion: insert tail iterator access if needed

4 years agoproject model: distinguish elements imported from external models
nik [Tue, 25 Apr 2017 11:53:37 +0000 (14:53 +0300)]
project model: distinguish elements imported from external models

This information is now used to show a warning if user tries to manually change dependencies of a module imported from an external model in the Project Structure dialog (IDEA-171948).

4 years agoReadWriteLockTests excluded
Dmitry Avdeev [Tue, 25 Apr 2017 11:39:45 +0000 (14:39 +0300)]
ReadWriteLockTests excluded

4 years agoJava: Fixed completion of overloaded method parameters in getDeclaredMethod("methodNa...
Pavel Dolgov [Tue, 25 Apr 2017 11:30:43 +0000 (14:30 +0300)]
Java: Fixed completion of overloaded method parameters in getDeclaredMethod("methodName", ...) (IDEA-171721)

4 years ago[parameter hints] do not use animation in bulk mode
Yaroslav Lepenkin [Tue, 25 Apr 2017 11:25:35 +0000 (14:25 +0300)]
[parameter hints] do not use animation in bulk mode

4 years ago[parameter hints] fixed isPreserveHint, since at the moment myHintText.get(offset...
Yaroslav Lepenkin [Tue, 25 Apr 2017 10:46:04 +0000 (13:46 +0300)]
[parameter hints] fixed isPreserveHint, since at the moment myHintText.get(offset) will always return null, which will cause unneeded hint replacement

4 years ago[param hints] use troove hash maps, since wrappers are evil
Yaroslav Lepenkin [Mon, 24 Apr 2017 14:01:06 +0000 (17:01 +0300)]
[param hints] use troove hash maps, since wrappers are evil

4 years ago[param hints] when soft wraps enabled and there is a lot of hints, add them in bulk...
Yaroslav Lepenkin [Mon, 24 Apr 2017 13:53:49 +0000 (16:53 +0300)]
[param hints] when soft wraps enabled and there is a lot of hints, add them in bulk mode

4 years agoUpdating versions of project dependencies: jdkBuild->u152b837.2
Anton Tarasov [Tue, 25 Apr 2017 11:21:27 +0000 (14:21 +0300)]
Updating versions of project dependencies: jdkBuild->u152b837.2

Anton Tarasov

4 years agoImplicitSubclassProvider API updates and ImplicitSubclassInspection descriptions... phpstorm/172.1762
Nicolay Mitropolsky [Tue, 25 Apr 2017 10:18:23 +0000 (13:18 +0300)]
ImplicitSubclassProvider API updates and ImplicitSubclassInspection descriptions improvements

4 years agobundle JavaEWAH as part of JGit lib pycharm/172.1760
Vladimir Krivosheev [Tue, 25 Apr 2017 10:02:35 +0000 (12:02 +0200)]
bundle JavaEWAH as part of JGit lib

4 years agoconvert ClientPropertiesManager to PersistentStateComponent
Vladimir Krivosheev [Tue, 25 Apr 2017 09:32:42 +0000 (11:32 +0200)]
convert ClientPropertiesManager to PersistentStateComponent

4 years agoFix EDU-935 ClassNotFoundException Move class to PyCharm Edu IDE src
Valentina Kiryushkina [Tue, 25 Apr 2017 09:54:45 +0000 (12:54 +0300)]
Fix EDU-935 ClassNotFoundException Move class to PyCharm Edu IDE src

4 years agoFind In Path popup: get rid of clashing mnemonics
Vassiliy.Kudryashov [Tue, 25 Apr 2017 09:50:35 +0000 (12:50 +0300)]
Find In Path popup: get rid of clashing mnemonics

4 years agoheadexprent is always single-element
Egor.Ushakov [Mon, 24 Apr 2017 17:16:57 +0000 (20:16 +0300)]
headexprent is always single-element

4 years agotoString for debugging
Egor.Ushakov [Mon, 24 Apr 2017 16:58:58 +0000 (19:58 +0300)]
toString for debugging

4 years agodo not collect field names into a separate set
Egor.Ushakov [Mon, 24 Apr 2017 16:45:23 +0000 (19:45 +0300)]
do not collect field names into a separate set

4 years agominor cleanup: avoid creating empty arrays and unneeded boxing
Egor.Ushakov [Mon, 24 Apr 2017 16:26:32 +0000 (19:26 +0300)]
minor cleanup: avoid creating empty arrays and unneeded boxing