idea/community.git
6 years agoprimitive type comparison internal inspection
Anna Kozlova [Fri, 6 Nov 2015 16:36:36 +0000 (17:36 +0100)]
primitive type comparison internal inspection

6 years agoequality -> .equals cleanup
Anna Kozlova [Fri, 6 Nov 2015 15:36:27 +0000 (16:36 +0100)]
equality -> .equals cleanup

6 years agoIDEA-146427 duplicated code
Sergey Malenkov [Fri, 6 Nov 2015 16:19:49 +0000 (19:19 +0300)]
IDEA-146427 duplicated code

6 years agoIDEA-146427 Do not create a Keymap copy if dialog is cancelled
Sergey Malenkov [Fri, 6 Nov 2015 16:12:10 +0000 (19:12 +0300)]
IDEA-146427 Do not create a Keymap copy if dialog is cancelled

6 years agovfs: support uri with custom protocol, like temp://, in VfsUtilCore#findRelativeFile...
Sergey Simonchik [Fri, 6 Nov 2015 16:40:49 +0000 (19:40 +0300)]
vfs: support uri with custom protocol, like temp://, in VfsUtilCore#findRelativeFile(uri, null)

6 years agoproper capitalization
Egor.Ushakov [Fri, 6 Nov 2015 16:19:07 +0000 (19:19 +0300)]
proper capitalization

6 years agouse LanguageUtil
Egor.Ushakov [Fri, 6 Nov 2015 15:57:56 +0000 (18:57 +0300)]
use LanguageUtil

6 years agoIDEA-147534 Inspection "@NotNull/@Nullable problems" - "Require @NotNull fileds to...
peter [Fri, 6 Nov 2015 15:46:16 +0000 (16:46 +0100)]
IDEA-147534 Inspection "@NotNull/@Nullable problems" - "Require @NotNull fileds to be initialized explicitly", does not trigger when using @NonnullByDefault

6 years agoadd 'appendable' to dictionary
peter [Fri, 6 Nov 2015 15:22:15 +0000 (16:22 +0100)]
add 'appendable' to dictionary

6 years ago[^cdr] fix data race in DumbService.runWhenSmart
peter [Fri, 6 Nov 2015 15:19:37 +0000 (16:19 +0100)]
[^cdr] fix data race in DumbService.runWhenSmart

6 years ago[git] Substitute trilead-ssh2 library with the patched one
Kirill Likhodedov [Fri, 6 Nov 2015 15:29:37 +0000 (18:29 +0300)]
[git] Substitute trilead-ssh2 library with the patched one

* Adds from no to 5 times speedup on git fetch
* The patch is made by TeamCity dev Dmitry Neverov as part of TW-14598.

6 years agofix unsorted array search
Anna Kozlova [Fri, 6 Nov 2015 15:13:59 +0000 (16:13 +0100)]
fix unsorted array search

6 years agochange signature: fix search for tags to remove in unsorted array (IDEA-147535)
Anna Kozlova [Fri, 6 Nov 2015 15:13:23 +0000 (16:13 +0100)]
change signature: fix search for tags to remove in unsorted array (IDEA-147535)

6 years agomove member: restore qualifier in switch labels for non-enum constants (IDEA-147539)
Anna Kozlova [Fri, 6 Nov 2015 14:09:47 +0000 (15:09 +0100)]
move member: restore qualifier in switch labels for non-enum constants (IDEA-147539)

6 years agotestdata for IDEA-147511
Anna Kozlova [Fri, 6 Nov 2015 12:43:17 +0000 (13:43 +0100)]
testdata for IDEA-147511

6 years agotests: allow scroll to source together with track running test as scroll should be...
Anna Kozlova [Fri, 6 Nov 2015 12:15:28 +0000 (13:15 +0100)]
tests: allow scroll to source together with track running test as scroll should be done for manual selection only

6 years agosm runner: scroll to source on manual selection only (IDEA-147403)
Anna Kozlova [Fri, 6 Nov 2015 12:11:11 +0000 (13:11 +0100)]
sm runner: scroll to source on manual selection only (IDEA-147403)

6 years agoStaticInitializerReferencesSubClassInspection: don't report private subclasses that...
peter [Fri, 6 Nov 2015 11:22:21 +0000 (12:22 +0100)]
StaticInitializerReferencesSubClassInspection: don't report private subclasses that can't be initialized by another thread

6 years agoIDEA-147454 Smart completion add parentheses to class declaration in throws statement
peter [Fri, 6 Nov 2015 10:51:14 +0000 (11:51 +0100)]
IDEA-147454 Smart completion add parentheses to class declaration in throws statement

6 years agouse consistent (and mockable) char width in tests appcode/144.901 clion/144.900
Dmitry Batrak [Fri, 6 Nov 2015 14:14:39 +0000 (17:14 +0300)]
use consistent (and mockable) char width in tests

6 years agovalidate soft wrap positions in editor stress test
Dmitry Batrak [Fri, 6 Nov 2015 08:47:37 +0000 (11:47 +0300)]
validate soft wrap positions in editor stress test

6 years ago[groovy] GroovyFindUsagesProvider: unused INSTANCE field and default constructor...
Daniil Ovchinnikov [Fri, 6 Nov 2015 13:53:11 +0000 (16:53 +0300)]
[groovy] GroovyFindUsagesProvider: unused INSTANCE field and default constructor removed

6 years ago[groovy] get presentable text in GroovyExpressionTypeProvider.
Daniil Ovchinnikov [Tue, 3 Nov 2015 13:29:46 +0000 (16:29 +0300)]
[groovy] get presentable text in GroovyExpressionTypeProvider.

It is needed to properly display `as`-coercion trait types e.g. `Foo as T1, T2` instead of `Foo`.

6 years ago[java] type annotations in method return type (IDEA-147494)
Roman Shevchenko [Fri, 6 Nov 2015 13:57:35 +0000 (14:57 +0100)]
[java] type annotations in method return type (IDEA-147494)

6 years agoworkaround for IDEA-147530: make sure that when a new light module is created it...
nik [Fri, 6 Nov 2015 13:56:23 +0000 (16:56 +0300)]
workaround for IDEA-147530: make sure that when a new light module is created it won't take settings from previously saved module

6 years agoIDEA-145612 IllegalArgumentException "invalid keyCode"
Denis Fokin [Fri, 6 Nov 2015 13:27:08 +0000 (17:27 +0400)]
IDEA-145612 IllegalArgumentException "invalid keyCode"

6 years agoShow only last days recent tests
Yaroslav Lepenkin [Fri, 6 Nov 2015 13:22:39 +0000 (16:22 +0300)]
Show only last days recent tests

6 years agoperformance test: increased time for hot file indent detection
Yaroslav Lepenkin [Fri, 6 Nov 2015 13:19:23 +0000 (16:19 +0300)]
performance test: increased time for hot file indent detection

6 years agoUnify line separators in documentation for Python keywords
Mikhail Golubev [Fri, 6 Nov 2015 12:21:59 +0000 (15:21 +0300)]
Unify line separators in documentation for Python keywords

It also fixes PyQuickDocTest#testReturnKeyword test on Windows.

6 years agoPY-17470 Fix IndexError in rest_formatter.py helper
Mikhail Golubev [Fri, 6 Nov 2015 11:35:16 +0000 (14:35 +0300)]
PY-17470 Fix IndexError in rest_formatter.py helper

This error occurs when there is no type test after colon
in `:type` and `:rtype` declarations.

6 years agoPY-17470 PY-17529 Don't attempt to remove quotes from already unescaped docstring
Mikhail Golubev [Fri, 6 Nov 2015 10:55:57 +0000 (13:55 +0300)]
PY-17470 PY-17529 Don't attempt to remove quotes from already unescaped docstring

Because PyStringLiteralExpressionImpl#getNodeTextRange used for that
strips at least first character unconditionally, user sees corrupted
docstring description without the first letter.

6 years agoFix typo in log message
Mikhail Golubev [Fri, 6 Nov 2015 10:48:29 +0000 (13:48 +0300)]
Fix typo in log message

6 years agoIDEA-146427 Entering and searching keyboard and mouse shortcuts in Settings | Keymap
Sergey Malenkov [Fri, 6 Nov 2015 13:04:07 +0000 (16:04 +0300)]
IDEA-146427 Entering and searching keyboard and mouse shortcuts in Settings | Keymap

6 years ago"initialize variable" & "initialize in constructor" suggests only public classes...
Dmitry Batkovich [Fri, 6 Nov 2015 12:59:45 +0000 (15:59 +0300)]
"initialize variable" & "initialize in constructor" suggests only public classes for collections

6 years agoIDEA-144272 - IAE at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.a
Michael Golubev [Fri, 6 Nov 2015 12:30:43 +0000 (13:30 +0100)]
IDEA-144272 - IAE at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.a

6 years ago"initialize variable" & "initialize in constructor" suggests default constructors...
Dmitry Batkovich [Fri, 6 Nov 2015 12:55:37 +0000 (15:55 +0300)]
"initialize variable" & "initialize in constructor" suggests default constructors (with inheritor's if collection) (IDEA-145431)

6 years agocorrectly render alternative sources from jdk (show something more than just rt.jar)
Egor.Ushakov [Fri, 6 Nov 2015 12:55:03 +0000 (15:55 +0300)]
correctly render alternative sources from jdk (show something more than just rt.jar)

6 years agofallback url provided when legacy key conversion is not possible (IDEA-147130),
Eugene Zhuravlev [Fri, 6 Nov 2015 12:35:31 +0000 (15:35 +0300)]
fallback url provided when legacy key conversion is not possible (IDEA-147130),
'JetProfile' term changed to 'JetBrains Account' in UI error messages

6 years agoproject leak via toolbar->icon->DeferredIcon.evaluator->RunManager$1->project
Vassiliy.Kudryashov [Fri, 6 Nov 2015 12:37:36 +0000 (15:37 +0300)]
project leak via toolbar->icon->DeferredIcon.evaluator->RunManager$1->project

6 years agoCSS: do not cache custom selectors
Alexander Zolotov [Thu, 5 Nov 2015 17:31:46 +0000 (20:31 +0300)]
CSS: do not cache custom selectors

6 years agoexternal system: do not cleanup orphan project libraries if import runs from Project...
Vladislav.Soroka [Fri, 6 Nov 2015 12:26:56 +0000 (15:26 +0300)]
external system: do not cleanup orphan project libraries if import runs from Project Structure Dialog

6 years agoOC-9697 Include ObjC symbols into search everywhere
Philipp Smorygo [Fri, 6 Nov 2015 12:23:36 +0000 (15:23 +0300)]
OC-9697 Include ObjC symbols into search everywhere

6 years agoIDEA-143572 Android: IAE at com.android.tools.idea.gradle.parser.GradleGroovyFile... appcode/144.899
Dmitry Avdeev [Fri, 6 Nov 2015 11:49:55 +0000 (14:49 +0300)]
IDEA-143572 Android: IAE at com.android.tools.idea.gradle.parser.GradleGroovyFile.checkInitialized: fix import Gradle module from project structure

6 years agodon't check public modifier for abstract classes cause inheritors would be checked...
Anna Kozlova [Fri, 6 Nov 2015 10:12:55 +0000 (11:12 +0100)]
don't check public modifier for abstract classes cause inheritors would be checked for actual runnable

6 years agodrill to directory content in case of flatten packages for content/source root direct...
Anna Kozlova [Thu, 5 Nov 2015 19:26:43 +0000 (20:26 +0100)]
drill to directory content in case of flatten packages for content/source root directories (IDEA-147449)

6 years agomaven: index update error log fix
Vladislav.Soroka [Fri, 6 Nov 2015 10:28:25 +0000 (13:28 +0300)]
maven: index update error log fix

6 years ago[platform] system health issues logged always
Roman Shevchenko [Fri, 6 Nov 2015 10:25:30 +0000 (11:25 +0100)]
[platform] system  health issues logged always

6 years agoIDEA-143572 Android: IAE at com.android.tools.idea.gradle.parser.GradleGroovyFile...
Dmitry Avdeev [Fri, 6 Nov 2015 09:09:07 +0000 (12:09 +0300)]
IDEA-143572 Android: IAE at com.android.tools.idea.gradle.parser.GradleGroovyFile.checkInitialized

6 years agomaven: fix blinking test
Vladislav.Soroka [Fri, 6 Nov 2015 09:51:53 +0000 (12:51 +0300)]
maven: fix blinking test

6 years agouse proper element type for building stubs in LightStubBuilder
Konstantin Ulitin [Fri, 6 Nov 2015 09:45:33 +0000 (12:45 +0300)]
use proper element type for building stubs in LightStubBuilder

6 years agoguava inspection description is rewritten (IDEA-147473) (IDEA-147460)
Dmitry Batkovich [Fri, 6 Nov 2015 09:46:48 +0000 (12:46 +0300)]
guava inspection description is rewritten (IDEA-147473) (IDEA-147460)

6 years agocheck for cyclic Disposable registrations for IDEA-147098
Alexey Kudravtsev [Fri, 6 Nov 2015 09:11:21 +0000 (12:11 +0300)]
check for cyclic Disposable registrations for IDEA-147098

6 years agoDo not run indent detector in any way in viewer mode
Yaroslav Lepenkin [Thu, 5 Nov 2015 19:12:52 +0000 (22:12 +0300)]
Do not run indent detector in any way in viewer mode

6 years agofix project leak via parsable appcode/144.896 clion/144.895
Dennis Ushakov [Fri, 6 Nov 2015 08:31:26 +0000 (11:31 +0300)]
fix project leak via parsable

6 years agocleanup
Dmitry Batrak [Fri, 6 Nov 2015 08:27:06 +0000 (11:27 +0300)]
cleanup

6 years agodon't invoke coordinate transformation functions while soft wrap model is in inconsis...
Dmitry Batrak [Fri, 6 Nov 2015 08:24:36 +0000 (11:24 +0300)]
don't invoke coordinate transformation functions while soft wrap model is in inconsistent state

6 years agomake sure seed and iteration are always logged, even if thrown exception is discarded...
Dmitry Batrak [Thu, 5 Nov 2015 18:51:17 +0000 (21:51 +0300)]
make sure seed and iteration are always logged, even if thrown exception is discarded upper in the call stack

6 years agodon't use legacy code with editor.new.rendering
Dmitry Batrak [Thu, 5 Nov 2015 18:50:27 +0000 (21:50 +0300)]
don't use legacy code with editor.new.rendering

6 years agoextract EditorStressTest
Dmitry Batrak [Thu, 5 Nov 2015 18:05:08 +0000 (21:05 +0300)]
extract EditorStressTest

6 years agouse Java 8 features in test
Dmitry Batrak [Thu, 5 Nov 2015 17:26:40 +0000 (20:26 +0300)]
use Java 8 features in test

6 years agoDBE-515 Connecting dialog: provide a way to see the full database error message appcode/144.893 clion/144.890 dbe/144.881 idea/144.882 phpstorm/144.891 pycharm/144.886 rubymine/144.887 webstorm/144.884
Gregory.Shrago [Fri, 6 Nov 2015 00:32:02 +0000 (03:32 +0300)]
DBE-515 Connecting dialog: provide a way to see the full database error message

6 years agoIDEA-135101 (False positive of "Empty class")
Bas Leijdekkers [Thu, 5 Nov 2015 20:40:21 +0000 (21:40 +0100)]
IDEA-135101 (False positive of "Empty class")

6 years agomake IG test light
Bas Leijdekkers [Thu, 5 Nov 2015 20:11:19 +0000 (21:11 +0100)]
make IG test light

6 years agoSSR: test if all variables are accessible from script
Bas Leijdekkers [Thu, 5 Nov 2015 14:59:05 +0000 (15:59 +0100)]
SSR: test if all variables are accessible from script

6 years agoDFM progress indicator: revert 1px icons
Sergey Ignatov [Thu, 5 Nov 2015 19:12:38 +0000 (22:12 +0300)]
DFM progress indicator: revert 1px icons

6 years agoadd many processes internal action: add a long description for some processes
Sergey Ignatov [Thu, 5 Nov 2015 18:48:00 +0000 (21:48 +0300)]
add many processes internal action: add a long description for some processes

6 years agoIDEA-141246 fix cancel button position for DFM progress indicator
Sergey Ignatov [Thu, 5 Nov 2015 18:43:26 +0000 (21:43 +0300)]
IDEA-141246 fix cancel button position for DFM progress indicator

6 years agoadd an inspection to find possible <clinit> deadlocks like in IDEA-147015
peter [Thu, 5 Nov 2015 18:42:38 +0000 (19:42 +0100)]
add an inspection to find possible <clinit> deadlocks like in IDEA-147015

6 years agorecognize IBM JDK 1.8 (IDEA-90661)
nik [Thu, 5 Nov 2015 17:58:04 +0000 (20:58 +0300)]
recognize IBM JDK 1.8 (IDEA-90661)

6 years agoNPE on open .form
Anna Kozlova [Thu, 5 Nov 2015 17:21:25 +0000 (18:21 +0100)]
NPE on open .form

6 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Thu, 5 Nov 2015 17:20:11 +0000 (18:20 +0100)]
Merge remote-tracking branch 'origin/master'

6 years ago[platform] allow only one background decompilation, to avoid SOE
Roman Shevchenko [Thu, 5 Nov 2015 17:19:13 +0000 (18:19 +0100)]
[platform] allow only one background decompilation, to avoid SOE

6 years agoIndent detector performance test: test separately hot and cold files
Yaroslav Lepenkin [Thu, 5 Nov 2015 17:06:32 +0000 (20:06 +0300)]
Indent detector performance test: test separately hot and cold files

6 years agoTypo fixed, since setUseTabs was used twice
Yaroslav Lepenkin [Thu, 5 Nov 2015 16:44:23 +0000 (19:44 +0300)]
Typo fixed, since setUseTabs was used twice

6 years agointroduce LanguageUtil.getLanguageForPsi
Gregory.Shrago [Thu, 5 Nov 2015 16:42:02 +0000 (19:42 +0300)]
introduce LanguageUtil.getLanguageForPsi

6 years agocompare primitive types with equals as type annotations could spoil them (IDEA-147399)
Anna Kozlova [Thu, 5 Nov 2015 16:15:20 +0000 (17:15 +0100)]
compare primitive types with equals as type annotations could spoil them (IDEA-147399)

6 years ago[java] optimization: do not build mirror tree for getText() and getTextLength() on...
Roman Shevchenko [Thu, 5 Nov 2015 16:27:11 +0000 (17:27 +0100)]
[java] optimization: do not build mirror tree for getText() and getTextLength() on a .class file

6 years agodom: prevent class initialization deadlock
peter [Thu, 5 Nov 2015 16:12:12 +0000 (17:12 +0100)]
dom: prevent class initialization deadlock

6 years agoif we set breakpoint in a file, we should stop in it - ignore sourcemap
Vladimir Krivosheev [Thu, 5 Nov 2015 16:17:21 +0000 (17:17 +0100)]
if we set breakpoint in a file, we should stop in it - ignore sourcemap

6 years agoconvert SuspendContextImpl, StringValue to kotlin
Vladimir Krivosheev [Thu, 5 Nov 2015 15:14:59 +0000 (16:14 +0100)]
convert SuspendContextImpl, StringValue to kotlin

6 years agoconvert SuspendContextImpl, StringValue to kotlin
Vladimir Krivosheev [Thu, 5 Nov 2015 15:14:41 +0000 (16:14 +0100)]
convert SuspendContextImpl, StringValue to kotlin

6 years agointroduce LanguageUtil.getLanguageForPsi
Gregory.Shrago [Thu, 5 Nov 2015 16:14:24 +0000 (19:14 +0300)]
introduce LanguageUtil.getLanguageForPsi

6 years ago(IDEA-147380) Change indent size and continuation indent size only if tab usage detec...
Yaroslav Lepenkin [Thu, 5 Nov 2015 15:28:22 +0000 (18:28 +0300)]
(IDEA-147380) Change indent size and continuation indent size only if tab usage detected and use tabs was switched off

6 years agoRecent tests: changed tests order - passed tests is added only if it is suite; first...
Yaroslav Lepenkin [Thu, 5 Nov 2015 02:05:55 +0000 (05:05 +0300)]
Recent tests: changed tests order - passed tests is added only if it is suite; first comes failed test group, last comes passed test group

6 years agomaven: test fix
Vladislav.Soroka [Thu, 5 Nov 2015 15:42:55 +0000 (18:42 +0300)]
maven: test fix

6 years agoconvert ValueModifierUtil to kotlin appcode/144.880 clion/144.879
Vladimir Krivosheev [Thu, 5 Nov 2015 14:50:23 +0000 (15:50 +0100)]
convert ValueModifierUtil to kotlin

6 years agoconvert ValueModifierUtil to kotlin
Vladimir Krivosheev [Thu, 5 Nov 2015 14:50:02 +0000 (15:50 +0100)]
convert ValueModifierUtil to kotlin

6 years agostructural search speedup: don't waste time in invokeAndWait, don't load decompiled...
peter [Thu, 5 Nov 2015 14:19:04 +0000 (15:19 +0100)]
structural search speedup: don't waste time in invokeAndWait, don't load decompiled document for class files

6 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Thu, 5 Nov 2015 14:32:30 +0000 (15:32 +0100)]
Merge remote-tracking branch 'origin/master'

6 years ago[platform] VM options copy on write (IDEA-147389)
Roman Shevchenko [Thu, 5 Nov 2015 14:31:50 +0000 (15:31 +0100)]
[platform] VM options copy on write (IDEA-147389)

Since all launchers are now capable of using a user copy of VM options file, it makes sense to save changed memory settings there instead of overwriting original file. This way we do not break OS X app signature, avoid patch upgrade conflicts, and do not depend on file permissions.

6 years agofollow IDEA-CR-6530
Anna Kozlova [Thu, 5 Nov 2015 14:19:49 +0000 (15:19 +0100)]
follow IDEA-CR-6530

6 years agonew inference: stop at first common supertypes pair during incorporation of upper...
Anna Kozlova [Thu, 5 Nov 2015 12:36:13 +0000 (13:36 +0100)]
new inference: stop at first common supertypes pair during incorporation of upper bounds (IDEA-147393)

6 years agotest navigation: don't ever treat current class as potential test
Anna Kozlova [Thu, 5 Nov 2015 10:53:41 +0000 (11:53 +0100)]
test navigation: don't ever treat current class as potential test

6 years agoTypo
Matthias Vill [Thu, 5 Nov 2015 09:19:55 +0000 (10:19 +0100)]
Typo

Changed internalization in notification title to internationalization

6 years agoguava type migration: testdata slightly corrected
Dmitry Batkovich [Thu, 5 Nov 2015 14:10:35 +0000 (17:10 +0300)]
guava type migration: testdata slightly corrected

6 years agoguava type migration: method renamed phpstorm/144.878
Dmitry Batkovich [Thu, 5 Nov 2015 13:59:41 +0000 (16:59 +0300)]
guava type migration: method renamed

6 years agoui: respect HiDPI displays in "Available Packages" dialog
Sergey Simonchik [Thu, 5 Nov 2015 13:53:36 +0000 (16:53 +0300)]
ui: respect HiDPI displays in "Available Packages" dialog

6 years agoguava type migration: method parameter migration involves local variables migration...
Dmitry Batkovich [Thu, 5 Nov 2015 13:50:21 +0000 (16:50 +0300)]
guava type migration: method parameter migration involves local variables migration if need

6 years agoremove unused field
Kirill Likhodedov [Wed, 4 Nov 2015 16:55:20 +0000 (19:55 +0300)]
remove unused field

6 years agoCleanup (consistency)
Roman Shevchenko [Thu, 5 Nov 2015 13:20:02 +0000 (14:20 +0100)]
Cleanup (consistency)