idea/community.git
5 years agoAdd missing @NotNull annotations on arguments of PyFile#find* methods
Mikhail Golubev [Tue, 20 Oct 2015 13:56:51 +0000 (16:56 +0300)]
Add missing @NotNull annotations on arguments of PyFile#find* methods

5 years agoPY-17265 Move package "makeFunctionTopLevel" under "com.jetbrains.refactoring.move...
Mikhail Golubev [Tue, 20 Oct 2015 13:44:21 +0000 (16:44 +0300)]
PY-17265 Move package "makeFunctionTopLevel" under "com.jetbrains.refactoring.move", add subpackage "moduleMembers"

5 years agoPY-17265 Check that target module doesn't contain function with this name already...
Mikhail Golubev [Tue, 20 Oct 2015 13:13:55 +0000 (16:13 +0300)]
PY-17265 Check that target module doesn't contain function with this name already and is importable

5 years agoPY-17265 Correctly update usages inside function escalated to other file
Mikhail Golubev [Tue, 20 Oct 2015 12:06:53 +0000 (15:06 +0300)]
PY-17265 Correctly update usages inside function escalated to other file

5 years agoPY-17265 Introduce new dialog for escalating local functions and methods
Mikhail Golubev [Mon, 19 Oct 2015 18:18:47 +0000 (21:18 +0300)]
PY-17265 Introduce new dialog for escalating local functions and methods

This dialog is similar to that previously used to move module members.

5 years agoPY-17265 Get rid of awkward singleton dialog policy
Mikhail Golubev [Mon, 19 Oct 2015 12:36:51 +0000 (15:36 +0300)]
PY-17265 Get rid of awkward singleton dialog policy

5 years agoPY-17265 Extracted PyBaseMoveDialog to later create new dialog for the refactoring
Mikhail Golubev [Mon, 19 Oct 2015 12:22:30 +0000 (15:22 +0300)]
PY-17265 Extracted PyBaseMoveDialog to later create new dialog for the refactoring

5 years agoPY-20377 Python dialect for annotations inside function type comments
Mikhail Golubev [Sun, 24 Jul 2016 10:57:49 +0000 (12:57 +0200)]
PY-20377 Python dialect for annotations inside function type comments

I also get rid of the legacy support of function type comments:
namely, removed PyFunctionTypeCommentReferenceContributor, and
PyTypingAnnotationInjector now handles type comments both for functions
and regular target expressions.

5 years agoUse #getParentDefinitionDocstring() in PyDocstringLanguageInjector
Mikhail Golubev [Mon, 25 Jul 2016 09:13:40 +0000 (11:13 +0200)]
Use #getParentDefinitionDocstring() in PyDocstringLanguageInjector

5 years agoPY-20801 Add missing "Intention" suffix to the name the class
Mikhail Golubev [Sun, 23 Oct 2016 12:46:54 +0000 (15:46 +0300)]
PY-20801 Add missing "Intention" suffix to the name the class

5 years agoPY-20801 Handle cases with nested target expressions and unpacking
Mikhail Golubev [Thu, 20 Oct 2016 21:25:31 +0000 (00:25 +0300)]
PY-20801 Handle cases with nested target expressions and unpacking

5 years agoPY-20801 Handle "with" statements and "for" loops by declaring type beforehand
Mikhail Golubev [Thu, 20 Oct 2016 15:37:16 +0000 (18:37 +0300)]
PY-20801 Handle "with" statements and "for" loops by declaring type beforehand

5 years agoPY-20801 "Convert to variable annotation" for simple assignments
Mikhail Golubev [Thu, 20 Oct 2016 14:57:09 +0000 (17:57 +0300)]
PY-20801 "Convert to variable annotation" for simple assignments

5 years agoremove unused code (convert to template string)
irengrig [Fri, 21 Oct 2016 15:43:24 +0000 (17:43 +0200)]
remove unused code (convert to template string)

5 years agowin 10: redesign combobox action button
Konstantin Bulenkov [Mon, 24 Oct 2016 18:23:47 +0000 (20:23 +0200)]
win 10: redesign combobox action button

5 years ago[java] module files change tracker - rename detection; single tracking point (IDEA...
Roman Shevchenko [Mon, 24 Oct 2016 17:11:30 +0000 (19:11 +0200)]
[java] module files change tracker - rename detection; single tracking point (IDEA-CR-14933)

5 years agoIpnb Fix according to a new api after merge
Valentina Kiryushkina [Mon, 24 Oct 2016 17:01:22 +0000 (20:01 +0300)]
Ipnb Fix according to a new api after merge

5 years agoInspect code
Valentina Kiryushkina [Thu, 20 Oct 2016 15:09:04 +0000 (18:09 +0300)]
Inspect code

5 years agoPY-19960 PY-14096 Merge right-click menu creation for toggle output and split/merge...
Valentina Kiryushkina [Thu, 20 Oct 2016 14:56:30 +0000 (17:56 +0300)]
PY-19960 PY-14096 Merge right-click menu creation for toggle output and split/merge actions

5 years agoPY-19960 Minor Reformat and remove obsolete TODO
Valentina Kiryushkina [Wed, 19 Oct 2016 17:53:28 +0000 (20:53 +0300)]
PY-19960 Minor Reformat and remove obsolete TODO

5 years agoPY-19960 Do not show merge above/below action if there's no corresponding action
Valentina Kiryushkina [Wed, 19 Oct 2016 17:45:00 +0000 (20:45 +0300)]
PY-19960 Do not show merge above/below action if there's no corresponding action

5 years agoPY-19960 Log validation failures
Valentina Kiryushkina [Wed, 19 Oct 2016 17:42:17 +0000 (20:42 +0300)]
PY-19960 Log validation failures

5 years agoPY-19960 Minor Add NotNull annotation
Valentina Kiryushkina [Wed, 19 Oct 2016 17:40:39 +0000 (20:40 +0300)]
PY-19960 Minor Add NotNull annotation

5 years agoPY-19960 Rename: mySelectedCell -> mySelectedCellPanel
Valentina Kiryushkina [Wed, 19 Oct 2016 17:19:20 +0000 (20:19 +0300)]
PY-19960 Rename: mySelectedCell -> mySelectedCellPanel

5 years agoPY-19960 Use getters to access cell panel fields
Valentina Kiryushkina [Wed, 19 Oct 2016 17:17:38 +0000 (20:17 +0300)]
PY-19960  Use getters to access cell panel fields

5 years agoPY-19960 Don't make empty code output panel hideable
Valentina Kiryushkina [Wed, 19 Oct 2016 09:10:55 +0000 (12:10 +0300)]
PY-19960 Don't make empty code output panel hideable

5 years agoPY-19960 Cleanup
Valentina Kiryushkina [Wed, 19 Oct 2016 09:08:42 +0000 (12:08 +0300)]
PY-19960 Cleanup

5 years agoPY-19960 Refactor: extract method and rename variable for readability
Valentina Kiryushkina [Mon, 17 Oct 2016 08:40:43 +0000 (11:40 +0300)]
PY-19960 Refactor: extract method and rename variable for readability

5 years agoPY-19960 Split markdown and heading cells correctly
Valentina Kiryushkina [Fri, 14 Oct 2016 16:12:03 +0000 (19:12 +0300)]
PY-19960 Split markdown and heading cells correctly

5 years agoPY-19960 UI change: use right-click pop-up menu to merge and split cells
Valentina Kiryushkina [Fri, 14 Oct 2016 15:54:49 +0000 (18:54 +0300)]
PY-19960 UI change: use right-click pop-up menu to merge and split cells

5 years agoPY-19960 Minor Disable context menu with reload action
Valentina Kiryushkina [Fri, 14 Oct 2016 15:02:49 +0000 (18:02 +0300)]
PY-19960 Minor Disable context menu with reload action

5 years agoPY-19960 Minor Reformat
Valentina Kiryushkina [Fri, 14 Oct 2016 14:41:24 +0000 (17:41 +0300)]
PY-19960 Minor Reformat

5 years agoPY-19960 Add initial support for split and merge cells
Valentina Kiryushkina [Tue, 11 Oct 2016 10:56:21 +0000 (13:56 +0300)]
PY-19960 Add initial support for split and merge cells

5 years agoFix PY-14096 Update code panel correctly
Valentina Kiryushkina [Mon, 10 Oct 2016 12:12:05 +0000 (15:12 +0300)]
Fix PY-14096 Update code panel correctly

5 years agoFix PY-14096 Respect "collapsed" cell metadata
Valentina Kiryushkina [Fri, 7 Oct 2016 16:19:56 +0000 (19:19 +0300)]
Fix PY-14096 Respect "collapsed" cell metadata

5 years agoFix PY-14096 Minor Make mouse listener nullable
Valentina Kiryushkina [Fri, 7 Oct 2016 14:52:34 +0000 (17:52 +0300)]
Fix PY-14096 Minor Make mouse listener nullable

5 years agoFix PY-14096 Add popup menu on right click
Valentina Kiryushkina [Fri, 7 Oct 2016 13:09:12 +0000 (16:09 +0300)]
Fix PY-14096 Add popup menu on right click

5 years agoFix PY-14096 Minor Refactor output panel creation
Valentina Kiryushkina [Fri, 7 Oct 2016 11:23:13 +0000 (14:23 +0300)]
Fix PY-14096 Minor Refactor output panel creation

5 years agoFix PY-14096 Make toggle bar prettier
Valentina Kiryushkina [Fri, 7 Oct 2016 11:07:00 +0000 (14:07 +0300)]
Fix PY-14096 Make toggle bar prettier

5 years agoFix PY-14096 Collapse code cells
Valentina Kiryushkina [Thu, 22 Sep 2016 15:23:46 +0000 (18:23 +0300)]
Fix PY-14096 Collapse code cells

5 years agoFix PY-16463 Would be nice to make a link in the IPythonNotebook console
Valentina Kiryushkina [Wed, 21 Sep 2016 14:53:57 +0000 (17:53 +0300)]
Fix PY-16463 Would be nice to make a link in the IPythonNotebook console

5 years agoFix PY-19654 Validate cell: show warning for invalid cells, but try to display ipnb...
Valentina Kiryushkina [Tue, 20 Sep 2016 17:23:37 +0000 (20:23 +0300)]
Fix PY-19654 Validate cell: show warning for invalid cells, but try to display ipnb file

5 years agoCleanup (formatting)
Roman Shevchenko [Mon, 24 Oct 2016 16:27:34 +0000 (18:27 +0200)]
Cleanup (formatting)

5 years agoUpdate PyNamedParameterImpl.collectUsedAttributes to not to make false positives...
Semyon Proshev [Mon, 24 Oct 2016 16:18:34 +0000 (19:18 +0300)]
Update PyNamedParameterImpl.collectUsedAttributes to not to make false positives with imported len functions

5 years agoTypeMigrationLabeler invokeLater: be prepared to possible PSI invalidations
peter [Mon, 24 Oct 2016 15:49:36 +0000 (17:49 +0200)]
TypeMigrationLabeler invokeLater: be prepared to possible PSI invalidations

5 years agoIDEA-162947 Add ability to use lambda expressions in breakpoint conditions
Egor.Ushakov [Mon, 24 Oct 2016 16:08:26 +0000 (19:08 +0300)]
IDEA-162947 Add ability to use lambda expressions in breakpoint conditions
- support log expressions as well

5 years agofixed condition extraction in tests
Egor.Ushakov [Mon, 24 Oct 2016 15:50:46 +0000 (18:50 +0300)]
fixed condition extraction in tests

5 years agocleanup
Egor.Ushakov [Mon, 24 Oct 2016 12:34:22 +0000 (15:34 +0300)]
cleanup

5 years agodiff: "Jump to Source" - do not use CommonDataKeys.NAVIGATABLE to avoid clash with...
Aleksey Pivovarov [Fri, 14 Oct 2016 11:32:22 +0000 (14:32 +0300)]
diff: "Jump to Source" - do not use CommonDataKeys.NAVIGATABLE to avoid clash with code navigation

5 years agodiff: "Jump to Source" - consume shortcut if action is disabled
Aleksey Pivovarov [Mon, 24 Oct 2016 15:19:55 +0000 (18:19 +0300)]
diff: "Jump to Source" - consume shortcut if action is disabled

5 years agodiff: "Jump to Source" - do not open temporary binary files
Aleksey Pivovarov [Mon, 24 Oct 2016 15:16:56 +0000 (18:16 +0300)]
diff: "Jump to Source" - do not open temporary binary files

5 years ago[java] module files change tracker - more lightweight instance cache (IDEA-CR-14933)
Roman Shevchenko [Mon, 24 Oct 2016 15:46:09 +0000 (17:46 +0200)]
[java] module files change tracker - more lightweight instance cache (IDEA-CR-14933)

5 years agoCleanup (cosmetics - IDEA-CR-14871)
Roman Shevchenko [Mon, 24 Oct 2016 15:26:43 +0000 (17:26 +0200)]
Cleanup (cosmetics  - IDEA-CR-14871)

5 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Mon, 24 Oct 2016 15:18:02 +0000 (17:18 +0200)]
Merge remote-tracking branch 'origin/master'

5 years ago[java] module files change tracker
Roman Shevchenko [Mon, 24 Oct 2016 15:17:30 +0000 (17:17 +0200)]
[java] module files change tracker

5 years ago[vcs-log] minor: better format
Julia Beliaeva [Mon, 24 Oct 2016 15:14:38 +0000 (18:14 +0300)]
[vcs-log] minor: better format

5 years ago[vcs-log] minor: use Comparator.comparing
Julia Beliaeva [Mon, 24 Oct 2016 15:13:33 +0000 (18:13 +0300)]
[vcs-log] minor: use Comparator.comparing

5 years ago[vcs-log] minor: remove unused method
Julia Beliaeva [Mon, 24 Oct 2016 15:12:51 +0000 (18:12 +0300)]
[vcs-log] minor: remove unused method

5 years ago[vcs-log] minor: use method references
Julia Beliaeva [Mon, 24 Oct 2016 15:12:24 +0000 (18:12 +0300)]
[vcs-log] minor: use method references

5 years ago[vcs-log] minor: move file and user filter classes to impl package
Julia Beliaeva [Mon, 24 Oct 2016 15:09:51 +0000 (18:09 +0300)]
[vcs-log] minor: move file and user filter classes to impl package

5 years ago[vcs-log] minor: move VcsLogStorage to data
Julia Beliaeva [Mon, 24 Oct 2016 15:00:04 +0000 (18:00 +0300)]
[vcs-log] minor: move VcsLogStorage to data

5 years ago[vcs-log] minor: move VcsLogRootFilterImpl to impl package
Julia Beliaeva [Mon, 24 Oct 2016 14:57:00 +0000 (17:57 +0300)]
[vcs-log] minor: move VcsLogRootFilterImpl to impl package

5 years ago[vcs-log] minor: move TroveUtil to util package
Julia Beliaeva [Mon, 24 Oct 2016 14:54:58 +0000 (17:54 +0300)]
[vcs-log] minor: move TroveUtil to util package

5 years ago[java] fixes module resolve results caching
Roman Shevchenko [Mon, 24 Oct 2016 15:09:22 +0000 (17:09 +0200)]
[java] fixes module resolve results caching

5 years agoAdd new action: Maximize/Restore Active Dialog
Vassiliy.Kudryashov [Mon, 24 Oct 2016 14:39:30 +0000 (17:39 +0300)]
Add new action: Maximize/Restore Active Dialog

5 years agoDon't resize non-resizable dialogs
Vassiliy.Kudryashov [Mon, 24 Oct 2016 14:04:30 +0000 (17:04 +0300)]
Don't resize non-resizable dialogs

5 years agobuild scripts: don't fail if JRE for Windows isn't available (IDEA-163031, IDEA-CR...
nik [Mon, 24 Oct 2016 14:55:53 +0000 (17:55 +0300)]
build scripts: don't fail if JRE for Windows isn't available (IDEA-163031, IDEA-CR-14908)

5 years agoavoid caret visual position changes on parameter hints adding (IDEA-115424)
Dmitry Batrak [Mon, 24 Oct 2016 14:55:30 +0000 (17:55 +0300)]
avoid caret visual position changes on parameter hints adding (IDEA-115424)

5 years agorevert redundant Project argument since getFilesToSearchInPsi() is accessed only...
Dmitry Batkovich [Mon, 24 Oct 2016 14:54:08 +0000 (17:54 +0300)]
revert redundant Project argument since getFilesToSearchInPsi() is accessed only in EDT

5 years agojunit: don't treat provider methods as test methods (IDEA-163058)
Anna.Kozlova [Mon, 24 Oct 2016 14:44:50 +0000 (16:44 +0200)]
junit: don't treat provider methods as test methods (IDEA-163058)

5 years agofunction expression searcher: find most likely files only among of files where occurr...
Dmitry Batkovich [Mon, 24 Oct 2016 14:46:45 +0000 (17:46 +0300)]
function expression searcher: find most likely files only among of files where occurrences was found

5 years agoAdjust indent synchronously on relatively small files
Rustam Vishnyakov [Mon, 24 Oct 2016 14:38:49 +0000 (17:38 +0300)]
Adjust indent synchronously on relatively small files

5 years agoPY-20832 Fixed: __iter__ is not inferred from for-statement
Semyon Proshev [Thu, 20 Oct 2016 17:51:54 +0000 (20:51 +0300)]
PY-20832 Fixed: __iter__ is not inferred from for-statement

Update PyNamedParameterImpl.collectUsedAttributes to honour for-statements

5 years agoPY-20833 Fixed: __len__ is not inferred from len(...)-statement
Semyon Proshev [Thu, 20 Oct 2016 17:47:13 +0000 (20:47 +0300)]
PY-20833 Fixed: __len__ is not inferred from len(...)-statement

 Update PyNamedParameterImpl.collectUsedAttributes to honour len(...)-statements

5 years agoPY-20364 Fixed: Hinting does not support `basestring` in `open()`
Semyon Proshev [Fri, 21 Oct 2016 15:42:59 +0000 (18:42 +0300)]
PY-20364 Fixed: Hinting does not support `basestring` in `open()`

Replace actual basestring type with union of str and unicode while matching types in PyTypeChecker

5 years agoPY-20939 Fixed: PyCharm should not suggest to update locally patched package of the...
Semyon Proshev [Thu, 20 Oct 2016 16:34:44 +0000 (19:34 +0300)]
PY-20939 Fixed: PyCharm should not suggest to update locally patched package of the last version

Override compareVersions in PyPackageManagementService to catch equal package versions which are not handled by VERSION_COMPARATOR

5 years agomake Caret.getOffset() work correctly from a side thread (under read action)
Dmitry Batrak [Mon, 24 Oct 2016 14:29:07 +0000 (17:29 +0300)]
make Caret.getOffset() work correctly from a side thread (under read action)

caret/selection marker disposal will be handled by RangeMarkerTree when no references to them will be left

5 years agoNPE
Alexey Kudravtsev [Mon, 24 Oct 2016 14:21:46 +0000 (17:21 +0300)]
NPE

5 years agocleanup
Alexey Kudravtsev [Mon, 24 Oct 2016 14:17:57 +0000 (17:17 +0300)]
cleanup

5 years agoNPE
Alexey Kudravtsev [Mon, 24 Oct 2016 14:09:08 +0000 (17:09 +0300)]
NPE

5 years ago[patch]: (IDEA-91846) use balloons for warn/info instead of dialogs
Nadya Zabrodina [Mon, 24 Oct 2016 14:17:04 +0000 (17:17 +0300)]
[patch]: (IDEA-91846) use balloons for warn/info instead of dialogs

* remove unnecessary parameter in showError method,
 use it only for real errors;
* cleanUp;

5 years agoIDEA-CR-14800 use == to compare attributes
Vladimir Krivosheev [Mon, 24 Oct 2016 14:01:58 +0000 (16:01 +0200)]
IDEA-CR-14800 use == to compare attributes

5 years agoIDEA-162301 NPE at com.intellij.ui.popup.PopupDispatcher.a
Sergey Malenkov [Mon, 24 Oct 2016 13:53:24 +0000 (16:53 +0300)]
IDEA-162301 NPE at com.intellij.ui.popup.PopupDispatcher.a

5 years agomaven: extensions tests fix
Vladislav.Soroka [Mon, 24 Oct 2016 13:30:32 +0000 (16:30 +0300)]
maven: extensions tests fix

5 years agobuild scripts: product-independent helper scripts for Mac OS distributions moved...
nik [Mon, 24 Oct 2016 13:24:38 +0000 (16:24 +0300)]
build scripts: product-independent helper scripts for Mac OS distributions moved to platform

5 years agoIDEA-162583 "Changed files" not available anymore in "Project" tool window. Instead...
Dmitry Avdeev [Mon, 24 Oct 2016 12:47:50 +0000 (15:47 +0300)]
IDEA-162583 "Changed files" not available anymore in "Project" tool window. Instead "Tests" is li...

5 years ago[shelf]: (IDEA-162691) shelving PNG files with the same name
Nadya Zabrodina [Mon, 24 Oct 2016 12:21:12 +0000 (15:21 +0300)]
[shelf]: (IDEA-162691) shelving PNG files with the same name

5 years agoIDEA-162314 Scrolling menu should update position of expanded submenu
Vassiliy.Kudryashov [Mon, 24 Oct 2016 10:46:22 +0000 (13:46 +0300)]
IDEA-162314 Scrolling menu should update position of expanded submenu

5 years agoannotate varargs methods with SafeVarargs or add corresponding external annotation...
Alexey Kudravtsev [Mon, 24 Oct 2016 12:03:03 +0000 (15:03 +0300)]
annotate varargs methods with SafeVarargs or add corresponding external annotation to get rid of yellow callsites

5 years agolook for SafeVarargs in external annotations to get rid of yellow code when java8...
Alexey Kudravtsev [Mon, 24 Oct 2016 12:00:53 +0000 (15:00 +0300)]
look for SafeVarargs in external annotations to get rid of yellow code when java8-level code calls java6-level varargs method.

5 years agocleanup
Alexey Kudravtsev [Thu, 20 Oct 2016 16:57:27 +0000 (19:57 +0300)]
cleanup

5 years agolambdify, cleanup
Alexey Kudravtsev [Thu, 20 Oct 2016 13:27:01 +0000 (16:27 +0300)]
lambdify, cleanup

5 years agoFailed getting template line shouldn't break debugging for the current frame (PY...
Elizaveta Shashkova [Mon, 24 Oct 2016 12:00:59 +0000 (15:00 +0300)]
Failed getting template line shouldn't break debugging for the current frame (PY-20545)

5 years agoRemove access to caret offset from a side thread without read action, result doesn...
Dmitry Batrak [Mon, 24 Oct 2016 10:34:16 +0000 (13:34 +0300)]
Remove access to caret offset from a side thread without read action, result doesn't seem to be used anyway

(for IDEA-135620)

5 years agofix test
Dmitry Batrak [Fri, 14 Oct 2016 11:35:16 +0000 (14:35 +0300)]
fix test

(for IDEA-135620)

5 years agoadd a performance test for typing with multiple carets
Dmitry Batrak [Fri, 14 Oct 2016 08:01:56 +0000 (11:01 +0300)]
add a performance test for typing with multiple carets

(for IDEA-135620)

5 years agoavoid unnecessary position panel updates
Dmitry Batrak [Thu, 13 Oct 2016 14:55:41 +0000 (17:55 +0300)]
avoid unnecessary position panel updates

(for IDEA-135620)

5 years agoavoid using AsyncResult for synchronous operations in FileEditorManagerImpl
Dmitry Batrak [Thu, 13 Oct 2016 14:41:26 +0000 (17:41 +0300)]
avoid using AsyncResult for synchronous operations in FileEditorManagerImpl

Each such operation involves Disposer.dispose call which generates a Throwable. When called thousand(s) of time within the same event, this creates a notable performance overhead
(for IDEA-135620)

5 years agoavoid creation of exception per document change (exception is generated in Disposer...
Dmitry Batrak [Thu, 13 Oct 2016 12:49:59 +0000 (15:49 +0300)]
avoid creation of exception per document change (exception is generated in Disposer.dispose() invoked from DaemonProgressIndicator.cancel())

in case of thousand(s) of document updates in a single event performance impact becomes noticeable
(for IDEA-135620)

5 years agooptimize capturing of selection state in editor
Dmitry Batrak [Thu, 13 Oct 2016 11:19:39 +0000 (14:19 +0300)]
optimize capturing of selection state in editor

(for IDEA-135620)