idea/community.git
4 years agoMerge branch 'ypankratyev/goto_testdata_fixes'
Yaroslav Pankratyev [Mon, 18 Sep 2017 04:09:20 +0000 (11:09 +0700)]
Merge branch 'ypankratyev/goto_testdata_fixes'

4 years agoBuild tool window: tab selection and window activation fixes
Vladislav.Soroka [Mon, 18 Sep 2017 03:45:29 +0000 (06:45 +0300)]
Build tool window: tab selection and window activation fixes

4 years agorestore some plugins compatibility (sanselan -> commons-imaging) appcode/173.2439 clion/173.2438 dbe/173.2443 idea/173.2440 phpstorm/173.2442 rubymine/173.2437 webstorm/173.2445
Gregory.Shrago [Sun, 17 Sep 2017 20:49:12 +0000 (23:49 +0300)]
restore some plugins compatibility (sanselan -> commons-imaging)

4 years agoIDEA-171004 - Allow to select and copy errors in the Docker view
Michael Golubev [Sun, 17 Sep 2017 20:19:57 +0000 (22:19 +0200)]
IDEA-171004 - Allow to select and copy errors in the Docker view

- can't use JBLabel # setCopyable since it does not auto-wrap

4 years agoRegister disposable in a read action EA-107471 appcode/173.2428 appcode/173.2431 clion/173.2429 clion/173.2432 clion/173.2434 phpstorm/173.2430
Kirill Likhodedov [Sun, 17 Sep 2017 07:40:42 +0000 (10:40 +0300)]
Register disposable in a read action EA-107471

This allows to avoid IOE if the parent has already been disposed.

Works only for disposables which are disposed in a write action,
but that's the majority. The rest can still get IOE which is logged
for statistical reasons.

Follow-up to 1b32242.

4 years agoReturn safe disposer registration, accidentally removed during refactoring
Kirill Likhodedov [Sun, 17 Sep 2017 07:35:21 +0000 (10:35 +0300)]
Return safe disposer registration, accidentally removed during refactoring

Introduced in 1b32242, but was removed in 6633c0a

4 years agoReturn the javadoc, accidentally removed together with unused method
Kirill Likhodedov [Sun, 17 Sep 2017 07:26:46 +0000 (10:26 +0300)]
Return the javadoc, accidentally removed together with unused method

Was removed in 6633c0a

4 years agoBuild tool window: request focus on build view switch
Vladislav.Soroka [Sun, 17 Sep 2017 06:28:07 +0000 (09:28 +0300)]
Build tool window: request focus on build view switch

4 years agoGradle test runner: set testing finished when no test events were received
Vladislav.Soroka [Sun, 17 Sep 2017 06:26:16 +0000 (09:26 +0300)]
Gradle test runner: set testing finished when no test events were received

4 years agoBuild tool window: dispose supplied content descriptor
Vladislav.Soroka [Sun, 17 Sep 2017 05:13:11 +0000 (08:13 +0300)]
Build tool window: dispose supplied content descriptor

4 years agoBuild tool window: dispose supplied execution console
Vladislav.Soroka [Sun, 17 Sep 2017 05:03:45 +0000 (08:03 +0300)]
Build tool window: dispose supplied execution console

4 years agoRemove obsolete android-gradle-jps module
Vladislav.Soroka [Sun, 17 Sep 2017 04:34:38 +0000 (07:34 +0300)]
Remove obsolete android-gradle-jps module

4 years agoGradle test runner: fire onTestingStarted onTestingFinished events
Vladislav.Soroka [Sun, 17 Sep 2017 04:28:30 +0000 (07:28 +0300)]
Gradle test runner: fire onTestingStarted onTestingFinished events

4 years agoGradle rerun filter
Vladislav.Soroka [Fri, 15 Sep 2017 13:35:31 +0000 (16:35 +0300)]
Gradle rerun filter

4 years agoExternal system api refactoring for better integration with Build tool window
Vladislav.Soroka [Fri, 15 Sep 2017 13:34:01 +0000 (16:34 +0300)]
External system api refactoring for better integration with Build tool window

4 years agoBuild tool window cleanup
Vladislav.Soroka [Fri, 15 Sep 2017 13:27:42 +0000 (16:27 +0300)]
Build tool window cleanup

4 years agoExternal system: do not add invalid 'null' settings
Vladislav.Soroka [Fri, 15 Sep 2017 13:15:30 +0000 (16:15 +0300)]
External system: do not add invalid 'null' settings

4 years agoGradle: project task runner extension id
Vladislav.Soroka [Fri, 15 Sep 2017 07:42:34 +0000 (10:42 +0300)]
Gradle: project task runner extension id

4 years agoProject task runner createExecutionEnvironment default implementation added
Vladislav.Soroka [Tue, 5 Sep 2017 10:25:21 +0000 (13:25 +0300)]
Project task runner createExecutionEnvironment default implementation added

4 years agoIDEA-179056 Confirm Exit, Do not ask me again - always appearing appcode/173.2421 clion/173.2417 dbe/173.2423 idea/173.2419 phpstorm/173.2422 rubymine/173.2418 webstorm/173.2425
Gregory.Shrago [Sat, 16 Sep 2017 22:22:00 +0000 (01:22 +0300)]
IDEA-179056 Confirm Exit, Do not ask me again - always appearing

4 years agoIDEA-176821 "Hide file extensions in editor tabs" removes all after dot
Gregory.Shrago [Sat, 16 Sep 2017 21:12:22 +0000 (00:12 +0300)]
IDEA-176821 "Hide file extensions in editor tabs" removes all after dot

4 years agoreformat
Gregory.Shrago [Sat, 16 Sep 2017 21:05:05 +0000 (00:05 +0300)]
reformat

4 years ago[vcs-log] add dispose check
Julia Beliaeva [Sat, 16 Sep 2017 20:25:47 +0000 (23:25 +0300)]
[vcs-log] add dispose check

EA-105362

4 years agocode style settings: modify documents in write-safe context
peter [Sat, 16 Sep 2017 17:27:03 +0000 (19:27 +0200)]
code style settings: modify documents in write-safe context

fixes ConfigurablesModifiedTest

4 years agoIDEA-178535 Duplicate class suggestions in cast
peter [Sat, 16 Sep 2017 09:58:43 +0000 (11:58 +0200)]
IDEA-178535 Duplicate class suggestions in cast

4 years agoIDEA-178377 No "final" completion suggestion in catch declaration
peter [Sat, 16 Sep 2017 08:53:08 +0000 (10:53 +0200)]
IDEA-178377 No "final" completion suggestion in catch declaration

4 years agojetbrains.dic "cname" appcode/173.2415 clion/173.2414
Yann Cébron [Sat, 16 Sep 2017 11:40:12 +0000 (13:40 +0200)]
jetbrains.dic "cname"

4 years agoPHP highlighting lexer restart state control phpstorm/173.2413
Alexey Gopachenko [Sat, 16 Sep 2017 12:38:31 +0000 (14:38 +0200)]
PHP highlighting lexer restart state control

4 years agoEA-105759 - PIEAE: PsiUtilCore.ensureValid appcode/173.2405 clion/173.2401 idea/173.2403 phpstorm/173.2406 phpstorm/173.2412 rubymine/173.2402 webstorm/173.2409
Gregory.Shrago [Fri, 15 Sep 2017 21:26:28 +0000 (00:26 +0300)]
EA-105759 - PIEAE: PsiUtilCore.ensureValid

4 years agofix GeneratorTest
peter [Fri, 15 Sep 2017 20:45:57 +0000 (22:45 +0200)]
fix GeneratorTest

4 years agoIDEA-178754 In-method class item reported as "default package"
peter [Fri, 15 Sep 2017 20:03:36 +0000 (22:03 +0200)]
IDEA-178754 In-method class item reported as "default package"

4 years agocompletion: place functional expressions after variables of expected type (IDEA-17442...
peter [Fri, 15 Sep 2017 19:57:11 +0000 (21:57 +0200)]
completion: place functional expressions after variables of expected type (IDEA-174428, IDEA-178600)

4 years agojetCheck: merge two ints into one double without sign promotion
peter [Fri, 15 Sep 2017 19:52:18 +0000 (21:52 +0200)]
jetCheck: merge two ints into one double without sign promotion

4 years agoIDEA-178933 Complete current statement for if statement without opening bracket
peter [Fri, 15 Sep 2017 18:06:17 +0000 (20:06 +0200)]
IDEA-178933 Complete current statement for if statement without opening bracket

4 years agogoto file: restore understanding of queries with wrong (russian) keyboard layout
peter [Fri, 15 Sep 2017 17:54:56 +0000 (19:54 +0200)]
goto file: restore understanding of queries with wrong (russian) keyboard layout

4 years agoIDEA-173927 Support keywords autocompletion when keyboard layout is incorrect
peter [Fri, 15 Sep 2017 17:32:29 +0000 (19:32 +0200)]
IDEA-173927 Support keywords autocompletion when keyboard layout is incorrect

4 years agoIDEA-178986 Search history no longer shows with Ctrl-H
Vassiliy.Kudryashov [Fri, 15 Sep 2017 19:06:55 +0000 (22:06 +0300)]
IDEA-178986 Search history no longer shows with Ctrl-H

Show hint on pressing legacy tooltip

4 years agoEA-107522 - assert: FileManagerImpl.getCachedPsiFile idea/173.2399
Gregory.Shrago [Fri, 15 Sep 2017 18:12:45 +0000 (21:12 +0300)]
EA-107522 - assert: FileManagerImpl.getCachedPsiFile

4 years agoUpdate comparator by request to resort a whole tree
Sergey Malenkov [Fri, 15 Sep 2017 17:45:37 +0000 (20:45 +0300)]
Update comparator by request to resort a whole tree

4 years agoafter review comments for green code
Maxim.Mossienko [Fri, 15 Sep 2017 17:58:21 +0000 (19:58 +0200)]
after review comments for green code

4 years agocoverage: separate options for implicit & empty constructors
Anna Kozlova [Fri, 15 Sep 2017 17:49:20 +0000 (20:49 +0300)]
coverage: separate options for implicit & empty constructors

4 years agoclass naming: description & ui tweaks
Anna Kozlova [Fri, 15 Sep 2017 16:55:17 +0000 (19:55 +0300)]
class naming: description & ui tweaks

4 years agoIDEA-85375 Run configurations dropbox should not change its width
Vassiliy.Kudryashov [Fri, 15 Sep 2017 17:36:16 +0000 (20:36 +0300)]
IDEA-85375 Run configurations dropbox should not change its width

Fix arrow icon location for empty combobox

4 years agoCleanup (using right API)
Roman Shevchenko [Fri, 15 Sep 2017 17:36:46 +0000 (20:36 +0300)]
Cleanup (using right API)

4 years agoCleanup (formatting)
Roman Shevchenko [Fri, 15 Sep 2017 17:33:49 +0000 (20:33 +0300)]
Cleanup (formatting)

4 years agoIDEA-179077 NPE at org.jetbrains.idea.perforce.application.PerforceInfoAndClient...
peter [Fri, 15 Sep 2017 16:39:19 +0000 (18:39 +0200)]
IDEA-179077 NPE at org.jetbrains.idea.perforce.application.PerforceInfoAndClient.calcInfoMap

4 years agofix LaterInvocatorTest
peter [Fri, 15 Sep 2017 16:29:40 +0000 (18:29 +0200)]
fix LaterInvocatorTest

4 years agotest framework: ensure temporary directory is deleted (IDEA-CR-24597)
nik [Fri, 15 Sep 2017 16:27:35 +0000 (19:27 +0300)]
test framework: ensure temporary directory is deleted (IDEA-CR-24597)

4 years agolet ChromeLocalVmConnection decide which port to use; fix react native debug url
Konstantin Ulitin [Fri, 15 Sep 2017 16:11:55 +0000 (19:11 +0300)]
let ChromeLocalVmConnection decide which port to use; fix react native debug url

4 years agomodified .iml
Anna Kozlova [Fri, 15 Sep 2017 16:09:06 +0000 (19:09 +0300)]
modified .iml

4 years agoadd new eclipse_license2
Anna Kozlova [Fri, 15 Sep 2017 15:38:37 +0000 (18:38 +0300)]
add new eclipse_license2

4 years agonaming convention: disable all to get no state when everything is disabled
Anna Kozlova [Fri, 15 Sep 2017 15:31:16 +0000 (18:31 +0300)]
naming convention: disable all to get no state when everything is disabled

4 years agoremove unused library from CE
Anna Kozlova [Fri, 15 Sep 2017 15:13:25 +0000 (18:13 +0300)]
remove unused library from CE

4 years ago[changes] add actions text and icon
Julia Beliaeva [Fri, 15 Sep 2017 15:24:29 +0000 (18:24 +0300)]
[changes] add actions text and icon

4 years agoA registry key to enable/disable patterns-injection to Kotlin annotations
Nicolay Mitropolsky [Fri, 15 Sep 2017 15:16:23 +0000 (18:16 +0300)]
A registry key to enable/disable patterns-injection to Kotlin annotations

4 years ago[followup] Use JBDimention.update to stick to JBUI.scale change
Anton Tarasov [Fri, 15 Sep 2017 15:11:49 +0000 (18:11 +0300)]
[followup] Use JBDimention.update to stick to JBUI.scale change

4 years agoUse JBDimention.update to stick to JBUI.scale change
Anton Tarasov [Fri, 15 Sep 2017 15:01:28 +0000 (18:01 +0300)]
Use JBDimention.update to stick to JBUI.scale change

4 years agoFix the combo arrow paint on JBUI.scale change
Anton Tarasov [Fri, 15 Sep 2017 14:09:05 +0000 (17:09 +0300)]
Fix the combo arrow paint on JBUI.scale change

- Use JBDimention.update() to stick to JBUI.scale
- Repeat 'bw' dancing for the arrow painting

4 years agopost-order dfs: parent() & backtrace() fix
Gregory.Shrago [Fri, 15 Sep 2017 14:02:58 +0000 (17:02 +0300)]
post-order dfs: parent() & backtrace() fix

4 years agocleanup
Gregory.Shrago [Fri, 15 Sep 2017 14:05:38 +0000 (17:05 +0300)]
cleanup

4 years agoEA-107332 - IAE: MacroComboBoxWithBrowseButton$.a
Sergey Malenkov [Fri, 15 Sep 2017 13:51:29 +0000 (16:51 +0300)]
EA-107332 - IAE: MacroComboBoxWithBrowseButton$.a

4 years agoIDEA-178896 maven - filter WEB-INF/classes entries if they appear in web resources...
Ivan Bessonov [Fri, 15 Sep 2017 13:53:29 +0000 (16:53 +0300)]
IDEA-178896 maven - filter WEB-INF/classes entries if they appear in web resources with enabled filtering

4 years agocleanup: map().filter(not-null) -> filterMap()
Gregory.Shrago [Fri, 15 Sep 2017 13:49:09 +0000 (16:49 +0300)]
cleanup: map().filter(not-null) -> filterMap()

4 years agoEA-107313 - NPE: AbstractTreeBuilder.getTreeStructureElement
Sergey Malenkov [Fri, 15 Sep 2017 13:03:56 +0000 (16:03 +0300)]
EA-107313 - NPE: AbstractTreeBuilder.getTreeStructureElement

4 years agoenable write-safe context checks in tests
peter [Fri, 15 Sep 2017 13:34:05 +0000 (15:34 +0200)]
enable write-safe context checks in tests

4 years agomark files as Ant in write-safe context
peter [Fri, 15 Sep 2017 13:30:07 +0000 (15:30 +0200)]
mark files as Ant in write-safe context

4 years agomake indexing pauseable again (and IDEA-176474 now works, yay!)
peter [Fri, 15 Sep 2017 12:56:41 +0000 (14:56 +0200)]
make indexing pauseable again (and IDEA-176474 now works, yay!)

4 years agoCacheUpdateRunner: processInReadAction is always true
peter [Fri, 15 Sep 2017 11:46:42 +0000 (13:46 +0200)]
CacheUpdateRunner: processInReadAction is always true

4 years agoEnforce null modifier list for decompiled anonymous classes
Maxim.Mossienko [Fri, 15 Sep 2017 13:17:05 +0000 (15:17 +0200)]
Enforce null modifier list for decompiled anonymous classes

4 years agoLogging for EA-107491 - NPE: ColorAndFontOptions.a
Gregory.Shrago [Fri, 15 Sep 2017 13:03:28 +0000 (16:03 +0300)]
Logging for EA-107491 - NPE: ColorAndFontOptions.a

4 years agopass action as a parameter to clear user data in action presentation
Konstantin Bulenkov [Fri, 15 Sep 2017 12:58:20 +0000 (14:58 +0200)]
pass action as a parameter to clear user data in action presentation

4 years agocollect stats before main menu selection got cleared
Konstantin Bulenkov [Fri, 15 Sep 2017 12:57:35 +0000 (14:57 +0200)]
collect stats before main menu selection got cleared

4 years agoadd support for Win/Linux. Use MenuSelectionManager to collect data
Konstantin Bulenkov [Fri, 15 Sep 2017 12:56:51 +0000 (14:56 +0200)]
add support for Win/Linux. Use MenuSelectionManager to collect data

4 years agouse Optional.of() instead ofNullable() in "opt" postfix template when expression...
Dmitry Batkovich [Fri, 15 Sep 2017 12:55:04 +0000 (15:55 +0300)]
use Optional.of() instead ofNullable() in "opt" postfix template when expression is not null

4 years agonaming convention: class naming convention disabled by default
Anna Kozlova [Fri, 15 Sep 2017 12:44:41 +0000 (15:44 +0300)]
naming convention: class naming convention disabled by default

4 years agostream postfix template shouldn't be available for primitive arrays except long[...
Dmitry Batkovich [Fri, 15 Sep 2017 12:27:58 +0000 (15:27 +0300)]
stream postfix template shouldn't be available for primitive arrays except long[], double[], int[]

4 years agodon't bundle junit rt jars, download on first run
Anna Kozlova [Fri, 15 Sep 2017 11:37:43 +0000 (14:37 +0300)]
don't bundle junit rt jars, download on first run

4 years agoFix updating from root with restoring paths appcode/173.2393 clion/173.2394
Sergey Malenkov [Fri, 15 Sep 2017 11:18:58 +0000 (14:18 +0300)]
Fix updating from root with restoring paths

4 years ago"idea.ProcessCanceledException=disabled" disables "impatient readers" optimisation...
Alexey Kudravtsev [Thu, 14 Sep 2017 15:26:33 +0000 (18:26 +0300)]
"idea.ProcessCanceledException=disabled" disables "impatient readers" optimisation to help debug highlighting in presence of cancelable indicators

4 years agoEnforce virtual file pointers leak tracking in fixtures;
Alexey Kudravtsev [Thu, 14 Sep 2017 13:24:51 +0000 (16:24 +0300)]
Enforce virtual file pointers leak tracking in fixtures;
moved tracking code away from VFPMI to VirtualFilePointerTracker because it's test-only
warn about not paired storePointers()/assertPointersAreDisposed() (memleaks otherwise from myStoredPointers)
(disable pointer leak tracking in FixtureRule.kt for now because only @develar knows what's going on there)

4 years agooverride
Alexey Kudravtsev [Thu, 14 Sep 2017 12:58:16 +0000 (15:58 +0300)]
override

4 years agocleanup
Alexey Kudravtsev [Thu, 14 Sep 2017 11:25:30 +0000 (14:25 +0300)]
cleanup

4 years agoclass naming convention: merge all inspections into one
Anna Kozlova [Fri, 15 Sep 2017 11:14:00 +0000 (14:14 +0300)]
class naming convention: merge all inspections into one

4 years ago[java] Project Amber: parser, inference, keyword highlighting (IDEA-178868) phpstorm/173.2391
Roman Shevchenko [Fri, 15 Sep 2017 09:56:37 +0000 (12:56 +0300)]
[java] Project Amber: parser, inference, keyword highlighting (IDEA-178868)

4 years agoremove unused field
Ekaterina Tuzova [Fri, 15 Sep 2017 09:54:23 +0000 (12:54 +0300)]
remove unused field

4 years ago[tests] minor Java parser test case optimization
Roman Shevchenko [Fri, 15 Sep 2017 09:51:37 +0000 (12:51 +0300)]
[tests] minor Java parser test case optimization

4 years agoPY-22398 False positive about missing argument for numpy.maximum.accumulate() appcode/173.2388 clion/173.2389
Ekaterina Tuzova [Thu, 14 Sep 2017 16:52:20 +0000 (19:52 +0300)]
PY-22398 False positive about missing argument for numpy.maximum.accumulate()

added skeleton for numpy.core.ufunc and numpy.core.dtype

4 years agoIDEA-167961 XSD editor with with multiple <xsd:import> for the same namespace only...
Dmitry Avdeev [Fri, 15 Sep 2017 08:48:30 +0000 (11:48 +0300)]
IDEA-167961 XSD editor with with multiple <xsd:import> for the same namespace only recognoses ele...

4 years agoJavaTargetElementEvaluator: fixes accoring to review IDEA-CR-24616
Tagir Valeev [Fri, 15 Sep 2017 08:34:07 +0000 (15:34 +0700)]
JavaTargetElementEvaluator: fixes accoring to review IDEA-CR-24616

Extracted method, PsiUtil#canBeOverridden used, JavaOverridingMethodsSearcher#findOverridingMethod used

4 years agoStandardInstructionVisitor#findSpecificMethod: PsiUtil#canBeOverridden, JavaOverridin...
Tagir Valeev [Fri, 15 Sep 2017 08:29:28 +0000 (15:29 +0700)]
StandardInstructionVisitor#findSpecificMethod: PsiUtil#canBeOverridden, JavaOverridingMethodsSearcher#findOverridingMethod used

Review ID: IDEA-CR-24590

4 years agoget rid of excess usage of Arrays.asList(T...)
stsypanov [Fri, 15 Sep 2017 08:17:27 +0000 (15:17 +0700)]
get rid of excess usage of Arrays.asList(T...)

GitHub pull request: https://github.com/JetBrains/intellij-community/pull/625

4 years agoEnforce null modifier list for decompiled anonymous and local classes
Maxim.Mossienko [Fri, 15 Sep 2017 07:59:41 +0000 (09:59 +0200)]
Enforce null modifier list for decompiled anonymous and local classes

4 years agofaster goto file
peter [Fri, 15 Sep 2017 07:34:46 +0000 (09:34 +0200)]
faster goto file

match unlikely names only after more likely ones produced no results

4 years agoIDEA-179038 When navigating to method definition specific type information known...
Tagir Valeev [Fri, 15 Sep 2017 07:28:30 +0000 (14:28 +0700)]
IDEA-179038 When navigating to method definition specific type information known from DFA could be used to find actual implementation

4 years agoexternal build: do not add duplicated directory entries
nik [Thu, 14 Sep 2017 19:07:46 +0000 (22:07 +0300)]
external build: do not add duplicated directory entries

Previously duplicated directory entries were produced for archives which include 'extracted directory' elements (IDEA-167542).

4 years agoArtifactBuildTest: create jar instead of reusing junit.jar
nik [Thu, 14 Sep 2017 18:58:41 +0000 (21:58 +0300)]
ArtifactBuildTest: create jar instead of reusing junit.jar

To make tests simpler and get rid of dependency on junit.jar.

4 years agoexternal build tests: ArtifactBuilderTest converted to Kotlin
nik [Thu, 14 Sep 2017 18:44:18 +0000 (21:44 +0300)]
external build tests: ArtifactBuilderTest converted to Kotlin

This is needed to allow using new DirectoryContentSpec API.

4 years agoexternal build tests: ArtifactBuilderTest.java -> ArtifactBuilderTest.kt
nik [Thu, 14 Sep 2017 18:26:34 +0000 (21:26 +0300)]
external build tests: ArtifactBuilderTest.java -> ArtifactBuilderTest.kt

4 years agoTypeConstraint as DfaFactType
Tagir Valeev [Fri, 15 Sep 2017 06:31:42 +0000 (13:31 +0700)]
TypeConstraint as DfaFactType

4 years agoSpellchecker: (minor) buffered reader stream of lines instead of readLine() in cycle
Olga Strizhenko [Tue, 22 Aug 2017 14:50:59 +0000 (17:50 +0300)]
Spellchecker: (minor) buffered reader stream of lines instead of readLine() in cycle