idea/community.git
4 years agoadd missed ide.mac.native.save.dialog
Vladimir Krivosheev [Tue, 8 Nov 2016 12:31:59 +0000 (13:31 +0100)]
add missed ide.mac.native.save.dialog

4 years agosimplify — remove DebuggableRunConfiguration.RunConfigurationWithConditionalRun interface
Vladimir Krivosheev [Tue, 8 Nov 2016 10:19:50 +0000 (11:19 +0100)]
simplify — remove DebuggableRunConfiguration.RunConfigurationWithConditionalRun interface

4 years agocleanup
Vladimir Krivosheev [Tue, 8 Nov 2016 10:10:27 +0000 (11:10 +0100)]
cleanup

4 years agocheck method signature in lambdas and bridge methods
Egor.Ushakov [Tue, 8 Nov 2016 12:58:27 +0000 (15:58 +0300)]
check method signature in lambdas and bridge methods

4 years agoANSI Coloring in Remote Python Console (PY-21317)
Elizaveta Shashkova [Tue, 8 Nov 2016 12:58:23 +0000 (15:58 +0300)]
ANSI Coloring in Remote Python Console (PY-21317)

Since IPython 5 the terminal interface is not compatible with Emacs `inferior-shell` and the `simple_prompt` flag is needed

4 years agoCleanup (typo)
Roman Shevchenko [Tue, 8 Nov 2016 12:56:28 +0000 (13:56 +0100)]
Cleanup (typo)

4 years agoadditional hint in error message (IDEA-161564)
Eugene Zhuravlev [Tue, 8 Nov 2016 12:28:49 +0000 (13:28 +0100)]
additional hint in error message (IDEA-161564)

4 years agoCleanup (duplicates)
Roman Shevchenko [Tue, 8 Nov 2016 12:02:04 +0000 (13:02 +0100)]
Cleanup (duplicates)

4 years agoCleanup (deprecated code; warnings; formatting) clion/171.813
Roman Shevchenko [Tue, 8 Nov 2016 11:53:29 +0000 (12:53 +0100)]
Cleanup (deprecated code; warnings; formatting)

4 years agoIDEA-131828 IDEA-162423 diff: register toolbar shortcuts from popup action groups
Aleksey Pivovarov [Tue, 8 Nov 2016 11:41:45 +0000 (14:41 +0300)]
IDEA-131828 IDEA-162423 diff: register toolbar shortcuts from popup action groups

4 years agoIDEA-131828 merge: add "compare base with <...>" actions
Aleksey Pivovarov [Tue, 13 Sep 2016 11:20:15 +0000 (14:20 +0300)]
IDEA-131828 merge: add "compare base with <...>" actions

4 years agoui: do not expand default selection in Keymap
Aleksey Pivovarov [Tue, 8 Nov 2016 10:51:31 +0000 (13:51 +0300)]
ui: do not expand default selection in Keymap

4 years agovcs: better action order in Keymap
Aleksey Pivovarov [Tue, 8 Nov 2016 09:54:41 +0000 (12:54 +0300)]
vcs: better action order in Keymap

4 years agointroduce sdk comparator for JdkComboBox rubymine/171.810
Dmitry.Krasilschikov [Tue, 8 Nov 2016 10:42:53 +0000 (13:42 +0300)]
introduce sdk comparator for JdkComboBox

4 years agoget rid of duplicated code - move JdkComboBox model reloading logic into the model...
Dmitry.Krasilschikov [Mon, 7 Nov 2016 14:46:37 +0000 (17:46 +0300)]
get rid of duplicated code - move JdkComboBox model reloading logic into the model itself

4 years agoWI-33168 Application no longer takes focus when hitting a breakpoint in 2016.3 EAP... phpstorm/171.809
Svetlana.Zemlyanskaya [Tue, 8 Nov 2016 10:25:03 +0000 (11:25 +0100)]
WI-33168 Application no longer takes focus when hitting a breakpoint in 2016.3 EAP during PHP Debug (change log level)

4 years agofile gist minor changes (IDEA-CR-15461)
peter [Tue, 8 Nov 2016 10:08:27 +0000 (11:08 +0100)]
file gist minor changes (IDEA-CR-15461)

4 years agomove some useful read/write abstractions to DataInputOutputUtil
peter [Tue, 8 Nov 2016 09:59:22 +0000 (10:59 +0100)]
move some useful read/write abstractions to DataInputOutputUtil

4 years ago+contrib
Sergey Simonchik [Tue, 8 Nov 2016 10:09:25 +0000 (13:09 +0300)]
+contrib

4 years agoavoid caret visual position changes on parameter hints adding (IDEA-115424)
Dmitry Batrak [Tue, 8 Nov 2016 09:16:13 +0000 (12:16 +0300)]
avoid caret visual position changes on parameter hints adding (IDEA-115424)

fix side effect of horizontal scrolling not working correctly for Home/End on a long line

4 years agoshow first result and start background thread to check the rest when search for imple...
Anna.Kozlova [Tue, 8 Nov 2016 09:13:52 +0000 (10:13 +0100)]
show first result and start background thread to check the rest when search for implementations

4 years agoPY-21244 Fix type annotations for the built-in function "map" clion/171.807
Mikhail Golubev [Mon, 7 Nov 2016 17:44:44 +0000 (20:44 +0300)]
PY-21244 Fix type annotations for the built-in function "map"

4 years agoJava8ReplaceMapGetInspection: missing statements.length check is added (EA-91331) appcode/171.806
Tagir Valeev [Tue, 8 Nov 2016 08:49:54 +0000 (15:49 +0700)]
Java8ReplaceMapGetInspection: missing statements.length check is added (EA-91331)

4 years ago[devkit] EA-91294 - NPE: LanguageResolvingUtil.getStringConstantExpression
Yann Cébron [Tue, 8 Nov 2016 08:32:49 +0000 (09:32 +0100)]
[devkit] EA-91294 - NPE: LanguageResolvingUtil.getStringConstantExpression

4 years agoIDEA-84959 Billion laughs XML pasting/clipboard & create 100% CPU
Dmitry Avdeev [Tue, 8 Nov 2016 07:51:43 +0000 (10:51 +0300)]
IDEA-84959 Billion laughs XML pasting/clipboard & create 100% CPU

4 years agoPsiElementConcatenationInspectionTest: mock library interfaces instead of actually...
Tagir Valeev [Tue, 8 Nov 2016 05:22:39 +0000 (12:22 +0700)]
PsiElementConcatenationInspectionTest: mock library interfaces instead of actually loading them as library (IDEA-CR-15335)

4 years agoWin Installer: the reset icon cache is moved to the end of copying data to installati... idea/171.803 pycharm/171.804 pycharm/171.805
Vladimir.Orlov [Mon, 7 Nov 2016 15:28:16 +0000 (18:28 +0300)]
Win Installer: the reset icon cache is moved to the end of copying data to installation folder.

4 years agoExpressionUtils.getAssignmentTo
Tagir Valeev [Tue, 8 Nov 2016 03:32:21 +0000 (10:32 +0700)]
ExpressionUtils.getAssignmentTo

4 years agoJavaDoc for OptionalUtil#getOptionalElementType; MethodCallUtils#isCallToStaticMethod... webstorm/171.802
Tagir Valeev [Tue, 8 Nov 2016 03:16:52 +0000 (10:16 +0700)]
JavaDoc for OptionalUtil#getOptionalElementType; MethodCallUtils#isCallToStaticMethod created and used; ExpressionUtils#isIdentityMapping -> isReferenceTo; used where applicable (IDEA-CR-15464).

4 years agoFix test appcode/171.798 clion/171.800 dbe/171.794 idea/171.796 phpstorm/171.797 pycharm/171.792 pycharm/171.795 rubymine/171.799
Dmitry Trofimov [Mon, 7 Nov 2016 12:58:07 +0000 (13:58 +0100)]
Fix test

4 years agoMerge remote-tracking branch 'origin/master'
Konstantin Bulenkov [Mon, 7 Nov 2016 23:26:35 +0000 (02:26 +0300)]
Merge remote-tracking branch 'origin/master'

4 years agoIDEA-163617 Project view throws exception and becomes unavailable until IDE is restarted
Konstantin Bulenkov [Mon, 7 Nov 2016 23:23:54 +0000 (02:23 +0300)]
IDEA-163617 Project view throws exception and becomes unavailable until IDE is restarted

4 years agoavoid extra diskaccess for windows
Maxim.Mossienko [Mon, 7 Nov 2016 20:52:44 +0000 (21:52 +0100)]
avoid extra diskaccess for windows

4 years ago[groovy] @ListenerList: test AST not loaded
Daniil Ovchinnikov [Mon, 7 Nov 2016 18:29:25 +0000 (21:29 +0300)]
[groovy] @ListenerList: test AST not loaded

4 years ago[groovy] @ListenerList tests: move common stuff to setUp()
Daniil Ovchinnikov [Mon, 7 Nov 2016 18:04:14 +0000 (21:04 +0300)]
[groovy] @ListenerList tests: move common stuff to setUp()

4 years ago[groovy] @ListenerList: fix empty custom name processing, add tests
Daniil Ovchinnikov [Mon, 7 Nov 2016 17:42:31 +0000 (20:42 +0300)]
[groovy] @ListenerList: fix empty custom name processing, add tests

4 years agojunit 5 assertions conversion: skip assertNotEquals fix for delta-methods (IDEA-163354)
Anna.Kozlova [Mon, 7 Nov 2016 17:48:50 +0000 (18:48 +0100)]
junit 5 assertions conversion: skip assertNotEquals fix for delta-methods (IDEA-163354)

4 years agoensure sending tree is specified for root node even (IDEA-163309)
Anna.Kozlova [Mon, 7 Nov 2016 17:33:12 +0000 (18:33 +0100)]
ensure sending tree is specified for root node even (IDEA-163309)

4 years agojunit 4 compatibility: ensure no ClassNotFoundError is thrown for unsupported cases...
Anna.Kozlova [Mon, 7 Nov 2016 17:17:10 +0000 (18:17 +0100)]
junit 4 compatibility: ensure no ClassNotFoundError is thrown for unsupported cases (IDEA-163641)

4 years agojunit 5: warn about junit 3 methods inside classes with junit 5 annotations (IDEA...
Anna.Kozlova [Mon, 7 Nov 2016 16:51:29 +0000 (17:51 +0100)]
junit 5: warn about junit 3 methods inside classes with junit 5 annotations (IDEA-163651)

4 years agoreigiable local classes inside static methods (IDEA-163615)
Anna.Kozlova [Mon, 7 Nov 2016 16:39:11 +0000 (17:39 +0100)]
reigiable local classes inside static methods (IDEA-163615)

4 years ago[groovy] @ListenerList: highlight errors
Daniil Ovchinnikov [Mon, 7 Nov 2016 17:23:39 +0000 (20:23 +0300)]
[groovy] @ListenerList: highlight errors

4 years ago[groovy] @ListenerList: implement as transformation support
Daniil Ovchinnikov [Mon, 7 Nov 2016 15:18:43 +0000 (18:18 +0300)]
[groovy] @ListenerList: implement as transformation support

4 years ago[groovy] fix language level in tests
Daniil Ovchinnikov [Mon, 7 Nov 2016 17:17:47 +0000 (20:17 +0300)]
[groovy] fix language level in tests

4 years ago[groovy] extract findDeclaredDetachedValue() to utility file
Daniil Ovchinnikov [Mon, 7 Nov 2016 13:56:42 +0000 (16:56 +0300)]
[groovy] extract findDeclaredDetachedValue() to utility file

4 years ago[vcs]: (IDEA-163332) extended toggle action for pushDialog (win/linux fix) appcode/171.790
Nadya Zabrodina [Mon, 7 Nov 2016 16:57:12 +0000 (19:57 +0300)]
[vcs]: (IDEA-163332) extended toggle action for pushDialog (win/linux fix)

4 years ago[patch]: cleanUp - inline
Nadya Zabrodina [Mon, 7 Nov 2016 09:31:08 +0000 (12:31 +0300)]
[patch]: cleanUp - inline

4 years agoblockingGet — do not call await if not pending
Vladimir Krivosheev [Mon, 7 Nov 2016 16:39:07 +0000 (17:39 +0100)]
blockingGet — do not call await if not pending

4 years agoSSR: improve multi-matching references qualified with this or super (IDEA-144697)
Bas Leijdekkers [Mon, 7 Nov 2016 13:31:40 +0000 (14:31 +0100)]
SSR: improve multi-matching references qualified with this or super (IDEA-144697)

4 years agofix typo in regexp test data
Bas Leijdekkers [Mon, 7 Nov 2016 13:25:42 +0000 (14:25 +0100)]
fix typo in regexp test data

4 years ago[vcs-log] apply text filter on focus change only when it has some unsaved changes
Julia Beliaeva [Mon, 7 Nov 2016 15:58:05 +0000 (18:58 +0300)]
[vcs-log] apply text filter on focus change only when it has some unsaved changes

IDEA-146772

4 years agoRe-fix NPE by creating list when it's needed
Andrey Vlasovskikh [Mon, 7 Nov 2016 15:43:33 +0000 (18:43 +0300)]
Re-fix NPE by creating list when it's needed

We depend on the fact that myResult is null if there is no __all__ in
the current file, so we cannot initialize it with an empty list.

4 years agojavac ast indices: revert enable by default
Dmitry Batkovich [Mon, 7 Nov 2016 15:52:40 +0000 (18:52 +0300)]
javac ast indices: revert enable by default

4 years agojavac ast indices: enable by default
Dmitry Batkovich [Mon, 7 Nov 2016 15:22:27 +0000 (18:22 +0300)]
javac ast indices: enable by default

4 years agoIDEA-163567 FileChooserFactoryImpl.createSaveFileDialog doesn't use native file chooser
Denis Fokin [Mon, 7 Nov 2016 15:03:54 +0000 (18:03 +0300)]
IDEA-163567 FileChooserFactoryImpl.createSaveFileDialog doesn't use native file chooser

4 years agobatch inspections: use psi-elements as keys for RefManager's table (IDEA-156604) appcode/171.788 clion/171.789
Dmitry Batkovich [Mon, 7 Nov 2016 14:57:37 +0000 (17:57 +0300)]
batch inspections: use psi-elements as keys for RefManager's table (IDEA-156604)

4 years agoIDEA-84959 Billion laughs XML pasting/clipboard & create 100% CPU
Dmitry Avdeev [Mon, 7 Nov 2016 14:33:56 +0000 (17:33 +0300)]
IDEA-84959 Billion laughs XML pasting/clipboard & create 100% CPU

4 years agodisable emulation for native methods
Egor.Ushakov [Mon, 7 Nov 2016 14:09:44 +0000 (17:09 +0300)]
disable emulation for native methods

4 years agorun intentions under transaction (IDEA-CR-15393)
peter [Mon, 7 Nov 2016 13:54:36 +0000 (14:54 +0100)]
run intentions under transaction (IDEA-CR-15393)

4 years agoimprove runInReadActionWithWriteActionPriority, add assertion (IDEA-CR-15454)
peter [Mon, 7 Nov 2016 12:45:14 +0000 (13:45 +0100)]
improve runInReadActionWithWriteActionPriority, add assertion (IDEA-CR-15454)

4 years ago[vcs-log] check for rendering component being SimpleColoredComponent instead of direc...
Julia Beliaeva [Mon, 7 Nov 2016 14:01:59 +0000 (17:01 +0300)]
[vcs-log] check for rendering component being SimpleColoredComponent instead of direct call to GraphCommitCellRenderer method

EA-91206

4 years agomigrate to matchers inspection: fix for migration of "assertFalse(collection.contains...
Dmitry Batkovich [Mon, 7 Nov 2016 13:50:51 +0000 (16:50 +0300)]
migrate to matchers inspection: fix for migration of "assertFalse(collection.contains(item));" statement (IDEA-163310)

4 years agoprocess only prepared classes
Egor.Ushakov [Mon, 7 Nov 2016 13:36:40 +0000 (16:36 +0300)]
process only prepared classes

4 years agocleanup
Sergey Ignatov [Mon, 7 Nov 2016 13:27:11 +0000 (14:27 +0100)]
cleanup

4 years agoshow new scratch file action only in main menu and at well known popups
Sergey Ignatov [Mon, 7 Nov 2016 13:26:45 +0000 (14:26 +0100)]
show new scratch file action only in main menu and at well known popups

4 years agocleanup
Sergey Ignatov [Mon, 7 Nov 2016 13:24:36 +0000 (14:24 +0100)]
cleanup

4 years agoredundant throws inspection: do not cache created quick fixes
Dmitry Batkovich [Mon, 7 Nov 2016 13:11:31 +0000 (16:11 +0300)]
redundant throws inspection: do not cache created quick fixes

4 years agooverride NotNullLazyValue#isComputed to compare actual field (IDEA-CR-15467)
Sergey Simonchik [Mon, 7 Nov 2016 12:38:43 +0000 (15:38 +0300)]
override NotNullLazyValue#isComputed to compare actual field (IDEA-CR-15467)

4 years agoshow modal progress on setting emulated method breakpoints
Egor.Ushakov [Mon, 7 Nov 2016 12:25:55 +0000 (15:25 +0300)]
show modal progress on setting emulated method breakpoints

4 years agoWin Installer: "Installation Options" dialog correctly shows checkbox for downloading... idea/171.787
Vladimir.Orlov [Mon, 7 Nov 2016 12:21:18 +0000 (15:21 +0300)]
Win Installer: "Installation Options" dialog correctly shows checkbox for downloading jre64. Earlier it worked if oracle jre 64 had been preinstalled.

4 years agojavac ast indices: check that project is not disposed before read action (IDEA-CR...
Dmitry Batkovich [Mon, 7 Nov 2016 12:20:51 +0000 (15:20 +0300)]
javac ast indices: check that project is not disposed before read action (IDEA-CR-15200)

4 years ago[groovy] script declarations: make code even more readable
Daniil Ovchinnikov [Mon, 7 Nov 2016 12:13:13 +0000 (15:13 +0300)]
[groovy] script declarations: make code even more readable

4 years agorun highlighting and find-in-project in "impatient" mode (which cancels whenever...
Alexey Kudravtsev [Mon, 7 Nov 2016 10:58:15 +0000 (13:58 +0300)]
run highlighting and find-in-project in "impatient" mode (which cancels whenever pending write action is detected) to fix thread starvation issues like IDEA-162320 IDEA stuck after calling Find in path during indexing

4 years agocleanup
Alexey Kudravtsev [Mon, 31 Oct 2016 12:44:39 +0000 (15:44 +0300)]
cleanup

4 years agoone more case of "can't scan binary" exception fixed
Alexey Kudravtsev [Mon, 31 Oct 2016 12:41:12 +0000 (15:41 +0300)]
one more case of "can't scan binary" exception fixed

4 years ago[groovy] substitutor computer: use VolatileNotNullLazyValue since atomic is not reall...
Daniil Ovchinnikov [Mon, 7 Nov 2016 11:59:01 +0000 (14:59 +0300)]
[groovy] substitutor computer: use VolatileNotNullLazyValue since atomic is not really needed (follow up IDEA-CR-15466)

4 years agosimplify CtrlMouseHandler (IDEA-CR-15401) appcode/171.786 clion/171.785
peter [Mon, 7 Nov 2016 11:50:24 +0000 (12:50 +0100)]
simplify CtrlMouseHandler (IDEA-CR-15401)

4 years agocleanup
Daniil Ovchinnikov [Mon, 7 Nov 2016 11:25:41 +0000 (14:25 +0300)]
cleanup

4 years agooverride NotNullLazyValue#isComputed to compare actual field
Sergey Simonchik [Mon, 7 Nov 2016 11:38:50 +0000 (14:38 +0300)]
override NotNullLazyValue#isComputed to compare actual field

4 years agounused return value local inspection: don't treat void return types
Dmitry Batkovich [Mon, 7 Nov 2016 11:34:04 +0000 (14:34 +0300)]
unused return value local inspection: don't treat void return types

4 years ago[groovy] substitutor computer: compute exit points atomically
Daniil Ovchinnikov [Mon, 7 Nov 2016 11:01:37 +0000 (14:01 +0300)]
[groovy] substitutor computer: compute exit points atomically

4 years ago@NotNull
Daniil Ovchinnikov [Mon, 7 Nov 2016 11:00:38 +0000 (14:00 +0300)]
@NotNull

4 years agoIDEA-163627 Simplify optional.isPresent() inspection could better handle some specifi... phpstorm/171.784
Tagir Valeev [Mon, 7 Nov 2016 10:20:46 +0000 (17:20 +0700)]
IDEA-163627 Simplify optional.isPresent() inspection could better handle some specific cases
IDEA-163462 Simplify Optional.isPresent() ? Optional.get() : ...

4 years agouse PsiFileGist instead of time-expensive indices for contract inference idea/171.783
peter [Mon, 7 Nov 2016 10:10:19 +0000 (11:10 +0100)]
use PsiFileGist instead of time-expensive indices for contract inference

4 years agointroduce VirtualFileGist and PsiFileGist
peter [Mon, 7 Nov 2016 07:41:20 +0000 (08:41 +0100)]
introduce VirtualFileGist and PsiFileGist

4 years agointroduce local tool for unused return value
Dmitry Batkovich [Mon, 7 Nov 2016 09:55:29 +0000 (12:55 +0300)]
introduce local tool for unused return value

4 years agounused return value fix should replace return-statements in write action
Dmitry Batkovich [Mon, 7 Nov 2016 09:49:40 +0000 (12:49 +0300)]
unused return value fix should replace return-statements in write action

4 years agounused return value inspection: do not cache quick fix (otherwise it doesn't work...
Dmitry Batkovich [Mon, 7 Nov 2016 09:16:17 +0000 (12:16 +0300)]
unused return value inspection: do not cache quick fix (otherwise it doesn't work after inspection re-run)

4 years agojavac ast indices: revert getDirtyScope()
Dmitry Batkovich [Mon, 7 Nov 2016 08:15:07 +0000 (11:15 +0300)]
javac ast indices: revert getDirtyScope()

4 years agofix compilation
Vladimir Krivosheev [Mon, 7 Nov 2016 09:32:12 +0000 (10:32 +0100)]
fix compilation

4 years agoIDEA-163532 Speed search in popups preselects the last match instead of the first
Sergey Malenkov [Mon, 7 Nov 2016 09:22:00 +0000 (12:22 +0300)]
IDEA-163532 Speed search in popups preselects the last match instead of the first

4 years agoIDEA-155007 check shouldKillProcessSoftly
Vladimir Krivosheev [Mon, 7 Nov 2016 09:21:50 +0000 (10:21 +0100)]
IDEA-155007 check shouldKillProcessSoftly

4 years agotest for ManagingFS.getModificationCount appcode/171.782 clion/171.781
Maxim.Mossienko [Mon, 7 Nov 2016 08:20:06 +0000 (09:20 +0100)]
test for ManagingFS.getModificationCount

4 years agojavac ast indices: EA-91164 - IAE: ProjectFileIndexImpl.$$$reportNull$$$
Dmitry Batkovich [Mon, 7 Nov 2016 08:10:21 +0000 (11:10 +0300)]
javac ast indices: EA-91164 - IAE: ProjectFileIndexImpl.$$$reportNull$$$

4 years agoproject files conversion: don't print message to log if a file under .idea doesn...
nik [Mon, 7 Nov 2016 07:37:30 +0000 (10:37 +0300)]
project files conversion: don't print message to log if a file under .idea doesn't exist

E.g. .idea/misc.xml may not be created for new projects.

4 years agoadd ProgressManager#runInReadActionWithWriteActionPriority API
peter [Mon, 7 Nov 2016 07:25:14 +0000 (08:25 +0100)]
add ProgressManager#runInReadActionWithWriteActionPriority API

4 years agohandle project closing during commitAndRunReadAction
peter [Mon, 7 Nov 2016 07:16:11 +0000 (08:16 +0100)]
handle project closing during commitAndRunReadAction

4 years agoassert pom transactions and psi->doc sync happen on valid psi
peter [Mon, 7 Nov 2016 07:04:55 +0000 (08:04 +0100)]
assert pom transactions and psi->doc sync happen on valid psi

4 years agomake PersistentMap implement Closeable
peter [Sat, 5 Nov 2016 20:47:17 +0000 (21:47 +0100)]
make PersistentMap implement Closeable

4 years agoStreamToLoopInspection: added ExplicitCollectTerminalOperation; StreamVariable simpli...
Tagir Valeev [Mon, 7 Nov 2016 05:13:39 +0000 (12:13 +0700)]
StreamToLoopInspection: added ExplicitCollectTerminalOperation; StreamVariable simplified; guard checks added (IDEA-CR-15249)