idea/community.git
4 years agoMerge remote-tracking branch 'origin/master' into florian.kistner/OC-9471
Florian Kistner [Fri, 26 Jan 2018 13:26:30 +0000 (14:26 +0100)]
Merge remote-tracking branch 'origin/master' into florian.kistner/OC-9471

4 years agoIDEA-CR-26346 Build scripts: create silent config for windows installation. Copy... idea/181.3171
Vladimir.Orlov [Fri, 26 Jan 2018 13:10:08 +0000 (16:10 +0300)]
IDEA-CR-26346 Build scripts: create silent config for windows installation. Copy silent.config before modification to avoid affect to subsequent build.

4 years agoFix Java safe delete test
Alexander Zolotov [Fri, 26 Jan 2018 13:10:31 +0000 (16:10 +0300)]
Fix Java safe delete test

move caret to class declaration if it's not configure in testdata

4 years agoDo not retry running GitLineHandler with same-instance computable
Ivan Semenov [Mon, 18 Dec 2017 14:25:34 +0000 (17:25 +0300)]
Do not retry running GitLineHandler with same-instance computable

4 years agoBetter API for GitCommandResult with auth
Ivan Semenov [Mon, 18 Dec 2017 12:28:11 +0000 (15:28 +0300)]
Better API for GitCommandResult with auth

4 years agoGet rid of GitCommandResult.merge
Ivan Semenov [Fri, 15 Dec 2017 15:13:26 +0000 (18:13 +0300)]
Get rid of GitCommandResult.merge

4 years agoMove git exit code analysis to GitCommandResult from GitHandler
Ivan Semenov [Fri, 15 Dec 2017 12:18:53 +0000 (15:18 +0300)]
Move git exit code analysis to GitCommandResult from GitHandler

4 years agocleanup
Sergey Ignatov [Fri, 26 Jan 2018 12:11:39 +0000 (15:11 +0300)]
cleanup

4 years agoget rid of yellow code
Sergey Ignatov [Fri, 26 Jan 2018 12:11:32 +0000 (15:11 +0300)]
get rid of yellow code

4 years agoIDEA-150988 - fixed evaluate position
Egor Ushakov [Fri, 26 Jan 2018 12:21:47 +0000 (15:21 +0300)]
IDEA-150988 - fixed evaluate position

4 years agoreadme.md: remove mention of Xbootclasspath
nik [Fri, 26 Jan 2018 12:39:53 +0000 (15:39 +0300)]
readme.md: remove mention of Xbootclasspath

It isn't required to run IDE or tests anymore (IDEA-185591).

4 years agoIDEA-185546 Project files new arrow (2018 EAP) location is inconsistent
Sergey Malenkov [Fri, 26 Jan 2018 12:35:05 +0000 (15:35 +0300)]
IDEA-185546 Project files new arrow (2018 EAP) location is inconsistent

4 years agonew statistics 2018.1: feature-usages-statistics(fus) service: sessions persistence...
sergey.vasiliev [Wed, 24 Jan 2018 15:06:46 +0000 (16:06 +0100)]
new statistics 2018.1: feature-usages-statistics(fus) service: sessions persistence, schedulers, cleanups

4 years agoWhen one popup has been already closed, and another is opening, the opposite window...
Denis Fokin [Fri, 26 Jan 2018 12:10:47 +0000 (15:10 +0300)]
When one popup has been already closed, and another is opening, the opposite window could be null.
This is not the best criteria to close all popups.

4 years agobuild scripts: remove Xbootclasspath from IDE command line args
nik [Fri, 26 Jan 2018 12:12:15 +0000 (15:12 +0300)]
build scripts: remove Xbootclasspath from IDE command line args

It isn't required anymore (IDEA-185591).

4 years agotest data fixed: missed carets restored
Dmitry Avdeev [Fri, 26 Jan 2018 11:55:27 +0000 (14:55 +0300)]
test data fixed: missed carets restored

4 years agorevert changes appcode/181.3169 clion/181.3167
Vladimir Krivosheev [Fri, 26 Jan 2018 10:50:55 +0000 (11:50 +0100)]
revert changes

4 years agorevert changes
Vladimir Krivosheev [Fri, 26 Jan 2018 10:40:41 +0000 (11:40 +0100)]
revert changes

4 years agofix testSurviveOnProjectReopen
Vladimir Krivosheev [Fri, 26 Jan 2018 10:36:12 +0000 (11:36 +0100)]
fix testSurviveOnProjectReopen

4 years agoImportedFacetsSerializationTest — set isCreateProjectFileExplicitly to false
Vladimir Krivosheev [Fri, 26 Jan 2018 09:57:27 +0000 (10:57 +0100)]
ImportedFacetsSerializationTest — set isCreateProjectFileExplicitly to false

4 years agoRunManager state is required for JPS
Vladimir Krivosheev [Fri, 26 Jan 2018 09:52:40 +0000 (10:52 +0100)]
RunManager state is required for JPS

4 years agofix tests
Vladimir Krivosheev [Fri, 26 Jan 2018 09:51:57 +0000 (10:51 +0100)]
fix tests

4 years agosome heavy tests requires created project base dir
Vladimir Krivosheev [Thu, 25 Jan 2018 17:29:40 +0000 (18:29 +0100)]
some heavy tests requires created project base dir

4 years agoprefer getModuleFilePath
Vladimir Krivosheev [Thu, 25 Jan 2018 17:21:11 +0000 (18:21 +0100)]
prefer getModuleFilePath

4 years agoprefer getModuleFilePath
Vladimir Krivosheev [Thu, 25 Jan 2018 16:33:17 +0000 (17:33 +0100)]
prefer getModuleFilePath

4 years agorename to more clear getProjectBaseDir
Vladimir Krivosheev [Thu, 25 Jan 2018 16:21:58 +0000 (17:21 +0100)]
rename to more clear getProjectBaseDir

4 years agoprefer getBasePath()
Vladimir Krivosheev [Thu, 25 Jan 2018 16:21:12 +0000 (17:21 +0100)]
prefer getBasePath()

4 years agoprefer getBasePath()
Vladimir Krivosheev [Thu, 25 Jan 2018 16:16:14 +0000 (17:16 +0100)]
prefer getBasePath()

4 years agoPlatformTestCase — do not create project/module files explicitly
Vladimir Krivosheev [Thu, 25 Jan 2018 15:19:41 +0000 (16:19 +0100)]
PlatformTestCase — do not create project/module files explicitly

4 years agoAbility for jar plugins to load optional dependencies from classpath
Maxim.Mossienko [Fri, 26 Jan 2018 11:36:40 +0000 (12:36 +0100)]
Ability for jar plugins to load optional dependencies from classpath

Current use case is to enable the loading for plugin testing purpose
when explicitly requested by system property (PR-701).

4 years agoPY-28016 Reset PyPIPackageCache in setUp() to read it anew in the test
Mikhail Golubev [Fri, 26 Jan 2018 09:35:03 +0000 (12:35 +0300)]
PY-28016 Reset PyPIPackageCache in setUp() to read it anew in the test

4 years agoIDEA-185286 Bug in PopupFactoryImpl.guessBestPopupLocation(Editor)
Yii.Guxing [Fri, 26 Jan 2018 11:22:13 +0000 (14:22 +0300)]
IDEA-185286 Bug in PopupFactoryImpl.guessBestPopupLocation(Editor)

4 years agoIDEA project configuration: remove Xbootclasspath from run configurations phpstorm/181.3164
nik [Fri, 26 Jan 2018 10:59:20 +0000 (13:59 +0300)]
IDEA project configuration: remove Xbootclasspath from run configurations

It isn't required anymore (IDEA-185591).

4 years agocleanup: fixing removed field name in comments
Maxim.Mossienko [Fri, 26 Jan 2018 10:17:25 +0000 (11:17 +0100)]
cleanup: fixing removed field name in comments

4 years agoFix DialogWrapper active component focusable search for error validation
Kirill Kirichenko [Fri, 26 Jan 2018 10:00:50 +0000 (13:00 +0300)]
Fix DialogWrapper active component focusable search for error validation

4 years agoDelegate background setter/getter in ComboBoxCompositeEditor to the editor delegate
Kirill Kirichenko [Fri, 26 Jan 2018 09:59:25 +0000 (12:59 +0300)]
Delegate background setter/getter in ComboBoxCompositeEditor to the editor delegate

4 years agoAlign JButton height with combobox/textfield in Darcula
Kirill Kirichenko [Fri, 26 Jan 2018 09:56:59 +0000 (12:56 +0300)]
Align JButton height with combobox/textfield in Darcula

4 years agoFix Darcula ComboBox with EditorTextField in disabled state
Kirill Kirichenko [Fri, 26 Jan 2018 09:55:42 +0000 (12:55 +0300)]
Fix Darcula ComboBox with EditorTextField in disabled state

4 years agoIDEA-169748 Fix DarculaPasswordFieldUI
Kirill Kirichenko [Fri, 26 Jan 2018 09:53:54 +0000 (12:53 +0300)]
IDEA-169748 Fix DarculaPasswordFieldUI

4 years agodependencies: use qualified module names clion/181.3162
Vladislav.Soroka [Fri, 26 Jan 2018 09:49:56 +0000 (12:49 +0300)]
dependencies: use qualified module names

4 years agoPsiParameterList#isEmpty; isEmpty and getParametersCount used where possible
Tagir Valeev [Fri, 26 Jan 2018 09:39:23 +0000 (16:39 +0700)]
PsiParameterList#isEmpty; isEmpty and getParametersCount used where possible

4 years agoControlFlowAnalyzer: redundant variable removed
Tagir Valeev [Fri, 26 Jan 2018 09:16:53 +0000 (16:16 +0700)]
ControlFlowAnalyzer: redundant variable removed

4 years agocapture agent: capture this in constructors only once, avoid chained constructor...
Egor Ushakov [Fri, 26 Jan 2018 09:25:36 +0000 (12:25 +0300)]
capture agent: capture this in constructors only once, avoid chained constructor calls

4 years agoIDEA project configuration: 'android.sdktools.layoutlib' module renamed
nik [Fri, 26 Jan 2018 09:24:05 +0000 (12:24 +0300)]
IDEA project configuration: 'android.sdktools.layoutlib' module renamed

...to 'intellij.android.layoutlib' because actually the module is located in Android Plugin sources and depends on IDE classes.

4 years agoAutoCloseableResourceInspection: warning on Files.lines,...: IDEA-182784
Roman Ivanov [Fri, 26 Jan 2018 09:17:27 +0000 (16:17 +0700)]
AutoCloseableResourceInspection: warning on Files.lines,...: IDEA-182784

4 years agoGuessManagerImpl: do not run DFA if assignment right-hands have the same type as...
Tagir Valeev [Fri, 26 Jan 2018 09:12:05 +0000 (16:12 +0700)]
GuessManagerImpl: do not run DFA if assignment right-hands have the same type as left-hands

Fixes IDEA-185290 Too long time takes filling of Ctrl+Space list. (fast code insertion)

4 years agoIDEA project configuration: 'android.sdktools.layoutlib' module renamed
nik [Fri, 26 Jan 2018 09:03:42 +0000 (12:03 +0300)]
IDEA project configuration: 'android.sdktools.layoutlib' module renamed

...to 'intellij.android.layoutlib' because actually the module is located in Android Plugin sources and depends on IDE classes.

4 years agoJavaCompletionUtil: do not add an unnecessary cast if hierarchy signature has several... appcode/181.3158
Tagir Valeev [Fri, 26 Jan 2018 08:05:05 +0000 (15:05 +0700)]
JavaCompletionUtil: do not add an unnecessary cast if hierarchy signature has several levels

Fixes IDEA-185554 Redundant cast on autocompletion

4 years agoIDEA-185093 Second popup sometimes dissapers idea/181.3157
Denis Fokin [Fri, 26 Jan 2018 07:58:16 +0000 (10:58 +0300)]
IDEA-185093 Second popup sometimes dissapers

4 years agoplatform: remove -Xbootclasspath arguments from IDE command line
nik [Fri, 26 Jan 2018 07:54:03 +0000 (10:54 +0300)]
platform: remove -Xbootclasspath arguments from IDE command line

It isn't required to have boot.jar on bootclasspath, it's enough to have its classes on the regular classpath (IDEA-185591). Now classes from 'intellij.platform.boot' module are packed into bootstrap.jar.

4 years agoplatform: remove -Xbootclasspath arguments from IDE command line
nik [Fri, 26 Jan 2018 07:20:57 +0000 (10:20 +0300)]
platform: remove -Xbootclasspath arguments from IDE command line

It isn't required to have boot.jar on bootclasspath, it's enough to have its classes on the regular classpath (IDEA-185591).

4 years agobuild scripts: javadoc refined
nik [Thu, 25 Jan 2018 16:04:25 +0000 (19:04 +0300)]
build scripts: javadoc refined

4 years agocleanup: remove obsolete unused build.xml
nik [Thu, 25 Jan 2018 15:20:05 +0000 (18:20 +0300)]
cleanup: remove obsolete unused build.xml

4 years agoConstantExpressionInspection: display computed value in inspection message, cosmetics
Tagir Valeev [Fri, 26 Jan 2018 05:36:52 +0000 (12:36 +0700)]
ConstantExpressionInspection: display computed value in inspection message, cosmetics

Review ID: IDEA-CR-28753

4 years agoIDEA-185548 Inspection to remove excessive Comparator.comparing call
Tagir Valeev [Fri, 26 Jan 2018 05:25:32 +0000 (12:25 +0700)]
IDEA-185548 Inspection to remove excessive Comparator.comparing call

4 years agoPsiExpressionList: added getExpressionCount() and isEmpty()
Tagir Valeev [Fri, 26 Jan 2018 04:14:27 +0000 (11:14 +0700)]
PsiExpressionList: added getExpressionCount() and isEmpty()

Optimized implementations in PsiExpressionListImpl, usages replaced where possible

4 years agoTryFinallyCanBeTryWithResources:remove finally if no stmt: IDEA-CR-28726 pycharm/181.3155 pycharm/181.3156
Roman Ivanov [Thu, 25 Jan 2018 10:26:19 +0000 (17:26 +0700)]
TryFinallyCanBeTryWithResources:remove finally if no stmt: IDEA-CR-28726

4 years agoTryFinallyCanBeTryWithResources: support java 9 variables : IDEA-171304
Roman Ivanov [Wed, 24 Jan 2018 09:52:26 +0000 (16:52 +0700)]
TryFinallyCanBeTryWithResources: support java 9 variables : IDEA-171304

4 years agoAutoCloseableResourceInspection: invert func, move class : IDEA-CR-28727
Roman Ivanov [Thu, 25 Jan 2018 09:37:48 +0000 (16:37 +0700)]
AutoCloseableResourceInspection: invert func, move class : IDEA-CR-28727

4 years agoAutoCloseableResourceInspection: ignore immediately closed : IDEA-171866
Roman Ivanov [Tue, 26 Dec 2017 04:26:07 +0000 (11:26 +0700)]
AutoCloseableResourceInspection: ignore immediately closed : IDEA-171866

4 years agoAutoCloseableResourceInspection: add EP to ignore implicit close
Roman Ivanov [Mon, 25 Dec 2017 11:14:45 +0000 (18:14 +0700)]
AutoCloseableResourceInspection: add EP to ignore implicit close

4 years agoIntentionPowerPackBundle.properties: restored constant.expression.intention.name webstorm/181.3154
Tagir Valeev [Fri, 26 Jan 2018 03:10:55 +0000 (10:10 +0700)]
IntentionPowerPackBundle.properties: restored constant.expression.intention.name

Used in constant subexpression intention action

4 years agoComparatorCombinatorsInspection: disable explicitly for Java <8
Tagir Valeev [Thu, 25 Jan 2018 10:12:59 +0000 (17:12 +0700)]
ComparatorCombinatorsInspection: disable explicitly for Java <8

4 years agounderTeamcity check moved to PyEnvTestSettings to improve logging appcode/181.3152 dbe/181.3147 idea/181.3145 phpstorm/181.3146 pycharm/181.3149 pycharm/181.3150 rubymine/181.3151
Ilya.Kazakevich [Thu, 25 Jan 2018 23:19:37 +0000 (02:19 +0300)]
underTeamcity check moved to PyEnvTestSettings to improve logging

4 years agoPython test Env configurations refactored dbe/181.3143 idea/181.3142
Ilya.Kazakevich [Thu, 25 Jan 2018 22:09:42 +0000 (01:09 +0300)]
Python test Env configurations refactored

4 years agoa better fix progress presentation mode for HiDPI Linux
Sergey Ignatov [Thu, 25 Jan 2018 21:25:53 +0000 (00:25 +0300)]
a better fix progress presentation mode for HiDPI Linux

scale progress bar prefered size properly, there's no need to fill the
whole row with it

avoid progress bar twitching

4 years agocleanup in passing loader options around
Maxim.Mossienko [Thu, 25 Jan 2018 20:40:32 +0000 (21:40 +0100)]
cleanup in passing loader options around

4 years ago[gui-test] fix home
Sergey Karashevich [Thu, 25 Jan 2018 20:34:55 +0000 (23:34 +0300)]
[gui-test] fix home

4 years agoAdd option to tolerate unexpected problem with jar file (IDEA-163705)
Maxim.Mossienko [Thu, 25 Jan 2018 20:30:14 +0000 (21:30 +0100)]
Add option to tolerate unexpected problem with jar file (IDEA-163705)

4 years agoWEB-21129: parameters -> params
Dennis Ushakov [Thu, 25 Jan 2018 20:05:47 +0000 (23:05 +0300)]
WEB-21129: parameters -> params

4 years ago[gui-test] fix relative path for the origin gant script
Sergey Karashevich [Thu, 25 Jan 2018 19:55:14 +0000 (22:55 +0300)]
[gui-test] fix relative path for the origin gant script

4 years agoEA-115156 - NPE: FindPopupDirectoryChooser.<init>
Vassiliy.Kudryashov [Thu, 25 Jan 2018 19:02:03 +0000 (22:02 +0300)]
EA-115156 - NPE: FindPopupDirectoryChooser.<init>

4 years ago[gui-test] add an optional prepare gant script to setup environment
Sergey Karashevich [Thu, 25 Jan 2018 18:19:19 +0000 (21:19 +0300)]
[gui-test] add an optional prepare gant script to setup environment

This script is needed to perform a custom shell script to setup environment before running tests, e.g. to start X server for UI tests.

4 years agoIDEA-185543: custom implementation of getPreferredScrollableViewportSize
Sergey Malenkov [Thu, 25 Jan 2018 17:48:43 +0000 (20:48 +0300)]
IDEA-185543: custom implementation of getPreferredScrollableViewportSize

4 years agoIDEA-185008 Show usages is closed on escape in usages settings dialog
Denis Fokin [Thu, 25 Jan 2018 17:26:06 +0000 (20:26 +0300)]
IDEA-185008 Show usages is closed on escape in usages settings dialog

4 years agoIDEA-185581 Can't add new Startup Tasks configuration
Denis Fokin [Thu, 25 Jan 2018 16:57:33 +0000 (19:57 +0300)]
IDEA-185581 Can't add new Startup Tasks configuration

4 years agoDon't pass null value for allRenames to RenamePsiElementProcessor#findCollisions()
Mikhail Golubev [Thu, 25 Jan 2018 16:06:39 +0000 (19:06 +0300)]
Don't pass null value for allRenames to RenamePsiElementProcessor#findCollisions()

since its nullability contract has changed.

Additionally, properly pass all elements renamed during change signature
instead, despite the fact that implementations of RenamePsiElementProcessor
for Python don't use it anyhow at the moment.

4 years agoCorrectly source paths with spaces (PY-28113)
Dmitry Trofimov [Thu, 25 Jan 2018 14:16:05 +0000 (15:16 +0100)]
Correctly source paths with spaces (PY-28113)

4 years agocapture agent: cleanup
Egor Ushakov [Thu, 25 Jan 2018 16:16:06 +0000 (19:16 +0300)]
capture agent: cleanup

4 years agocapture agent: speedup on java 9, avoid calling getStackTraceDepth all the time
Egor Ushakov [Thu, 25 Jan 2018 16:12:10 +0000 (19:12 +0300)]
capture agent: speedup on java 9, avoid calling getStackTraceDepth all the time

4 years ago[followup] Log PNG/SVG icons load time statistics dbe/181.3136
Anton Tarasov [Thu, 25 Jan 2018 16:03:48 +0000 (19:03 +0300)]
[followup] Log PNG/SVG icons load time statistics

fix ConcurrentModificationException

4 years agovcs: do not report error for changes without mappings
Aleksey Pivovarov [Thu, 25 Jan 2018 13:24:03 +0000 (16:24 +0300)]
vcs: do not report error for changes without mappings

* related PartialChangeTracker could've been removed during update

4 years agovcs: do not use actual trackers in ChangeListUpdater
Aleksey Pivovarov [Thu, 25 Jan 2018 13:57:08 +0000 (16:57 +0300)]
vcs: do not use actual trackers in ChangeListUpdater

4 years agoredundant deprecation removed
Alexey Kudravtsev [Thu, 25 Jan 2018 15:22:36 +0000 (18:22 +0300)]
redundant deprecation removed

4 years agocleanup
Alexey Kudravtsev [Thu, 25 Jan 2018 14:36:33 +0000 (17:36 +0300)]
cleanup

4 years agoUse env vars for tests instead of sys.properties
Ilya.Kazakevich [Thu, 25 Jan 2018 15:42:05 +0000 (18:42 +0300)]
Use env vars for tests instead of sys.properties

It may not be easy to push java properties through runner
in TC, so we use env var.

4 years agoSupport incomplete stubs by changing language level to Python 3.7 (PY-22868)
Semyon Proshev [Tue, 23 Jan 2018 18:01:55 +0000 (21:01 +0300)]
Support incomplete stubs by changing language level to Python 3.7 (PY-22868)

4 years agovcs: deprecate `Consumer<VcsDirtyScopeManager>` in `CLM.invokeAfterUpdate()`
Aleksey Pivovarov [Sun, 14 Jan 2018 18:55:37 +0000 (21:55 +0300)]
vcs: deprecate `Consumer<VcsDirtyScopeManager>` in `CLM.invokeAfterUpdate()`

follow-up: 4cfac8006412037e5fc17f478dce7ac25d641348

4 years agovcs: do not move changes to affected changelist explicitly in "Apply Patch"
Aleksey Pivovarov [Thu, 18 Jan 2018 17:41:24 +0000 (20:41 +0300)]
vcs: do not move changes to affected changelist explicitly in "Apply Patch"

* switch default changelist instead
* this enables support for Partial changes for applied patches

4 years agovcs: simplify - remove code duplication
Aleksey Pivovarov [Thu, 18 Jan 2018 12:59:03 +0000 (15:59 +0300)]
vcs: simplify - remove code duplication

4 years agovcs: simplify - unify code flows for similar methods
Aleksey Pivovarov [Thu, 18 Jan 2018 12:51:40 +0000 (15:51 +0300)]
vcs: simplify - unify code flows for similar methods

* refresh and move to target changelist at the very end

4 years agovcs: simplify - inline helper class
Aleksey Pivovarov [Thu, 18 Jan 2018 12:03:24 +0000 (15:03 +0300)]
vcs: simplify - inline helper class

4 years agovcs: simplify - extract method
Aleksey Pivovarov [Sun, 14 Jan 2018 19:34:30 +0000 (22:34 +0300)]
vcs: simplify - extract method

4 years agovcs: remove support for CustomBinaryPatchApplier
Aleksey Pivovarov [Thu, 18 Jan 2018 11:56:41 +0000 (14:56 +0300)]
vcs: remove support for CustomBinaryPatchApplier

4 years agovcs: better error message if we failed to rollback partially applied patch
Aleksey Pivovarov [Sun, 14 Jan 2018 18:47:22 +0000 (21:47 +0300)]
vcs: better error message if we failed to rollback partially applied patch

4 years agovcs: cleanup
Aleksey Pivovarov [Thu, 18 Jan 2018 11:48:33 +0000 (14:48 +0300)]
vcs: cleanup

4 years agovcs: remove generics from PathsVerifier
Aleksey Pivovarov [Thu, 18 Jan 2018 11:45:44 +0000 (14:45 +0300)]
vcs: remove generics from PathsVerifier

* they are not needed and do not contribute to type safety

4 years agovcs: introduce data class
Aleksey Pivovarov [Thu, 18 Jan 2018 11:42:48 +0000 (14:42 +0300)]
vcs: introduce data class

4 years agovcs: apply patch - remove custom binary patch applied for shelve
Aleksey Pivovarov [Thu, 18 Jan 2018 11:18:55 +0000 (14:18 +0300)]
vcs: apply patch - remove custom binary patch applied for shelve

* it can be handled by default logic now

4 years agovcs: simplify - inline couple of methods
Aleksey Pivovarov [Thu, 18 Jan 2018 11:13:57 +0000 (14:13 +0300)]
vcs: simplify - inline couple of methods