idea/community.git
3 years agoMerge remote-tracking branch 'stats-collector/master' into community/master
Vitaliy.Bibaev [Mon, 7 May 2018 15:32:08 +0000 (18:32 +0300)]
Merge remote-tracking branch 'stats-collector/master' into community/master

3 years agoAC/C++: CPP-11711 Freezes related to SearchEverywhere
Dmitry Semeniouta [Tue, 13 Feb 2018 12:44:34 +0000 (15:44 +0300)]
AC/C++: CPP-11711 Freezes related to SearchEverywhere

(cherry picked from commit bdc3bae)

3 years agoallow for javadoc to autopopup together with completion (IDEA-76223)
peter [Fri, 4 May 2018 09:43:50 +0000 (11:43 +0200)]
allow for javadoc to autopopup together with completion (IDEA-76223)

3 years agowhen lookup is shown, display documentation only for lookup items
peter [Fri, 4 May 2018 09:20:25 +0000 (11:20 +0200)]
when lookup is shown, display documentation only for lookup items

it's strange when doc popup is aligned to selected lookup item but shows doc for something else
even stranger if this happens automatically (IDEA-76223)

3 years agoUi DSL — get rid of setDefaultVisualPadding, get rid of static debug millis in test...
Vladimir Krivosheev [Fri, 4 May 2018 09:48:49 +0000 (11:48 +0200)]
Ui DSL — get rid of setDefaultVisualPadding, get rid of static debug millis in test, do not paint debug grid (but still enable debug mode to compute debug bounds)

3 years agoInlined file variable
Rustam Vishnyakov [Fri, 4 May 2018 09:22:14 +0000 (12:22 +0300)]
Inlined file variable

https://upsource.jetbrains.com/IDEA/review/IDEA-CR-32092?commentId=ddf03cd4-ea99-4c3e-8c26-8ebace06e04c&filePath=/community/plugins/InspectionGadgets/src/com/siyeh/ig/migration/WhileCanBeForeachInspection.java

3 years agoIDEA-CR-32092 Migration to PsiFile-based CodeStyle API
Rustam Vishnyakov [Fri, 4 May 2018 09:16:10 +0000 (12:16 +0300)]
IDEA-CR-32092 Migration to PsiFile-based CodeStyle API

3 years agoManualArrayCopyInspection: minor, typo appcode/182.2097
Roman.Ivanov [Fri, 4 May 2018 08:56:45 +0000 (15:56 +0700)]
ManualArrayCopyInspection: minor, typo

3 years agoadd help id for "Add/Edit Method Contract" dialog (DOC-4391) clion/182.2096
peter [Fri, 4 May 2018 08:54:09 +0000 (10:54 +0200)]
add help id for "Add/Edit Method Contract" dialog (DOC-4391)

3 years agoRename IconCache to LafIconLookup and remove redundant cache from it
Kirill Kirichenko [Fri, 4 May 2018 08:30:44 +0000 (11:30 +0300)]
Rename IconCache to LafIconLookup and remove redundant cache from it

3 years agoIDEA-190424 New Darcula radio/checkbox svg icons
Kirill Kirichenko [Fri, 4 May 2018 08:28:32 +0000 (11:28 +0300)]
IDEA-190424 New Darcula radio/checkbox svg icons

3 years agoWrapperTypeMayBePrimitive: add version to description
Roman.Ivanov [Fri, 4 May 2018 08:42:38 +0000 (15:42 +0700)]
WrapperTypeMayBePrimitive: add version to description

3 years agoManualArrayCopyInspection: prevent changing semantics : IDEA-52481
Roman.Ivanov [Fri, 4 May 2018 08:17:04 +0000 (15:17 +0700)]
ManualArrayCopyInspection: prevent changing semantics : IDEA-52481

3 years agounnecessarily qualified inner class: check accessibility
Anna.Kozlova [Thu, 3 May 2018 17:31:04 +0000 (19:31 +0200)]
unnecessarily qualified inner class: check accessibility

3 years agoremove duplicated check for onTheFly mode
Anna.Kozlova [Thu, 3 May 2018 17:08:47 +0000 (19:08 +0200)]
remove duplicated check for onTheFly mode

3 years agoIDEA-107264 Don't repeatedly steal focus on project opening
Denis Fokin [Fri, 4 May 2018 07:17:15 +0000 (10:17 +0300)]
IDEA-107264 Don't repeatedly steal focus on project opening

3 years agoadd AnnotationUtil.flattenArray
peter [Fri, 4 May 2018 05:32:06 +0000 (07:32 +0200)]
add AnnotationUtil.flattenArray

to unify special single array element processing in annotation attributes

3 years agoGradle/C++: workaround NoClassDefFoundError sometimes happened on CI windows10 agent...
Vladislav.Soroka [Fri, 4 May 2018 05:22:53 +0000 (08:22 +0300)]
Gradle/C++: workaround NoClassDefFoundError sometimes happened on CI windows10 agent with MSVC 2017

3 years agoIDEA-191092 Bundle External systems API as a separate plugin for CLion pycharm/182.2094 pycharm/182.2095
Vladislav.Soroka [Thu, 3 May 2018 07:50:48 +0000 (10:50 +0300)]
IDEA-191092 Bundle External systems API as a separate plugin for CLion

3 years agoAddExceptionToExistingCatchFix: check if element is valid: IDEA-191360
Roman.Ivanov [Fri, 4 May 2018 03:59:42 +0000 (10:59 +0700)]
AddExceptionToExistingCatchFix: check if element is valid: IDEA-191360

3 years agoWrapperTypeMayBePrimitiveInspection: convert boxed calls when possible
Roman.Ivanov [Thu, 3 May 2018 12:24:08 +0000 (19:24 +0700)]
WrapperTypeMayBePrimitiveInspection: convert boxed calls when possible

3 years agoIDEA-182875 Move expand/collapse icons to the tool window header appcode/182.2092 clion/182.2090 dbe/182.2088 idea/182.2087 phpstorm/182.2086 pycharm/182.2085 pycharm/182.2091 rubymine/182.2089 webstorm/182.2093
Vassiliy.Kudryashov [Thu, 3 May 2018 22:27:56 +0000 (01:27 +0300)]
IDEA-182875 Move expand/collapse icons to the tool window header

Step 1: header redesign

3 years agoAdd Associate With File Type action to Editor Tab actions
Konstantin Bulenkov [Thu, 3 May 2018 20:32:31 +0000 (22:32 +0200)]
Add Associate With File Type action to Editor Tab actions

IDEA-97714 Add "Associate With File Type" to the editor tab context menu and menu

3 years agoclean up. simplify getting project from data context
Konstantin Bulenkov [Thu, 3 May 2018 19:44:04 +0000 (21:44 +0200)]
clean up. simplify getting project from data context

3 years agoadd ellipsis to Associate File Type action text
Konstantin Bulenkov [Thu, 3 May 2018 19:42:31 +0000 (21:42 +0200)]
add ellipsis to Associate File Type action text

3 years agoIDEA-190937 Change scratch language not always updates file extension 2
Gregory.Shrago [Thu, 3 May 2018 19:55:34 +0000 (22:55 +0300)]
IDEA-190937 Change scratch language not always updates file extension 2

Support scratches with
1. no extension (e.g. scratch1)
2. multipart extension (e.g. blade)
3. undetectable extensions (e.g. ApacheConfig)

3 years agodrop extra dot in default extension
Gregory.Shrago [Thu, 3 May 2018 19:49:36 +0000 (22:49 +0300)]
drop extra dot in default extension

3 years agosvn: Fix null trunk url processing while reading branch configuration
Konstantin Kolosovsky [Thu, 3 May 2018 19:31:18 +0000 (22:31 +0300)]
svn: Fix null trunk url processing while reading branch configuration

IDEA-190935

3 years agoensure ProcessOutputType.getBaseOutputType returns STDOUT/STDERR/SYSTEM
Sergey Simonchik [Thu, 3 May 2018 18:02:42 +0000 (21:02 +0300)]
ensure ProcessOutputType.getBaseOutputType returns STDOUT/STDERR/SYSTEM

3 years agoPostprocessReformattingAspect: remove unused psi-text consistency check
peter [Thu, 3 May 2018 15:48:17 +0000 (17:48 +0200)]
PostprocessReformattingAspect: remove unused psi-text consistency check

and PsiTreeDebugBuilder with its only remaining usage as well

3 years agoDebugUtil.psiToStringIgnoringNonCode: ignore empty non-whitespace leaves
peter [Thu, 3 May 2018 15:44:24 +0000 (17:44 +0200)]
DebugUtil.psiToStringIgnoringNonCode: ignore empty non-whitespace leaves

e.g. newlines in some languages

3 years agoProject view change doesn't reflect updated theme
Konstantin Bulenkov [Thu, 3 May 2018 16:53:52 +0000 (18:53 +0200)]
Project view change doesn't reflect updated theme

https://github.com/JetBrains/intellij-community/pull/784
http://b.android.com/208136

3 years agodon't accept private method as super; check same virtual method without cast
Anna.Kozlova [Thu, 3 May 2018 16:48:13 +0000 (18:48 +0200)]
don't accept private method as super; check same virtual method without cast

IDEA-191197

3 years agofix getRefs/getDefs consistency
Anna.Kozlova [Thu, 3 May 2018 16:42:07 +0000 (18:42 +0200)]
fix getRefs/getDefs consistency

IDEA-CR-32302

3 years agodisable drop for non yet initialized projects
Anna.Kozlova [Thu, 3 May 2018 15:20:50 +0000 (17:20 +0200)]
disable drop for non yet initialized projects

EA-119730 - assert: DumbServiceImpl.completeJustSubmittedTasks

3 years ago[project] renames Windows file watcher directory clion/182.2084
Roman Shevchenko [Thu, 3 May 2018 16:43:33 +0000 (18:43 +0200)]
[project] renames Windows file watcher directory

3 years ago[project] migrates Windows file watcher build to CMake
Roman Shevchenko [Thu, 3 May 2018 16:35:27 +0000 (18:35 +0200)]
[project] migrates Windows file watcher build to CMake

3 years agoUi DSL — fix baseline align for TextField
Vladimir Krivosheev [Thu, 3 May 2018 15:40:49 +0000 (17:40 +0200)]
Ui DSL — fix baseline align for TextField

3 years agocleanup (use already introduced local variable)
Dmitry Batkovich [Tue, 6 Feb 2018 13:36:03 +0000 (16:36 +0300)]
cleanup (use already introduced local variable)

3 years agomake methods private
Dmitry Batkovich [Tue, 6 Feb 2018 13:36:03 +0000 (16:36 +0300)]
make methods private

3 years agoIDEA-191318 Icons are not scaled correctly in presentation mode
Anton Tarasov [Thu, 3 May 2018 15:21:59 +0000 (18:21 +0300)]
IDEA-191318 Icons are not scaled correctly in presentation mode

3 years agofix NPE EA-116354
Konstantin Bulenkov [Thu, 3 May 2018 15:24:07 +0000 (17:24 +0200)]
fix NPE EA-116354

3 years agoclean up. Simplify empty border
Konstantin Bulenkov [Thu, 3 May 2018 13:48:22 +0000 (15:48 +0200)]
clean up. Simplify empty border

3 years agoauto-import should be skipped for sync tag editing (WEB-32268)
Dennis Ushakov [Thu, 3 May 2018 15:04:44 +0000 (18:04 +0300)]
auto-import should be skipped for sync tag editing (WEB-32268)

3 years agosupport multiple ant build files removal (IDEA-38486)
Eugene Zhuravlev [Thu, 3 May 2018 15:07:03 +0000 (17:07 +0200)]
support multiple ant build files removal (IDEA-38486)

3 years agowrite action: EA-119265 - assert: PersistentFSImpl.processEvent
Anna.Kozlova [Thu, 3 May 2018 13:52:30 +0000 (15:52 +0200)]
write action: EA-119265 - assert: PersistentFSImpl.processEvent

3 years agomake MAPPER public for separate java plugin
Anna.Kozlova [Thu, 3 May 2018 13:48:32 +0000 (15:48 +0200)]
make MAPPER public for separate java plugin

EA-118104 - IAE: MethodReferencesSearch.uniqueResults

3 years agoEA-117885 - NPE: MoveFilesOrDirectoriesUtil.getContainerDirectory
Anna.Kozlova [Thu, 3 May 2018 13:42:16 +0000 (15:42 +0200)]
EA-117885 - NPE: MoveFilesOrDirectoriesUtil.getContainerDirectory

3 years agoEA-116912 - NPE: RefMethodImpl.buildReferences
Anna.Kozlova [Thu, 3 May 2018 13:35:34 +0000 (15:35 +0200)]
EA-116912 - NPE: RefMethodImpl.buildReferences

3 years ago[github] Migrate to MGA on explicit action appcode/182.2083 clion/182.2082
Ivan Semenov [Sat, 28 Apr 2018 11:59:51 +0000 (14:59 +0300)]
[github] Migrate to MGA on explicit action

3 years ago[github] Reduce dependency on GithubAccount in legacy-actions code
Ivan Semenov [Fri, 27 Apr 2018 14:24:55 +0000 (17:24 +0300)]
[github] Reduce dependency on GithubAccount in legacy-actions code

3 years ago[github] Fix login dialog context help wording
Ivan Semenov [Thu, 26 Apr 2018 15:15:32 +0000 (18:15 +0300)]
[github] Fix login dialog context help wording

3 years ago[github] Allow pre-filling password in login dialog
Ivan Semenov [Thu, 26 Apr 2018 15:00:14 +0000 (18:00 +0300)]
[github] Allow pre-filling password in login dialog

3 years agoGradle: open project test SDK leak fix
Vladislav.Soroka [Thu, 3 May 2018 14:40:38 +0000 (17:40 +0300)]
Gradle: open project test SDK leak fix

3 years agoIDEA-186587 'Replace all' confirmation popup is out of focus
Vassiliy.Kudryashov [Thu, 3 May 2018 14:26:52 +0000 (17:26 +0300)]
IDEA-186587 'Replace all' confirmation popup is out of focus

3 years ago[jvm-lang] making JvmMetaLanguage rely on `JvmDeclarationSearcher` definition phpstorm/182.2081
Nicolay Mitropolsky [Thu, 3 May 2018 14:12:35 +0000 (17:12 +0300)]
[jvm-lang] making JvmMetaLanguage rely on `JvmDeclarationSearcher` definition

not on `JvmLanguage` marker interface.

3 years agofailed test line highlighting: "Runtime problem" text attributes
Dmitry Avdeev [Thu, 3 May 2018 14:08:05 +0000 (17:08 +0300)]
failed test line highlighting: "Runtime problem" text attributes

3 years agoadd logging for EA-115508 - assert: ProjectViewDropTarget$CopyDropHandler.doDrop
Anna.Kozlova [Thu, 3 May 2018 13:06:48 +0000 (15:06 +0200)]
add logging for EA-115508 - assert: ProjectViewDropTarget$CopyDropHandler.doDrop

3 years agopush down: show conflict on attempt to push implements to anonymous
Anna.Kozlova [Thu, 3 May 2018 12:58:09 +0000 (14:58 +0200)]
push down: show conflict on attempt to push implements to anonymous

EA-118269 - NPE: JavaPushDownDelegate.pushDownToClass

3 years agochange signature conflicts: read access + process all overriding methods
Anna.Kozlova [Thu, 3 May 2018 12:07:35 +0000 (14:07 +0200)]
change signature conflicts: read access + process all overriding methods

EA-118949 - assert: SharedImplUtil.findFileElement

3 years agoMerge remote-tracking branch 'origin/master'
Konstantin Bulenkov [Thu, 3 May 2018 13:28:52 +0000 (15:28 +0200)]
Merge remote-tracking branch 'origin/master'

3 years agofix weird NPE EA-118906
Konstantin Bulenkov [Thu, 3 May 2018 13:28:01 +0000 (15:28 +0200)]
fix weird NPE EA-118906

3 years agoMerge branch 'master' of git.labs.intellij.net:idea/community
Vasily Romanikhin [Thu, 3 May 2018 13:13:08 +0000 (16:13 +0300)]
Merge branch 'master' of git.labs.intellij.net:idea/community

3 years ago[ui] Allow running `UIUtil.fixFormattedField` in headless mode
Ivan Semenov [Sat, 28 Apr 2018 13:58:15 +0000 (16:58 +0300)]
[ui] Allow running `UIUtil.fixFormattedField` in headless mode

Otherwise TraverseUI fails on Mac

3 years agomake "use bounded wildcards" inspection off by default, enable in our project profile...
Alexey Kudravtsev [Thu, 3 May 2018 12:58:43 +0000 (15:58 +0300)]
make "use bounded wildcards" inspection off by default, enable in our project profile instead

3 years agoCPP-744: fixed FileUtil.FILE_HASHING_STRATEGY
Vasily Romanikhin [Wed, 18 Apr 2018 12:37:04 +0000 (15:37 +0300)]
CPP-744: fixed FileUtil.FILE_HASHING_STRATEGY

3 years agofix NPE EA-119795
Konstantin Bulenkov [Thu, 3 May 2018 12:47:02 +0000 (14:47 +0200)]
fix NPE EA-119795

3 years agoMerge remote-tracking branch 'origin/master'
Konstantin Bulenkov [Thu, 3 May 2018 12:32:02 +0000 (14:32 +0200)]
Merge remote-tracking branch 'origin/master'

3 years agoadd json lib license
Konstantin Bulenkov [Thu, 3 May 2018 12:30:16 +0000 (14:30 +0200)]
add json lib license

3 years agoGradle: use the same gradle wrapper for open project test
Vladislav.Soroka [Thu, 3 May 2018 12:09:57 +0000 (15:09 +0300)]
Gradle: use the same gradle wrapper for open project test

3 years agorefs in package-info: track annotation args appcode/182.2080 clion/182.2079
Anna.Kozlova [Thu, 3 May 2018 11:44:52 +0000 (13:44 +0200)]
refs in package-info: track annotation args

IDEA-CR-32300

3 years agovcs: add tests for ChangeListManager
Aleksey Pivovarov [Thu, 3 May 2018 09:59:00 +0000 (12:59 +0300)]
vcs: add tests for ChangeListManager

3 years agovcs: extract changelist tests class
Aleksey Pivovarov [Thu, 3 May 2018 09:59:00 +0000 (12:59 +0300)]
vcs: extract changelist tests class

3 years agoIDEA-92390 vcs: keep change in the same changelist after file rename
Aleksey Pivovarov [Thu, 3 May 2018 09:43:44 +0000 (12:43 +0300)]
IDEA-92390 vcs: keep change in the same changelist after file rename

3 years agoFUS-31 UI: user settings => don't send usage.value<=0 phpstorm/182.2078
sergey.vasiliev [Mon, 12 Mar 2018 12:51:32 +0000 (13:51 +0100)]
FUS-31 UI: user settings => don't send usage.value<=0

3 years agoSSR: use a smart list
Bas Leijdekkers [Thu, 3 May 2018 10:32:34 +0000 (12:32 +0200)]
SSR: use a smart list

3 years agotag tree highlighting for jsx (WEB-30656)
Dennis Ushakov [Thu, 3 May 2018 09:44:34 +0000 (12:44 +0300)]
tag tree highlighting for jsx (WEB-30656)

3 years agoInspection for detecting and fixing places in API where bounded wildcards (? super...
Alexey Kudravtsev [Thu, 3 May 2018 10:25:34 +0000 (13:25 +0300)]
Inspection for detecting and fixing places in API where bounded wildcards (? super T or ? extends T) can be used

3 years agocleanup
Alexey Kudravtsev [Thu, 3 May 2018 10:20:15 +0000 (13:20 +0300)]
cleanup

3 years agoget rid of XStackFrameEx and changed priority of stack frame changed notifications
Arseny Chernyaev [Thu, 3 May 2018 10:25:14 +0000 (13:25 +0300)]
get rid of XStackFrameEx and changed priority of stack frame changed notifications

3 years agoGradle/C++: compatibility fix for the 4.5.x version
Vladislav.Soroka [Thu, 3 May 2018 10:10:56 +0000 (13:10 +0300)]
Gradle/C++: compatibility fix for the 4.5.x version

3 years agoIDEA-191219 Font doesn't scale well in presentation mode in debugger view Frames...
Egor Ushakov [Thu, 3 May 2018 10:00:51 +0000 (13:00 +0300)]
IDEA-191219 Font doesn't scale well in presentation mode in debugger view Frames section

3 years agoNPE
Anna.Kozlova [Thu, 3 May 2018 09:48:55 +0000 (11:48 +0200)]
NPE

3 years agotestng convert javadoc to annotations: fix invalid access
Anna.Kozlova [Thu, 3 May 2018 09:32:30 +0000 (11:32 +0200)]
testng convert javadoc to annotations: fix invalid access

3 years agoEA-119713 - assert: NoSwingUnderWriteAction.lambda$watchForEvents$
Anna.Kozlova [Thu, 3 May 2018 09:07:28 +0000 (11:07 +0200)]
EA-119713 - assert: NoSwingUnderWriteAction.lambda$watchForEvents$

pull warning dialog outside write action

3 years agoEA-119731 - NPE: GenerateMembersUtil.substituteTypeParameter
Anna.Kozlova [Thu, 3 May 2018 08:55:39 +0000 (10:55 +0200)]
EA-119731 - NPE: GenerateMembersUtil.substituteTypeParameter

avoid NPE when mirror doesn't exist

3 years agoEA-119775 - NPE: VcsBackgroundOperationsConfigurable.isModified
Anna.Kozlova [Thu, 3 May 2018 08:50:47 +0000 (10:50 +0200)]
EA-119775 - NPE: VcsBackgroundOperationsConfigurable.isModified

3 years ago[gui-test] use project creator in CommandLineProjectGuiTest appcode/182.2077 clion/182.2076
Sergey Karashevich [Thu, 3 May 2018 08:46:35 +0000 (11:46 +0300)]
[gui-test] use project creator in CommandLineProjectGuiTest

3 years agofix typo
Anna.Kozlova [Thu, 3 May 2018 07:26:58 +0000 (09:26 +0200)]
fix typo

3 years agoMaven: do not use hardcoded icons resource URLs
Vladislav.Soroka [Thu, 3 May 2018 07:06:34 +0000 (10:06 +0300)]
Maven: do not use hardcoded icons resource URLs

3 years agoui: emulate mouseMoved event to have missing HyperlinkEvent(EXITED) (IDEA-191300)
Sergey Simonchik [Thu, 3 May 2018 07:03:07 +0000 (10:03 +0300)]
ui: emulate mouseMoved event to have missing HyperlinkEvent(EXITED) (IDEA-191300)

Workaround for JDK bug https://bugs.openjdk.java.net/browse/JDK-8202529

3 years agoListRemoveInLoop: remove range-check automatically if can be proven to be redundant. pycharm/182.2073 pycharm/182.2074
Tagir Valeev [Thu, 3 May 2018 04:32:22 +0000 (11:32 +0700)]
ListRemoveInLoop: remove range-check automatically if can be proven to be redundant.

3 years agoListRemoveInLoop: fixes according to review IDEA-CR-31882
Tagir Valeev [Thu, 3 May 2018 04:03:16 +0000 (11:03 +0700)]
ListRemoveInLoop: fixes according to review IDEA-CR-31882

3 years agoManualArrayToCollectionCopyInspection: cosmetic
Tagir Valeev [Thu, 3 May 2018 03:44:14 +0000 (10:44 +0700)]
ManualArrayToCollectionCopyInspection: cosmetic

3 years agogreenify appcode/182.2069 clion/182.2068 dbe/182.2066 idea/182.2064 phpstorm/182.2070 pycharm/182.2067 pycharm/182.2071 rubymine/182.2065 webstorm/182.2072
Maxim.Kolmakov [Wed, 2 May 2018 23:58:03 +0000 (01:58 +0200)]
greenify

3 years agoGUI-91 No access to button in debug toolwindow
Maxim.Kolmakov [Wed, 2 May 2018 23:55:45 +0000 (01:55 +0200)]
GUI-91 No access to button in debug toolwindow

3 years agoGUI-90 No access to 'Close' button in run toolwindow
Maxim.Kolmakov [Wed, 2 May 2018 23:29:23 +0000 (01:29 +0200)]
GUI-90 No access to 'Close' button in run toolwindow

3 years agoadd json lib to community
Konstantin Bulenkov [Wed, 2 May 2018 22:49:10 +0000 (00:49 +0200)]
add json lib to community

3 years agoadd json library to parse JSON
Konstantin Bulenkov [Wed, 2 May 2018 22:40:41 +0000 (00:40 +0200)]
add json library to parse JSON

3 years agoreuse JBTextField empty-text; solve AA problem phpstorm/182.2063
Gregory.Shrago [Wed, 2 May 2018 21:54:34 +0000 (00:54 +0300)]
reuse JBTextField empty-text; solve AA problem