idea/community.git
2 years agoMerge remote-tracking branch 'origin/master' into prendota/plugin-manager-new-protocol
Ivan Chirkov [Fri, 17 Apr 2020 10:40:43 +0000 (12:40 +0200)]
Merge remote-tracking branch 'origin/master' into prendota/plugin-manager-new-protocol

# Conflicts:
# community/platform/platform-impl/src/com/intellij/ide/plugins/PluginNode.java
# community/platform/platform-impl/src/com/intellij/ide/plugins/newui/MyPluginModel.java
# community/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateChecker.kt

GitOrigin-RevId: 5ee8edd3161b27355cc491fc6cb7e83f2df89f4d

2 years agoPluginManagerConfigurable: do not get custom repository plugins from network for...
Ivan Chirkov [Fri, 17 Apr 2020 10:32:18 +0000 (12:32 +0200)]
PluginManagerConfigurable: do not get custom repository plugins from network for `myPluginModel`

GitOrigin-RevId: df809aa92b48e44f40978bd97362e01abc5e3dd0

2 years agoUpdateChecker.kt: simplify `incompatiblePlugins` calculation
Ivan Chirkov [Thu, 16 Apr 2020 11:10:51 +0000 (13:10 +0200)]
UpdateChecker.kt: simplify `incompatiblePlugins` calculation

GitOrigin-RevId: 2408de9b87c9576635d27d28c56f9fd5be4954c4

2 years agoPlugin manager: `MyPluginModel.getCustomRepoPlugins` marked as NotNull
Ivan Chirkov [Thu, 16 Apr 2020 10:03:33 +0000 (12:03 +0200)]
Plugin manager: `MyPluginModel.getCustomRepoPlugins` marked as NotNull

GitOrigin-RevId: 1d6e6aa1713b108746f09214ad20699089bc64fa

2 years agoFixed typo after merge
Ivan Chirkov [Thu, 16 Apr 2020 10:02:16 +0000 (12:02 +0200)]
Fixed typo after merge

GitOrigin-RevId: 10cec9ed9a974c02b7c5142588d42c67e2eb0fff

2 years agoPlugin manager: internationalize icon message, use `ProcessIOExecutorService` to...
Ivan Chirkov [Thu, 16 Apr 2020 10:00:28 +0000 (12:00 +0200)]
Plugin manager: internationalize icon message, use `ProcessIOExecutorService` to load plugin description

GitOrigin-RevId: 99d9a899848c9ac43156c742a8e792256d23169a

2 years agocheck external id is not null
Prendota [Thu, 16 Apr 2020 09:16:47 +0000 (12:16 +0300)]
check external id is not null

GitOrigin-RevId: 01d05093fe547851952989bb0b9cf50ef3edea9f

2 years agoAdd throwStatusCodeException for MarketplaceRequests
Prendota [Thu, 16 Apr 2020 09:15:44 +0000 (12:15 +0300)]
Add throwStatusCodeException for MarketplaceRequests

GitOrigin-RevId: a5965d6c36f30404549c5c9af397ef965fb4d5d8

2 years agoCatch exceptions while getting tags/vendor/compatible updates from marketplace
Prendota [Thu, 9 Apr 2020 09:08:48 +0000 (12:08 +0300)]
Catch exceptions while getting tags/vendor/compatible updates from marketplace

GitOrigin-RevId: 59e58dbf5cd55b12198db923465e1ba3e7ba75fd

2 years agoMarketplace: trimEnd / for PLUGIN_MANAGER_URL
Prendota [Wed, 8 Apr 2020 09:00:53 +0000 (12:00 +0300)]
Marketplace: trimEnd / for PLUGIN_MANAGER_URL

GitOrigin-RevId: ed8c528b7ef174f788ede60b02579dde2e1a1ec4

2 years agoMarketplace: add @Throws(IOException::class) for API
Prendota [Wed, 8 Apr 2020 08:52:30 +0000 (11:52 +0300)]
Marketplace: add @Throws(IOException::class) for API

GitOrigin-RevId: 468294bc990281bb93c5494c572f301c22770a5a

2 years agoAfter merge fix
Ivan Chirkov [Wed, 1 Apr 2020 13:42:12 +0000 (15:42 +0200)]
After merge fix

GitOrigin-RevId: ac5276ca7c92ae42c17ab395cf0304be3d4c3f70

2 years agoMerge branch 'master' into prendota/plugin-manager-new-protocol
Ivan Chirkov [Wed, 1 Apr 2020 13:35:47 +0000 (15:35 +0200)]
Merge branch 'master' into prendota/plugin-manager-new-protocol

# Conflicts:
# community/platform/built-in-server/src/org/jetbrains/ide/InstallPluginService.kt
# community/platform/platform-impl/src/com/intellij/ide/plugins/PluginRepositoryRequests.java
# community/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateChecker.kt

GitOrigin-RevId: dfb975be09d1ad5233242459028163bb441aa987

2 years agoPluginDetailsPageComponent: removed redundant dispose
Ivan Chirkov [Wed, 1 Apr 2020 13:24:43 +0000 (15:24 +0200)]
PluginDetailsPageComponent: removed redundant dispose

GitOrigin-RevId: 47ac8805e9800072cc2c4367d554a04ee1c10889

2 years agoSimplify getting compatible update
Prendota [Wed, 1 Apr 2020 08:56:27 +0000 (11:56 +0300)]
Simplify getting compatible update

GitOrigin-RevId: 30d39fbda8220efe834ba9ead8047ff764305eb4

2 years agoUse build as a request parameter for getting vendors & tags
Prendota [Tue, 31 Mar 2020 14:40:54 +0000 (17:40 +0300)]
Use build as a request parameter for getting vendors & tags

GitOrigin-RevId: e32afa86c351ffd4944428b6bad6a72679bde0a6

2 years agoMarketplace: drop mock and use production url for getting organizations & tags
Prendota [Tue, 31 Mar 2020 09:44:17 +0000 (12:44 +0300)]
Marketplace: drop mock and use production url for getting organizations & tags

GitOrigin-RevId: 2d9d14a0285a74de4dd7d18a1719b1ee746657a6

2 years agoPluginNode: add missing java doc for externalUpdateId & externalPluginId
Prendota [Tue, 31 Mar 2020 08:23:32 +0000 (11:23 +0300)]
PluginNode: add missing java doc for externalUpdateId & externalPluginId

GitOrigin-RevId: b1253ed422a44233c810c7fec687d10d8142e2c3

2 years agoValidate nullable exsternalUpadate id from Marketplace
Prendota [Tue, 31 Mar 2020 08:22:15 +0000 (11:22 +0300)]
Validate nullable exsternalUpadate id from Marketplace

GitOrigin-RevId: 3ef1c4a888b5ae40f7a76369d977380f718a109a

2 years agoPluginUpdateDialog: provide custom repos plugins for `PluginInstallOperation`
Ivan Chirkov [Mon, 30 Mar 2020 14:24:09 +0000 (16:24 +0200)]
PluginUpdateDialog: provide custom repos plugins for `PluginInstallOperation`

GitOrigin-RevId: 938048b0e3f4dc3c33ab477c001ee32a6aa30048

2 years agoPluginInstallOperation: added TODOs to make it receive only custom plugins
Ivan Chirkov [Mon, 30 Mar 2020 11:56:37 +0000 (13:56 +0200)]
PluginInstallOperation: added TODOs to make it receive only custom plugins

GitOrigin-RevId: bf9de89629d990a2a2ef684db2e552fe7a2b2548

2 years agoRemoved 'PluginManagerMain.downloadPlugins' - it was scheduled for removal and no...
Ivan Chirkov [Mon, 30 Mar 2020 11:54:41 +0000 (13:54 +0200)]
Removed 'PluginManagerMain.downloadPlugins' - it was scheduled for removal and no active external usages have been found

GitOrigin-RevId: 18aaf71b0e412ed6440aaa606240cb936ea780bf

2 years agoPluginInstallOperation: take latest plugin from custom repos and Marketplace for...
Ivan Chirkov [Fri, 27 Mar 2020 15:35:01 +0000 (16:35 +0100)]
PluginInstallOperation: take latest plugin from custom repos and Marketplace for dependencies

GitOrigin-RevId: 011ba4ae176ba77e987a93a5e374c565e9621385

2 years agoPlugin manager: resolved TODOs
Ivan Chirkov [Fri, 27 Mar 2020 15:17:23 +0000 (16:17 +0100)]
Plugin manager: resolved TODOs

GitOrigin-RevId: 0f8a5dd567f89a7a21e815aafb1d29d98991a050

2 years agoPlugin manager: search by vendors via Marketplace server
Ivan Chirkov [Fri, 27 Mar 2020 15:15:15 +0000 (16:15 +0100)]
Plugin manager: search by vendors via Marketplace server

GitOrigin-RevId: 2741d9910b8747d27ed0a1978f2d26696e4c687f

2 years agoCollect plugins from custom repositories by taking latest version for every plugin
Ivan Chirkov [Thu, 26 Mar 2020 16:11:22 +0000 (17:11 +0100)]
Collect plugins from custom repositories by taking latest version for every plugin

GitOrigin-RevId: 2e636bf8bf03332ca00ede7c4bccbd207961ef68

2 years agoSearchQueryParser: vendors -> organization
Prendota [Fri, 27 Mar 2020 14:07:26 +0000 (17:07 +0300)]
SearchQueryParser: vendors -> organization

GitOrigin-RevId: 042a2c8a613034cc8e1f1926006bcecd373c0061

2 years agoMarketplaceRequests: remove redundant JvmStatic & JvmOverloads
Prendota [Fri, 27 Mar 2020 09:30:23 +0000 (12:30 +0300)]
MarketplaceRequests: remove redundant JvmStatic & JvmOverloads

GitOrigin-RevId: 1cef2c6171221bc74ae81ea2d4d94eacc969c8f2

2 years agoCombine PluginMetaLoader with MarketplaceRequests
Prendota [Fri, 27 Mar 2020 08:55:41 +0000 (11:55 +0300)]
Combine PluginMetaLoader with MarketplaceRequests

GitOrigin-RevId: 182ec3e662830f9dba34098fb5de9b64793bb246

2 years agoPluginsMetaLoader moved to `marketplace` package
Ivan Chirkov [Thu, 26 Mar 2020 15:52:43 +0000 (16:52 +0100)]
PluginsMetaLoader moved to `marketplace` package

GitOrigin-RevId: f0dd82d2c518aea11244f6f0ab1a63a575f4d0c6

2 years agoPluginInstallOperation: get PluginNode from PluginMetaLoader
Prendota [Thu, 26 Mar 2020 11:29:33 +0000 (14:29 +0300)]
PluginInstallOperation: get PluginNode from PluginMetaLoader

GitOrigin-RevId: 3d342df36f692961af68d71674eeba1842c45e16

2 years agorefactor: clean up InstallPluginService.kt
Prendota [Thu, 26 Mar 2020 11:22:09 +0000 (14:22 +0300)]
refactor: clean up InstallPluginService.kt

GitOrigin-RevId: 3f676cd2377f03dccfb9fe4a5a947a5bda69a07a

2 years agoMyPluginModel: use customPlugins list and requests to Marketplace instead of allPlugi...
Ivan Chirkov [Thu, 26 Mar 2020 08:35:13 +0000 (09:35 +0100)]
MyPluginModel: use customPlugins list and requests to Marketplace instead of allPlugins list

GitOrigin-RevId: 94c69c8db2e27d3ee86cc36f54dd9b65f2645919

2 years agoPlugin manager: get list of tags from server instead of plugin list XML
Ivan Chirkov [Wed, 25 Mar 2020 12:33:45 +0000 (13:33 +0100)]
Plugin manager: get list of tags from server instead of plugin list XML

GitOrigin-RevId: 50e6b23fe18c200da3ceffece1aaebe3e36807ac

2 years agoPlugin manager: `PAID` is available in search index on server - no need to filter...
Ivan Chirkov [Wed, 25 Mar 2020 11:56:44 +0000 (12:56 +0100)]
Plugin manager: `PAID` is available in search index on server - no need to filter manually

GitOrigin-RevId: 63f336cfab5621d55215b16b135b7c3e1321c18e

2 years agoPlugin manager: search by vendors via Marketplace server
Ivan Chirkov [Wed, 25 Mar 2020 11:55:23 +0000 (12:55 +0100)]
Plugin manager: search by vendors via Marketplace server

GitOrigin-RevId: ee087d9f605fc026cd5af4efe48a8b001cd412f9

2 years agoRename: loadRepositoryPlugins -> getCustomRepositoryPlugins
Prendota [Wed, 25 Mar 2020 08:23:43 +0000 (11:23 +0300)]
Rename: loadRepositoryPlugins -> getCustomRepositoryPlugins

GitOrigin-RevId: 50102aa9226a3f25f31776a3e56fb4d15f554d2c

2 years agoMarketplace: add mock API for vendors & tags
Prendota [Wed, 25 Mar 2020 08:22:10 +0000 (11:22 +0300)]
Marketplace: add mock API for vendors & tags

GitOrigin-RevId: 1e6ee3534048cba6380e711baa4cb22d9686934f

2 years agoTrack access to XML lists
Ivan Chirkov [Fri, 20 Mar 2020 18:47:41 +0000 (19:47 +0100)]
Track access to XML lists

GitOrigin-RevId: 24257c95aea5ea142208b6407898fca4dd68210f

2 years agoGetting rid of XML plugin lists for plugin manager - it is now not required for searc...
Ivan Chirkov [Fri, 20 Mar 2020 12:27:28 +0000 (13:27 +0100)]
Getting rid of XML plugin lists for plugin manager - it is now not required for search (~95%) and navigation

XML plugin list is still required for search by tags and vendors and also for installation of plugins

GitOrigin-RevId: 9381b51d6f5a16d86d197f309ebbaa7a2fd8e9db

2 years agoPluginManagerConfigurable.getRepositoryPlugins: get ready for "myAllRepositoryPlugins...
Ivan Chirkov [Thu, 19 Mar 2020 21:16:21 +0000 (22:16 +0100)]
PluginManagerConfigurable.getRepositoryPlugins: get ready for "myAllRepositoryPluginsList" being not loaded

GitOrigin-RevId: c6b9023e0acf00b07bd48d590df5d1db8b1d0b6c

2 years agoPluginRepositoryObjects: add Paid tag
Prendota [Thu, 19 Mar 2020 12:31:55 +0000 (15:31 +0300)]
PluginRepositoryObjects: add Paid tag

GitOrigin-RevId: 65e5241b1034d47de361f518a6045fe9c7ac09ec

2 years agoGet rid of PluginRepositoryRequests.java use MarketplaceRequests.kt instead
Prendota [Wed, 18 Mar 2020 12:58:39 +0000 (15:58 +0300)]
Get rid of PluginRepositoryRequests.java use MarketplaceRequests.kt instead

GitOrigin-RevId: 4657d7ca6550ffdc0f09a7077080f275ab82b149

2 years agoPluginPriceService: move price request to service
Prendota [Wed, 18 Mar 2020 12:51:23 +0000 (15:51 +0300)]
PluginPriceService: move price request to service

GitOrigin-RevId: 85e1c4ad930e0e27178881003de42f1c605adc08

2 years agoPluginManager: use new protocol for marketplace plugins
Prendota [Wed, 18 Mar 2020 09:09:05 +0000 (12:09 +0300)]
PluginManager: use new protocol for marketplace plugins

GitOrigin-RevId: 8aaca60cc80eff6de449c8a5f6b7fe9fcb8860e3

2 years ago[PluginManager] use new protocol for getting featured plugins
Prendota [Tue, 17 Mar 2020 14:25:59 +0000 (17:25 +0300)]
[PluginManager] use new protocol for getting featured plugins

GitOrigin-RevId: 6f3910785016e615293e90c8941beb91bd09788a

2 years agoAdded progress to PluginDetailsPageComponent.
Ivan Chirkov [Tue, 17 Mar 2020 11:24:52 +0000 (12:24 +0100)]
Added progress to PluginDetailsPageComponent.

GitOrigin-RevId: e3af309bdbcfb66b88fb539f31e738ee4c5216a0

2 years agoWIP: get meta for plugins for plugin manager
Prendota [Fri, 13 Mar 2020 11:17:34 +0000 (14:17 +0300)]
WIP: get meta for plugins for plugin manager

GitOrigin-RevId: cba95fc7ef88760c46a1c88d5878a3abf6fd91cd

2 years agoPlugin manager: use dump implementation for marketplace tab
Prendota [Wed, 11 Mar 2020 13:37:45 +0000 (16:37 +0300)]
Plugin manager: use dump implementation for marketplace tab

GitOrigin-RevId: 646d6ac46e146c0043cc82e5583a560fdb61f430

2 years ago[platform] javadoc: mention that methods which changes project model may be called...
nik [Fri, 17 Apr 2020 10:06:37 +0000 (13:06 +0300)]
[platform] javadoc: mention that methods which changes project model may be called on modifiable instance only

GitOrigin-RevId: 168eddbd70709dd5e44187f776cafb91ee3ea3cc

2 years agomore logging for EA-229798
Egor Ushakov [Fri, 17 Apr 2020 10:07:38 +0000 (13:07 +0300)]
more logging for EA-229798

GitOrigin-RevId: 6a3d0eb7940aa593b9547ed395a9196f4ac3e8fc

2 years agooptimize mouse events processing in editor
Dmitry Batrak [Fri, 17 Apr 2020 10:03:21 +0000 (13:03 +0300)]
optimize mouse events processing in editor

optimize creation of EditorMouseEvent

GitOrigin-RevId: acfa9ee602359238d9401ca5c3aba200fdb420a2

2 years agoIDEA-237691 Kotlin update is failing on IDEA 2020.1
Anton Tarasov [Fri, 17 Apr 2020 09:53:42 +0000 (12:53 +0300)]
IDEA-237691 Kotlin update is failing on IDEA 2020.1

GitOrigin-RevId: a514c4d68d50967fe2ed9d267e9534b02e7d8a14

2 years ago[external system] convert ExternalSystemModulePropertyManager interface to abstract...
nik [Fri, 17 Apr 2020 09:57:03 +0000 (12:57 +0300)]
[external system] convert ExternalSystemModulePropertyManager interface to abstract class to restore binary compatibility

This interface was extracted from a class in 2b5c46ed1ddc and it breaks binary compatibility with plugin which bytecode uses invokevirtual instruction to call the interface methods.

GitOrigin-RevId: 7354c5e84fa75e8d447351efa85dca73a44cd245

2 years agoIDEA-236390 Implement new UI for editing run configuration settings
Dmitry Avdeev [Fri, 17 Apr 2020 09:33:05 +0000 (12:33 +0300)]
IDEA-236390 Implement new UI for editing run configuration settings

using JButton to make tags focusable

GitOrigin-RevId: 0eaff8d44c1213a6194adecd15c5fd1d6dfd8bf1

2 years ago[tests] close project if some tests in ModulesConfigurationTest fails
nik [Fri, 17 Apr 2020 09:32:17 +0000 (12:32 +0300)]
[tests] close project if some tests in ModulesConfigurationTest fails

Otherwise subsequent tests will fail with assertion because non-closed project cannot be disposed.

GitOrigin-RevId: 95e3486f7e883be0f786d0efb3cfd3ef98ef4dab

2 years ago[workspace model] support serialization in JPS format for projects imported from...
nik [Fri, 17 Apr 2020 09:31:09 +0000 (12:31 +0300)]
[workspace model] support serialization in JPS format for projects imported from external systems

When a project is imported from Maven/Gradle we store its configuration files in JPS format under the caches directory by default; also there is an option to store them in regular .idea/.iml files. We need to support this in legacy bridge to ensure that JPS build works for such projects.

This change introduces JpsImportedEntitySource which is used to distinguish imported entities, provides an implementation of ExternalSystemModulePropertyManager which stores data in the entity stores, added properties to store module type and other module options in the entity storage. Also it changes expected data for some tests on JPS serialization to make them more consistent with the actual behavior in production.

GitOrigin-RevId: 1e843fc2785b9b0a151ac2070d10be6f0b67edf2

2 years ago[test framework] move definitions of MockFacet to testFramework to allow writing...
nik [Fri, 17 Apr 2020 09:19:35 +0000 (12:19 +0300)]
[test framework] move definitions of MockFacet to testFramework to allow writing tests on facets in externalSystem tests

GitOrigin-RevId: 3d9e532478a27268a7ec3af14b461858a8787e94

2 years agoWrite aggregate inspections results only if they have reported problems
Artemy Pestretsov [Fri, 17 Apr 2020 08:34:00 +0000 (11:34 +0300)]
Write aggregate inspections results only if they have reported problems

GitOrigin-RevId: 8ca293624946d42ed403e0834050bd888e8eee81

2 years agoWEB-37591 WEB-44955 Add tooltip, I18n captions and new preview file for HTML indentation
Piotr Tomiak [Fri, 17 Apr 2020 09:20:47 +0000 (11:20 +0200)]
WEB-37591 WEB-44955 Add tooltip, I18n captions and new preview file for HTML indentation

GitOrigin-RevId: 147148c5756b11388073eb33b1e3af42a8cc2833

2 years agoAddress JBR-2299 [mac] jcef requests for "chromium safe storage" keychain access
Anton Tarasov [Fri, 17 Apr 2020 09:11:48 +0000 (12:11 +0300)]
Address JBR-2299 [mac] jcef requests for "chromium safe storage" keychain access

GitOrigin-RevId: 8c25fd3b2200a187696f13dec4d7bb3f0e4060b1

2 years agoExceptionLineRefiner non-public (IDEA-CR-61583)
Tagir Valeev [Fri, 17 Apr 2020 08:47:05 +0000 (15:47 +0700)]
ExceptionLineRefiner non-public (IDEA-CR-61583)

GitOrigin-RevId: bfd6a6bdeb5fdf56eeb17a7a92efcf64e899c6f8

2 years agoprepare java jigsaw stacktrace foldings (IDEA-237983)
Anna Kozlova [Fri, 17 Apr 2020 08:31:17 +0000 (10:31 +0200)]
prepare java jigsaw stacktrace foldings (IDEA-237983)

GitOrigin-RevId: e2d512d27ee0fac664656ae8cc564994a1906168

2 years agoIDEA-231790 Small tooltips
Dmitry Batrak [Fri, 17 Apr 2020 08:14:16 +0000 (11:14 +0300)]
IDEA-231790 Small tooltips

another fix (which shouldn't cause RUBY-26192)

GitOrigin-RevId: 04b469dae611d7a0fcc3c6b629ea4ed25d3ea6b4

2 years agoRUBY-26192 Empty line after text in offenses
Dmitry Batrak [Fri, 17 Apr 2020 07:43:37 +0000 (10:43 +0300)]
RUBY-26192 Empty line after text in offenses

this rolls back the fix for IDEA-231790, it will be fixed in another way

GitOrigin-RevId: c8fe5d8a8b59ce0ef575511d0e485dc8bdf95e51

2 years agoIncrement version of ui.tips collector
Vitaliy.Bibaev [Fri, 17 Apr 2020 07:07:18 +0000 (10:07 +0300)]
Increment version of ui.tips collector

GitOrigin-RevId: 31f33b82296f347d978094627d6ce3f2d52ca4cc

2 years agoIDEA-233778 Intention preview: Exception when preview is not available
Tagir Valeev [Fri, 17 Apr 2020 07:53:30 +0000 (14:53 +0700)]
IDEA-233778 Intention preview: Exception when preview is not available

GitOrigin-RevId: b7b5d9ed7eda956bef6c7a450518e394a7ffa728

2 years ago[jps-cache] Change decoded string
Mikhail Mazurkevich [Fri, 17 Apr 2020 07:49:09 +0000 (10:49 +0300)]
[jps-cache] Change decoded string

GitOrigin-RevId: dd8cbb8a6bee6b2c14038c27fede18c9133cd8d0

2 years agoIDEA-237717 Support inlining in DFA for methods, which accepts and calls given lambda
Tagir Valeev [Fri, 17 Apr 2020 07:17:25 +0000 (14:17 +0700)]
IDEA-237717 Support inlining in DFA for methods, which accepts and calls given lambda

GitOrigin-RevId: abca4626c35c54fc6786ba816daa6a05e0236b30

2 years agoIterableUsedAsVarargInspection: fix for classes w/o qualified name
Tagir Valeev [Fri, 17 Apr 2020 06:58:46 +0000 (13:58 +0700)]
IterableUsedAsVarargInspection: fix for classes w/o qualified name

GitOrigin-RevId: ac68a89671f683d4be9a323823f3589cfac78451

2 years agooptimize mouse events processing in editor
Dmitry Batrak [Fri, 17 Apr 2020 07:02:05 +0000 (10:02 +0300)]
optimize mouse events processing in editor

All editor mouse event listeners need information about location in editor at mouse position. Every listener calculated it independently,
now they can use pre-calculated information, available in EditorMouseEvent.

GitOrigin-RevId: 4aaf4a6280c213216d0e0fc0b35b6d25bbcf9bb6

2 years agoJPS caches: fail on non-200 code: close executor and report errors
Dmitriy.Panov [Fri, 17 Apr 2020 06:58:49 +0000 (09:58 +0300)]
JPS caches: fail on non-200 code: close executor and report errors

GitOrigin-RevId: ac20083b47eedbc4f06f1e0f9940c84a0acc62b2

2 years agoindexes: decouple stub index serialization && stub index management inside ide
Dmitro Batko [Fri, 17 Apr 2020 05:47:53 +0000 (08:47 +0300)]
indexes: decouple stub index serialization && stub index management inside ide

GitOrigin-RevId: e0f618502d9881e4d26a203842ef72413616a7db

2 years agojava: make resolveAllQualifiers go through RecursionManager to take advantage of...
Peter Gromov [Fri, 17 Apr 2020 05:48:21 +0000 (07:48 +0200)]
java: make resolveAllQualifiers go through RecursionManager to take advantage of its memoization (IDEA-236961)

GitOrigin-RevId: 1bfe281cbfaa8c6423a12313daf6f72aae738846

2 years agoJavaStubBuilderTest: reattemptUntilJitSettlesDown
Peter Gromov [Fri, 17 Apr 2020 05:40:04 +0000 (07:40 +0200)]
JavaStubBuilderTest: reattemptUntilJitSettlesDown

GitOrigin-RevId: 13f29494ca0168aff84154a669b02c717b7a6c2a

2 years agoUnifying code for exception navigation and breakpoint creation
Tagir Valeev [Fri, 17 Apr 2020 05:59:13 +0000 (12:59 +0700)]
Unifying code for exception navigation and breakpoint creation

Fixes IDEA-237888 Exceptions incorrectly detected for unrelated input in docker log console

AdvancedExceptionFilter extracted because Kotlin plugin creates ExceptionFilter internally and performs double work for some reason. This is not that visible for normal links as intersecting links are ignored, but inlays like 'Create breakpoint' get duplicated

GitOrigin-RevId: 892d2e7ec2d9152c93d8f328b655106789b7082a

2 years agoDo not change visited link color (otherwise library link becomes like source code...
Tagir Valeev [Fri, 17 Apr 2020 03:25:52 +0000 (10:25 +0700)]
Do not change visited link color (otherwise library link becomes like source code link)

GitOrigin-RevId: acbbdfdb0f0cafe55977e102055b264add63506a

2 years agoJPS caches: fail on non-200 code: revert for POST
Dmitriy.Panov [Fri, 17 Apr 2020 05:25:42 +0000 (08:25 +0300)]
JPS caches: fail on non-200 code: revert for POST

GitOrigin-RevId: 2e7de6c064bd6839e133d62e40e9a08d7803c00d

2 years agofix cases of RecursionManager both over- and under-memoizing (needed for IDEA-236961)
Peter Gromov [Fri, 17 Apr 2020 05:01:40 +0000 (07:01 +0200)]
fix cases of RecursionManager both over- and under-memoizing (needed for IDEA-236961)

Track preventions per each doPreventingRecursion frame separately to avoid misses when the same prevention happens via different routes.

This increased the number of same memoizations with different dependencies and made keeping them all in the memory very expensive. But it seems that well-behaved memoized values may only vary depending on where the recursion strongly-connected graph was entered, so we now memoize just one value per key and drop it if that entrance's changes.

GitOrigin-RevId: 8ef0402509af0f300318a2fc85d876b0678474c9

2 years agoMultiPsiElementHyperlinkInfo: fix indent; remove read action; fix list presentation
Tagir Valeev [Fri, 17 Apr 2020 03:18:46 +0000 (10:18 +0700)]
MultiPsiElementHyperlinkInfo: fix indent; remove read action; fix list presentation

Review ID: IDEA-CR-61472

GitOrigin-RevId: b177a880d252954baecb91c1c1fd7243112905af

2 years agoIDEA-CR-61064: IDEA-235111 Extend events with unique id
Anastasia Ivanova [Fri, 17 Apr 2020 03:06:15 +0000 (10:06 +0700)]
IDEA-CR-61064: IDEA-235111 Extend events with unique id

GitOrigin-RevId: 3d6846e9e47a00020441ed329d0b7889465ffd9c

2 years ago[updater] showing correct path in a conflict message for a moved file
Roman Shevchenko [Thu, 16 Apr 2020 22:39:31 +0000 (00:39 +0200)]
[updater] showing correct path in a conflict message for a moved file

GitOrigin-RevId: e274b1a3cdbd077eb645507b0aa9a40d6ce78fa5

2 years agoIDEA-237659 don't localize access modifiers
Dmitry.Krasilschikov [Thu, 16 Apr 2020 21:12:20 +0000 (00:12 +0300)]
IDEA-237659 don't localize access modifiers

GitOrigin-RevId: 0df3537f513da616d0a2510b19dd2e018ec693e9

2 years agoIDEA-233416 "Copy File Name" -> "File Name"
Dmitry.Krasilschikov [Mon, 6 Apr 2020 16:52:09 +0000 (19:52 +0300)]
IDEA-233416 "Copy File Name" -> "File Name"

GitOrigin-RevId: 878c1042fb11390e882123e9e3e10d922e4e1d04

2 years agocr-IDEA-1324 IDEA-237884 - hotfix for KotlinSDK incorrect warnings
Eugene Petrenko [Thu, 16 Apr 2020 20:42:06 +0000 (22:42 +0200)]
cr-IDEA-1324 IDEA-237884 - hotfix for KotlinSDK incorrect warnings

Check SDK is not downloading

GitOrigin-RevId: 87c3d12468c0cf1a18f69fa2731ac8a17963aeba

2 years agoMinor: encapsulate ActionsLocalSummary state
Vitaliy.Bibaev [Thu, 16 Apr 2020 19:53:59 +0000 (22:53 +0300)]
Minor: encapsulate ActionsLocalSummary state

GitOrigin-RevId: 05eb0928bbdfa02fb0df4e86f3f8c48fe94e5de1

2 years agoMinor: fix wrong annotation
Vitaliy.Bibaev [Thu, 16 Apr 2020 19:10:36 +0000 (22:10 +0300)]
Minor: fix wrong annotation

GitOrigin-RevId: 3760d219c9f5a0d8f8ba0bb11a1f7b9f54ee0b7e

2 years agoIDEA-225870 IDEA-225871 Improve logging
Vitaliy.Bibaev [Thu, 16 Apr 2020 18:58:44 +0000 (21:58 +0300)]
IDEA-225870 IDEA-225871 Improve logging

GitOrigin-RevId: 6afab93f34de0d56bd0790372f7446fdbb1024bb

2 years agoIDEA-225870 IDEA-225871 Use http to fetch recommendation
Vitaliy.Bibaev [Thu, 16 Apr 2020 18:56:53 +0000 (21:56 +0300)]
IDEA-225870 IDEA-225871 Use http to fetch recommendation

GitOrigin-RevId: 9f19808974e216598103483b19194be343c46cc1

2 years agoIDEA-225870 IDEA-225871 Sort available tips on the server using information about...
Vitaliy.Bibaev [Thu, 16 Apr 2020 14:22:53 +0000 (17:22 +0300)]
IDEA-225870 IDEA-225871 Sort available tips on the server using information about actions that a user aware

GitOrigin-RevId: 230052ee04d992b2cb878696bb85d0795b9c8e25

2 years agoMake ActionsLocalSummary accessible
Vitaliy.Bibaev [Thu, 26 Mar 2020 13:38:33 +0000 (16:38 +0300)]
Make ActionsLocalSummary accessible

GitOrigin-RevId: 4d22a66961446558a2e5deda46315592587f45a2

2 years agoIDEA-CR-61508: PY-39703 Add TypedDict keys completion
Lada Gagina [Tue, 31 Mar 2020 10:18:47 +0000 (13:18 +0300)]
IDEA-CR-61508: PY-39703 Add TypedDict keys completion

GitOrigin-RevId: b4e71d5edff69b23e1f1eb68ffe77f994a6a0293

2 years ago[textmate] extract lexing logic to core module
Alexander Zolotov [Thu, 16 Apr 2020 19:06:14 +0000 (22:06 +0300)]
[textmate] extract lexing logic to core module

GitOrigin-RevId: d01044338d1e9c3513f75ef451f214154dd2ed60

2 years agoannotation method: detect default value based on "default" keyword (IDEA-237774)
Anna Kozlova [Thu, 16 Apr 2020 19:28:20 +0000 (21:28 +0200)]
annotation method: detect default value based on "default" keyword (IDEA-237774)

GitOrigin-RevId: 64be4b28fc7fe9e79aae58ddba140bd65d56c2ef

2 years agojava type system: use captured wildcard bounds in cast context (IDEA-233551)
Anna Kozlova [Thu, 16 Apr 2020 10:37:28 +0000 (12:37 +0200)]
java type system: use captured wildcard bounds in cast context (IDEA-233551)

starting with javac 1.9+ such code starting to compile, javac 8 rejects the code with the same language level used

GitOrigin-RevId: 87a1e4d475927af0ee71cd74f5a66e130908ed82

2 years agojunit: simplify console folding patterns
Anna Kozlova [Thu, 16 Apr 2020 09:20:22 +0000 (11:20 +0200)]
junit: simplify console folding patterns

GitOrigin-RevId: 026c8363340844a1c0d773a77306d9e58c9fc39b

2 years agoJPS caches: fail on non-200 code: revert for PUT
Dmitriy.Panov [Thu, 16 Apr 2020 19:30:02 +0000 (22:30 +0300)]
JPS caches: fail on non-200 code: revert for PUT

GitOrigin-RevId: 39eaecdf71396d08081bf1eca62d63242726eb00

2 years agoJPS caches: fail on non-200 code
Dmitriy.Panov [Thu, 16 Apr 2020 18:58:38 +0000 (21:58 +0300)]
JPS caches: fail on non-200 code

GitOrigin-RevId: 02ad946d0617ed7736e7e02cc53598a080dd1343

2 years ago[Workspace Model] Update soft references
Alex Plate [Thu, 16 Apr 2020 19:05:49 +0000 (22:05 +0300)]
[Workspace Model] Update soft references

GitOrigin-RevId: 06aa147289f685bfd26d2ba0af56c61541b8de9d

2 years ago[Workspace Model] Cleanup PEntityStorage
Alex Plate [Thu, 16 Apr 2020 18:23:08 +0000 (21:23 +0300)]
[Workspace Model] Cleanup PEntityStorage

GitOrigin-RevId: 129c66e0045aa1cf0801e7dd0fc648e5005cc796