idea/community.git
7 years agoartifact builder tests: duplicated method removed
nik [Thu, 30 Jul 2015 07:49:09 +0000 (10:49 +0300)]
artifact builder tests: duplicated method removed

7 years agofixed Select all and delete doesn't work: "it's not allowed to delete answer placehol...
Ekaterina Tuzova [Thu, 30 Jul 2015 08:28:55 +0000 (11:28 +0300)]
fixed Select all and delete doesn't work: "it's not allowed to delete answer placeholder" #37

7 years agofixed Hide publications folder (/.publications) in study project view #43
Ekaterina Tuzova [Wed, 29 Jul 2015 18:43:31 +0000 (21:43 +0300)]
fixed Hide publications folder (/.publications) in study project view #43

do not show any folder which starts with "."

7 years agofixed NPE caused by task containing folder
Ekaterina Tuzova [Wed, 29 Jul 2015 18:42:46 +0000 (21:42 +0300)]
fixed NPE caused by task containing folder

7 years agoextracted "tests.py" as a constant
Ekaterina Tuzova [Wed, 29 Jul 2015 18:36:55 +0000 (21:36 +0300)]
extracted "tests.py" as a constant

7 years agoJavaFunctionalExpressionSearcher: in small scopes, don't bother with method stub...
peter [Thu, 30 Jul 2015 06:37:16 +0000 (08:37 +0200)]
JavaFunctionalExpressionSearcher: in small scopes, don't bother with method stub index

non-call usages are included, don't search for them again

7 years agoJavaFunctionalExpressionSearcher: in small scopes, don't bother with method stub... appcode/142.3605 clion/142.3602 dbe/142.3609 idea/142.3604 phpstorm/142.3607 pycharm/142.3601 rubymine/142.3606 webstorm/142.3600
peter [Wed, 29 Jul 2015 20:55:02 +0000 (22:55 +0200)]
JavaFunctionalExpressionSearcher: in small scopes, don't bother with method stub index

but include non-call usages

7 years agoCleanup (warnings; typos)
Roman Shevchenko [Wed, 29 Jul 2015 20:10:17 +0000 (22:10 +0200)]
Cleanup (warnings; typos)

7 years agoJavaFunctionalExpressionSearcher: in small scopes, don't bother with method stub...
peter [Wed, 29 Jul 2015 20:04:15 +0000 (22:04 +0200)]
JavaFunctionalExpressionSearcher: in small scopes, don't bother with method stub index

7 years ago[ui] fixes app activation/deactivation tracking via window focus events (IDEA-142728)
Roman Shevchenko [Wed, 29 Jul 2015 19:38:46 +0000 (21:38 +0200)]
[ui] fixes app activation/deactivation tracking via window focus events (IDEA-142728)

7 years agowhen file content is reloaded externally, clear all roots in the view provider (EA...
peter [Wed, 29 Jul 2015 19:26:09 +0000 (21:26 +0200)]
when file content is reloaded externally, clear all roots in the view provider (EA-69225 - assert: SingleRootFileViewProvider.setContent)

7 years agoPsiToDocumentSynchronizer shouldn't be the first one to load AST
peter [Wed, 29 Jul 2015 19:09:30 +0000 (21:09 +0200)]
PsiToDocumentSynchronizer shouldn't be the first one to load AST

e.g. for file-level childrenChanged event AST may be missing, and that's OK

7 years agoIDEA-143013 Compound RC: StackOverflowError on enabling Compound RC inside another...
Vassiliy.Kudryashov [Wed, 29 Jul 2015 18:41:58 +0000 (21:41 +0300)]
IDEA-143013 Compound RC: StackOverflowError on enabling Compound RC inside another Compound RC

7 years agoskip shorter entities too
Dennis Ushakov [Wed, 29 Jul 2015 18:33:59 +0000 (21:33 +0300)]
skip shorter entities too
#WEB-17454 fixed

7 years agofix javadoc incremental reparse; add diagnostics for stub-ast mismatches caused by...
peter [Wed, 29 Jul 2015 18:13:53 +0000 (20:13 +0200)]
fix javadoc incremental reparse; add diagnostics for stub-ast mismatches caused by such events

7 years agoan ability to turn off gutter icons for annotations inferred from source (IDEA-135399)
peter [Wed, 29 Jul 2015 17:32:55 +0000 (19:32 +0200)]
an ability to turn off gutter icons for annotations inferred from source (IDEA-135399)

7 years agoIDEA-137170 Static nullability analysis incorrectly marks parameter as @Nullable...
peter [Wed, 29 Jul 2015 16:59:15 +0000 (18:59 +0200)]
IDEA-137170 Static nullability analysis incorrectly marks parameter as @Nullable in Android SDK

7 years agocleaned up pycharm educational menu items appcode/142.3598
Ekaterina Tuzova [Wed, 29 Jul 2015 18:20:10 +0000 (21:20 +0300)]
cleaned up pycharm educational menu items

7 years agorequire ; at the end of entity clion/142.3597
Dennis Ushakov [Wed, 29 Jul 2015 17:25:26 +0000 (20:25 +0300)]
require ; at the end of entity
#WEB-17454 fixed

7 years agonormalize file reference names
Dennis Ushakov [Wed, 29 Jul 2015 17:06:50 +0000 (20:06 +0300)]
normalize file reference names
#WEB-17490 fixed

7 years agocleanup: extract method
Konstantin Ulitin [Wed, 29 Jul 2015 16:43:16 +0000 (19:43 +0300)]
cleanup: extract method

7 years agoMoved study component initialization to the proper place
Ekaterina Tuzova [Wed, 29 Jul 2015 16:03:34 +0000 (19:03 +0300)]
Moved study component initialization to the proper place

7 years agowrite history right into file to avoid OOME
Anna Kozlova [Wed, 29 Jul 2015 15:49:09 +0000 (17:49 +0200)]
write history right into file to avoid OOME

7 years agoResource bundle editor: Show full key name in status bar IDEA-71760
Dmitry Batkovich [Wed, 29 Jul 2015 14:51:29 +0000 (17:51 +0300)]
Resource bundle editor: Show full key name in status bar IDEA-71760

7 years agoIf one thread finished its work, debugger loses access to other suspended threads...
Elizaveta Shashkova [Wed, 29 Jul 2015 14:03:22 +0000 (17:03 +0300)]
If one thread finished its work, debugger loses access to other suspended threads (PY-16525)

After killing thread check if there are other suspended threads and notify UI of it.

7 years agolst: fix popup size
Aleksey Pivovarov [Wed, 29 Jul 2015 13:26:08 +0000 (16:26 +0300)]
lst: fix popup size

7 years agorefactoring - replaced int constants with enums appcode/142.3595
Egor.Ushakov [Wed, 29 Jul 2015 13:10:42 +0000 (16:10 +0300)]
refactoring - replaced int constants with enums

7 years agocleanup
Vladimir Krivosheev [Wed, 29 Jul 2015 11:07:22 +0000 (13:07 +0200)]
cleanup

7 years agonot null
Vladimir Krivosheev [Wed, 29 Jul 2015 10:33:54 +0000 (12:33 +0200)]
not null

7 years agocleanup
Vladimir Krivosheev [Wed, 29 Jul 2015 07:50:30 +0000 (09:50 +0200)]
cleanup

7 years agocleanup
Vladimir Krivosheev [Wed, 29 Jul 2015 07:25:35 +0000 (09:25 +0200)]
cleanup

7 years agoStateStorageManagerImpl — don't implement Disposable, use parentDisposable directly
Vladimir Krivosheev [Wed, 29 Jul 2015 07:24:53 +0000 (09:24 +0200)]
StateStorageManagerImpl — don't implement Disposable, use parentDisposable directly

7 years agobase createStorageData impl, cleanup
Vladimir Krivosheev [Tue, 28 Jul 2015 16:29:49 +0000 (18:29 +0200)]
base createStorageData impl, cleanup

7 years agoextract getOrCreateStorage, cleanup (returned storage is always not-null)
Vladimir Krivosheev [Tue, 28 Jul 2015 16:20:04 +0000 (18:20 +0200)]
extract getOrCreateStorage, cleanup (returned storage is always not-null)

7 years agousage of other.xml is deprecated — custom file should be used instead
Vladimir Krivosheev [Tue, 28 Jul 2015 15:35:47 +0000 (17:35 +0200)]
usage of other.xml is deprecated — custom file should be used instead

7 years agoreduce usage of project.getStateStore
Vladimir Krivosheev [Tue, 28 Jul 2015 15:29:00 +0000 (17:29 +0200)]
reduce usage of project.getStateStore

7 years agowe don't write xml prolog due to historical reasons (and should not in any case)...
Vladimir Krivosheev [Tue, 28 Jul 2015 14:17:18 +0000 (16:17 +0200)]
we don't write xml prolog due to historical reasons (and should not in any case) (regression in 142 branch since 3/7/15)

7 years agoFinally we reduce level of default project settings hack to minimum. No more fragile...
Vladimir Krivosheev [Tue, 28 Jul 2015 13:57:58 +0000 (15:57 +0200)]
Finally we reduce level of default project settings hack to minimum. No more fragile logic (save inside getState(), boolean flags),  no more double save (it is was impossible to fix it correctly).

Also, default project state is not loaded on ProjectManagerImpl initialization, so, VFS roots assert works correctly in tests (because ProjectManager.openProjects is used, but it was totally wrong — we use VFS to load state from disk (it is another issue why we load configs during tests))

7 years agorename property to avoid possible conflicts with plugins
Anna Kozlova [Wed, 29 Jul 2015 12:59:17 +0000 (14:59 +0200)]
rename property to avoid possible conflicts with plugins

7 years agochange signature dialog: ensure that signature would be updated when modality state...
Anna Kozlova [Wed, 29 Jul 2015 12:58:06 +0000 (14:58 +0200)]
change signature dialog: ensure that signature would be updated when modality state corresponds to dialog so find usages under progress won't deadlock (IDEA-143236)

7 years agoIDEA-143164 clion/142.3594
Maxim.Mossienko [Wed, 29 Jul 2015 12:09:34 +0000 (14:09 +0200)]
IDEA-143164
IDEA 15 EAP Hangs Sometimes for a Few Minutes

7 years agoGuavaFluentIterableInspection: visitor moved to checkFile() + fixed findContainingMet...
Dmitry Batkovich [Wed, 29 Jul 2015 12:11:48 +0000 (15:11 +0300)]
GuavaFluentIterableInspection: visitor moved to checkFile() + fixed findContainingMethodReturnType() method when expression is placed inside lambda expression

7 years agodisable classpath jar by default; leave enabled for tests and app phpstorm/142.3593
Anna Kozlova [Wed, 29 Jul 2015 11:30:14 +0000 (13:30 +0200)]
disable classpath jar by default; leave enabled for tests and app

7 years agoeditor: enable debugger breakpoint actions in dumb mode
Aleksey Pivovarov [Wed, 29 Jul 2015 10:37:17 +0000 (13:37 +0300)]
editor: enable debugger breakpoint actions in dumb mode

7 years ago[test] test timeout increased to adopt for a slow partial refresh appcode/142.3592
Roman Shevchenko [Wed, 29 Jul 2015 10:04:12 +0000 (12:04 +0200)]
[test] test timeout increased to adopt for a slow partial refresh

7 years agoeditor: mark few GutterMarks as DumbAware
Aleksey Pivovarov [Wed, 22 Jul 2015 12:46:20 +0000 (15:46 +0300)]
editor: mark few GutterMarks as DumbAware

7 years agoeditor: require marking GutterMark with DumbAware (rr=peter)
Aleksey Pivovarov [Tue, 21 Jul 2015 13:46:16 +0000 (16:46 +0300)]
editor: require marking GutterMark with DumbAware (rr=peter)

7 years agoeditor: better wording for notification
Aleksey Pivovarov [Wed, 22 Jul 2015 10:11:00 +0000 (13:11 +0300)]
editor: better wording for notification

7 years agoCache values of JsonObject#findProperty using CachedValuesManager
Mikhail Golubev [Tue, 28 Jul 2015 19:31:42 +0000 (22:31 +0300)]
Cache values of JsonObject#findProperty using CachedValuesManager

Cache is invalidated on every change in containing PSI file.

7 years agocleanup
Dmitry Batkovich [Wed, 29 Jul 2015 09:46:12 +0000 (12:46 +0300)]
cleanup

7 years agoGuavaFluentIterableInspection: used thread-safe collections as final fields in visitor
Dmitry Batkovich [Wed, 29 Jul 2015 09:43:25 +0000 (12:43 +0300)]
GuavaFluentIterableInspection: used thread-safe collections as final fields in visitor

7 years agofixed usage type for static fields and methods (IDEA-143229)
nik [Wed, 29 Jul 2015 09:12:47 +0000 (12:12 +0300)]
fixed usage type for static fields and methods (IDEA-143229)

7 years agounused code removed
nik [Wed, 29 Jul 2015 07:25:28 +0000 (10:25 +0300)]
unused code removed

7 years agoIDEA-141164 Ability to generate code inferred annotations
peter [Wed, 29 Jul 2015 09:03:24 +0000 (11:03 +0200)]
IDEA-141164 Ability to generate code inferred annotations

abort when the file is non-writable

7 years agocheck for empty array too
Maxim.Mossienko [Wed, 29 Jul 2015 08:42:51 +0000 (10:42 +0200)]
check for empty array too

7 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Wed, 29 Jul 2015 08:35:20 +0000 (10:35 +0200)]
Merge remote-tracking branch 'origin/master'

7 years ago[vfs] adds special handling for cross-case rename (via an intermediate file)
Roman Shevchenko [Wed, 29 Jul 2015 08:32:03 +0000 (10:32 +0200)]
[vfs] adds special handling for cross-case rename (via an intermediate file)

7 years agofunctional expressions searcher: extract methods
Anna Kozlova [Wed, 29 Jul 2015 07:59:12 +0000 (09:59 +0200)]
functional expressions searcher: extract methods

7 years agonew inference: check low and eq bounds the same for parameterization
Anna Kozlova [Tue, 28 Jul 2015 19:45:49 +0000 (21:45 +0200)]
new inference: check low and eq bounds the same for parameterization

7 years agonew inference: ensure erased target type if substitutor was raw (IDEA-143183)
Anna Kozlova [Tue, 28 Jul 2015 18:19:59 +0000 (20:19 +0200)]
new inference: ensure erased target type if substitutor was raw (IDEA-143183)

7 years agoInspectionToolsConfigurable: moved ui initialization from constructor to createCompon...
Dmitry Batkovich [Wed, 29 Jul 2015 07:41:01 +0000 (10:41 +0300)]
InspectionToolsConfigurable: moved ui initialization from constructor to createComponent()

7 years agouse read action for PSI access in JavaFunctionalExpressionSearcher
peter [Wed, 29 Jul 2015 07:28:48 +0000 (09:28 +0200)]
use read action for PSI access in JavaFunctionalExpressionSearcher

7 years agoLanguagePerFileConfigurable: allow bg dumb mode
peter [Wed, 29 Jul 2015 07:18:23 +0000 (09:18 +0200)]
LanguagePerFileConfigurable: allow bg dumb mode

7 years agounused deprecated methods removed
nik [Wed, 29 Jul 2015 07:23:25 +0000 (10:23 +0300)]
unused deprecated methods removed

7 years agoadd dependency on external library quick-fix: API simplified, duplicated code removed
nik [Wed, 29 Jul 2015 05:31:13 +0000 (08:31 +0300)]
add dependency on external library quick-fix: API simplified, duplicated code removed

7 years agoTreeTraverser: shorten names clion/142.3588 dbe/142.3583 idea/142.3587 phpstorm/142.3586 pycharm/142.3584 rubymine/142.3585 webstorm/142.3582
Gregory.Shrago [Tue, 28 Jul 2015 19:34:47 +0000 (22:34 +0300)]
TreeTraverser: shorten names

7 years agofrom non-project non-library (e.g. light) files, resolve in allScope (fixes Generator...
peter [Tue, 28 Jul 2015 20:09:59 +0000 (22:09 +0200)]
from non-project non-library (e.g. light) files, resolve in allScope (fixes GeneratorTest)

7 years agoIDEA-143165 IntelliJ 15 EAP Quick find not replacing text with new find text
Vassiliy.Kudryashov [Tue, 28 Jul 2015 19:59:20 +0000 (22:59 +0300)]
IDEA-143165 IntelliJ 15 EAP  Quick find not replacing text with new find text

7 years agoIDEA-142415 Actions in Commit Dialog are not updated until some activity from the...
Sergey Malenkov [Tue, 28 Jul 2015 19:33:47 +0000 (22:33 +0300)]
IDEA-142415 Actions in Commit Dialog are not updated until some activity from the user

7 years agoTreeTraverser: shorten names clion/142.3579
Gregory.Shrago [Tue, 28 Jul 2015 19:01:45 +0000 (22:01 +0300)]
TreeTraverser: shorten names

7 years agoExtract ArbitraryPlaceUrlReferenceProvider into platform (fixes WEB-17031)
Alexander Zolotov [Tue, 28 Jul 2015 19:01:29 +0000 (22:01 +0300)]
Extract ArbitraryPlaceUrlReferenceProvider into platform (fixes WEB-17031)

7 years agoIDEA-142816 Action toolbar: buttons should be center-aligned vertically
Vassiliy.Kudryashov [Tue, 28 Jul 2015 18:54:44 +0000 (21:54 +0300)]
IDEA-142816 Action toolbar: buttons should be center-aligned vertically

7 years agoavoid INRE causing holes in java structure view (IDEA-142210)
peter [Tue, 28 Jul 2015 18:39:20 +0000 (20:39 +0200)]
avoid INRE causing holes in java structure view (IDEA-142210)

7 years agoIDEA-143193 Wrong popup info for not registered URI
Dmitry Avdeev [Tue, 28 Jul 2015 18:34:53 +0000 (21:34 +0300)]
IDEA-143193 Wrong popup info for not registered URI

7 years agoit's expensive to store all document LineSets since commit, so replay them instead
peter [Tue, 28 Jul 2015 18:18:35 +0000 (20:18 +0200)]
it's expensive to store all document LineSets since commit, so replay them instead

7 years agoIDEA-85878 Expression Evaluation - IDEA should already know packages
Egor.Ushakov [Tue, 28 Jul 2015 18:14:31 +0000 (21:14 +0300)]
IDEA-85878 Expression Evaluation - IDEA should already know packages

7 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Tue, 28 Jul 2015 18:00:36 +0000 (20:00 +0200)]
Merge remote-tracking branch 'origin/master'

7 years agoPluggable file watcher
Dmitry Lomov [Tue, 28 Jul 2015 17:59:20 +0000 (19:59 +0200)]
Pluggable file watcher

This implements a new extension point that allows plugins to provide their own implementation of file watchers, not requiring a different fsnotifier binary.

https://github.com/JetBrains/intellij-community/pull/292

7 years agodon't assert about ModalityState.any in tests where it's equal to NON_MODAL
peter [Tue, 28 Jul 2015 17:45:57 +0000 (19:45 +0200)]
don't assert about ModalityState.any in tests where it's equal to NON_MODAL

7 years agoRemoved unused method isHierarhyEnabled
Maxim.Mossienko [Tue, 28 Jul 2015 17:01:00 +0000 (19:01 +0200)]
Removed unused method isHierarhyEnabled

7 years agoIDEA-85878 Expression Evaluation - IDEA should already know packages - compute eval...
Egor.Ushakov [Tue, 28 Jul 2015 17:23:55 +0000 (20:23 +0300)]
IDEA-85878 Expression Evaluation - IDEA should already know packages - compute eval xexpression, not plain text

7 years agoAIOOBE
Anna Kozlova [Tue, 28 Jul 2015 17:12:40 +0000 (19:12 +0200)]
AIOOBE

7 years agoCPP-4093 DumbService exception in "add file extension" dialog
peter [Tue, 28 Jul 2015 17:07:44 +0000 (19:07 +0200)]
CPP-4093 DumbService exception in "add file extension" dialog

7 years agodocument LineSet: use 37.5% less memory
peter [Tue, 28 Jul 2015 16:58:43 +0000 (18:58 +0200)]
document LineSet: use 37.5% less memory

7 years agofunction expression search optimization: index for method names with function express...
Anna Kozlova [Tue, 28 Jul 2015 16:32:04 +0000 (18:32 +0200)]
function expression search optimization: index for method names with function expression argument

7 years agoIDEA-115957 Keymap: Mouse shortcut conflict detection broken: Depends on current...
Vassiliy.Kudryashov [Tue, 28 Jul 2015 16:12:48 +0000 (19:12 +0300)]
IDEA-115957 Keymap: Mouse shortcut conflict detection broken: Depends on current filter

7 years agoGrAnonymousClassDefinitionImpl: store qualified base class name in stubs
peter [Tue, 28 Jul 2015 16:15:46 +0000 (18:15 +0200)]
GrAnonymousClassDefinitionImpl: store qualified base class name in stubs

7 years agolibrary classes use scope should not be "all project" phpstorm/142.3577
peter [Tue, 28 Jul 2015 15:30:59 +0000 (17:30 +0200)]
library classes use scope should not be "all project"

7 years agosaveAll in settings dialog can start bg dumb mode (EA-71064 - Throwable: DumbServiceI...
peter [Tue, 28 Jul 2015 14:29:56 +0000 (16:29 +0200)]
saveAll in settings dialog can start bg dumb mode (EA-71064 - Throwable: DumbServiceImpl.a)

7 years agosvn: Refactored SvnDiffProvider - code simplified, warnings fixed, @NotNull
Konstantin Kolosovsky [Tue, 28 Jul 2015 14:25:08 +0000 (17:25 +0300)]
svn: Refactored SvnDiffProvider - code simplified, warnings fixed, @NotNull

7 years agoIDEA-139842 Additional diagnostics for failures while retrieving last commit message...
Konstantin Kolosovsky [Tue, 28 Jul 2015 13:07:40 +0000 (16:07 +0300)]
IDEA-139842 Additional diagnostics for failures while retrieving last commit message for given file

7 years agoIDEA-139842 Do not fail in case of error while retrieving last commit message for...
Konstantin Kolosovsky [Tue, 28 Jul 2015 12:57:14 +0000 (15:57 +0300)]
IDEA-139842 Do not fail in case of error while retrieving last commit message for given file (use empty commit message instead)

7 years ago[vfs] ensures a directory consistency during refresh (IDEA-142978)
Roman Shevchenko [Tue, 28 Jul 2015 14:31:49 +0000 (16:31 +0200)]
[vfs] ensures a directory consistency during refresh (IDEA-142978)

7 years agoIDEA-143181 NPE at com.intellij.diagnostic.ErrorNotifier$1.hyperlinkUpdate on pressin...
peter [Tue, 28 Jul 2015 14:09:38 +0000 (16:09 +0200)]
IDEA-143181 NPE at com.intellij.diagnostic.ErrorNotifier$1.hyperlinkUpdate on pressing IDE Fatal Error notification on Welcome Screen

7 years agoprohibit to start refresh session with ModalityState.any() to prevent dumb mode start...
peter [Tue, 28 Jul 2015 13:52:13 +0000 (15:52 +0200)]
prohibit to start refresh session with ModalityState.any() to prevent dumb mode starting from any dialog

7 years agofor nonword characters consider whole words boundary to be just different character...
Maxim.Mossienko [Tue, 28 Jul 2015 13:13:52 +0000 (15:13 +0200)]
for nonword characters consider whole words boundary to be just different character (r=Peter.Gromov)

7 years agoClean up and simplify in JsonFormattingTest
Mikhail Golubev [Tue, 28 Jul 2015 13:28:28 +0000 (16:28 +0300)]
Clean up and simplify in JsonFormattingTest

* It extends JsonTestCase, not FormatterTestCase
* Remove unnecessary wrappers, because in test mode formatter resets
settings automatically
* Add @MagicConstant annotation for wrapping settings in
JsonCodeStyleSettings

7 years agoAdd helper method addProperty in JsonPsiUtil
Mikhail Golubev [Tue, 28 Jul 2015 13:07:47 +0000 (16:07 +0300)]
Add helper method addProperty in JsonPsiUtil

7 years agoPY-16163 Do not split raw strings on escape sequences for spell checking
Mikhail Golubev [Fri, 17 Jul 2015 19:29:21 +0000 (22:29 +0300)]
PY-16163 Do not split raw strings on escape sequences for spell checking

7 years agoallow dumb mode for all open projects (RUBY-16985)
peter [Tue, 28 Jul 2015 13:42:41 +0000 (15:42 +0200)]
allow dumb mode for all open projects (RUBY-16985)