idea/community.git
6 years agoinspection view: commit is redundant here IDEA-160735
Dmitry Batkovich [Mon, 5 Sep 2016 07:37:21 +0000 (10:37 +0300)]
inspection view: commit is redundant here IDEA-160735

6 years agoEA-87767 - assert: ComponentManagerImpl.getPicoContainer
Anna Kozlova [Sun, 4 Sep 2016 18:13:37 +0000 (21:13 +0300)]
EA-87767 - assert: ComponentManagerImpl.getPicoContainer

6 years agoEA-87751 - SOE: TitleCapitalizationInspection.getTitleValue
Anna Kozlova [Sun, 4 Sep 2016 18:12:23 +0000 (21:12 +0300)]
EA-87751 - SOE: TitleCapitalizationInspection.getTitleValue

6 years agounused declaration: move unused local variables check to unused declaration
Anna Kozlova [Sun, 4 Sep 2016 18:02:45 +0000 (21:02 +0300)]
unused declaration: move unused local variables check to unused declaration

6 years agounused declaration: report methods directly called from test sources (IDEA-160530)
Anna Kozlova [Sun, 4 Sep 2016 16:40:41 +0000 (19:40 +0300)]
unused declaration: report methods directly called from test sources (IDEA-160530)

6 years agounused assignment: check lambda body for unused assignments
Anna Kozlova [Fri, 2 Sep 2016 13:31:53 +0000 (16:31 +0300)]
unused assignment: check lambda body for unused assignments

6 years agounused declaration: fix export to xml/html with new settings; tests added
Anna Kozlova [Fri, 2 Sep 2016 10:15:20 +0000 (13:15 +0300)]
unused declaration: fix export to xml/html with new settings; tests added

6 years agoextract super: eliminate duplication, correct invokeLater
Anna Kozlova [Fri, 2 Sep 2016 09:37:06 +0000 (12:37 +0300)]
extract super: eliminate duplication, correct invokeLater

6 years agoIDEA-CR-13504 Lambda to method-reference: PsiVariable is accepted as it's necessary... appcode/163.3915 clion/163.3912 dbe/163.3911 idea/163.3919 pycharm/163.3913 pycharm/163.3917 rubymine/163.3916 webstorm/163.3920
Tagir Valeev [Mon, 5 Sep 2016 01:56:24 +0000 (08:56 +0700)]
IDEA-CR-13504 Lambda to method-reference: PsiVariable is accepted as it's necessary for StreamApiMigrationInspection;
StreamApiMigrationInspection.TerminalBlock simplified (myFrom/myTo did not actually improve performance, but added unnecessary logic)

6 years agoPY-20610 Fix function annotation highlighting
Lada Gagina [Sun, 4 Sep 2016 18:25:48 +0000 (21:25 +0300)]
PY-20610 Fix function annotation highlighting

Fix PyTypeCheckerInspection so it doesn't highlight arrow in python 3 type annotations.

6 years ago[grails] hide old grails tool window by default
Daniil Ovchinnikov [Sun, 4 Sep 2016 15:09:47 +0000 (18:09 +0300)]
[grails] hide old grails tool window by default

6 years agoNPE diagnostics. EA-87874 appcode/163.3900
Kirill Likhodedov [Sun, 4 Sep 2016 14:29:42 +0000 (17:29 +0300)]
NPE diagnostics. EA-87874

6 years ago[groovy] enable unnecessary semicolon inspection by default appcode/163.3890 clion/163.3889
Daniil Ovchinnikov [Sun, 4 Sep 2016 10:58:40 +0000 (13:58 +0300)]
[groovy] enable unnecessary semicolon inspection by default

6 years agocleanup: remove unnecessary semicolons
Daniil Ovchinnikov [Sun, 4 Sep 2016 10:43:08 +0000 (13:43 +0300)]
cleanup: remove unnecessary semicolons

6 years agoMac LaF: Always use system selection preferences. Patch from Dennis. Thanks! appcode/163.3874 clion/163.3871 dbe/163.3872 idea/163.3873 phpstorm/163.3867 phpstorm/163.3885 pycharm/163.3869 pycharm/163.3875 rubymine/163.3868 webstorm/163.3876
Konstantin Bulenkov [Sat, 3 Sep 2016 20:58:18 +0000 (22:58 +0200)]
Mac LaF: Always use system selection preferences. Patch from Dennis. Thanks!

6 years agoreduce contrast in gray filters for darcula nad bright themes
Konstantin Bulenkov [Sat, 3 Sep 2016 19:54:24 +0000 (21:54 +0200)]
reduce contrast in gray filters for darcula nad bright themes

6 years agolambdify appcode/163.3862 clion/163.3861 dbe/163.3859
Kirill Likhodedov [Sat, 3 Sep 2016 12:36:32 +0000 (15:36 +0300)]
lambdify

6 years agocleanup: no need to generify the type
Kirill Likhodedov [Sat, 3 Sep 2016 12:34:49 +0000 (15:34 +0300)]
cleanup: no need to generify the type

Any generification complicates the code.
Here the actual type is used only if one place of GitIntegrationEnabler
which is easily worked around by saving GitVcs to a field.

6 years agocleanup: functional style, some reformat, cleaner names
Kirill Likhodedov [Sat, 3 Sep 2016 12:21:54 +0000 (15:21 +0300)]
cleanup: functional style, some reformat, cleaner names

Also inlined a trivial conversion method with just one usage.

6 years agoNo need in write action
Kirill Likhodedov [Sat, 3 Sep 2016 12:07:52 +0000 (15:07 +0300)]
No need in write action

Was added long ago due to a misunderstanding of the refreshAndFind
method which javadoc has been fixed since then.

6 years agoIDEA-160408 Quote not recognized as an end to String appcode/163.3856 clion/163.3857 phpstorm/163.3855
Dmitry Avdeev [Sat, 3 Sep 2016 09:56:56 +0000 (12:56 +0300)]
IDEA-160408 Quote not recognized as an end to String

6 years agoopen project set in a transaction
peter [Sat, 3 Sep 2016 09:16:55 +0000 (11:16 +0200)]
open project set in a transaction

6 years agopython: perform model modifications in a write-safe context appcode/163.3853 clion/163.3852
peter [Sat, 3 Sep 2016 07:54:31 +0000 (09:54 +0200)]
python: perform model modifications in a write-safe context

6 years agosettings-repository: remove unnecessary invokeAndWait in sync which is always called...
peter [Sat, 3 Sep 2016 07:32:09 +0000 (09:32 +0200)]
settings-repository: remove unnecessary invokeAndWait in sync which is always called on EDT

6 years agoSkeletons sync appcode/163.3843 dbe/163.3847 idea/163.3841 pycharm/163.3840 pycharm/163.3845 rubymine/163.3844 webstorm/163.3850
Ilya.Kazakevich [Fri, 2 Sep 2016 21:12:52 +0000 (00:12 +0300)]
Skeletons sync

6 years agoPY-20464: Sync with skeletons
Ilya.Kazakevich [Fri, 2 Sep 2016 21:12:28 +0000 (00:12 +0300)]
PY-20464: Sync with skeletons

6 years agosynchronize FindInProjectTask.myLargeFiles (EA-87713 - IAE: TObjectHash.throwObjectCo...
peter [Fri, 2 Sep 2016 20:20:06 +0000 (22:20 +0200)]
synchronize FindInProjectTask.myLargeFiles (EA-87713 - IAE: TObjectHash.throwObjectContractViolation)

6 years agoformatter: perform document modifications in a write-safe context
peter [Fri, 2 Sep 2016 20:08:04 +0000 (22:08 +0200)]
formatter: perform document modifications in a write-safe context

6 years agoom.intellij.util.IncorrectOperationException: Sorry but parent: ETF dispose has alrea...
Vassiliy.Kudryashov [Fri, 2 Sep 2016 19:47:39 +0000 (22:47 +0300)]
om.intellij.util.IncorrectOperationException: Sorry but parent: ETF dispose has already been disposed

6 years agocommunity: use short form of application.invokeAndWait
peter [Fri, 2 Sep 2016 19:25:41 +0000 (21:25 +0200)]
community: use short form of application.invokeAndWait

6 years agoplatform: use short form of application.invokeAndWait
peter [Fri, 2 Sep 2016 19:20:00 +0000 (21:20 +0200)]
platform: use short form of application.invokeAndWait

6 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Fri, 2 Sep 2016 18:55:48 +0000 (21:55 +0300)]
Merge remote-tracking branch 'origin/master'

6 years agofixed endless flickering in frames view
Egor.Ushakov [Fri, 2 Sep 2016 16:22:16 +0000 (19:22 +0300)]
fixed endless flickering in frames view

6 years agoCleanup (logger access; copyright; dead code)
Roman Shevchenko [Fri, 2 Sep 2016 14:01:09 +0000 (17:01 +0300)]
Cleanup (logger access; copyright; dead code)

6 years agoFIXED WI-33037 Caret isn't indented if there is a comment multiline comment after...
Rustam Vishnyakov [Fri, 2 Sep 2016 15:40:58 +0000 (18:40 +0300)]
FIXED WI-33037 Caret isn't indented if there is a comment multiline comment after block start statement

6 years agoAdd registry key select.context.run.configuration appcode/163.3798 clion/163.3797 idea/163.3802
Vassiliy.Kudryashov [Fri, 2 Sep 2016 14:29:52 +0000 (17:29 +0300)]
Add registry key select.context.run.configuration

6 years agoWI-33073 Save project template doesn't work
Shaverdova Elena [Fri, 2 Sep 2016 14:28:15 +0000 (16:28 +0200)]
WI-33073 Save project template doesn't work

6 years agoFix exception on new project creation from template
Shaverdova Elena [Thu, 1 Sep 2016 18:23:42 +0000 (20:23 +0200)]
Fix exception on new project creation from template

6 years agoProper invokeAndWait to avoid exception on nontrivial workspace.xml
Shaverdova Elena [Wed, 31 Aug 2016 18:12:30 +0000 (20:12 +0200)]
Proper invokeAndWait to avoid exception on nontrivial workspace.xml

6 years agorefacoring: extract content iterator into a private class
Shaverdova Elena [Tue, 30 Aug 2016 17:03:59 +0000 (19:03 +0200)]
refacoring: extract content iterator into a private class

6 years agoFixing tests:
Ilya.Kazakevich [Fri, 2 Sep 2016 14:04:45 +0000 (17:04 +0300)]
Fixing tests:

* With new pytest even one import error stops testing process. So, there should be 1 fail in old pytest and 2 fails in new one

6 years agoRUBY-18262 Sorting order for Rails 5.0.0 and 5.0.0.racecar1 is incorrect
Andrey Vokin [Fri, 2 Sep 2016 14:14:01 +0000 (16:14 +0200)]
RUBY-18262 Sorting order for Rails 5.0.0 and 5.0.0.racecar1 is incorrect

6 years agoreduce amount of debugger communication within read action
Egor.Ushakov [Fri, 2 Sep 2016 12:17:06 +0000 (15:17 +0300)]
reduce amount of debugger communication within read action

6 years agowording for jdk version mismatch notification
Egor.Ushakov [Fri, 2 Sep 2016 10:10:04 +0000 (13:10 +0300)]
wording for jdk version mismatch notification

6 years agoadded read action
Egor.Ushakov [Fri, 2 Sep 2016 09:58:46 +0000 (12:58 +0300)]
added read action

6 years agoJava control flow: Check for side effect of exception thrown when extracting a method...
Pavel Dolgov [Fri, 2 Sep 2016 13:47:06 +0000 (16:47 +0300)]
Java control flow: Check for side effect of exception thrown when extracting a method - javadoc updated according to the review comments, a minor refactoring applied (IDEA-79444, IDEA-159916)

6 years agovcs: use short form of application.invokeAndWait
peter [Fri, 2 Sep 2016 14:01:45 +0000 (16:01 +0200)]
vcs: use short form of application.invokeAndWait

6 years agotests: use short form of application.invokeAndWait
peter [Fri, 2 Sep 2016 13:51:28 +0000 (15:51 +0200)]
tests: use short form of application.invokeAndWait

6 years agoTransactionGuardImpl.assertWriteActionAllowed: more diagnostics (IDEA-160724)
peter [Fri, 2 Sep 2016 13:34:00 +0000 (15:34 +0200)]
TransactionGuardImpl.assertWriteActionAllowed: more diagnostics (IDEA-160724)

6 years agoIDEA-160408 Quote not recognized as an end to String
Dmitry Avdeev [Fri, 2 Sep 2016 12:50:25 +0000 (15:50 +0300)]
IDEA-160408 Quote not recognized as an end to String

6 years agoadd Application#invokeAndWait(runnable) using default modality state
peter [Fri, 2 Sep 2016 12:44:36 +0000 (14:44 +0200)]
add Application#invokeAndWait(runnable) using default modality state

6 years agoTransactionGuard javadoc: describe more ways of resolving transaction exceptions
peter [Fri, 2 Sep 2016 12:38:25 +0000 (14:38 +0200)]
TransactionGuard javadoc: describe more ways of resolving transaction exceptions

6 years agoAdd test for argument parsing for subprocess (PY-20476 ) clion/163.3788
Elizaveta Shashkova [Fri, 2 Sep 2016 12:08:20 +0000 (15:08 +0300)]
Add test for argument parsing for subprocess (PY-20476 )

6 years agoIDEA-160389 Manage Code style setting | Copy to project doesn't update settings edito...
Rustam Vishnyakov [Thu, 1 Sep 2016 17:14:58 +0000 (20:14 +0300)]
IDEA-160389 Manage Code style setting | Copy to project doesn't update settings editor until settings dialog is reopened

6 years agoIDEA-160426 Export of Code Style does not include JavaDoc configurations
Rustam Vishnyakov [Thu, 1 Sep 2016 11:01:14 +0000 (14:01 +0300)]
IDEA-160426 Export of Code Style does not include JavaDoc configurations

6 years agobuild scripts: don't specify too restrictive since-build for non-bundled plugins - 2
nik [Fri, 2 Sep 2016 12:18:05 +0000 (15:18 +0300)]
build scripts: don't specify too restrictive since-build for non-bundled plugins - 2

6 years agobuild scripts: don't specify too restrictive since-build for non-bundled plugins
nik [Fri, 2 Sep 2016 12:16:58 +0000 (15:16 +0300)]
build scripts: don't specify too restrictive since-build for non-bundled plugins

6 years agoJava control flow: Check for side effect of exception thrown when extracting a method...
Pavel Dolgov [Fri, 2 Sep 2016 12:14:34 +0000 (15:14 +0300)]
Java control flow: Check for side effect of exception thrown when extracting a method - javadoc improved, a long computation is split into several helper methods (IDEA-79444, IDEA-159916)

6 years agoMerge remote-tracking branch 'origin/master'
Alexey Utkin [Fri, 2 Sep 2016 12:09:17 +0000 (15:09 +0300)]
Merge remote-tracking branch 'origin/master'

6 years agoMerge remote-tracking branch 'origin/master' appcode/163.3783
Roman Shevchenko [Fri, 2 Sep 2016 11:59:48 +0000 (14:59 +0300)]
Merge remote-tracking branch 'origin/master'

6 years agoCleanup (internal type text expressed via canonical wherever possible)
Roman Shevchenko [Fri, 2 Sep 2016 11:58:53 +0000 (14:58 +0300)]
Cleanup (internal type text expressed via canonical wherever possible)

6 years ago[groovy] use any() instead of isNotEmpty()
Daniil Ovchinnikov [Fri, 2 Sep 2016 11:47:26 +0000 (14:47 +0300)]
[groovy] use any() instead of isNotEmpty()

6 years agooptimize imports
Daniil Ovchinnikov [Thu, 1 Sep 2016 14:03:52 +0000 (17:03 +0300)]
optimize imports

6 years ago[groovy] convert language to Kotlin
Daniil Ovchinnikov [Tue, 30 Aug 2016 16:48:11 +0000 (19:48 +0300)]
[groovy] convert language to Kotlin

6 years agoPY-19992 Pep8ExternalAnnotator takes into account inspection's scope
Mikhail Golubev [Fri, 2 Sep 2016 11:24:49 +0000 (14:24 +0300)]
PY-19992 Pep8ExternalAnnotator takes into account inspection's scope

Previously, it simply didn't run if "PEP 8 coding style violation"
inspection wasn't enabled in all scopes.

6 years agoproperties: rewrite fix for IDEA-97844. associate string literal in field with proper...
Dmitry Batkovich [Fri, 2 Sep 2016 11:21:00 +0000 (14:21 +0300)]
properties: rewrite fix for IDEA-97844. associate string literal in field with properties file

6 years agoOfflineProblemDescriptor: remove obsolete later(commitAll())
Dmitry Batkovich [Fri, 2 Sep 2016 09:33:36 +0000 (12:33 +0300)]
OfflineProblemDescriptor: remove obsolete later(commitAll())

6 years agoinspection settings: source profile is not deleted after rename - fixed IDEA-160657
Dmitry Batkovich [Fri, 2 Sep 2016 08:56:40 +0000 (11:56 +0300)]
inspection settings: source profile is not deleted after rename - fixed IDEA-160657

6 years agoinspection settings: import profile with same name as existed IDEA-160668
Dmitry Batkovich [Fri, 2 Sep 2016 08:19:54 +0000 (11:19 +0300)]
inspection settings: import profile with same name as existed IDEA-160668

6 years agoCleanup (formatting; warnings)
Roman Shevchenko [Fri, 2 Sep 2016 11:32:54 +0000 (14:32 +0300)]
Cleanup (formatting; warnings)

6 years agoNPE in DCAI.runPasses() when the editor was not async loaded in time
Alexey Kudravtsev [Fri, 2 Sep 2016 11:26:37 +0000 (14:26 +0300)]
NPE in DCAI.runPasses() when the editor was not async loaded in time

6 years agoPY-20617 Don't show PEP 8 warnings in Python console
Mikhail Golubev [Fri, 2 Sep 2016 10:42:52 +0000 (13:42 +0300)]
PY-20617 Don't show PEP 8 warnings in Python console

Additionally, Pep8ExternalAnnotator was changed so that it doesn't run
if the corresponding inspection was suppressed for a file with one of
PythonVisitorFilters. Previosuly it worked only if the inspection
explicily run the annotator, e.g. when one used "Inspect code" action.

6 years agoIDEA-160707 Stream API migration: support object arrays phpstorm/163.3780
Tagir Valeev [Fri, 2 Sep 2016 10:50:00 +0000 (17:50 +0700)]
IDEA-160707 Stream API migration: support object arrays

6 years agoPass virtualenv variables to the python process (PY-15085)
Dmitry Trofimov [Fri, 2 Sep 2016 10:50:17 +0000 (12:50 +0200)]
Pass virtualenv variables to the python process (PY-15085)

6 years agoMerge remote-tracking branch 'origin/master' pycharm/163.3778
Dmitry Trofimov [Fri, 2 Sep 2016 10:37:38 +0000 (12:37 +0200)]
Merge remote-tracking branch 'origin/master'

6 years agoAdd terminal plugin dependency
Dmitry Trofimov [Fri, 2 Sep 2016 10:36:34 +0000 (12:36 +0200)]
Add terminal plugin dependency

6 years agoMerge branch 'uta/rainbow'
Alexey Utkin [Fri, 2 Sep 2016 09:28:57 +0000 (12:28 +0300)]
Merge branch 'uta/rainbow'

6 years agovcs: do not fail to create patch with mixed binary-text FileType
Aleksey Pivovarov [Fri, 2 Sep 2016 09:15:04 +0000 (12:15 +0300)]
vcs: do not fail to create patch with mixed binary-text FileType

6 years agovcs: extract class
Aleksey Pivovarov [Fri, 2 Sep 2016 09:12:43 +0000 (12:12 +0300)]
vcs: extract class

6 years agodiff: disable "Jump To Source" action if it can't be done
Aleksey Pivovarov [Fri, 2 Sep 2016 09:02:15 +0000 (12:02 +0300)]
diff: disable "Jump To Source" action if it can't be done

6 years agodiff: fix SOE on ctrl+click in unified viewer
Aleksey Pivovarov [Fri, 2 Sep 2016 08:59:30 +0000 (11:59 +0300)]
diff: fix SOE on ctrl+click in unified viewer

follow-up: ce738a9

6 years ago[updater] fixes FS case-sensitivity detection appcode/163.3773 clion/163.3774 idea/163.3775
Roman Shevchenko [Fri, 2 Sep 2016 08:49:13 +0000 (11:49 +0300)]
[updater] fixes FS case-sensitivity detection

6 years agoIDEA-158861 make tests green
Alexey Utkin [Fri, 2 Sep 2016 08:46:53 +0000 (11:46 +0300)]
IDEA-158861 make tests green

6 years agobuild scripts: allow products to disable building no-jdk.tar.gz artifact dbe/163.3838
nik [Fri, 2 Sep 2016 07:52:49 +0000 (10:52 +0300)]
build scripts: allow products to disable building no-jdk.tar.gz artifact

6 years agoIDEA-160693 Active windows could be not showing
Denis Fokin [Fri, 2 Sep 2016 07:42:19 +0000 (10:42 +0300)]
IDEA-160693 Active windows could be not showing

6 years agoinspection settings: IDEA-160655
Dmitry Batkovich [Fri, 2 Sep 2016 07:53:10 +0000 (10:53 +0300)]
inspection settings: IDEA-160655

6 years agoIDEA-160637 test fixed
Tagir Valeev [Fri, 2 Sep 2016 07:45:40 +0000 (14:45 +0700)]
IDEA-160637 test fixed

6 years agoIDEA-160637 Stream API migration: support map and flatMap steps
Tagir Valeev [Fri, 2 Sep 2016 07:40:40 +0000 (14:40 +0700)]
IDEA-160637 Stream API migration: support map and flatMap steps

6 years agoputIfAbsent & computeIfAbsent used; cosmetic fixes pycharm/163.3767 pycharm/163.3768 webstorm/163.3766
Tagir Valeev [Fri, 2 Sep 2016 03:13:40 +0000 (10:13 +0700)]
putIfAbsent & computeIfAbsent used; cosmetic fixes

6 years agoStreamApiMigrationInspection refactoring: getStatementOfClass extracted
Tagir Valeev [Thu, 1 Sep 2016 08:18:46 +0000 (15:18 +0700)]
StreamApiMigrationInspection refactoring: getStatementOfClass extracted

6 years agorename startIndex => index appcode/163.3763 clion/163.3759 dbe/163.3758 idea/163.3761 phpstorm/163.3762 pycharm/163.3756 rubymine/163.3764
Sergey Simonchik [Thu, 1 Sep 2016 23:33:44 +0000 (02:33 +0300)]
rename startIndex => index

6 years agoMerge remote-tracking branch 'origin/master' pycharm/163.3748 pycharm/163.3749
Dmitry Trofimov [Thu, 1 Sep 2016 23:18:38 +0000 (01:18 +0200)]
Merge remote-tracking branch 'origin/master'

6 years agoAdd python-terminal to the community modules list
Dmitry Trofimov [Thu, 1 Sep 2016 23:14:28 +0000 (01:14 +0200)]
Add python-terminal to the community modules list

6 years ago[hg] throw VcsException if hg log command has some error output
Julia Beliaeva [Fri, 5 Aug 2016 20:35:45 +0000 (23:35 +0300)]
[hg] throw VcsException if hg log command has some error output

6 years ago[hg] minor: lambdas, diamonds, reformat
Julia Beliaeva [Fri, 5 Aug 2016 18:14:16 +0000 (21:14 +0300)]
[hg] minor: lambdas, diamonds, reformat

6 years ago[hg] fix incorrect chunking of revision hash arguments for history command
Julia Beliaeva [Thu, 4 Aug 2016 18:20:09 +0000 (21:20 +0300)]
[hg] fix incorrect chunking of revision hash arguments for history command

For hg log command revisions are provided as a list of pairs "-r <revision>". So when spliting long command line arguments into chunks to execute the command on each of them separately "-r" should not be separated with its "<hash>".

6 years ago-l = another option for --login
Dmitry Trofimov [Thu, 1 Sep 2016 20:08:06 +0000 (22:08 +0200)]
-l = another option for --login

6 years agoImprove comments
Dmitry Trofimov [Thu, 1 Sep 2016 20:06:56 +0000 (22:06 +0200)]
Improve comments

6 years agoMerge remote-tracking branch 'origin/master'
Dmitry Trofimov [Thu, 1 Sep 2016 19:59:03 +0000 (21:59 +0200)]
Merge remote-tracking branch 'origin/master'

6 years agoAuto activate of virtualenv in terminal for projects with Python Virtualenv interpret...
Dmitry Trofimov [Thu, 1 Sep 2016 19:58:10 +0000 (21:58 +0200)]
Auto activate of virtualenv in terminal for projects with Python Virtualenv interpreters (PY-10498)