idea/community.git
5 years agoMerge remote-tracking branch 'origin/master'
Konstantin Bulenkov [Sat, 2 Jul 2016 17:49:57 +0000 (19:49 +0200)]
Merge remote-tracking branch 'origin/master'

5 years agoIDEA-86712 common api & error message handling
Kirill Likhodedov [Sat, 2 Jul 2016 16:21:33 +0000 (19:21 +0300)]
IDEA-86712 common api & error message handling

In addition to this, the original fix 9e0119d has error: it used to
display the error message in the same thread as test (not EDT) thus
leading to an assertion.

5 years agoIDEA-86712 provide error message of repository test failure
Kirill Likhodedov [Sat, 2 Jul 2016 15:59:56 +0000 (18:59 +0300)]
IDEA-86712 provide error message of repository test failure

5 years agoIDEA-155713 rephrase
Kirill Likhodedov [Sat, 2 Jul 2016 15:54:39 +0000 (18:54 +0300)]
IDEA-155713 rephrase

Avoid both path & directory in a single phrase.
Propose a solution instead of providing technical error details.

5 years agoIDEA-155714 git clone dialog: recheck directory on frame activation
Kirill Likhodedov [Sat, 2 Jul 2016 15:46:15 +0000 (18:46 +0300)]
IDEA-155714 git clone dialog: recheck directory on frame activation

if the user has selected a non-empty directory and received the error,
he possibly could go to the file manager and clean/remove the directory.

5 years agoIDEA-149027 Allow to clone into existing empty folder
Kirill Likhodedov [Sat, 2 Jul 2016 15:39:14 +0000 (18:39 +0300)]
IDEA-149027 Allow to clone into existing empty folder

5 years agoIDEA-135612 Git clone dialog: create parent dir automatically
Kirill Likhodedov [Sat, 2 Jul 2016 15:35:39 +0000 (18:35 +0300)]
IDEA-135612 Git clone dialog: create parent dir automatically

Warn only if it can't be created or is not writeable

5 years agoremove deprecated getContainer() appcode/163.880 appcode/163.887 clion/163.881 clion/163.888 phpstorm/163.884
Gregory.Shrago [Sat, 2 Jul 2016 07:33:54 +0000 (10:33 +0300)]
remove deprecated getContainer()

5 years agoIDEA-157667 Editor's scrollbar thumb: alpha and colors appcode/163.879 clion/163.869 dbe/163.870 idea/163.872 idea/163.873 phpstorm/163.871 pycharm/163.868 pycharm/163.877 rubymine/163.878 webstorm/163.874 webstorm/163.875
Dmitry Batkovich [Fri, 1 Jul 2016 18:07:04 +0000 (21:07 +0300)]
IDEA-157667 Editor's scrollbar thumb: alpha and colors
tune border alignment for Retina on Mac

5 years agoavoid unneeded clearing of text layout and size caches in editor
Dmitry Batrak [Fri, 1 Jul 2016 16:28:12 +0000 (19:28 +0300)]
avoid unneeded clearing of text layout and size caches in editor

5 years agoread action added; search for class names, not methods
Anna Kozlova [Fri, 1 Jul 2016 16:27:48 +0000 (19:27 +0300)]
read action added; search for class names, not methods

5 years agofix default getter template for boolean fields with meaningful starting 'is' (IDEA...
Anna Kozlova [Fri, 1 Jul 2016 16:22:08 +0000 (19:22 +0300)]
fix default getter template for boolean fields with meaningful starting 'is' (IDEA-148006)

5 years agocreate new file: allow unknown file type so empty file is created without open editor...
Anna Kozlova [Fri, 1 Jul 2016 15:45:08 +0000 (18:45 +0300)]
create new file: allow unknown file type so empty file is created without open editor (IDEA-156511)

5 years agoCCE (IDEA-157733)
Anna Kozlova [Fri, 1 Jul 2016 14:46:19 +0000 (17:46 +0300)]
CCE (IDEA-157733)

5 years ago[platform] logger severity reduced (EA-81103)
Roman Shevchenko [Fri, 1 Jul 2016 17:03:28 +0000 (20:03 +0300)]
[platform] logger severity reduced (EA-81103)

5 years agoIDEA-157667 Editor's scrollbar thumb: alpha and colors
Sergey Malenkov [Fri, 1 Jul 2016 16:39:51 +0000 (19:39 +0300)]
IDEA-157667 Editor's scrollbar thumb: alpha and colors
fix border alignment for Retina on Mac

5 years ago[java] diagnostics for missing JRT FS provider (EA-84606)
Roman Shevchenko [Fri, 1 Jul 2016 16:36:41 +0000 (19:36 +0300)]
[java] diagnostics for missing JRT FS provider (EA-84606)

5 years agoinspection toolwindow: html report: use custom colors for warning/error severities...
Dmitry Batkovich [Fri, 1 Jul 2016 16:22:46 +0000 (19:22 +0300)]
inspection toolwindow: html report: use custom colors for warning/error severities IDEA-157004

5 years ago[java] navigation around decompiled code (test updated)
Roman Shevchenko [Fri, 1 Jul 2016 16:20:26 +0000 (19:20 +0300)]
[java] navigation around decompiled code (test updated)

5 years agofix PIEAE compilation
peter [Fri, 1 Jul 2016 16:03:26 +0000 (18:03 +0200)]
fix PIEAE compilation

5 years agodon't queue "reindexRefreshedFiles" dumb mode task if it's already enqueued for this...
peter [Fri, 1 Jul 2016 16:01:04 +0000 (18:01 +0200)]
don't queue "reindexRefreshedFiles" dumb mode task if it's already enqueued for this project

5 years agoBetter message formatiing
Dmitry Trofimov [Thu, 30 Jun 2016 16:50:38 +0000 (18:50 +0200)]
Better message formatiing

5 years agoAdd flush to stderr write
Dmitry Trofimov [Thu, 30 Jun 2016 16:44:42 +0000 (18:44 +0200)]
Add flush to stderr write

5 years agoinspection toolwindow: escape mnemonics in fix buttons
Dmitry Batkovich [Fri, 1 Jul 2016 16:00:00 +0000 (19:00 +0300)]
inspection toolwindow: escape mnemonics in fix buttons

5 years agoAddMethodQualifierFix prevent IOOBE in getText()
Dmitry Batkovich [Fri, 1 Jul 2016 13:50:18 +0000 (16:50 +0300)]
AddMethodQualifierFix prevent IOOBE in getText()

5 years agoinspection toolwindow: restore selection after exclude/include IDEA-156675
Dmitry Batkovich [Fri, 1 Jul 2016 11:29:09 +0000 (14:29 +0300)]
inspection toolwindow: restore selection after exclude/include IDEA-156675

5 years agoWinProcessManager moved from util to platform to allow using Java 8 features
nik [Fri, 1 Jul 2016 16:00:33 +0000 (19:00 +0300)]
WinProcessManager moved from util to platform to allow using Java 8 features

5 years agocleanup
Vladimir Krivosheev [Fri, 1 Jul 2016 15:53:33 +0000 (17:53 +0200)]
cleanup

5 years agoreverted
Alexey Kudravtsev [Fri, 1 Jul 2016 15:53:09 +0000 (18:53 +0300)]
reverted

5 years agomore diagnostics
Alexey Kudravtsev [Fri, 1 Jul 2016 13:59:49 +0000 (16:59 +0300)]
more diagnostics

5 years ago[performance] Reimplement myKeyHashToVirtualFileMapping via AppendableStorageBackedBy...
Maxim.Mossienko [Fri, 1 Jul 2016 15:18:41 +0000 (17:18 +0200)]
[performance] Reimplement myKeyHashToVirtualFileMapping via AppendableStorageBackedByResizableMappedFile instead of PersistentBTreeEnumerator. Old implementation used AppendableStorageBackedByResizableMappedFile under the hood anyway but also guaranteed absence of the duplicates with significant overhead, however duplicates are not the problem.

5 years agobetter code after review
Maxim.Mossienko [Fri, 1 Jul 2016 15:07:51 +0000 (17:07 +0200)]
better code after review

5 years agoUsability: Find in Path -- NOT in Whole project (IDEA-87037)
Maxim.Mossienko [Fri, 1 Jul 2016 14:23:41 +0000 (16:23 +0200)]
Usability: Find in Path -- NOT in Whole project (IDEA-87037)

5 years ago[groovy] get public class from source if possible (IDEA-154252)
Daniil Ovchinnikov [Fri, 1 Jul 2016 14:26:40 +0000 (17:26 +0300)]
[groovy] get public class from source if possible (IDEA-154252)

5 years ago[shelf]: refresh VF content of patchFile before apply; cleanUp
Nadya Zabrodina [Fri, 1 Jul 2016 14:08:26 +0000 (17:08 +0300)]
[shelf]: refresh VF content of patchFile before apply; cleanUp

5 years agoPsiInvalidElementAccessException: prevent creation SOE (EA-84774), construct from...
peter [Fri, 1 Jul 2016 12:53:50 +0000 (14:53 +0200)]
PsiInvalidElementAccessException: prevent creation SOE (EA-84774), construct from an ASTNode

5 years agoFIXED WEB-428 php tags in className - broken breadcrumbs.
Rustam Vishnyakov [Fri, 1 Jul 2016 14:37:56 +0000 (17:37 +0300)]
FIXED WEB-428 php tags in className - broken breadcrumbs.

5 years agoCPP-778 Support for semantic per-variable highlighting (visitor fixes)
Alexey Utkin [Fri, 1 Jul 2016 14:20:39 +0000 (17:20 +0300)]
CPP-778 Support for semantic per-variable highlighting (visitor fixes)

5 years agoCPP-778 Support for semantic per-variable highlighting (HighlightVisitor approach...
Alexey Utkin [Fri, 1 Jul 2016 12:22:08 +0000 (15:22 +0300)]
CPP-778 Support for semantic per-variable highlighting (HighlightVisitor approach was applied)

5 years agonavigation: don't show notification that nothing was found after cancel of the modal...
Anna Kozlova [Fri, 1 Jul 2016 11:50:24 +0000 (14:50 +0300)]
navigation: don't show notification that nothing was found after cancel of the modal progress (IDEA-157671)

5 years agoIDEA-157963 Editor search leak when closing the editor
Dmitry Batrak [Fri, 1 Jul 2016 13:57:47 +0000 (16:57 +0300)]
IDEA-157963 Editor search leak when closing the editor

5 years ago[platform] safe write tracing (IDEA-156742)
Roman Shevchenko [Fri, 1 Jul 2016 13:48:07 +0000 (16:48 +0300)]
[platform] safe write tracing (IDEA-156742)

5 years agoPromise.cancel() API instead of low-level OBSOLETE_ERROR
Vladimir Krivosheev [Fri, 1 Jul 2016 13:26:17 +0000 (15:26 +0200)]
Promise.cancel() API instead of low-level OBSOLETE_ERROR

5 years agoIDEA-CR-11983 simplify code
Vladimir Krivosheev [Fri, 1 Jul 2016 13:11:22 +0000 (15:11 +0200)]
IDEA-CR-11983 simplify code

5 years agoJava intention: Quick fix for error "foreach not applicable to type java.util.Iterato... rubymine/163.849
Pavel Dolgov [Fri, 1 Jul 2016 13:27:28 +0000 (16:27 +0300)]
Java intention: Quick fix for error "foreach not applicable to type java.util.Iterator" - a test added (IDEA-124751)

5 years agofix test (failing after commit 6f7d1a6)
Dmitry Batrak [Fri, 1 Jul 2016 13:17:26 +0000 (16:17 +0300)]
fix test (failing after commit 6f7d1a6)

runInDispatchThread wasn't invoked previously here

5 years agoJava intention: Quick fix for error "foreach not applicable to type java.util.Iterato...
Pavel Dolgov [Fri, 1 Jul 2016 13:06:13 +0000 (16:06 +0300)]
Java intention: Quick fix for error "foreach not applicable to type java.util.Iterator" (IDEA-124751)

5 years agoJava inspection: Removed AddOverrideAnnotationAction, because MissingOverrideAnnotati...
Pavel Dolgov [Thu, 30 Jun 2016 11:55:06 +0000 (14:55 +0300)]
Java inspection: Removed AddOverrideAnnotationAction, because MissingOverrideAnnotationInspection does the same thing (and a bit more). Enable MissingOverrideAnnotationInspection by default at INFORMATION level. (IDEA-157727)

5 years agoreset accidentally changed upper limit on 64 bit system for ByteBuffers
Maxim.Mossienko [Fri, 1 Jul 2016 10:34:16 +0000 (12:34 +0200)]
reset accidentally changed upper limit on 64 bit system for ByteBuffers
(cherry picked from commit d06b1c0)

5 years agoIDEA-CR-11785 Allow getting file info from FileIndex for injected files
Ivan Bessonov [Fri, 1 Jul 2016 13:06:25 +0000 (16:06 +0300)]
IDEA-CR-11785 Allow getting file info from FileIndex for injected files

5 years agoincrement PSI modification counter on file reparse to make sure elements wouldn't...
Alexey Kudravtsev [Fri, 1 Jul 2016 12:52:11 +0000 (15:52 +0300)]
increment PSI modification counter on file reparse to make sure elements wouldn't be invalid inexpectedly (e.g. during folding) EA-84255 - PIEAE: LeafPsiElement.a

5 years agogive app scheduler a name for debug
Alexey Kudravtsev [Thu, 30 Jun 2016 12:51:41 +0000 (15:51 +0300)]
give app scheduler a name for debug

5 years agocleanup
Alexey Kudravtsev [Thu, 30 Jun 2016 12:08:07 +0000 (15:08 +0300)]
cleanup

5 years agoCleanup (formatting)
Roman Shevchenko [Fri, 1 Jul 2016 12:47:38 +0000 (15:47 +0300)]
Cleanup (formatting)

5 years ago[java] navigation around decompiled code
Roman Shevchenko [Fri, 1 Jul 2016 12:43:15 +0000 (15:43 +0300)]
[java] navigation around decompiled code

Fixes IDEA-157772; reduces the number of cases where PsiCompiledFile check is necessary.

5 years agoRUBY-18140 Markdown setting plugin: Unable to save settings Popup
Vladimir Krivosheev [Fri, 1 Jul 2016 12:38:34 +0000 (14:38 +0200)]
RUBY-18140 Markdown setting plugin: Unable to save settings Popup

Include component name into the error message

5 years agoadd proper warning to the error panel pycharm/163.847
Ekaterina Tuzova [Fri, 1 Jul 2016 12:29:07 +0000 (15:29 +0300)]
add proper warning to the error panel

5 years agoEDU-613 Desktop shortcut is not created. Cleanup.
Vladimir.Orlov [Fri, 1 Jul 2016 12:14:26 +0000 (15:14 +0300)]
EDU-613 Desktop shortcut is not created. Cleanup.

5 years agoMerge remote-tracking branch 'origin/master'
Vladimir.Orlov [Fri, 1 Jul 2016 12:11:07 +0000 (15:11 +0300)]
Merge remote-tracking branch 'origin/master'

5 years agoEDU-613 Desktop shortcut is not created. Cleanup.
Vladimir.Orlov [Fri, 1 Jul 2016 12:07:32 +0000 (15:07 +0300)]
EDU-613 Desktop shortcut is not created. Cleanup.

5 years agoLogging improved to track why can't we rerun tests clion/163.846
Ilya.Kazakevich [Fri, 1 Jul 2016 11:56:49 +0000 (14:56 +0300)]
Logging improved to track why can't we rerun tests

5 years ago[Recent Tests] add statistics
Yaroslav Lepenkin [Fri, 1 Jul 2016 11:49:24 +0000 (14:49 +0300)]
[Recent Tests] add statistics

5 years agoExceptions in collecting call signatures shouldn't break debugger (PY-19650) pycharm/163.844
Elizaveta Shashkova [Fri, 1 Jul 2016 11:45:55 +0000 (14:45 +0300)]
Exceptions in collecting call signatures shouldn't break debugger (PY-19650)

5 years agoIDEA-157555 Modal dialogs are shown twice
Sergey Malenkov [Fri, 1 Jul 2016 09:50:28 +0000 (12:50 +0300)]
IDEA-157555 Modal dialogs are shown twice
improve logging

5 years agoMerge remote-tracking branch 'origin/master' phpstorm/163.839 pycharm/163.842
Vladimir.Orlov [Fri, 1 Jul 2016 11:09:17 +0000 (14:09 +0300)]
Merge remote-tracking branch 'origin/master'

5 years agoEDU-613 Desktop shortcut is not created
Vladimir.Orlov [Fri, 1 Jul 2016 11:06:24 +0000 (14:06 +0300)]
EDU-613 Desktop shortcut is not created

5 years agoPromise.cancel() API instead of low-level OBSOLETE_ERROR
Vladimir Krivosheev [Fri, 1 Jul 2016 10:33:15 +0000 (12:33 +0200)]
Promise.cancel() API instead of low-level OBSOLETE_ERROR

5 years agoAsyncPromise — cleanup
Vladimir Krivosheev [Fri, 1 Jul 2016 09:16:31 +0000 (11:16 +0200)]
AsyncPromise — cleanup

5 years agoconvert RejectErrorReporter, AsyncPromise to kotlin
Vladimir Krivosheev [Fri, 1 Jul 2016 09:11:26 +0000 (11:11 +0200)]
convert RejectErrorReporter, AsyncPromise to kotlin

5 years agoconvert RejectErrorReporter, AsyncPromise to kotlin
Vladimir Krivosheev [Fri, 1 Jul 2016 09:10:58 +0000 (11:10 +0200)]
convert RejectErrorReporter, AsyncPromise to kotlin

5 years agocleanup
Vladimir Krivosheev [Wed, 29 Jun 2016 15:23:11 +0000 (17:23 +0200)]
cleanup

5 years agomove Promise to platform-api
Vladimir Krivosheev [Wed, 29 Jun 2016 15:12:39 +0000 (17:12 +0200)]
move Promise to platform-api

5 years agoconvert Promise.any to kt
Vladimir Krivosheev [Wed, 29 Jun 2016 15:03:02 +0000 (17:03 +0200)]
convert Promise.any to kt

5 years agorun inspection by name: inspection options: remove profile chooser and copy options...
Dmitry Batkovich [Fri, 1 Jul 2016 10:56:37 +0000 (13:56 +0300)]
run inspection by name: inspection options: remove profile chooser and copy options from current profile

5 years ago[fixed failing test: formatOptimizeRearrangeVcsChanges] fixed test data, since diff...
Yaroslav Lepenkin [Fri, 1 Jul 2016 10:46:45 +0000 (13:46 +0300)]
[fixed failing test: formatOptimizeRearrangeVcsChanges] fixed test data, since diff now shows one more line

5 years agosimplify guided traversal API
Gregory.Shrago [Fri, 1 Jul 2016 10:26:45 +0000 (13:26 +0300)]
simplify guided traversal API

5 years agoWEB-21106 Cannot change numeric value of Javascript property when stopped in debugger
Konstantin Ulitin [Fri, 1 Jul 2016 10:24:45 +0000 (13:24 +0300)]
WEB-21106 Cannot change numeric value of Javascript property when stopped in debugger

5 years agodisable assertion in tests
Dmitry Batrak [Fri, 1 Jul 2016 10:08:07 +0000 (13:08 +0300)]
disable assertion in tests

due to HtmlHighlightingTest tests failing (external links validation via external annotator is performed in EDT in tests, see ExternalToolPassFactory)

5 years agoreplace PlatformTestCase.isRunInEdt() with UsefulTestCase.runInDispatchThread(),...
Dmitry Batrak [Fri, 1 Jul 2016 09:23:37 +0000 (12:23 +0300)]
replace PlatformTestCase.isRunInEdt() with UsefulTestCase.runInDispatchThread(), there's no reason to keep both

5 years agomake stack shorter & reduce garbage
Gregory.Shrago [Fri, 1 Jul 2016 09:49:51 +0000 (12:49 +0300)]
make stack shorter & reduce garbage

5 years agoSuppressions: do not show host-suppressions available in injections only
Alexander Zolotov [Fri, 1 Jul 2016 09:36:51 +0000 (12:36 +0300)]
Suppressions: do not show host-suppressions available in injections only

5 years agoReuse production code for retrieving available intentions and their
Alexander Zolotov [Fri, 1 Jul 2016 09:34:47 +0000 (12:34 +0300)]
Reuse production code for retrieving available intentions and their
sub-actions in tests

5 years agounchecked cast warning: missed captured wildcards (IDEA-158080); reifiable captured...
Anna Kozlova [Fri, 1 Jul 2016 09:24:06 +0000 (12:24 +0300)]
unchecked cast warning: missed captured wildcards (IDEA-158080); reifiable captured wildcard type

5 years agothis and super are not available inside anonymous class args
Anna Kozlova [Fri, 1 Jul 2016 09:01:48 +0000 (12:01 +0300)]
this and super are not available inside anonymous class args

5 years agoproperties: resolve property reference do not ignore pom target elements with XmlProperty
Dmitry Batkovich [Fri, 1 Jul 2016 09:39:20 +0000 (12:39 +0300)]
properties: resolve property reference do not ignore pom target elements with XmlProperty

5 years agosearch for > position
Dennis Ushakov [Fri, 1 Jul 2016 09:30:32 +0000 (12:30 +0300)]
search for > position

5 years agousages view: regression: exclude/include action must be available only on UsagesNode...
Dmitry Batkovich [Fri, 1 Jul 2016 09:00:43 +0000 (12:00 +0300)]
usages view: regression: exclude/include action must be available only on UsagesNode-s and don't produce class cast exceptions IDEA-157266

5 years agoproperties: check that element is property before doing a resolve IDEA-158028
Dmitry Batkovich [Fri, 1 Jul 2016 08:34:19 +0000 (11:34 +0300)]
properties: check that element is property before doing a resolve IDEA-158028

5 years agofix test appcode/163.834 clion/163.835
Bas Leijdekkers [Fri, 1 Jul 2016 08:20:24 +0000 (10:20 +0200)]
fix test

5 years ago[formatter] moved from java-impl to core, extra ranges calculation now works for...
Yaroslav Lepenkin [Fri, 1 Jul 2016 08:11:09 +0000 (11:11 +0300)]
[formatter] moved from java-impl to core, extra ranges calculation now works for every language

5 years agochange signature: restore explicit check for used parameters
Anna Kozlova [Fri, 1 Jul 2016 08:04:51 +0000 (11:04 +0300)]
change signature: restore explicit check for used parameters

5 years agoremove unused (wrong named) EP declaration
Anna Kozlova [Fri, 1 Jul 2016 08:02:40 +0000 (11:02 +0300)]
remove unused (wrong named) EP declaration

5 years agotemp disable conflict check to fix tests
Anna Kozlova [Fri, 1 Jul 2016 07:42:04 +0000 (10:42 +0300)]
temp disable conflict check to fix tests

5 years agofix index initialization issues in python tests?
peter [Fri, 1 Jul 2016 07:15:47 +0000 (09:15 +0200)]
fix index initialization issues in python tests?

5 years agoless info logging when running test appcode/163.824 clion/163.821 dbe/163.822 idea/163.823 phpstorm/163.825 pycharm/163.830 pycharm/163.833 rubymine/163.832 webstorm/163.827 webstorm/163.828
Maxim.Mossienko [Thu, 30 Jun 2016 22:37:35 +0000 (00:37 +0200)]
less info logging when running test

5 years agobetter diagnostic of ioexception when FileOutputStream constructor throws FileNotFoun...
Maxim.Mossienko [Thu, 30 Jun 2016 22:36:50 +0000 (00:36 +0200)]
better diagnostic of ioexception when FileOutputStream constructor throws FileNotFoundException

5 years agoPY-19136: Filter out nulls to prevent NPE
Ilya.Kazakevich [Thu, 30 Jun 2016 22:31:43 +0000 (01:31 +0300)]
PY-19136: Filter out nulls to prevent NPE

5 years agoPY-19136: Returning null leads to NPE because #ensureValid is @NotNull
Ilya.Kazakevich [Thu, 30 Jun 2016 22:18:09 +0000 (01:18 +0300)]
PY-19136: Returning null leads to NPE because #ensureValid is @NotNull

5 years agoPY-19137: Move object to parent in superclass extracting even for Py3K if class expli...
Ilya.Kazakevich [Thu, 30 Jun 2016 21:55:37 +0000 (00:55 +0300)]
PY-19137: Move object to parent in superclass extracting even for Py3K if class explicitly extends object

5 years agoPY-19015: fix for "rerun" for failed tox tests
Ilya.Kazakevich [Thu, 30 Jun 2016 20:28:59 +0000 (23:28 +0300)]
PY-19015: fix for "rerun" for failed tox tests

Tox fetches env id (like py27) and provides it to configuration.