idea/community.git
4 years agosearch for tests in directory restored for down-up approach
Anna.Kozlova [Thu, 8 Feb 2018 12:43:44 +0000 (13:43 +0100)]
search for tests in directory restored for down-up approach

extended scope to ensure that the directory itself is included for new search

4 years agorevert final fields for our serialization
Anna.Kozlova [Thu, 8 Feb 2018 12:17:37 +0000 (13:17 +0100)]
revert final fields for our serialization

4 years agointroduce variable: accept tailing dots (IDEA-186331)
Anna.Kozlova [Thu, 8 Feb 2018 10:44:14 +0000 (11:44 +0100)]
introduce variable: accept tailing dots (IDEA-186331)

4 years agopush down/inline superclass: don't change foreign inheritors (IDEA-186323)
Anna.Kozlova [Thu, 8 Feb 2018 10:16:03 +0000 (11:16 +0100)]
push down/inline superclass: don't change foreign inheritors (IDEA-186323)

4 years agoAllow null argument in PyReferenceImpl.isInOwnScopeComprehension (EA-115933)
Semyon Proshev [Thu, 8 Feb 2018 13:01:49 +0000 (16:01 +0300)]
Allow null argument in PyReferenceImpl.isInOwnScopeComprehension (EA-115933)

4 years agocleanup
Alexey Kudravtsev [Thu, 8 Feb 2018 12:52:56 +0000 (15:52 +0300)]
cleanup

4 years agofixed finishPsiModification never called sometimes
Alexey Kudravtsev [Wed, 7 Feb 2018 15:48:28 +0000 (18:48 +0300)]
fixed finishPsiModification never called sometimes

4 years agomore interruptibility in method call hierarchy
Alexey Kudravtsev [Wed, 7 Feb 2018 15:47:38 +0000 (18:47 +0300)]
more interruptibility in method call hierarchy

4 years agorenamed async annotation (IDEA-CR-19020)
Egor Ushakov [Thu, 8 Feb 2018 12:52:35 +0000 (15:52 +0300)]
renamed async annotation (IDEA-CR-19020)

4 years agoIconCache class is missing
Kirill Kirichenko [Thu, 8 Feb 2018 12:28:45 +0000 (15:28 +0300)]
IconCache class is missing

4 years agoMove and rename MacIntelliJIconCache to IconCache
Kirill Kirichenko [Thu, 8 Feb 2018 12:08:23 +0000 (15:08 +0300)]
Move and rename MacIntelliJIconCache to IconCache

4 years agouse min time when benchmarking performance test agents, not average
peter [Thu, 8 Feb 2018 12:10:54 +0000 (13:10 +0100)]
use min time when benchmarking performance test agents, not average

for more stability
as this results in lower timings, some test expectations are updated

4 years agoavoid smart pointer leaks after project closing by not storing them in VFS user data...
peter [Thu, 8 Feb 2018 12:06:14 +0000 (13:06 +0100)]
avoid smart pointer leaks after project closing by not storing them in VFS user data at all

4 years agoIDEA-186293 Smart completion fails when invoked in context of call of inaccessible...
peter [Thu, 8 Feb 2018 11:54:19 +0000 (12:54 +0100)]
IDEA-186293 Smart completion fails when invoked in context of call of inaccessible method

4 years agoWorkaround "JRE-650 AA rendering into BufferedImage differs b/w displays" appcode/181.3623 clion/181.3620 phpstorm/181.3621
Anton Tarasov [Thu, 8 Feb 2018 11:50:08 +0000 (14:50 +0300)]
Workaround "JRE-650 AA rendering into BufferedImage differs b/w displays"

4 years agoRevert FileStructurePopup checkboxes layout. Added horizontal gap. phpstorm/181.3617 phpstorm/181.3618 phpstorm/181.3619
Kirill Kirichenko [Thu, 8 Feb 2018 10:45:11 +0000 (13:45 +0300)]
Revert FileStructurePopup checkboxes layout. Added horizontal gap.

4 years agoLet InternalDecorator to decide when to activate an editor
Denis Fokin [Thu, 8 Feb 2018 10:04:52 +0000 (13:04 +0300)]
Let InternalDecorator to decide when to activate an editor

4 years agoIDEA-186054 Caret is reset to position (1,1) on editor drag-out phpstorm/181.3615
Dmitry Batrak [Thu, 8 Feb 2018 09:12:51 +0000 (12:12 +0300)]
IDEA-186054 Caret is reset to position (1,1) on editor drag-out

4 years agorename Extract Class Dialog -> Extract Delegate
Anna.Kozlova [Thu, 8 Feb 2018 08:18:52 +0000 (09:18 +0100)]
rename Extract Class Dialog -> Extract Delegate

4 years agobuild scripts: PyCharm EDU, eap=true pycharm/181.3613
Vladimir.Orlov [Thu, 8 Feb 2018 09:03:23 +0000 (12:03 +0300)]
build scripts: PyCharm EDU, eap=true

4 years agoflowAssert: expected testdata fixed after bf640e78a9 appcode/181.3612 clion/181.3610 phpstorm/181.3611
Tagir Valeev [Thu, 8 Feb 2018 08:47:23 +0000 (15:47 +0700)]
flowAssert: expected testdata fixed after bf640e78a9

4 years agoFieldMayBeFinal: reused control flow and highlighting methods; DefiniteAssignment... phpstorm/181.3607
Tagir Valeev [Thu, 8 Feb 2018 06:51:22 +0000 (13:51 +0700)]
FieldMayBeFinal: reused control flow and highlighting methods; DefiniteAssignment becomes unnecessary

4 years agoControlFlowUtil#isVariableAssignedInLoop: evaluate constant conditions
Tagir Valeev [Thu, 8 Feb 2018 06:29:49 +0000 (13:29 +0700)]
ControlFlowUtil#isVariableAssignedInLoop: evaluate constant conditions

Fixes IDEA-186306 good code red: variable might be assigned in loop

4 years agoEffectiveFinal tests reported in IDEA-154224, IDEA-163280, IDEA-171790
Tagir Valeev [Thu, 8 Feb 2018 06:21:31 +0000 (13:21 +0700)]
EffectiveFinal tests reported in IDEA-154224, IDEA-163280, IDEA-171790

4 years agoFinalVariableMightNotHaveBeenInitializedInsideLambda: added separate initializer...
Tagir Valeev [Thu, 8 Feb 2018 05:31:34 +0000 (12:31 +0700)]
FinalVariableMightNotHaveBeenInitializedInsideLambda: added separate initializer test

4 years agoControlFlowAnalyzer: fix control flow for assert (IDEA-186305) idea/181.3606 phpstorm/181.3600 phpstorm/181.3601 pycharm/181.3598 pycharm/181.3599
Tagir Valeev [Thu, 8 Feb 2018 04:54:49 +0000 (11:54 +0700)]
ControlFlowAnalyzer: fix control flow for assert (IDEA-186305)

4 years agoControlFlowUtil: warnings and typos fixed
Tagir Valeev [Wed, 7 Feb 2018 09:54:12 +0000 (16:54 +0700)]
ControlFlowUtil: warnings and typos fixed

4 years agoMerge remote-tracking branch 'origin/master' clion/181.3590 dbe/181.3594 phpstorm/181.3593 phpstorm/181.3597 pycharm/181.3591 pycharm/181.3592 rubymine/181.3596 webstorm/181.3589
Vladimir.Orlov [Thu, 8 Feb 2018 03:23:49 +0000 (06:23 +0300)]
Merge remote-tracking branch 'origin/master'

4 years agoDjango tests moved to JUnit4 appcode/181.3587 clion/181.3584 dbe/181.3585 idea/181.3580 phpstorm/181.3579 phpstorm/181.3581 pycharm/181.3582 pycharm/181.3586 rubymine/181.3583
Ilya.Kazakevich [Wed, 7 Feb 2018 22:47:43 +0000 (01:47 +0300)]
Django tests moved to JUnit4

To use Assume we need to be JUnit4 based, so DjangoTestCase does not inherit TestCase anymore

4 years agoleaked test moved to staging
Ilya.Kazakevich [Wed, 7 Feb 2018 22:24:07 +0000 (01:24 +0300)]
leaked test moved to staging

4 years agoremove unused TaskInfo.getProcessId phpstorm/181.3577 phpstorm/181.3578
peter [Wed, 7 Feb 2018 20:32:01 +0000 (21:32 +0100)]
remove unused TaskInfo.getProcessId

4 years agoFind tool window: split 'show preview' setting to two for find/replace
Vassiliy.Kudryashov [Wed, 7 Feb 2018 20:24:41 +0000 (23:24 +0300)]
Find tool window: split 'show preview' setting to two for find/replace

4 years agoDon't inherit PYTHONPATH if parent envs disabled (PY-19218) phpstorm/181.3576
Dmitry Trofimov [Wed, 7 Feb 2018 18:55:46 +0000 (19:55 +0100)]
Don't inherit PYTHONPATH if parent envs disabled (PY-19218)

4 years agoSpellchecker: WI-40621 quick-fix order is counter-productive phpstorm/181.3575
Olga Strizhenko [Wed, 7 Feb 2018 19:08:37 +0000 (22:08 +0300)]
Spellchecker: WI-40621 quick-fix order is counter-productive

4 years agofix GroovyCompilerTest, add a test for failing single file recompilation phpstorm/181.3574
peter [Wed, 7 Feb 2018 18:51:44 +0000 (19:51 +0100)]
fix GroovyCompilerTest, add a test for failing single file recompilation

4 years ago[yaml] new extension point for structure view customization
Sergey.Anchipolevsky [Wed, 7 Feb 2018 18:36:52 +0000 (21:36 +0300)]
[yaml] new extension point for structure view customization

4 years agoproject configuration: improve automatic grouping by module names
nik [Wed, 7 Feb 2018 18:37:57 +0000 (19:37 +0100)]
project configuration: improve automatic grouping by module names

Don't split qualified name by dots in places where it leads to incorrect identifiers (e.g. after digits) to avoid creating unnecessary groups for modules which names include version numbers (IDEA-180295).

4 years agorefactor: move ModuleGrouper's implementations to '.impl' module
nik [Wed, 7 Feb 2018 17:09:05 +0000 (18:09 +0100)]
refactor: move ModuleGrouper's implementations to '.impl' module

4 years agoReduce unstubbing while processing instance level declarations (PY-27863)
Semyon Proshev [Tue, 6 Feb 2018 18:44:44 +0000 (21:44 +0300)]
Reduce unstubbing while processing instance level declarations (PY-27863)

Stub->AST switch happened when passed location was inside unstubbed file.

4 years agoIDEA-186334 Show class javadoc-level for .class completion
peter [Wed, 7 Feb 2018 17:39:12 +0000 (18:39 +0100)]
IDEA-186334 Show class javadoc-level for .class completion

4 years agoreturn ShortenCommandLine from ShortenCommandLineModeCombo#getSelectedItem
Daniil Ovchinnikov [Wed, 7 Feb 2018 18:02:06 +0000 (21:02 +0300)]
return ShortenCommandLine from ShortenCommandLineModeCombo#getSelectedItem

4 years ago[java] highlights illegal modifiers in 'requires java.base' (IDEA-184708)
Roman Shevchenko [Wed, 7 Feb 2018 18:04:03 +0000 (19:04 +0100)]
[java] highlights illegal modifiers in 'requires java.base' (IDEA-184708)

4 years ago[test framework] annotates light project descriptor constants
Roman Shevchenko [Wed, 7 Feb 2018 17:47:16 +0000 (18:47 +0100)]
[test framework] annotates light project descriptor constants

... to prevent an alternatively intellectual plugin from complaining about platform types

4 years agoCleanup (formatting)
Roman Shevchenko [Wed, 7 Feb 2018 17:43:37 +0000 (18:43 +0100)]
Cleanup (formatting)

4 years agoupdate api usage (IDEA-CR-28325)
Anna.Kozlova [Wed, 7 Feb 2018 17:33:23 +0000 (18:33 +0100)]
update api usage (IDEA-CR-28325)

4 years agopreselect superclass name chosen previously (IDEA-179774)
Uria Ashkenazy Adler [Wed, 7 Feb 2018 17:26:03 +0000 (18:26 +0100)]
preselect superclass name chosen previously (IDEA-179774)

4 years agoinherit with different parameterization: fix for raw types (IDEA-186271)
Anna.Kozlova [Wed, 7 Feb 2018 17:23:02 +0000 (18:23 +0100)]
inherit with different parameterization: fix for raw types (IDEA-186271)

4 years agogenerate equals: skip equals generated in the same class (IDEA-170746)
Anna.Kozlova [Wed, 7 Feb 2018 13:56:49 +0000 (14:56 +0100)]
generate equals: skip equals generated in the same class (IDEA-170746)

4 years ago[groovy] console: always add new line after execution (IDEA-186243)
Daniil Ovchinnikov [Wed, 7 Feb 2018 17:31:45 +0000 (20:31 +0300)]
[groovy] console: always add new line after execution (IDEA-186243)

4 years ago[groovy] rename console.txt to console.groovy
Daniil Ovchinnikov [Wed, 7 Feb 2018 17:08:55 +0000 (20:08 +0300)]
[groovy] rename console.txt to console.groovy

4 years agolst: fix tests - sync changes with CLM
Aleksey Pivovarov [Wed, 7 Feb 2018 17:25:41 +0000 (20:25 +0300)]
lst: fix tests - sync changes with CLM

follow-up: 02793483964f076c4c39abb7681fc3997bbdf3b6

4 years agoIDEA-186347 Update embedded consent options and related text
Eugene Zhuravlev [Wed, 7 Feb 2018 17:22:55 +0000 (18:22 +0100)]
IDEA-186347 Update embedded consent options and related text

4 years agofix occasional case when changelist wasn't auto-removed after everything inside was...
peter [Wed, 7 Feb 2018 17:23:59 +0000 (18:23 +0100)]
fix occasional case when changelist wasn't auto-removed after everything inside was reverted

4 years agomore daemon reactivity during contract inference
peter [Wed, 7 Feb 2018 17:11:56 +0000 (18:11 +0100)]
more daemon reactivity during contract inference

4 years agodfa: reflect the new field checking behavior in the UI (IDEA-121405)
peter [Wed, 7 Feb 2018 16:48:14 +0000 (17:48 +0100)]
dfa: reflect the new field checking behavior in the UI (IDEA-121405)

4 years agoalways return canonical text from PsiTypeResult
Daniil Ovchinnikov [Wed, 7 Feb 2018 16:42:40 +0000 (19:42 +0300)]
always return canonical text from PsiTypeResult

4 years agofix DummyHolder copying and stubbed PSI mark/release after copying
peter [Wed, 7 Feb 2018 16:41:30 +0000 (17:41 +0100)]
fix DummyHolder copying and stubbed PSI mark/release after copying

fixes LambdaToAnonymousTransformTest

4 years agoIDEA-121405 Report nullable values assigned to non-annotated fields
peter [Wed, 7 Feb 2018 16:38:01 +0000 (17:38 +0100)]
IDEA-121405 Report nullable values assigned to non-annotated fields

4 years agostatus bar: pause progress icon only if all progresses are paused, not any
peter [Wed, 7 Feb 2018 14:56:14 +0000 (15:56 +0100)]
status bar: pause progress icon only if all progresses are paused, not any

4 years agoPY-28170 Warn about admin permissions for installing packages and suggest creating... webstorm/181.3573
Andrey Vlasovskikh [Wed, 7 Feb 2018 16:33:10 +0000 (19:33 +0300)]
PY-28170 Warn about admin permissions for installing packages and suggest creating virtualenvs

4 years agoIDEA-185688 Groovy association item is not displayed correctly
Vladimir.Orlov [Wed, 7 Feb 2018 16:22:34 +0000 (19:22 +0300)]
IDEA-185688 Groovy association item is not displayed correctly

4 years agoinfo message for situations when full chunk rebuild is requested by a builder
Eugene Zhuravlev [Wed, 7 Feb 2018 16:07:14 +0000 (17:07 +0100)]
info message for situations when full chunk rebuild is requested by a builder

4 years ago[groovy] show parameter hints for unary numeric expressions (IDEA-186292)
Daniil Ovchinnikov [Wed, 7 Feb 2018 16:10:13 +0000 (19:10 +0300)]
[groovy] show parameter hints for unary numeric expressions (IDEA-186292)

4 years agolst: use link with dropdown instead of "Move to ChangeList" action
Aleksey Pivovarov [Wed, 7 Feb 2018 15:14:19 +0000 (18:14 +0300)]
lst: use link with dropdown instead of "Move to ChangeList" action

4 years agoAdd test to reproduce EA-1732880
Vitaliy.Bibaev [Wed, 7 Feb 2018 15:22:22 +0000 (18:22 +0300)]
Add test to reproduce EA-1732880

4 years agoIDEA-177411 - report statistics (IDEA-CR-29056) appcode/181.3571 clion/181.3568
Egor Ushakov [Wed, 7 Feb 2018 14:51:54 +0000 (17:51 +0300)]
IDEA-177411 - report statistics (IDEA-CR-29056)

4 years agofix typo in dfa warning text
peter [Wed, 7 Feb 2018 14:49:02 +0000 (15:49 +0100)]
fix typo in dfa warning text

4 years agoIG: fix field may be final after return inside lambda (IDEA-186267)
Bas Leijdekkers [Wed, 7 Feb 2018 14:44:45 +0000 (15:44 +0100)]
IG: fix field may be final after return inside lambda (IDEA-186267)

4 years agolst: forbid moving ranges to non-existent changelists
Aleksey Pivovarov [Wed, 7 Feb 2018 14:18:44 +0000 (17:18 +0300)]
lst: forbid moving ranges to non-existent changelists

4 years agodiff: do not ask for target changelist for skipped changes - use active
Aleksey Pivovarov [Wed, 7 Feb 2018 12:53:59 +0000 (15:53 +0300)]
diff: do not ask for target changelist for skipped changes - use active

4 years agodiff: show current changelist name in content title
Aleksey Pivovarov [Wed, 7 Feb 2018 12:18:52 +0000 (15:18 +0300)]
diff: show current changelist name in content title

4 years agoremove test bomb phpstorm/181.3565
Daniil Ovchinnikov [Wed, 7 Feb 2018 14:18:53 +0000 (17:18 +0300)]
remove test bomb

4 years agoInsert space between checkboxes in Rename dialog
Kirill Kirichenko [Wed, 7 Feb 2018 13:47:37 +0000 (16:47 +0300)]
Insert space between checkboxes in Rename dialog

4 years agoIDEA-186238 Object.getClass() is twice as pure than anything - better fix...
Egor Ushakov [Wed, 7 Feb 2018 13:34:07 +0000 (16:34 +0300)]
IDEA-186238 Object.getClass() is twice as pure than anything - better fix...

4 years agodon't change attributes if there's no element (IDEA-186322) idea/181.3563
Dennis Ushakov [Wed, 7 Feb 2018 13:12:14 +0000 (16:12 +0300)]
don't change attributes if there's no element (IDEA-186322)

4 years agoFix DarculaPasswordFieldUI insets and painting
Kirill Kirichenko [Wed, 7 Feb 2018 13:21:28 +0000 (16:21 +0300)]
Fix DarculaPasswordFieldUI insets and painting

4 years agoupdate deps of ij-rpc-client
Vladimir Krivosheev [Wed, 7 Feb 2018 13:08:53 +0000 (14:08 +0100)]
update deps of ij-rpc-client

4 years agoprovide default implementations for tree settings
Sergey Malenkov [Wed, 7 Feb 2018 12:23:00 +0000 (15:23 +0300)]
provide default implementations for tree settings

4 years agofixed equals method: replace || with &&
Sergey Malenkov [Wed, 7 Feb 2018 12:09:35 +0000 (15:09 +0300)]
fixed equals method: replace || with &&

4 years agoFixed EA-115912 - NPE: MacIntelliJComboBoxUI$.paint
Kirill Kirichenko [Wed, 7 Feb 2018 12:57:01 +0000 (15:57 +0300)]
Fixed EA-115912 - NPE: MacIntelliJComboBoxUI$.paint

4 years ago[java] prepares Ant build generator to ASM .jar rename
Roman Shevchenko [Wed, 7 Feb 2018 12:50:25 +0000 (13:50 +0100)]
[java] prepares Ant build generator to ASM .jar rename

4 years agouse read lock instead of write
Alexey Kudravtsev [Wed, 7 Feb 2018 12:38:16 +0000 (15:38 +0300)]
use read lock instead of write

4 years ago[platform] improves default SDK versions string comparator (IDEA-CR-28783)
Roman Shevchenko [Wed, 7 Feb 2018 12:40:56 +0000 (13:40 +0100)]
[platform] improves default SDK versions string comparator (IDEA-CR-28783)

4 years agoIDEA-134545 Change Signature dialog uses syntax highlight colors, but not background
Kirill Kirichenko [Wed, 7 Feb 2018 12:36:48 +0000 (15:36 +0300)]
IDEA-134545 Change Signature dialog uses syntax highlight colors, but not background

4 years agodisable tests until https://youtrack.jetbrains.com/issue/TW-50656 is solved
Sergey Simonchik [Wed, 7 Feb 2018 12:22:56 +0000 (15:22 +0300)]
disable tests until https://youtrack.jetbrains.com/issue/TW-50656 is solved

4 years agoDisable Nextras Orm Plugin and PHP Annotations as incompatible
Maxim.Kolmakov [Wed, 7 Feb 2018 12:12:09 +0000 (13:12 +0100)]
Disable Nextras Orm Plugin and PHP Annotations as incompatible

4 years agoIDEA project configuration: set minimum version of Kotlin plugin to 1.2
nik [Wed, 7 Feb 2018 12:08:59 +0000 (13:08 +0100)]
IDEA project configuration: set minimum version of Kotlin plugin to 1.2

4 years agoIDEA-185911 Incorrect popup height causing scrollbar to appear
Sergey Malenkov [Wed, 7 Feb 2018 12:05:14 +0000 (15:05 +0300)]
IDEA-185911 Incorrect popup height causing scrollbar to appear

maximal row count increased for all list-based popups

4 years ago[kubernetes, yaml] wording
Sergey.Anchipolevsky [Wed, 7 Feb 2018 12:02:03 +0000 (15:02 +0300)]
[kubernetes, yaml] wording

4 years agodictionary: antivirus clion/181.3560
Anton Makeev [Wed, 7 Feb 2018 11:07:06 +0000 (12:07 +0100)]
dictionary: antivirus

4 years agocleanup phpstorm/181.3554
Alexey Kudravtsev [Wed, 7 Feb 2018 10:55:59 +0000 (13:55 +0300)]
cleanup

4 years agoleaking timer threads in MacOSXPreferencesFile
Alexey Kudravtsev [Wed, 7 Feb 2018 10:55:36 +0000 (13:55 +0300)]
leaking timer threads in MacOSXPreferencesFile

4 years agoMerge branch 'master' of git.labs.intellij.net:idea/community
Anton Makeev [Wed, 7 Feb 2018 10:41:45 +0000 (11:41 +0100)]
Merge branch 'master' of git.labs.intellij.net:idea/community

4 years agoIG: field assigned in catch block may not be final (IDEA-186267)
Bas Leijdekkers [Wed, 7 Feb 2018 10:07:40 +0000 (11:07 +0100)]
IG: field assigned in catch block may not be final (IDEA-186267)

4 years agobuild: force save application settings before starting build
nik [Wed, 7 Feb 2018 10:28:56 +0000 (11:28 +0100)]
build: force save application settings before starting build

Otherwise JDK settings may not be saved (IDEA-186248).

4 years agoclean old doc when selected item changes and it doesn't have element
Dennis Ushakov [Wed, 7 Feb 2018 10:32:31 +0000 (13:32 +0300)]
clean old doc when selected item changes and it doesn't have element

4 years agoMerge branch 'amakeev/file-root-icons'
Anton Makeev [Wed, 7 Feb 2018 10:33:37 +0000 (11:33 +0100)]
Merge branch 'amakeev/file-root-icons'

4 years agoNicer paths for files being reindexed
Maxim.Mossienko [Wed, 7 Feb 2018 10:29:07 +0000 (11:29 +0100)]
Nicer paths for files being reindexed

4 years agoDo not rebuild indices on AssertionError
Maxim.Mossienko [Wed, 7 Feb 2018 10:28:17 +0000 (11:28 +0100)]
Do not rebuild indices on AssertionError

4 years agojson-rpc: add method close() to close connection from client's side
Irina.Chernushina [Tue, 6 Feb 2018 09:59:25 +0000 (10:59 +0100)]
json-rpc: add method close() to close connection from client's side

(cherry picked from commit 126f4c5)