idea/community.git
5 years agoMerge remote-tracking branch 'origin/master' into develar/is
Vladimir Krivosheev [Wed, 22 Jun 2016 12:40:12 +0000 (14:40 +0200)]
Merge remote-tracking branch 'origin/master' into develar/is

# Conflicts:
# java/java-tests/testSrc/com/intellij/codeInspection/OfflineInspectionResultViewTest.java
# platform/analysis-impl/src/com/intellij/codeInsight/daemon/impl/HighlightInfoType.java
# platform/lang-impl/src/com/intellij/codeInspection/actions/CodeCleanupAction.java
# platform/lang-impl/src/com/intellij/codeInspection/actions/CodeInspectionAction.java

5 years agomulti-process debug — use the same host as main process
Vladimir Krivosheev [Wed, 22 Jun 2016 12:17:20 +0000 (14:17 +0200)]
multi-process debug — use the same host as main process

5 years agodictionary: toolchains appcode/163.373 clion/163.372
Anton Makeev [Wed, 22 Jun 2016 11:54:35 +0000 (13:54 +0200)]
dictionary: toolchains

5 years agoEDU-479 Renaming variable inside a file with the same name
Liana Bakradze [Wed, 22 Jun 2016 11:47:39 +0000 (14:47 +0300)]
EDU-479 Renaming variable inside a file with the same name

5 years agoclarifiy APP_CONFIG deprecation note phpstorm/163.371
Vladimir Krivosheev [Mon, 20 Jun 2016 15:18:07 +0000 (17:18 +0200)]
clarifiy APP_CONFIG deprecation note

5 years agoremove unused deprecated method
Vladimir Krivosheev [Mon, 20 Jun 2016 15:16:06 +0000 (17:16 +0200)]
remove unused deprecated method

5 years agoclarifiy APP_CONFIG deprecation note
Vladimir Krivosheev [Mon, 20 Jun 2016 10:16:49 +0000 (12:16 +0200)]
clarifiy APP_CONFIG deprecation note

5 years agogetDetachedInitializer() to avoid excessive stub-to-AST switches in PsiUtil.isConstan...
Alexey Kudravtsev [Wed, 22 Jun 2016 10:51:47 +0000 (13:51 +0300)]
getDetachedInitializer() to avoid excessive stub-to-AST switches in PsiUtil.isConstantExpression()

5 years agodisposed project leak in tests
Alexey Kudravtsev [Wed, 22 Jun 2016 10:50:21 +0000 (13:50 +0300)]
disposed project leak in tests

5 years agoassertion to avoid scanning compiled elements
Alexey Kudravtsev [Wed, 22 Jun 2016 10:49:44 +0000 (13:49 +0300)]
assertion to avoid scanning compiled elements

5 years agoEA-82721 - ISE: VisibilityUtil.getVisibilityString
Alexey Kudravtsev [Wed, 22 Jun 2016 10:49:18 +0000 (13:49 +0300)]
EA-82721 - ISE: VisibilityUtil.getVisibilityString

5 years agonotnull
Alexey Kudravtsev [Wed, 22 Jun 2016 10:48:27 +0000 (13:48 +0300)]
notnull

5 years agodo not find too many usages during "too many usages" warning
Alexey Kudravtsev [Wed, 22 Jun 2016 10:48:10 +0000 (13:48 +0300)]
do not find too many usages during "too many usages" warning

5 years agoEA-83759 - NPE: FileUtilRt.doCreateTempFile
Alexey Kudravtsev [Tue, 21 Jun 2016 17:08:29 +0000 (20:08 +0300)]
EA-83759 - NPE: FileUtilRt.doCreateTempFile

5 years agocleanup
Alexey Kudravtsev [Tue, 21 Jun 2016 16:56:31 +0000 (19:56 +0300)]
cleanup

5 years agoEA-83803 - NPE: UsageInfoUsageAdapter.highlightInEditor
Alexey Kudravtsev [Tue, 21 Jun 2016 16:44:32 +0000 (19:44 +0300)]
EA-83803 - NPE: UsageInfoUsageAdapter.highlightInEditor

5 years agodiagnostics for EA-83464 - assert: ProgressWrapper.<init>
Alexey Kudravtsev [Tue, 21 Jun 2016 16:38:17 +0000 (19:38 +0300)]
diagnostics for EA-83464 - assert: ProgressWrapper.<init>

5 years ago assertion for EA-83474 - SIOOBE: CharTableImpl.createSequence
Alexey Kudravtsev [Tue, 21 Jun 2016 16:26:19 +0000 (19:26 +0300)]
 assertion for EA-83474 - SIOOBE: CharTableImpl.createSequence

5 years agoreplace LightVirtualFile.markReadOnly with setWritable(false)
peter [Wed, 22 Jun 2016 10:36:05 +0000 (12:36 +0200)]
replace LightVirtualFile.markReadOnly with setWritable(false)

5 years agoJava inspection: convert the intention for "Replace lambda with anonymous class"...
Pavel Dolgov [Tue, 21 Jun 2016 16:13:06 +0000 (19:13 +0300)]
Java inspection: convert the intention for "Replace lambda with anonymous class" into an INFORMATION-level inspection

5 years agofix ant completion tests
Eugene Zhuravlev [Wed, 22 Jun 2016 10:25:56 +0000 (12:25 +0200)]
fix ant completion tests

5 years agoassert model changes happen in EDT, clarify transaction assertions and add one that... webstorm/163.369
peter [Wed, 22 Jun 2016 09:23:59 +0000 (11:23 +0200)]
assert model changes happen in EDT, clarify transaction assertions and add one that bg progress should have a write-safe modality

5 years agoSSR inspection: avoid map.get with nontrivial equals/hashCode for each PSI element
peter [Wed, 22 Jun 2016 09:16:07 +0000 (11:16 +0200)]
SSR inspection: avoid map.get with nontrivial equals/hashCode for each PSI element

5 years agoincrease ReservedCodeCacheSize for tests: some builds report code cache overflow
peter [Wed, 22 Jun 2016 08:56:55 +0000 (10:56 +0200)]
increase ReservedCodeCacheSize for tests: some builds report code cache overflow

5 years agominor isRawSubstitutor optimization
peter [Wed, 22 Jun 2016 08:51:43 +0000 (10:51 +0200)]
minor isRawSubstitutor optimization

5 years agofix new project list background for darkula appcode/163.367 clion/163.368 rubymine/163.366
Dennis Ushakov [Fri, 10 Jun 2016 11:10:40 +0000 (13:10 +0200)]
fix new project list background for darkula

5 years ago[vcs-log] do not check for registry in VcsLogProgress (never use status bar progress) clion/163.360 dbe/163.358 idea/163.361 phpstorm/163.359
Julia Beliaeva [Tue, 21 Jun 2016 21:56:01 +0000 (00:56 +0300)]
[vcs-log] do not check for registry in VcsLogProgress (never use status bar progress)

5 years ago[vcs-log] remove deprecated classes
Julia Beliaeva [Tue, 21 Jun 2016 21:33:13 +0000 (00:33 +0300)]
[vcs-log] remove deprecated classes

5 years agoproceed with event processing once indices are initialized, 4 (EA-84618)
Maxim.Mossienko [Tue, 21 Jun 2016 21:10:53 +0000 (23:10 +0200)]
proceed with event processing once indices are initialized, 4 (EA-84618)

5 years ago[vcs-log] revert (painting of current branch is too slow): use BitSetFlags instead...
Julia Beliaeva [Tue, 21 Jun 2016 21:03:22 +0000 (00:03 +0300)]
[vcs-log] revert (painting of current branch is too slow): use BitSetFlags instead of TIntHashSet

5 years agomore diagnostics for hanging waitForAlarm in tests
peter [Tue, 21 Jun 2016 20:52:24 +0000 (22:52 +0200)]
more diagnostics for hanging waitForAlarm in tests

5 years agoEA-83882 - NPE: InstalledPackagesPanel.buildNameToPackageMap
Sergey Simonchik [Tue, 21 Jun 2016 18:03:54 +0000 (21:03 +0300)]
EA-83882 - NPE: InstalledPackagesPanel.buildNameToPackageMap

5 years agoPY-17815 EA-67335 Don't save PSI reference in quick fix, save its class and find...
Mikhail Golubev [Thu, 9 Jun 2016 18:38:40 +0000 (21:38 +0300)]
PY-17815 EA-67335 Don't save PSI reference in quick fix, save its class and find it later

Also I prohibited showing the hint when underlying PSI element was
changed but revived by SmartPointer when these old and new elements
have different names.

I'm not yet sure whether it's possible to get rid of PSI reference
in the quickfix completely since there might be multiple references
on the same element and we don't want to suppress the hint because
some other unrelated references are resolved successfully (PY-3167).

5 years agoPY-19884 Add a test on type checking of set collection
Mikhail Golubev [Tue, 21 Jun 2016 16:50:06 +0000 (19:50 +0300)]
PY-19884 Add a test on type checking of set collection

5 years agoPY-19884 Add support for abc classes Set and MutableSet in PyABCUtil
Mikhail Golubev [Tue, 21 Jun 2016 12:40:33 +0000 (15:40 +0300)]
PY-19884 Add support for abc classes Set and MutableSet in PyABCUtil

5 years agoPY-19884 Snapshot of python-skeletons with set/frozenset @ ca4a0c4
Mikhail Golubev [Tue, 21 Jun 2016 16:32:44 +0000 (19:32 +0300)]
PY-19884 Snapshot of python-skeletons with set/frozenset @ ca4a0c4

5 years agoSimpleToolWindowPanel: extend AnAction list for panels with several toolbars phpstorm/163.374
Andrey Akinshin [Tue, 21 Jun 2016 05:57:24 +0000 (08:57 +0300)]
SimpleToolWindowPanel: extend AnAction list for panels with several toolbars

5 years agoFix according to review IDEA-CR-11509: 1) Add expose annotations to fields in Course...
Valentina Kiryushkina [Tue, 21 Jun 2016 16:18:06 +0000 (19:18 +0300)]
Fix according to review IDEA-CR-11509: 1) Add expose annotations to fields in Course and Lesson classes  2) Encapsulate id field in Course 3) Improve logging for adaptive stepic connector, show notification to user if problem occurred

5 years agoAdd latex display support for task description panel
Valentina Kiryushkina [Tue, 21 Jun 2016 16:14:20 +0000 (19:14 +0300)]
Add latex display support for task description panel

5 years agoFix according to review IDEA-CR-11509: 1) Don't post attempts to Stepic in Course...
Valentina Kiryushkina [Tue, 21 Jun 2016 14:52:34 +0000 (17:52 +0300)]
Fix according to review IDEA-CR-11509: 1) Don't post attempts to Stepic in Course creator projects 2) Add progress for getting course from stepic in project generator 3) Set timeout for stepic requests 4) Don't cache adaptive courses with no recommendations

5 years ago+toString()
Konstantin Bulenkov [Tue, 21 Jun 2016 15:10:32 +0000 (17:10 +0200)]
+toString()

5 years agoshow list cell renderer and editor in ui inspector
Konstantin Bulenkov [Tue, 21 Jun 2016 15:09:30 +0000 (17:09 +0200)]
show list cell renderer and editor in ui inspector

5 years agoIDEA-157490 Documentation for intentions and inspections
cheptsov [Thu, 30 Jun 2016 14:56:12 +0000 (16:56 +0200)]
IDEA-157490 Documentation for intentions and inspections

5 years agoEA-84619 vcs: AnAction.setEnabled clion/163.356
Aleksey Pivovarov [Tue, 21 Jun 2016 14:13:33 +0000 (17:13 +0300)]
EA-84619 vcs: AnAction.setEnabled

5 years agoEDU-612 Placeholder without frame idea/163.355
Liana Bakradze [Tue, 21 Jun 2016 14:18:43 +0000 (17:18 +0300)]
EDU-612 Placeholder without frame

5 years agoA fix for IDEA-156846 Color: "Default text" resets to white by itself, leads to brack...
Rustam Vishnyakov [Tue, 21 Jun 2016 14:04:04 +0000 (17:04 +0300)]
A fix for IDEA-156846 Color: "Default text" resets to white by itself, leads to brackets on white background

5 years agodrop cached initializer on stub-to-ast switch
Alexey Kudravtsev [Tue, 21 Jun 2016 14:02:44 +0000 (17:02 +0300)]
drop cached initializer on stub-to-ast switch

5 years agoChannelRegistrar — don't use netty channel group
Vladimir Krivosheev [Tue, 21 Jun 2016 13:20:08 +0000 (15:20 +0200)]
ChannelRegistrar — don't use netty channel group

5 years agocleanup
Alexey Kudravtsev [Tue, 21 Jun 2016 13:24:23 +0000 (16:24 +0300)]
cleanup

5 years agofile is not writable exception fixed
Alexey Kudravtsev [Tue, 21 Jun 2016 13:24:15 +0000 (16:24 +0300)]
file is not writable exception fixed

5 years agocleanup
Alexey Kudravtsev [Tue, 21 Jun 2016 11:05:19 +0000 (14:05 +0300)]
cleanup

5 years agoJava inspection: convert the intention for "Replace diamond with explicit type argume... rubymine/163.354
Pavel Dolgov [Tue, 21 Jun 2016 12:29:47 +0000 (15:29 +0300)]
Java inspection: convert the intention for "Replace diamond with explicit type arguments" into an INFORMATION-level inspection

5 years agoIDEA-CR-11636: don't leak stuff <..> after dialog closing
Gregory.Shrago [Tue, 21 Jun 2016 12:21:48 +0000 (15:21 +0300)]
IDEA-CR-11636: don't leak stuff <..> after dialog closing

5 years agoCPP-5515 Support attach with LLDB on Linux: suggest only default selected debugger
Anton Makeev [Tue, 21 Jun 2016 12:09:37 +0000 (14:09 +0200)]
CPP-5515 Support attach with LLDB on Linux: suggest only default selected debugger

5 years agoIDEA-133672 Maven. No tooltip for "Download sources and documentation" button.
Vladislav.Soroka [Tue, 21 Jun 2016 12:06:25 +0000 (15:06 +0300)]
IDEA-133672 Maven. No tooltip for "Download sources and documentation" button.

5 years agoremove redundant Expose annotations
Liana Bakradze [Tue, 21 Jun 2016 11:52:48 +0000 (14:52 +0300)]
remove redundant Expose annotations

5 years agoTurn on "Show returned values" by default (PY-19710) appcode/163.352 clion/163.353 phpstorm/163.351
Elizaveta Shashkova [Tue, 21 Jun 2016 11:35:57 +0000 (14:35 +0300)]
Turn on "Show returned values" by default (PY-19710)

5 years agoIDEA-152063 IntelliJ fails to use encoding from project settings for files containing...
Anton Makeev [Tue, 21 Jun 2016 11:33:07 +0000 (13:33 +0200)]
IDEA-152063 IntelliJ fails to use encoding from project settings for files containing breakpoints when project is opened: do not send event on encoding reset + API clarified

5 years agoJava inspection: INFORMATION inspections shouldn't be cleanup tools
Pavel Dolgov [Tue, 21 Jun 2016 10:48:25 +0000 (13:48 +0300)]
Java inspection: INFORMATION inspections shouldn't be cleanup tools

5 years agoIDEA-157667 Editor's scrollbar thumb: alpha and colors
Sergey Malenkov [Tue, 21 Jun 2016 10:21:22 +0000 (13:21 +0300)]
IDEA-157667 Editor's scrollbar thumb: alpha and colors
add ability to customize border of a scroll bar on Mac
temporary change for designer

5 years agomark detached initializer generated from stub read-only
Alexey Kudravtsev [Tue, 21 Jun 2016 10:23:01 +0000 (13:23 +0300)]
mark detached initializer generated from stub read-only

5 years agothrow on modification of non-writable light file
Alexey Kudravtsev [Tue, 21 Jun 2016 10:22:51 +0000 (13:22 +0300)]
throw on modification of non-writable light file

5 years agoawaitTermination should really wait for all tasks, tests added
Alexey Kudravtsev [Tue, 21 Jun 2016 09:53:33 +0000 (12:53 +0300)]
awaitTermination should really wait for all tasks, tests added

5 years agoDon't let JavaRearranger break a color scheme by altering original text attributes.
Rustam Vishnyakov [Tue, 21 Jun 2016 10:16:45 +0000 (13:16 +0300)]
Don't let JavaRearranger break a color scheme by altering original text attributes.

5 years agoJava inspection: intentions -> INFORMATION inspections - fix inspection metadata...
Pavel Dolgov [Tue, 21 Jun 2016 10:09:43 +0000 (13:09 +0300)]
Java inspection: intentions -> INFORMATION inspections - fix inspection metadata, add inspection descriptions

5 years agoIDEA-152063 IntelliJ fails to use encoding from project settings for files containing...
Anton Makeev [Tue, 21 Jun 2016 09:52:28 +0000 (11:52 +0200)]
IDEA-152063 IntelliJ fails to use encoding from project settings for files containing breakpoints when project is opened: do not send event on encoding reset

5 years agoinvalidate smart pointers when elements really become invalid (IDEA-157564)
peter [Tue, 21 Jun 2016 09:15:16 +0000 (11:15 +0200)]
invalidate smart pointers when elements really become invalid (IDEA-157564)

5 years agomore DRY in notnull instrumentation (IDEA-CR-11417)
peter [Tue, 21 Jun 2016 09:03:24 +0000 (11:03 +0200)]
more DRY in notnull instrumentation (IDEA-CR-11417)

5 years agodon't leak stuff <..> after dialog closing appcode/163.348 clion/163.349 pycharm/163.346 pycharm/163.347
Gregory.Shrago [Tue, 21 Jun 2016 04:35:31 +0000 (07:35 +0300)]
don't leak stuff <..> after dialog closing

5 years agoGPUB sync: make _COLLAPSE_ work with other modifiers: check endIndex webstorm/163.344 webstorm/163.345
Gregory.Shrago [Tue, 21 Jun 2016 00:10:20 +0000 (03:10 +0300)]
GPUB sync: make _COLLAPSE_ work with other modifiers: check endIndex

5 years agoNPE fix
Gregory.Shrago [Mon, 20 Jun 2016 23:26:52 +0000 (02:26 +0300)]
NPE fix

5 years agoEA-84531 - assert: EditorWindowImpl.a appcode/163.339 clion/163.342 dbe/163.336 idea/163.340 phpstorm/163.338 pycharm/163.341 rubymine/163.343
Gregory.Shrago [Mon, 20 Jun 2016 21:18:24 +0000 (00:18 +0300)]
EA-84531 - assert: EditorWindowImpl.a

5 years agoTest thread leak fix
Ilya.Kazakevich [Mon, 20 Jun 2016 21:37:07 +0000 (00:37 +0300)]
Test thread leak fix

We should wait for all thread listeners to complete after semaphore is released

5 years agoEA-73636 - ISE: GitUpdateProcess.updateImpl
Gregory.Shrago [Mon, 20 Jun 2016 21:05:15 +0000 (00:05 +0300)]
EA-73636 - ISE: GitUpdateProcess.updateImpl

5 years ago[groovy] use substitutor when checking for applicability
Daniil Ovchinnikov [Mon, 20 Jun 2016 19:19:44 +0000 (22:19 +0300)]
[groovy] use substitutor when checking for applicability

5 years agoUI Inspector: remove isXxxSet fields and mark appropriate properties as changed if...
Konstantin Bulenkov [Mon, 20 Jun 2016 18:32:07 +0000 (20:32 +0200)]
UI Inspector: remove isXxxSet fields and mark appropriate properties as changed if they are

5 years agoWI-32113 implemented the link to the code style settings page
Artem Khvastunov [Tue, 14 Jun 2016 10:33:20 +0000 (12:33 +0200)]
WI-32113 implemented the link to the code style settings page

(cherry picked from commit d7b6800387df1b90f2a891f920dbba3baa349c0c)

5 years ago@NotNull instrumentation: added test for duplicated labels in tableswitch instruction...
nik [Mon, 20 Jun 2016 18:49:03 +0000 (21:49 +0300)]
@NotNull instrumentation: added test for duplicated labels in tableswitch instruction (IDEA-CR-11417)

5 years agoMerge remote-tracking branch 'origin/new-winpty'
Dmitry Trofimov [Mon, 20 Jun 2016 18:36:54 +0000 (20:36 +0200)]
Merge remote-tracking branch 'origin/new-winpty'

5 years agoIDEA-157667 Editor's scrollbar thumb: alpha and colors
Sergey Malenkov [Mon, 20 Jun 2016 18:05:22 +0000 (21:05 +0300)]
IDEA-157667 Editor's scrollbar thumb: alpha and colors
add ability to customize color and alpha of a scroll bar
temporary change for designer

5 years agoJava inspection: convert the intention for "Infer lambda parameter type" into an...
Pavel Dolgov [Mon, 20 Jun 2016 17:56:30 +0000 (20:56 +0300)]
Java inspection: convert the intention for "Infer lambda parameter type" into an INFORMATION-level inspection

5 years agoIntroduce getFullName in PyRequirement which returns name and extras
Semyon Proshev [Mon, 20 Jun 2016 16:37:40 +0000 (19:37 +0300)]
Introduce getFullName in PyRequirement which returns name and extras

5 years agoExtract and save extras in PyRequirement
Semyon Proshev [Mon, 20 Jun 2016 16:36:17 +0000 (19:36 +0300)]
Extract and save extras in PyRequirement

5 years agoPY-19796 Fixed: Incorrect parameter type hint for ord() function parameter
Semyon Proshev [Fri, 17 Jun 2016 17:43:44 +0000 (20:43 +0300)]
PY-19796 Fixed: Incorrect parameter type hint for ord() function parameter

Update skeleton of ord function to accept bytes in Py3

5 years agoStrong references removed from ``PythonPathCache`` since cache should not prevent...
Ilya.Kazakevich [Tue, 31 May 2016 21:15:48 +0000 (00:15 +0300)]
Strong references removed from ``PythonPathCache`` since cache should not prevent anything from GC

5 years ago[groovy] methods with default parameters are not abstract in traits even if code...
Daniil Ovchinnikov [Mon, 20 Jun 2016 15:11:46 +0000 (18:11 +0300)]
[groovy] methods with default parameters are not abstract in traits even if code method is abstract

5 years agoEDU-608 Execute "tests.py" action doesn't create Run Study Tests configuration
Liana Bakradze [Mon, 20 Jun 2016 15:27:55 +0000 (18:27 +0300)]
EDU-608 Execute "tests.py" action doesn't create Run Study Tests configuration

5 years agomoved install requirements to the proper place
Ekaterina Tuzova [Mon, 20 Jun 2016 15:31:11 +0000 (18:31 +0300)]
moved install requirements to the proper place

5 years agoJava inspection: convert the intention for "Expand lambda expression body to code...
Pavel Dolgov [Mon, 20 Jun 2016 15:22:14 +0000 (18:22 +0300)]
Java inspection: convert the intention for "Expand lambda expression body to code block" into an INFORMATION-level inspection

5 years agorun inspections in parallel
Anna Kozlova [Mon, 20 Jun 2016 15:05:21 +0000 (18:05 +0300)]
run inspections in parallel

5 years agoinstallation fix
Ekaterina Tuzova [Mon, 20 Jun 2016 15:09:08 +0000 (18:09 +0300)]
installation fix

5 years agomerge
Ekaterina Tuzova [Mon, 20 Jun 2016 15:07:54 +0000 (18:07 +0300)]
merge

5 years agoinstall course requirements on the fly
Ekaterina Tuzova [Mon, 20 Jun 2016 14:58:48 +0000 (17:58 +0300)]
install course requirements on the fly

5 years agofixed PyCharm new project layout
Ekaterina Tuzova [Mon, 20 Jun 2016 13:11:05 +0000 (16:11 +0300)]
fixed PyCharm new project layout

5 years agofixed CCE
Ekaterina Tuzova [Fri, 17 Jun 2016 15:41:47 +0000 (18:41 +0300)]
fixed CCE

5 years agoPY-11166 Ability to create new projects without selecting Python interpreter
Ekaterina Tuzova [Fri, 17 Jun 2016 15:38:13 +0000 (18:38 +0300)]
PY-11166 Ability to create new projects without selecting Python interpreter

Extracted python interpreter combobox

5 years agoproper capitalization
Ekaterina Tuzova [Thu, 16 Jun 2016 18:49:46 +0000 (21:49 +0300)]
proper capitalization

5 years agoPY-11166 Ability to create new projects without selecting Python interpreter
Ekaterina Tuzova [Wed, 15 Jun 2016 15:22:04 +0000 (18:22 +0300)]
PY-11166 Ability to create new projects without selecting Python interpreter

5 years agoavoid duplicate gdsl queries for each of GroovyReferenceProcessor.allProcessors clion/163.335
peter [Mon, 20 Jun 2016 14:13:21 +0000 (16:13 +0200)]
avoid duplicate gdsl queries for each of GroovyReferenceProcessor.allProcessors

5 years agogroovy very minor performance
peter [Mon, 20 Jun 2016 13:59:19 +0000 (15:59 +0200)]
groovy very minor performance