idea/community.git
5 years agoMerge remote-tracking branch 'origin/master'
Dmitry Trofimov [Sun, 30 Oct 2016 17:36:00 +0000 (18:36 +0100)]
Merge remote-tracking branch 'origin/master'

5 years ago[vcs-log] create empty fake visible pack for empty visible graph
Julia Beliaeva [Sun, 30 Oct 2016 17:25:44 +0000 (20:25 +0300)]
[vcs-log] create empty fake visible pack for empty visible graph

EA-87115

5 years ago[vcs-log] minor: lambdify, use Comparator.comparingInt
Julia Beliaeva [Sun, 30 Oct 2016 17:10:49 +0000 (20:10 +0300)]
[vcs-log] minor: lambdify, use Comparator.comparingInt

5 years ago[vcs-log] minor: lambdify
Julia Beliaeva [Sun, 30 Oct 2016 16:51:39 +0000 (19:51 +0300)]
[vcs-log] minor: lambdify

5 years ago[vcs-log] minor: inline parameter that is always true
Julia Beliaeva [Sun, 30 Oct 2016 16:50:58 +0000 (19:50 +0300)]
[vcs-log] minor: inline parameter that is always true

5 years ago[git] do not mix normal output with error output; check exit code before parsing...
Julia Beliaeva [Sat, 29 Oct 2016 16:33:24 +0000 (19:33 +0300)]
[git] do not mix normal output with error output; check exit code before parsing remaining buffer on process terminated

EA-90861

5 years agoAdd test for '-m package' interpreter option in debug mode (PY-15230)
Dmitry Trofimov [Sun, 30 Oct 2016 12:05:30 +0000 (13:05 +0100)]
Add test for '-m package' interpreter option in debug mode (PY-15230)

Currently -m is removed while package stays in the options. This breaks the process launch.

5 years agoStreamify instead of for appcode/171.578 appcode/171.581 clion/171.579 clion/171.582
Kirill Likhodedov [Sun, 30 Oct 2016 11:10:12 +0000 (14:10 +0300)]
Streamify instead of for

5 years agoMove utility method from the API
Kirill Likhodedov [Sun, 30 Oct 2016 11:08:26 +0000 (14:08 +0300)]
Move utility method from the API

It is used only in the ShelveChangesManager, no external usages.

5 years agoCleanup & lambdify phpstorm/171.576
Kirill Likhodedov [Sun, 30 Oct 2016 10:09:40 +0000 (13:09 +0300)]
Cleanup & lambdify

5 years agoSuppress invokeLater warning since it is justified and explained
Kirill Likhodedov [Sun, 30 Oct 2016 10:07:05 +0000 (13:07 +0300)]
Suppress invokeLater warning since it is justified and explained

5 years agoUse recommended method instead of deprecated
Kirill Likhodedov [Sun, 30 Oct 2016 09:47:28 +0000 (12:47 +0300)]
Use recommended method instead of deprecated

ProjectLevelVcsManager#add/removeVcsListener has been deprecated for
a long time, but some usages were still not updated.

5 years agoDon't explicitly disconnect from project's message bus
Kirill Likhodedov [Sat, 29 Oct 2016 17:25:53 +0000 (20:25 +0300)]
Don't explicitly disconnect from project's message bus

It is disconnected on dispose anyway.
Also don't expect and pass the MessageBus in the constructor:
it is just the project.getMessageBus() anyway.

5 years agoLambdify
Kirill Likhodedov [Sat, 29 Oct 2016 17:11:07 +0000 (20:11 +0300)]
Lambdify

5 years agoRemove unused methods
Kirill Likhodedov [Sat, 29 Oct 2016 17:10:24 +0000 (20:10 +0300)]
Remove unused methods

5 years agoPY-21278 Deadlock on closing PyCharm when Python debug server configuration is waitin... appcode/171.574 clion/171.565 clion/171.575 dbe/171.567 phpstorm/171.571 pycharm/171.566 pycharm/171.570 rubymine/171.568 webstorm/171.573
Alexander Koshevoy [Sat, 29 Oct 2016 23:19:21 +0000 (02:19 +0300)]
PY-21278 Deadlock on closing PyCharm when Python debug server configuration is waiting for a script to be connected fixed

5 years agoflat welcome screen: use the whole page for the single project generator
Sergey Ignatov [Mon, 24 Oct 2016 19:40:24 +0000 (22:40 +0300)]
flat welcome screen: use the whole page for the single project generator

5 years agoIG: merge 3 inspections into one "Call to suspicious String method" inspection
Bas Leijdekkers [Fri, 28 Oct 2016 15:34:13 +0000 (17:34 +0200)]
IG: merge 3 inspections into one "Call to suspicious String method" inspection

5 years agoIG: warn on equalsIgnoreCase(), compareTo() and compareToIgnoreCase() call to itself...
Bas Leijdekkers [Fri, 28 Oct 2016 12:05:09 +0000 (14:05 +0200)]
IG: warn on equalsIgnoreCase(), compareTo() and compareToIgnoreCase() call to itself (IDEA-162797)

5 years agoAllow "Convert 'compareTo()' expression to 'equals()' call" intention in more cases
Bas Leijdekkers [Fri, 28 Oct 2016 11:32:24 +0000 (13:32 +0200)]
Allow "Convert 'compareTo()' expression to 'equals()' call" intention in more cases

5 years ago[vcs-log] fix spelling
Julia Beliaeva [Sat, 22 Oct 2016 16:45:30 +0000 (19:45 +0300)]
[vcs-log] fix spelling

5 years ago[vcs-log] re-use displayFatalErrorMessage
Julia Beliaeva [Fri, 21 Oct 2016 13:55:03 +0000 (16:55 +0300)]
[vcs-log] re-use displayFatalErrorMessage

5 years ago[vcs-log] rename processErrorFirstTime -> processError
Julia Beliaeva [Fri, 21 Oct 2016 13:54:13 +0000 (16:54 +0300)]
[vcs-log] rename processErrorFirstTime -> processError

5 years ago[vcs-log] move isBroken check out of invokeLater
Julia Beliaeva [Fri, 21 Oct 2016 13:51:50 +0000 (16:51 +0300)]
[vcs-log] move isBroken check out of invokeLater

5 years ago[vcs-log] rename FatalErrorConsumer -> FatalErrorHandler
Julia Beliaeva [Fri, 21 Oct 2016 13:42:42 +0000 (16:42 +0300)]
[vcs-log] rename FatalErrorConsumer -> FatalErrorHandler

5 years ago[vcs-log] add logging message when log caches deleted
Julia Beliaeva [Fri, 14 Oct 2016 16:02:08 +0000 (19:02 +0300)]
[vcs-log] add logging message when log caches deleted

5 years ago[vcs-log] register caches invalidator for log so that Invalidate... action would...
Julia Beliaeva [Fri, 14 Oct 2016 15:40:52 +0000 (18:40 +0300)]
[vcs-log] register caches invalidator for log so that Invalidate... action would remove system/vcs-log directory

1. On invalidateCaches create a "corruption.marker" in system/vcs-log.
2. Check existence of this marker before creating log storage and indexes. If marker exists, remove system/vcs-log.
3. Problem arises, however, when system/vcs-log could not be deleted. Nothing can be done here, so just display error balloon, fallback to memory storage and empty indexes. Loading log in background should be disabled in this case.

5 years agoWrite correct process output in case it terminates with an error.
Dmitry Trofimov [Sat, 29 Oct 2016 16:08:56 +0000 (18:08 +0200)]
Write correct process output in case it terminates with an error.

5 years agoRemove unused inner class
Kirill Likhodedov [Sat, 29 Oct 2016 15:31:28 +0000 (18:31 +0300)]
Remove unused inner class

5 years agoLambdify
Kirill Likhodedov [Sat, 29 Oct 2016 15:30:19 +0000 (18:30 +0300)]
Lambdify

5 years agoRemove useless annotation
Kirill Likhodedov [Sat, 29 Oct 2016 15:29:04 +0000 (18:29 +0300)]
Remove useless annotation

5 years agoallow to override initial selection in open file action
Sergey Ignatov [Sat, 29 Oct 2016 14:24:15 +0000 (17:24 +0300)]
allow to override initial selection in open file action

5 years ago[Parameter Name Hints] add ToggleInlineHints action to parameter hints popup menu... appcode/171.562 clion/171.561
Yaroslav Lepenkin [Fri, 28 Oct 2016 15:02:07 +0000 (18:02 +0300)]
[Parameter Name Hints] add ToggleInlineHints action to parameter hints popup menu. In regular popup menu action will be shown only if hints are disabled and there is a hint to show at caret.

5 years agoshow git merge dialog in a write-safe context (EA-90653 - assert: FileDocumentManager... appcode/171.560 clion/171.559
peter [Sat, 29 Oct 2016 11:03:46 +0000 (13:03 +0200)]
show git merge dialog in a write-safe context (EA-90653 - assert: FileDocumentManagerImpl.saveAllDocuments)

5 years agohandle MethodOrClosureScopeChooser selection in a write-safe context (EA-90852 -...
peter [Sat, 29 Oct 2016 10:35:28 +0000 (12:35 +0200)]
handle MethodOrClosureScopeChooser selection in a write-safe context (EA-90852 - assert: PsiModificationTrackerImpl.fireEvent)

5 years agoPY-21273 Fixing deadlock on debugging Python script in docker container phpstorm/171.558
Alexander Koshevoy [Sat, 29 Oct 2016 10:52:45 +0000 (13:52 +0300)]
PY-21273 Fixing deadlock on debugging Python script in docker container

Critical sections in ClientModeDebuggerTransport under mySocketObject shortened, myState taken out of them completely.

5 years agoPY-21273 Fixing deadlock on debugging Python script in docker container
Alexander Koshevoy [Sat, 29 Oct 2016 10:07:07 +0000 (13:07 +0300)]
PY-21273 Fixing deadlock on debugging Python script in docker container

Excessive synchronization on calling waitForConnect() of the main debugger removed. Operations with myOtherDebuggers made safe without going into critical sections if some uncontrolled methods are called within them, particularly in isConnected() method.

5 years agofix compilation
peter [Sat, 29 Oct 2016 09:03:08 +0000 (11:03 +0200)]
fix compilation

5 years agoadd diagnostics and make non-exceptional EA-83768 - assert: AstPath.invalidatePaths
peter [Sat, 29 Oct 2016 09:02:50 +0000 (11:02 +0200)]
add diagnostics and make non-exceptional EA-83768 - assert: AstPath.invalidatePaths

5 years agoattempt as many tearDown activities as possible despite exceptions appcode/171.557 clion/171.556
peter [Sat, 29 Oct 2016 08:51:24 +0000 (10:51 +0200)]
attempt as many tearDown activities as possible despite exceptions

5 years agoteach more tests that find in path is multithreaded (IDEA-CR-15039)
peter [Fri, 28 Oct 2016 16:58:49 +0000 (18:58 +0200)]
teach more tests that find in path is multithreaded (IDEA-CR-15039)

5 years agoa test proving that root changes increase psi mod counts
peter [Fri, 28 Oct 2016 16:48:10 +0000 (18:48 +0200)]
a test proving that root changes increase psi mod counts

5 years agoMerge remote-tracking branch 'origin/master' appcode/171.546 clion/171.553 dbe/171.548 idea/171.550 phpstorm/171.551 pycharm/171.547 pycharm/171.552 rubymine/171.549 webstorm/171.555
Dmitry Trofimov [Fri, 28 Oct 2016 22:04:50 +0000 (00:04 +0200)]
Merge remote-tracking branch 'origin/master'

5 years agoFix deadlock when running remote debug server (PY-21278)
Dmitry Trofimov [Fri, 28 Oct 2016 22:03:50 +0000 (00:03 +0200)]
Fix deadlock when running remote debug server (PY-21278)

5 years agoget rid of extra Disposable instance (IDEA-CR-15107)
Sergey Simonchik [Fri, 28 Oct 2016 21:44:47 +0000 (00:44 +0300)]
get rid of extra Disposable instance (IDEA-CR-15107)

5 years agonew icons for Project View tool window
Konstantin Bulenkov [Fri, 28 Oct 2016 19:59:39 +0000 (21:59 +0200)]
new icons for Project View tool window

5 years agoPY-21132: Passing -m option correctly
Ilya.Kazakevich [Fri, 28 Oct 2016 18:21:13 +0000 (21:21 +0300)]
PY-21132: Passing -m option correctly

5 years agoIDEA-162905 improve performance of children processing
Sergey Malenkov [Fri, 28 Oct 2016 18:19:49 +0000 (21:19 +0300)]
IDEA-162905 improve performance of children processing

5 years agotemplates: show custom templates after regular code completion
Andrey Starovoyt [Fri, 28 Oct 2016 17:48:10 +0000 (20:48 +0300)]
templates: show custom templates after regular code completion

5 years agofixed AIOOB in MethodBytecodeUtil.visit
Egor.Ushakov [Fri, 28 Oct 2016 17:32:21 +0000 (20:32 +0300)]
fixed AIOOB in MethodBytecodeUtil.visit

5 years agotest output order: ensure that tree view with predefined structure searches for place...
Anna.Kozlova [Fri, 28 Oct 2016 17:34:41 +0000 (19:34 +0200)]
test output order: ensure that tree view with predefined structure searches for place for new printable (IDEA-163309)

5 years agoskip set invalid package fix (IDEA-163244)
Anna.Kozlova [Fri, 28 Oct 2016 16:41:28 +0000 (18:41 +0200)]
skip set invalid package fix (IDEA-163244)

5 years agoPY-21083 Fixed: Inspection of float.fromhex expecting incorrect arguments
Semyon Proshev [Fri, 28 Oct 2016 17:08:12 +0000 (20:08 +0300)]
PY-21083 Fixed: Inspection of float.fromhex expecting incorrect arguments

Add skeleton for float.fromhex

5 years agoemulated method breakpoints now work in lambdas clion/171.541
Egor.Ushakov [Fri, 28 Oct 2016 16:51:16 +0000 (19:51 +0300)]
emulated method breakpoints now work in lambdas

5 years agoextracted safe allLineLocations to utils
Egor.Ushakov [Fri, 28 Oct 2016 15:54:20 +0000 (18:54 +0300)]
extracted safe allLineLocations to utils

5 years agowrite action around console clear
fitermay [Wed, 26 Oct 2016 14:49:28 +0000 (10:49 -0400)]
write action around console clear

5 years agoPY-21146: Use PSI to check for multiline statements
fitermay [Mon, 24 Oct 2016 05:17:51 +0000 (01:17 -0400)]
PY-21146: Use PSI to check for multiline statements

5 years agoPY-21203: Remove extra trailing output generated by EnterHandler before execution
fitermay [Sun, 23 Oct 2016 18:06:24 +0000 (14:06 -0400)]
PY-21203: Remove extra trailing output generated by EnterHandler before execution

5 years agoPY-21145: Make interrupt action clear the console input when not executing
fitermay [Sat, 22 Oct 2016 05:03:41 +0000 (01:03 -0400)]
PY-21145: Make interrupt action clear the console input when not executing

5 years agoPY-21125: Handle newline characters inside lexer tokens
fitermay [Sat, 22 Oct 2016 04:13:53 +0000 (00:13 -0400)]
PY-21125: Handle newline characters inside lexer tokens

5 years agoCleanup (extracts exception handling)
Roman Shevchenko [Fri, 28 Oct 2016 16:33:29 +0000 (18:33 +0200)]
Cleanup (extracts exception handling)

5 years agoEA-90808 - E: BaseRefactoringProcessor.run
Anna.Kozlova [Fri, 28 Oct 2016 15:57:48 +0000 (17:57 +0200)]
EA-90808 - E: BaseRefactoringProcessor.run

5 years agosuper expression rules should not apply to this expressions (IDEA-163303)
Anna.Kozlova [Fri, 28 Oct 2016 15:54:44 +0000 (17:54 +0200)]
super expression rules should not apply to this expressions (IDEA-163303)

5 years agoMerge remote-tracking branch 'origin/master' clion/171.539
Roman Shevchenko [Fri, 28 Oct 2016 16:02:41 +0000 (18:02 +0200)]
Merge remote-tracking branch 'origin/master'

5 years ago[java] fixes blocking accept() call in process proxy
Roman Shevchenko [Fri, 28 Oct 2016 16:02:21 +0000 (18:02 +0200)]
[java] fixes blocking accept() call in process proxy

5 years agoFix indent
Elizaveta Shashkova [Fri, 28 Oct 2016 15:55:00 +0000 (18:55 +0300)]
Fix indent

5 years agoTests: add timeout for exec() and fix console tests
Elizaveta Shashkova [Fri, 28 Oct 2016 15:52:46 +0000 (18:52 +0300)]
Tests: add timeout for exec() and fix console tests

5 years agoIDEA-163261 German Keyboard: File Search, ALT-a enters weird character
Denis Fokin [Fri, 28 Oct 2016 14:01:48 +0000 (17:01 +0300)]
IDEA-163261 German Keyboard: File Search, ALT-a enters weird character

5 years ago[groovy] @IndexedProperty: use PsiUtil#substituteTypeParameter(), test
Daniil Ovchinnikov [Fri, 28 Oct 2016 15:47:10 +0000 (18:47 +0300)]
[groovy] @IndexedProperty: use PsiUtil#substituteTypeParameter(), test

5 years agojavac ast indices: cache whole dirty scope (vfs changed + uncommitted)
Dmitry Batkovich [Fri, 28 Oct 2016 15:38:21 +0000 (18:38 +0300)]
javac ast indices: cache whole dirty scope (vfs changed + uncommitted)

5 years ago[followup] Add/refactor JBUI.JBIcon/ScalableJBIcon/ValidatingScalableJBIcon
Anton Tarasov [Fri, 28 Oct 2016 15:35:29 +0000 (18:35 +0300)]
[followup] Add/refactor JBUI.JBIcon/ScalableJBIcon/ValidatingScalableJBIcon

5 years agomaven: save maven project tree data in the background thread
Vladislav.Soroka [Fri, 28 Oct 2016 15:30:45 +0000 (18:30 +0300)]
maven: save maven project tree data in the background thread

5 years ago@NotNull ExtensionPointName
Daniil Ovchinnikov [Fri, 28 Oct 2016 14:59:13 +0000 (17:59 +0300)]
@NotNull ExtensionPointName

5 years agofixed smart step into interface method implemented by lambda
Egor.Ushakov [Fri, 28 Oct 2016 15:10:26 +0000 (18:10 +0300)]
fixed smart step into interface method implemented by lambda

5 years agofix test data appcode/171.536
Vladimir Krivosheev [Fri, 28 Oct 2016 15:01:14 +0000 (17:01 +0200)]
fix test data

5 years agofix testdata
Anna.Kozlova [Fri, 28 Oct 2016 14:54:16 +0000 (16:54 +0200)]
fix testdata

5 years agoIDEA-163238 Synchronize settings make the IDE unusable
Vladimir Krivosheev [Fri, 28 Oct 2016 14:44:41 +0000 (16:44 +0200)]
IDEA-163238 Synchronize settings make the IDE unusable

5 years agoCleanup (duplicated properties)
Roman Shevchenko [Fri, 28 Oct 2016 14:45:12 +0000 (16:45 +0200)]
Cleanup (duplicated properties)

5 years agoCleanup (process proxy port is an implementation detail)
Roman Shevchenko [Fri, 28 Oct 2016 14:32:08 +0000 (16:32 +0200)]
Cleanup (process proxy port is an implementation detail)

5 years ago[build] Unix distributions do not contain breakgen libs anymore
Roman Shevchenko [Fri, 28 Oct 2016 14:27:25 +0000 (16:27 +0200)]
[build] Unix distributions do not contain breakgen libs anymore

5 years agoUpdate PyStringLiteralExpressionManipulator to correctly process unquoted newContent.
Semyon Proshev [Fri, 28 Oct 2016 14:26:33 +0000 (17:26 +0300)]
Update PyStringLiteralExpressionManipulator to correctly process unquoted newContent.
Fix tests in AppEngineMoveTest.

5 years agoIDEA-155007 IDEA does not kill the debug process immediately
Vladimir Krivosheev [Fri, 28 Oct 2016 14:17:34 +0000 (16:17 +0200)]
IDEA-155007 IDEA does not kill the debug process immediately

5 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Fri, 28 Oct 2016 14:13:58 +0000 (16:13 +0200)]
Merge remote-tracking branch 'origin/master'

5 years ago[project] no more .jnilib files in CE/bin/mac
Roman Shevchenko [Fri, 28 Oct 2016 14:13:26 +0000 (16:13 +0200)]
[project] no more .jnilib files in CE/bin/mac

5 years ago[project] no more .so libs in CE/bin/linux
Roman Shevchenko [Fri, 28 Oct 2016 14:09:31 +0000 (16:09 +0200)]
[project] no more .so libs in CE/bin/linux

5 years agoIDEA-161501 ui: fix indeterminate progress rendering under HiDPI
Aleksey Pivovarov [Fri, 28 Oct 2016 13:50:10 +0000 (16:50 +0300)]
IDEA-161501 ui: fix indeterminate progress rendering under HiDPI

follow-up: a895bbe

5 years ago[platform] breakgen build scripts optimization
Roman Shevchenko [Fri, 28 Oct 2016 14:03:48 +0000 (16:03 +0200)]
[platform] breakgen build scripts optimization

5 years ago[followup] Add/refactor JBUI.JBIcon/ScalableJBIcon/ValidatingScalableJBIcon
Anton Tarasov [Fri, 28 Oct 2016 13:44:56 +0000 (16:44 +0300)]
[followup] Add/refactor JBUI.JBIcon/ScalableJBIcon/ValidatingScalableJBIcon

5 years agoIDEA-CR-15134 use val
Vladimir Krivosheev [Fri, 28 Oct 2016 13:43:40 +0000 (15:43 +0200)]
IDEA-CR-15134 use val

5 years agoRegistry key to control building a project tree
Sergey Malenkov [Fri, 28 Oct 2016 13:40:06 +0000 (16:40 +0300)]
Registry key to control building a project tree

5 years agojunit 5 conversion: convert tests without @RunWith/@Rule/@ClassRule annotations
Anna.Kozlova [Fri, 28 Oct 2016 13:25:16 +0000 (15:25 +0200)]
junit 5 conversion: convert tests without @RunWith/@Rule/@ClassRule annotations

5 years agofix quick fix name
Anna.Kozlova [Fri, 28 Oct 2016 09:41:57 +0000 (11:41 +0200)]
fix quick fix name

5 years agospeedup contract inference index
peter [Fri, 28 Oct 2016 12:18:35 +0000 (14:18 +0200)]
speedup contract inference index

reduce the number of passes over light AST
because it doesn't remember the contents of lazy-parseable tokens for long
and thus might parse the same code block several times

5 years agocontract inference index
peter [Fri, 28 Oct 2016 11:09:25 +0000 (13:09 +0200)]
contract inference index

5 years agoLookupPreview editor changes should be guarded (EA-90748 - Throwable: ObjectTree...
peter [Fri, 28 Oct 2016 11:05:21 +0000 (13:05 +0200)]
LookupPreview editor changes should be guarded (EA-90748 - Throwable: ObjectTree.rememberDisposedTrace)

5 years agowait for pending filters in cmake console
Anton Makeev [Fri, 28 Oct 2016 13:23:46 +0000 (15:23 +0200)]
wait for pending filters in cmake console

5 years agoIDEA-161501 ui: fix indeterminate progress rendering under HiDPI
Aleksey Pivovarov [Fri, 28 Oct 2016 12:43:29 +0000 (15:43 +0300)]
IDEA-161501 ui: fix indeterminate progress rendering under HiDPI

5 years agoui: fix HiDPI scaling in Editor Search and Replace UI
Aleksey Pivovarov [Fri, 28 Oct 2016 12:03:51 +0000 (15:03 +0300)]
ui: fix HiDPI scaling in Editor Search and Replace UI

* do not scale `icon.getIconWidth()`
* use JBDimension to avoid multiplicative scaling with `JBDimension.scale()`
* do not set minimumSize depending on icon size - it's unnecessary,
  as actual size will be calculated as `Math.max(iconSize, minimumSize)`

follow-up: 7aa6ce4c45f898fcf7aa37ea83c6ff03de348a9d

5 years agoUse new way to register MnemonicHelper
Sergey Malenkov [Fri, 28 Oct 2016 12:47:58 +0000 (15:47 +0300)]
Use new way to register MnemonicHelper

5 years agouse StreamEx.ofTree
Egor.Ushakov [Fri, 28 Oct 2016 12:45:35 +0000 (15:45 +0300)]
use StreamEx.ofTree