idea/community.git
5 years agoFixed `ResultOfAssignmentUsed` inspection, when it's not in method
Pap Lőrinc [Wed, 2 Mar 2016 16:54:47 +0000 (18:54 +0200)]
Fixed `ResultOfAssignmentUsed` inspection, when it's not in method

5 years agoSSR: fix finding packageLocal and instance fields appcode/146.379 clion/146.380 phpstorm/146.378
Bas Leijdekkers [Sat, 5 Mar 2016 08:53:48 +0000 (09:53 +0100)]
SSR: fix finding packageLocal and instance fields

5 years agoSSR: call checkSearchPattern() in structural replace test
Bas Leijdekkers [Fri, 4 Mar 2016 19:09:08 +0000 (20:09 +0100)]
SSR: call checkSearchPattern() in structural replace test

5 years agoSSR: fix bad psi tree when replacing parameter
Bas Leijdekkers [Fri, 4 Mar 2016 14:04:15 +0000 (15:04 +0100)]
SSR: fix bad psi tree when replacing parameter

5 years agoSSR: fix exception when search pattern method, replacement pattern method and replace...
Bas Leijdekkers [Fri, 4 Mar 2016 10:11:06 +0000 (11:11 +0100)]
SSR: fix exception when search pattern method, replacement pattern method and replaced method have no body

5 years agoIDEA-152313 (Structural replace with local variable definition leads to inconsistent...
Bas Leijdekkers [Thu, 3 Mar 2016 19:49:06 +0000 (20:49 +0100)]
IDEA-152313 (Structural replace with local variable definition leads to inconsistent state with IDEA error highlighter)

5 years agospeedup gradle console filter, on IDEA-CR-9069
Sergey Ignatov [Sat, 5 Mar 2016 10:13:48 +0000 (13:13 +0300)]
speedup gradle console filter, on IDEA-CR-9069

5 years agospeedup gradle console filter, fix IDEA-150077
Sergey Ignatov [Sat, 5 Mar 2016 09:32:01 +0000 (12:32 +0300)]
speedup gradle console filter, fix IDEA-150077

– cheap check if the string starts with / or {Alpha}:\
– check if the project has any gradle module
– wrap pattern matching with the bombed char sequence

5 years agoremove an unnecessary cast
Sergey Ignatov [Fri, 4 Mar 2016 15:33:44 +0000 (18:33 +0300)]
remove an unnecessary cast

5 years agospeed up UrlFilter
peter [Sat, 5 Mar 2016 09:16:16 +0000 (10:16 +0100)]
speed up UrlFilter

5 years agoinline functional expression: surround with parenthesis if inlined in method referenc... appcode/146.371 clion/146.373 dbe/146.374 phpstorm/146.369 pycharm/146.372 pycharm/146.376 rubymine/146.375 webstorm/146.377
Anna Kozlova [Fri, 4 Mar 2016 18:53:55 +0000 (19:53 +0100)]
inline functional expression: surround with parenthesis if inlined in method reference qualifier (IDEA-152600)

5 years agoIDEA-152440 Changes in License Dialog: 'Terms Of Service' (TOS) and 'Privacy Policy...
Vassiliy.Kudryashov [Fri, 4 Mar 2016 18:49:50 +0000 (21:49 +0300)]
IDEA-152440 Changes in License Dialog: 'Terms Of Service' (TOS) and 'Privacy Policy' (PP)

5 years agoIDEA-152440 Changes in License Dialog: 'Terms Of Service' (TOS) and 'Privacy Policy...
Vassiliy.Kudryashov [Fri, 4 Mar 2016 18:06:38 +0000 (21:06 +0300)]
IDEA-152440 Changes in License Dialog: 'Terms Of Service' (TOS) and 'Privacy Policy' (PP)
Stage #2: Navigation for internal HTML references has been added.

5 years agoCleanup (formatting)
Roman Shevchenko [Fri, 4 Mar 2016 18:05:53 +0000 (19:05 +0100)]
Cleanup (formatting)

5 years agoCleanup (typo)
Roman Shevchenko [Fri, 4 Mar 2016 18:05:06 +0000 (19:05 +0100)]
Cleanup (typo)

5 years ago[java] "Surround with try-with-resources" registered as surround template (IDEA-152348)
Roman Shevchenko [Fri, 4 Mar 2016 17:49:42 +0000 (18:49 +0100)]
[java] "Surround with try-with-resources" registered as surround template (IDEA-152348)

5 years agoProductivity Guide entry for 'move element left/right' actions clion/146.367
Dmitry Batrak [Fri, 4 Mar 2016 17:16:55 +0000 (20:16 +0300)]
Productivity Guide entry for 'move element left/right' actions

5 years agofind usages: display modal progress for one potentially slow initialization part
peter [Fri, 4 Mar 2016 17:09:55 +0000 (18:09 +0100)]
find usages: display modal progress for one potentially slow initialization part

5 years agotransactions: minor javadoc updates, store transaction start stack trace for easier...
peter [Fri, 4 Mar 2016 17:08:26 +0000 (18:08 +0100)]
transactions: minor javadoc updates, store transaction start stack trace for easier diagnostics

5 years agoensure other threads don't sleep under LookupImpl lock when we need it on EDT
peter [Fri, 4 Mar 2016 16:56:18 +0000 (17:56 +0100)]
ensure other threads don't sleep under LookupImpl lock when we need it on EDT

5 years agosmart enter for try-with-resources body
peter [Fri, 4 Mar 2016 16:54:09 +0000 (17:54 +0100)]
smart enter for try-with-resources body

5 years agomaven: resolve workspace artifacts, support source/test-source (IDEA-152144) and...
Vladislav.Soroka [Fri, 4 Mar 2016 16:39:35 +0000 (19:39 +0300)]
maven: resolve workspace artifacts, support source/test-source (IDEA-152144) and javadoc/test-javadoc artifacts

5 years agoRevert: rollback changes in tips css
Konstantin Bulenkov [Fri, 4 Mar 2016 16:29:11 +0000 (17:29 +0100)]
Revert: rollback changes in tips css

5 years agoMvcModuleStructureSynchronizer: start and end bg calculation in the same non-modal...
peter [Fri, 4 Mar 2016 15:16:20 +0000 (16:16 +0100)]
MvcModuleStructureSynchronizer: start and end bg calculation in the same non-modal state to prevent multiple restarts when a dialog is shown

5 years agoinit toolwindows in any modality state
peter [Fri, 4 Mar 2016 15:14:36 +0000 (16:14 +0100)]
init toolwindows in any modality state

5 years agoeditor notifications are recalculated in any modality state, so apply the results...
peter [Fri, 4 Mar 2016 14:51:12 +0000 (15:51 +0100)]
editor notifications are recalculated in any modality state, so apply the results also in any state

5 years agoremote-servers tips
Konstantin Bulenkov [Fri, 4 Mar 2016 16:12:26 +0000 (17:12 +0100)]
remote-servers tips

5 years agoupdate Tips&Tricks in Platform
Konstantin Bulenkov [Fri, 4 Mar 2016 16:08:25 +0000 (17:08 +0100)]
update Tips&Tricks in Platform

5 years agoinline to anonymous: change wording (IDEA-152534)
Anna Kozlova [Fri, 4 Mar 2016 15:54:55 +0000 (16:54 +0100)]
inline to anonymous: change wording (IDEA-152534)

5 years agoinline super: process only extends/implements if only one class should be updated...
Anna Kozlova [Fri, 4 Mar 2016 15:45:04 +0000 (16:45 +0100)]
inline super: process only extends/implements if only one class should be updated (IDEA-152597)

5 years agoinline super: don't search for inheritors (may be only this should be replaced: IDEA...
Anna Kozlova [Fri, 4 Mar 2016 15:32:44 +0000 (16:32 +0100)]
inline super: don't search for inheritors (may be only this should be replaced: IDEA-152522); dialog layout simplified (IDEA-152474)

5 years agoinline super: don't warn for unresolved constructor with new array (IDEA-152583)
Anna Kozlova [Fri, 4 Mar 2016 14:19:28 +0000 (15:19 +0100)]
inline super: don't warn for unresolved constructor with new array (IDEA-152583)

5 years agoinference: proper exceptions thrown checks (IDEA-152577)
Anna Kozlova [Fri, 4 Mar 2016 11:19:21 +0000 (12:19 +0100)]
inference: proper exceptions thrown checks (IDEA-152577)

5 years agomethod ref: ensure equivalence (IDEA-152384)
Anna Kozlova [Fri, 4 Mar 2016 10:35:19 +0000 (11:35 +0100)]
method ref: ensure equivalence (IDEA-152384)

5 years agoupdate IdeTipsAndTricks.xml
Konstantin Bulenkov [Fri, 4 Mar 2016 15:55:51 +0000 (16:55 +0100)]
update IdeTipsAndTricks.xml

5 years agoplugin loading: don't fail if one of plugins required for a plugin which defines...
nik [Fri, 4 Mar 2016 15:11:49 +0000 (18:11 +0300)]
plugin loading: don't fail if one of plugins required for a plugin which defines a module cannot be loaded (IDEA-152606)

5 years agoIDEA-152440 Changes in License Dialog: 'Terms Of Service' (TOS) and 'Privacy Policy...
Vassiliy.Kudryashov [Fri, 4 Mar 2016 14:59:23 +0000 (17:59 +0300)]
IDEA-152440 Changes in License Dialog: 'Terms Of Service' (TOS) and 'Privacy Policy' (PP)

5 years agoupdate Tips&Tricks in IDEA CE
Konstantin Bulenkov [Fri, 4 Mar 2016 14:57:42 +0000 (15:57 +0100)]
update Tips&Tricks in IDEA CE

5 years agoPriliminary fix for expandable hints on the completion popup appcode/146.365 clion/146.366
Sergey Malenkov [Fri, 4 Mar 2016 14:26:35 +0000 (17:26 +0300)]
Priliminary fix for expandable hints on the completion popup

5 years ago[tests] test cases added
Roman Shevchenko [Fri, 4 Mar 2016 14:32:42 +0000 (15:32 +0100)]
[tests] test cases added

5 years ago(by patch from IDEA-151808) Walk up to the root to determine if file is in content...
peter [Fri, 4 Mar 2016 13:55:02 +0000 (14:55 +0100)]
(by patch from IDEA-151808) Walk up to the root to determine if file is in content roots

5 years agoblinking test fixed appcode/146.364 appcode/146.650 appcode/146.843 clion/146.362
Dmitry Avdeev [Fri, 4 Mar 2016 13:28:16 +0000 (16:28 +0300)]
blinking test fixed

5 years agovcs: More diagnostics for new project vcs-es detection
Konstantin Kolosovsky [Thu, 3 Mar 2016 11:46:56 +0000 (14:46 +0300)]
vcs: More diagnostics for new project vcs-es detection

5 years agoIDEA-119539 Optimized before and after filepaths comparison while detecting if "Chang...
Konstantin Kolosovsky [Wed, 2 Mar 2016 15:53:13 +0000 (18:53 +0300)]
IDEA-119539 Optimized before and after filepaths comparison while detecting if "Change" is move/rename

Frequent "FilePath.getIOFile()" calls could lead to performance issues. For instance, there are snapshots with slow "Change.isMoved() or Change.isRenamed()" -> "Change.cacheRenameOrMove()" -> "Change.revisionPathsSame()" -> "LocalFilePath.getIOFile()" method calls.

5 years agoRevert: vcs: Refactored "FilePath" implementations not to create new "File" instances...
Konstantin Kolosovsky [Wed, 2 Mar 2016 14:14:55 +0000 (17:14 +0300)]
Revert: vcs: Refactored "FilePath" implementations not to create new "File" instances on each "getIOFile()" call - reuse same "File" instance created in constructor instead (d962b00bb55b09bc5487ed0f5b7d51c0049edec2)

5 years agomaven: show ommited by conflict dependency nodes
Vladislav.Soroka [Fri, 4 Mar 2016 12:49:00 +0000 (15:49 +0300)]
maven: show ommited by conflict dependency nodes

5 years agoDo not wrap javadoc description if every line is shorter than description (IDEA-152431)
Yaroslav Lepenkin [Fri, 4 Mar 2016 10:48:54 +0000 (13:48 +0300)]
Do not wrap javadoc description if every line is shorter than description (IDEA-152431)

Current wrapping approach sadly merges all lines and then tries to reflow text.

5 years agoMark CHeckinProjectPanel#getCommitMessage() as @NotNull & check usages idea/146.361
Kirill Likhodedov [Fri, 4 Mar 2016 11:59:35 +0000 (14:59 +0300)]
Mark CHeckinProjectPanel#getCommitMessage() as @NotNull & check usages

5 years agoDevKit: IconsReferencesContributor cleanup
Yann Cébron [Fri, 4 Mar 2016 12:08:26 +0000 (13:08 +0100)]
DevKit: IconsReferencesContributor cleanup

5 years agoinspection tool window: create temp old presentation for unused inspection
Dmitry Batkovich [Fri, 4 Mar 2016 12:00:36 +0000 (15:00 +0300)]
inspection tool window: create temp old presentation for unused inspection

5 years agoinspection tool window: show "nothing to view" panel when entry point node is selecte...
Dmitry Batkovich [Fri, 4 Mar 2016 07:26:29 +0000 (10:26 +0300)]
inspection tool window: show "nothing to view" panel when entry point node is selected. show fixes for unused declaration

5 years agoIDEA-139173 DevKit: highlight unresolved icon references appcode/146.360 clion/146.359
Yann Cébron [Fri, 4 Mar 2016 11:39:42 +0000 (12:39 +0100)]
IDEA-139173 DevKit: highlight unresolved icon references
plugin.xml: action/group@icon

5 years ago[java] correct language levels for array stub classes (IDEA-152384)
Roman Shevchenko [Fri, 4 Mar 2016 11:19:22 +0000 (12:19 +0100)]
[java] correct language levels for array stub classes (IDEA-152384)

5 years ago@Presentation#typeName: require title capitalization phpstorm/146.358
Yann Cébron [Fri, 4 Mar 2016 10:49:27 +0000 (11:49 +0100)]
@Presentation#typeName: require title capitalization

5 years agomaven: honor dependency winners (IDEA-133331)
Vladislav.Soroka [Fri, 4 Mar 2016 10:46:33 +0000 (13:46 +0300)]
maven: honor dependency winners (IDEA-133331)

5 years agojavafx: Improve comparison of primitive values in the inspection of redundant FXML...
Pavel Dolgov [Fri, 4 Mar 2016 10:23:07 +0000 (13:23 +0300)]
javafx: Improve comparison of primitive values in the inspection of redundant FXML attributes and tags, test renamed to match the inspection name (IDEA-102276)

5 years agofixed quick eval inside new array creation
Egor.Ushakov [Fri, 4 Mar 2016 10:16:10 +0000 (13:16 +0300)]
fixed quick eval inside new array creation

5 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Fri, 4 Mar 2016 09:45:54 +0000 (10:45 +0100)]
Merge remote-tracking branch 'origin/master'

5 years agoCleanup (better API for overriding PSI factory)
Roman Shevchenko [Fri, 4 Mar 2016 09:45:33 +0000 (10:45 +0100)]
Cleanup (better API for overriding PSI factory)

5 years agoadded with to study EP's
Liana Bakradze [Fri, 4 Mar 2016 09:32:08 +0000 (12:32 +0300)]
added with to study  EP's

5 years agoDon't disable popup on Ctrl+hover for non-navigatable items, just don't change their... appcode/146.357 clion/146.356
Dmitry Batrak [Fri, 4 Mar 2016 08:44:17 +0000 (11:44 +0300)]
Don't disable popup on Ctrl+hover for non-navigatable items, just don't change their style to hyperlink and don't change mouse cursor (required for WEB-13238)

This also restores a condition defining non-navigatable elements created for WEB-4470, which was partially removed for IDEA-108939

5 years agodisable a workaround for a Mac OS JDK issue, when custom JDK with a fix is used idea/146.355
Dmitry Batrak [Fri, 4 Mar 2016 08:05:13 +0000 (11:05 +0300)]
disable a workaround for a Mac OS JDK issue, when custom JDK with a fix is used

5 years agohandle INRE in more actionPerformed calls
peter [Fri, 4 Mar 2016 07:10:44 +0000 (08:10 +0100)]
handle INRE in more actionPerformed calls

5 years agoTransactionGuard: expand javadoc + FAQ, @WrapInTransaction, minor movements
peter [Fri, 4 Mar 2016 07:08:09 +0000 (08:08 +0100)]
TransactionGuard: expand javadoc + FAQ, @WrapInTransaction, minor movements

5 years agoIDEA-152528 Keyboard shortcut input dialog is not repainted properly appcode/146.349 clion/146.345 dbe/146.346 idea/146.348 phpstorm/146.347 pycharm/146.344 pycharm/146.350 rubymine/146.351 webstorm/146.353
Sergey Malenkov [Thu, 3 Mar 2016 19:27:22 +0000 (22:27 +0300)]
IDEA-152528 Keyboard shortcut input dialog is not repainted properly

5 years agoIDEA-149210 Rework IDE notifications
Alexander Lobas [Thu, 3 Mar 2016 18:30:30 +0000 (21:30 +0300)]
IDEA-149210 Rework IDE notifications

5 years agoCleanup (shared instances; unused code)
Roman Shevchenko [Thu, 3 Mar 2016 18:14:07 +0000 (19:14 +0100)]
Cleanup (shared instances; unused code)

5 years agoinline superclass: proceed arrays (IDEA-152539)
Anna Kozlova [Thu, 3 Mar 2016 17:49:12 +0000 (18:49 +0100)]
inline superclass: proceed arrays (IDEA-152539)

5 years agoinline superclass: don't start push refactoring (with find usages, etc) inside inline...
Anna Kozlova [Thu, 3 Mar 2016 17:24:43 +0000 (18:24 +0100)]
inline superclass: don't start push refactoring (with find usages, etc) inside inline; don't collect usages in all inheritors when at the end only one would be processed (IDEA-152480)

5 years agoinline local: search for usages in use-scope, accept non-project files (IDEA-152532)
Anna Kozlova [Thu, 3 Mar 2016 15:41:03 +0000 (16:41 +0100)]
inline local: search for usages in use-scope, accept non-project files (IDEA-152532)

5 years agoinline superclass: skip constructors without body, e.g. kotlin default constructors...
Anna Kozlova [Thu, 3 Mar 2016 15:15:39 +0000 (16:15 +0100)]
inline superclass: skip constructors without body, e.g. kotlin default constructors (IDEA-152476)

5 years agoCleanup (constant)
Roman Shevchenko [Thu, 3 Mar 2016 17:00:33 +0000 (18:00 +0100)]
Cleanup (constant)

5 years agoMerge remote-tracking branch 'origin/master'
Roman Shevchenko [Thu, 3 Mar 2016 16:51:00 +0000 (17:51 +0100)]
Merge remote-tracking branch 'origin/master'

5 years agoCleanup (typo)
Roman Shevchenko [Thu, 3 Mar 2016 16:50:17 +0000 (17:50 +0100)]
Cleanup (typo)

5 years ago[vcs-log] minor: move not null annotation
Julia Beliaeva [Thu, 3 Mar 2016 16:38:45 +0000 (19:38 +0300)]
[vcs-log] minor: move not null annotation

5 years agoIDEA-149210 Rework IDE notifications
Alexander Lobas [Thu, 3 Mar 2016 16:30:55 +0000 (19:30 +0300)]
IDEA-149210 Rework IDE notifications

5 years agoreplace usages of SequenceLock with ReentrantLock
Maxim.Mossienko [Thu, 3 Mar 2016 16:02:43 +0000 (17:02 +0100)]
replace usages of SequenceLock with ReentrantLock

5 years agodiff: do not fail on editors with negative size
Aleksey Pivovarov [Thu, 3 Mar 2016 15:50:17 +0000 (18:50 +0300)]
diff: do not fail on editors with negative size

this can actually happen for some layouts, ex: BorderLayout

5 years agodiff: allow to change proportions in three-side viewer
Aleksey Pivovarov [Wed, 16 Sep 2015 13:56:10 +0000 (16:56 +0300)]
diff: allow to change proportions in three-side viewer

5 years agoWallpaper: do not eat cpu cycles if not configured: but track system property
Gregory.Shrago [Thu, 3 Mar 2016 15:44:22 +0000 (18:44 +0300)]
Wallpaper: do not eat cpu cycles if not configured: but track system property

5 years ago[ui] correct initial state of plugin update info dialog
Roman Shevchenko [Thu, 3 Mar 2016 15:41:32 +0000 (16:41 +0100)]
[ui] correct initial state of plugin update info dialog

Disables "OK" button if no plugins are selected.

5 years agomaven: downgrade maven-resolver-* modules to Java 6 because they are added to classpa...
nik [Thu, 3 Mar 2016 15:39:58 +0000 (18:39 +0300)]
maven: downgrade maven-resolver-* modules to Java 6 because they are added to classpath of maven process which may be started under older Java

5 years agomaven: bombed some maven blinking tests
Vladislav.Soroka [Thu, 3 Mar 2016 15:12:29 +0000 (18:12 +0300)]
maven: bombed some maven blinking tests

5 years agodiff: simplify getting affected side by context
Aleksey Pivovarov [Wed, 24 Feb 2016 08:37:48 +0000 (11:37 +0300)]
diff: simplify getting affected side by context

5 years agofixed PY-15859 Map F1 and help button (if any) of the IPython Notebook console to...
Ekaterina Tuzova [Thu, 3 Mar 2016 15:06:32 +0000 (18:06 +0300)]
fixed PY-15859 Map F1 and help button (if any) of the IPython Notebook console to the specified id

5 years agofixed PY-15718 IPython Notebook: invalid project selected as serving directory in...
Ekaterina Tuzova [Thu, 3 Mar 2016 14:53:55 +0000 (17:53 +0300)]
fixed PY-15718 IPython Notebook: invalid project selected as serving directory in multi-project structure

5 years agofixed editing cell on enter
Ekaterina Tuzova [Thu, 3 Mar 2016 14:23:43 +0000 (17:23 +0300)]
fixed editing cell on enter

do not provide EDITOR, cause it'll catch this typing event

5 years agofixed PY-15045 Newly created cell evaluation
Ekaterina Tuzova [Thu, 3 Mar 2016 14:05:41 +0000 (17:05 +0300)]
fixed PY-15045 Newly created cell evaluation

do not remove cell from update map on empty payload. On payload is executed even on plain code evaluation

5 years agoinspection tool window: throw exception if can't create inspection output dir
Dmitry Batkovich [Thu, 3 Mar 2016 15:02:13 +0000 (18:02 +0300)]
inspection tool window: throw exception if can't create inspection output dir

5 years agoinspection tool window: create inspection xml if no problems
Dmitry Batkovich [Thu, 3 Mar 2016 14:59:17 +0000 (17:59 +0300)]
inspection tool window: create inspection xml if no problems

5 years agomerge: @CalledInAwt
Aleksey Pivovarov [Thu, 3 Mar 2016 13:26:47 +0000 (16:26 +0300)]
merge: @CalledInAwt

5 years agomerge: remove painting on scrollbar background
Aleksey Pivovarov [Thu, 3 Mar 2016 13:10:59 +0000 (16:10 +0300)]
merge: remove painting on scrollbar background

this is no longer necessary, as we use transparent scrollbar for the middle editor now

5 years agodiff: replace helper class with util one
Aleksey Pivovarov [Thu, 3 Mar 2016 13:06:41 +0000 (16:06 +0300)]
diff: replace helper class with util one

5 years agomerge: cleanup - renames
Aleksey Pivovarov [Fri, 26 Feb 2016 15:18:05 +0000 (18:18 +0300)]
merge: cleanup - renames

5 years agomerge: remove duplication
Aleksey Pivovarov [Fri, 26 Feb 2016 15:18:05 +0000 (18:18 +0300)]
merge: remove duplication

5 years agomerge: cleanup
Aleksey Pivovarov [Fri, 26 Feb 2016 14:54:33 +0000 (17:54 +0300)]
merge: cleanup

5 years agomerge: simplify highligters update
Aleksey Pivovarov [Thu, 3 Mar 2016 12:15:22 +0000 (15:15 +0300)]
merge: simplify highligters update

* update inner highlighters independently

5 years agodiff: cleanup
Aleksey Pivovarov [Fri, 26 Feb 2016 14:37:42 +0000 (17:37 +0300)]
diff: cleanup

5 years agomerge: better range painting for right-only modifications
Aleksey Pivovarov [Fri, 26 Feb 2016 14:19:27 +0000 (17:19 +0300)]
merge: better range painting for right-only modifications

do not paint in gutter background of middle editor for right-only changes, if there are no line numbers shown

5 years agogradle: fix orphaned data computation
Vladislav.Soroka [Thu, 3 Mar 2016 14:45:55 +0000 (17:45 +0300)]
gradle: fix orphaned data computation