idea/community.git
9 years agoMerge remote-tracking branch 'origin/master'
Dmitry Trofimov [Mon, 18 Feb 2013 20:07:35 +0000 (21:07 +0100)]
Merge remote-tracking branch 'origin/master'

9 years agoCleanup
Roman Shevchenko [Mon, 18 Feb 2013 19:36:52 +0000 (20:36 +0100)]
Cleanup

9 years agoCR-IC-92 (*Impl abuse corrected)
Roman Shevchenko [Mon, 18 Feb 2013 19:22:51 +0000 (20:22 +0100)]
CR-IC-92 (*Impl abuse corrected)

9 years agoCR-IC-92 (wandering DirectoryIndexImpl returned to platform; obsolete classes dropped)
Roman Shevchenko [Mon, 18 Feb 2013 18:42:14 +0000 (19:42 +0100)]
CR-IC-92 (wandering DirectoryIndexImpl returned to platform; obsolete classes dropped)

9 years agohandle Groovy Shell running problems (e.g. misconfigured jdk) (EA-41168)
peter [Mon, 18 Feb 2013 18:00:52 +0000 (19:00 +0100)]
handle Groovy Shell running problems (e.g. misconfigured jdk) (EA-41168)

9 years agoPsiMultiReference.toString (diagnose EA-41947)
peter [Mon, 18 Feb 2013 17:51:14 +0000 (18:51 +0100)]
PsiMultiReference.toString (diagnose EA-41947)

9 years agoincorrect reference range diagnostics (EA-42507)
peter [Mon, 18 Feb 2013 17:45:52 +0000 (18:45 +0100)]
incorrect reference range diagnostics (EA-42507)

9 years agofix "IncorrectOperationException: No line comment prefix defined for language HTML...
peter [Mon, 18 Feb 2013 17:07:06 +0000 (18:07 +0100)]
fix "IncorrectOperationException: No line comment prefix defined for language HTML" (EA-42780)

9 years agofix IOOBE (EA-42811)
peter [Mon, 18 Feb 2013 16:56:20 +0000 (17:56 +0100)]
fix IOOBE (EA-42811)

9 years agothere are no \r's in documents
peter [Mon, 18 Feb 2013 16:55:59 +0000 (17:55 +0100)]
there are no \r's in documents

9 years agoremove unused methods
peter [Mon, 18 Feb 2013 16:55:12 +0000 (17:55 +0100)]
remove unused methods

9 years agodiagnostics for inconsistent TemplateState (EA-42819)
peter [Mon, 18 Feb 2013 16:52:23 +0000 (17:52 +0100)]
diagnostics for inconsistent TemplateState (EA-42819)

9 years agodiagnostics for elements with null range (EA-43121)
peter [Mon, 18 Feb 2013 16:33:23 +0000 (17:33 +0100)]
diagnostics for elements with null range (EA-43121)

9 years agocalculate identifier end offset based on document text, not file's (EA-43209)
peter [Mon, 18 Feb 2013 16:29:52 +0000 (17:29 +0100)]
calculate identifier end offset based on document text, not file's (EA-43209)

9 years agofor a wrong date/time format, output an error message, don't log an error (EA-43511)
peter [Mon, 18 Feb 2013 15:56:14 +0000 (16:56 +0100)]
for a wrong date/time format, output an error message, don't log an error (EA-43511)

9 years agodon't try to render invalid lookup elements (EA-43983)
peter [Mon, 18 Feb 2013 15:42:13 +0000 (16:42 +0100)]
don't try to render invalid lookup elements (EA-43983)

9 years agoMerge branch 'master' of git.labs.intellij.net:idea/community
Michael Golubev [Mon, 18 Feb 2013 17:53:46 +0000 (18:53 +0100)]
Merge branch 'master' of git.labs.intellij.net:idea/community

9 years agoIDEA-101128 - Error while creating a new cluster in AWS Manager - move warningDecorat...
Michael Golubev [Mon, 18 Feb 2013 17:43:07 +0000 (18:43 +0100)]
IDEA-101128 - Error while creating a new cluster in AWS Manager - move warningDecorator icon to platform icons

9 years agoAction text fixed
Roman Shevchenko [Mon, 18 Feb 2013 17:42:49 +0000 (18:42 +0100)]
Action text fixed

9 years agolambda: inference from formal params fixed (IDEA-101176)
anna [Mon, 18 Feb 2013 17:13:09 +0000 (18:13 +0100)]
lambda: inference from formal params fixed (IDEA-101176)

9 years agoEA-44003 - SOE: PsiResolveHelperImpl.inferBySubtypingConstraint
anna [Mon, 18 Feb 2013 11:48:57 +0000 (12:48 +0100)]
EA-44003 - SOE: PsiResolveHelperImpl.inferBySubtypingConstraint

9 years agotrack modification stamp to restart the lexer in order to avoid unexpected lexer...
Maxim.Mossienko [Mon, 18 Feb 2013 16:51:56 +0000 (17:51 +0100)]
track modification stamp to restart the lexer in order to avoid unexpected lexer assertions from edited code (EA-30079, EA-43510 ) review+ CR-IC

9 years agoIDEA-101362 New Project Wizard: selecting Java Module does not suggest technologies...
Dmitry Avdeev [Mon, 18 Feb 2013 16:19:15 +0000 (20:19 +0400)]
IDEA-101362 New Project Wizard: selecting Java Module does not suggest technologies page

9 years agotoString()
Dmitry Avdeev [Mon, 18 Feb 2013 15:20:46 +0000 (19:20 +0400)]
toString()

9 years agoFixed thread leak in multiprocess debugger.
Dmitry Trofimov [Mon, 18 Feb 2013 16:31:08 +0000 (17:31 +0100)]
Fixed thread leak in multiprocess debugger.

9 years agoDisposal of consoleView depends on contentDescriptor.
Dmitry Trofimov [Mon, 18 Feb 2013 16:30:12 +0000 (17:30 +0100)]
Disposal of consoleView depends on contentDescriptor.

9 years agoIDEA-25146 Maven integration, resolve dependencies from project
Sergey Evdokimov [Mon, 18 Feb 2013 16:28:25 +0000 (20:28 +0400)]
IDEA-25146 Maven integration, resolve dependencies from project

9 years agodrop duplicate registration
Gregory.Shrago [Mon, 18 Feb 2013 16:03:07 +0000 (20:03 +0400)]
drop duplicate registration

9 years agoWEB-6698 java.lang.ClassNotFoundException: com.intellij.openapi.projectRoots.JdkPopup... cidr/126.297
Vassiliy Kudryashov [Mon, 18 Feb 2013 15:44:52 +0000 (19:44 +0400)]
WEB-6698 java.lang.ClassNotFoundException: com.intellij.openapi.projectRoots.JdkPopupAction on File/Open

9 years agorenaming fields / locals for better understanding code +review CR-IC
Maxim.Mossienko [Mon, 18 Feb 2013 15:20:35 +0000 (16:20 +0100)]
renaming fields / locals for better understanding code +review CR-IC

9 years agofindInPath utility method
Sergey Simonchik [Mon, 18 Feb 2013 14:53:35 +0000 (18:53 +0400)]
findInPath utility method

9 years agoin completion usage recency, less is better
peter [Mon, 18 Feb 2013 14:25:22 +0000 (15:25 +0100)]
in completion usage recency, less is better

9 years agoStatisticsInfo.toString which doesn't cause SOE
peter [Mon, 18 Feb 2013 14:24:48 +0000 (15:24 +0100)]
StatisticsInfo.toString which doesn't cause SOE

9 years agoa bit more comprehensive comment in MinusculeMatcher.matchingDegree
peter [Mon, 18 Feb 2013 13:58:00 +0000 (14:58 +0100)]
a bit more comprehensive comment in MinusculeMatcher.matchingDegree

9 years agouse CharArrayUtil.indexOf instead of StringUtil.indexOf
peter [Mon, 18 Feb 2013 13:29:44 +0000 (14:29 +0100)]
use CharArrayUtil.indexOf instead of StringUtil.indexOf

9 years agoSpeedSearchObjectWithWeight: less garbage, make field private
peter [Mon, 18 Feb 2013 13:25:13 +0000 (14:25 +0100)]
SpeedSearchObjectWithWeight: less garbage, make field private

9 years agoallow to save documents with lookup open unless trailing whitespace stripping will...
peter [Mon, 18 Feb 2013 12:46:27 +0000 (13:46 +0100)]
allow to save documents with lookup open unless trailing whitespace stripping will really cause the lookup to close (IDEA-101293)

9 years agoExtract loadBranchesInBackgroundableAndExecuteAction method to a separate util class.
Nadya.Zabrodina [Mon, 18 Feb 2013 13:26:19 +0000 (17:26 +0400)]
Extract loadBranchesInBackgroundableAndExecuteAction method to a separate util class.

*Add consumer to argument list to handle success.

9 years agoIDEA-96525 now it is possible to import android module which doesn't contain sources...
Eugene Kudelevsky [Mon, 18 Feb 2013 13:21:16 +0000 (17:21 +0400)]
IDEA-96525 now it is possible to import android module which doesn't contain sources, or import a project containing such module

9 years agoIcon on gutter for two colors
Vassiliy Kudryashov [Mon, 18 Feb 2013 13:13:19 +0000 (17:13 +0400)]
Icon on gutter for two colors

9 years agoprocessing workspace.xml
Dmitry Avdeev [Mon, 18 Feb 2013 13:10:20 +0000 (17:10 +0400)]
processing workspace.xml

9 years agoDarcula colors for file status (IDEA-96595, IDEA-97351, IDEA-96647, IDEA-99313)
Konstantin Bulenkov [Mon, 18 Feb 2013 12:29:59 +0000 (13:29 +0100)]
Darcula colors for file status (IDEA-96595, IDEA-97351, IDEA-96647, IDEA-99313)

9 years agoproject view: show path to content root directory instead of path to .idea directory...
nik [Mon, 18 Feb 2013 12:19:27 +0000 (16:19 +0400)]
project view: show path to content root directory instead of path to .idea directory for root module nodes

9 years agotemplate processing fixed
Dmitry Avdeev [Mon, 18 Feb 2013 12:18:27 +0000 (16:18 +0400)]
template processing fixed

9 years agoNPE fixed
Dmitry Avdeev [Mon, 18 Feb 2013 12:06:41 +0000 (16:06 +0400)]
NPE fixed

9 years agometadata
Dmitry Avdeev [Mon, 18 Feb 2013 11:56:06 +0000 (15:56 +0400)]
metadata

9 years agoIDEA-101258 WIndows: Suggest installed JDKs in filechooser
Vassiliy Kudryashov [Mon, 18 Feb 2013 11:45:13 +0000 (15:45 +0400)]
IDEA-101258 WIndows: Suggest installed JDKs in filechooser

9 years agoupdate for darcula and retina devices
Konstantin Bulenkov [Mon, 18 Feb 2013 10:55:50 +0000 (11:55 +0100)]
update for darcula and retina devices

9 years agoCleanup
Roman Shevchenko [Mon, 18 Feb 2013 10:57:58 +0000 (11:57 +0100)]
Cleanup

9 years agoRemoved unnecessary method validateOptions() and setOkActionEnabled method call.
Nadya.Zabrodina [Mon, 18 Feb 2013 10:52:48 +0000 (14:52 +0400)]
Removed unnecessary method validateOptions() and setOkActionEnabled method call.

*There is nothing to validate in this dialog.

9 years agoFix VFS children loading
Roman Shevchenko [Mon, 18 Feb 2013 10:47:54 +0000 (11:47 +0100)]
Fix VFS children loading

9 years agocleanup
Alexey Kudravtsev [Fri, 15 Feb 2013 15:32:04 +0000 (19:32 +0400)]
cleanup

9 years agonotnull
Alexey Kudravtsev [Fri, 15 Feb 2013 12:04:45 +0000 (16:04 +0400)]
notnull

9 years agonotnull
Alexey Kudravtsev [Fri, 15 Feb 2013 11:44:57 +0000 (15:44 +0400)]
notnull

9 years agomoved off the testFramework, made thread-safe
Alexey Kudravtsev [Fri, 15 Feb 2013 10:31:30 +0000 (14:31 +0400)]
moved off the testFramework, made thread-safe

9 years agomoved off the testFramework, made thread-safe
Alexey Kudravtsev [Fri, 15 Feb 2013 10:30:49 +0000 (14:30 +0400)]
moved off the testFramework, made thread-safe

9 years agonotnull
Alexey Kudravtsev [Fri, 15 Feb 2013 10:28:17 +0000 (14:28 +0400)]
notnull

9 years agoskip inference from parent for diamond's search for constructor (IDEA-101166)
anna [Mon, 18 Feb 2013 10:29:40 +0000 (11:29 +0100)]
skip inference from parent for diamond's search for constructor (IDEA-101166)

9 years agoEA-43977 - NPE: UnwrapTagFix.applyFix
anna [Mon, 18 Feb 2013 08:59:13 +0000 (09:59 +0100)]
EA-43977 - NPE: UnwrapTagFix.applyFix

9 years agoIDEA-101151 Gradle: Do not default to 'use local gradle distribution' when it's not...
Denis.Zhdanov [Mon, 18 Feb 2013 10:28:32 +0000 (14:28 +0400)]
IDEA-101151 Gradle: Do not default to 'use local gradle distribution' when it's not necessary

1. Remove 'prefer wrapper to local' from default project settings;
2. Select 'use wrapper' by default for every wrapper-aware project on importing;

9 years agoEmmet
Alexander Zolotov [Mon, 18 Feb 2013 10:18:37 +0000 (14:18 +0400)]
Emmet
 - Added XSL declaration snippet
 - Add missing css snippets

9 years agosave project as template: custom file processing phpstorm/126.296
Dmitry Avdeev [Mon, 18 Feb 2013 10:03:58 +0000 (14:03 +0400)]
save project as template: custom file processing

9 years agoBomd bad test
Sergey Evdokimov [Mon, 18 Feb 2013 10:03:03 +0000 (14:03 +0400)]
Bomd bad test

9 years ago[diff] Simplify, fix warnings, fix code style.
Kirill Likhodedov [Mon, 18 Feb 2013 09:59:15 +0000 (13:59 +0400)]
[diff] Simplify, fix warnings, fix code style.

9 years ago[diff] Go to source on Ctrl/Cmd+Click on line number of local version
Kirill Likhodedov [Mon, 18 Feb 2013 09:57:36 +0000 (13:57 +0400)]
[diff] Go to source on Ctrl/Cmd+Click on line number of local version

Go to source was previously executed on plain click, but it provided
a lot of confusion and was removed: IDEA-100782.

But some users miss this feature: IDEA-101289.
For them use Ctrl/Cmd+Click (as in Go to declaration in the editor).

9 years agoRevert "[diff] Stop "Go to source" on click on local version in the diff dialog."
Kirill Likhodedov [Mon, 18 Feb 2013 08:53:00 +0000 (12:53 +0400)]
Revert "[diff] Stop "Go to source" on click on local version in the diff dialog."

This reverts commit e74b321e79f92074e4b0763c4546d5fc7b0d9efe.

User requests this functionality to be kept, but with Ctrl/Alt+Click IDEA-101289
The change from Click to Ctrl/Alt+Click will follow.

9 years agoFix spellchecker tests
Roman Shevchenko [Mon, 18 Feb 2013 09:41:25 +0000 (10:41 +0100)]
Fix spellchecker tests

9 years agoRUBY-13086: (code cleanup) let's use ContainerUtil
Oleg Sukhodolsky [Mon, 18 Feb 2013 08:39:38 +0000 (12:39 +0400)]
RUBY-13086: (code cleanup) let's use ContainerUtil

9 years agoRUBY-13086: (refactoring) textAvailable(@NotNull List<Pair<String, Key>>) introduce...
Oleg Sukhodolsky [Mon, 18 Feb 2013 07:46:28 +0000 (11:46 +0400)]
RUBY-13086: (refactoring)   textAvailable(@NotNull List<Pair<String, Key>>) introduced to allow future performance optimization

9 years ago[github] Fix connection timeout value. IDEA-101292
Kirill Likhodedov [Sat, 16 Feb 2013 13:04:30 +0000 (17:04 +0400)]
[github] Fix connection timeout value. IDEA-101292

Set connection timeout params on the connection manager instead of
setting them on the client.

Setting these params on the client has no effect, because HttpConnection
is created in HttpMethodDirector#executeMethod, and it inherits params
from the HttpConnectionManager.

Connection parameters are applied to the HttpConnection from
HttpMethod (which inherits them from HttpClient) only AFTER connection
is open, see HttpMethodDirector#executeWithRetry (this.conn.open()
and only then applyConnectionParams()), but the SO_TIMEOUT is already
needed when _opening_ connection.

9 years ago[github] Notify about concrete error. IDEA-76963
Kirill Likhodedov [Sat, 16 Feb 2013 11:51:44 +0000 (15:51 +0400)]
[github] Notify about concrete error. IDEA-76963

Instead of just saying "Cannot login with given credentials", show the
exact reason why login has failed.

* Don't catch IOException early (in retrieveCurrentUserInfo), pass it
  through to the GUI clients and show the error in UI: via a Message
  in the Settings; via the error label in GithubLoginDialog; via
  Notifications in other places.
* For this use ThrowableComputable instead of Computable where needed.
* Leave one call untouched as an exception: checkCredentials is designed
  as a quick-check of credentials and connection validity, so let it
  return boolean as it was.

9 years ago[github] Show only own repositories in the checkout dialog.
Kirill Likhodedov [Fri, 15 Feb 2013 17:18:05 +0000 (21:18 +0400)]
[github] Show only own repositories in the checkout dialog.

Don't query and show starred repositories there.

Motivation:
* In contrast with hosted GitHub, GitHub enterprise API doesn't return
  own repositories in /user/starred even if they are starred:
  http://youtrack.jetbrains.com/issue/IDEA-100618#comment=27-445958
  That causes a serious problem that own repositories are unavailable
  in the checkout dialog combobox.
* User can create a repository but not star it, and it won't be listed
  even with hosted GitHub.
* GitHub returns only 30 repositories (IDEA-89630) which causes problems
  and we don't want starred (less important) repositories interfere with
  own (more important) repositories.

9 years agoMacros with parameters
Fedor Korotkov [Sun, 17 Feb 2013 18:35:00 +0000 (22:35 +0400)]
Macros with parameters

9 years agocheck whether target scope contains module-based targets only cidr/126.294 idea/126.295 phpstorm/126.291 pycharm/126.292 rubymine/126.293 storm/126.290
Eugene Zhuravlev [Sun, 17 Feb 2013 17:26:06 +0000 (18:26 +0100)]
check whether target scope contains module-based targets only

9 years agoUse ParametersList to parse goals list
Sergey Evdokimov [Sun, 17 Feb 2013 16:41:02 +0000 (20:41 +0400)]
Use ParametersList to parse goals list

9 years agohasworktodo is checked only for module-based targets
Eugene Zhuravlev [Sun, 17 Feb 2013 15:58:25 +0000 (16:58 +0100)]
hasworktodo is checked only for module-based targets

9 years agoavoid using reflection based mergeArrays phpstorm/126.289
Alexey Gopachenko [Sun, 17 Feb 2013 13:57:29 +0000 (14:57 +0100)]
avoid using reflection based mergeArrays

9 years agoEnv tests work with remote python interpreters. cidr/126.284 idea/126.285 phpstorm/126.283 phpstorm/126.288 pycharm/126.287 rubymine/126.286 storm/126.282
Dmitry Trofimov [Sat, 16 Feb 2013 21:20:10 +0000 (22:20 +0100)]
Env tests work with remote python interpreters.

9 years agoEA-37608 - ASE: ArrayUtil.append
Maxim.Mossienko [Sat, 16 Feb 2013 10:03:34 +0000 (11:03 +0100)]
EA-37608 - ASE: ArrayUtil.append

9 years agofix css completion tests phpstorm/126.281
peter [Sat, 16 Feb 2013 09:04:31 +0000 (10:04 +0100)]
fix css completion tests

9 years agoavoid using reflection based instanceof cidr/126.277 idea/126.280 phpstorm/126.276 pycharm/126.279 rubymine/126.278 storm/126.275
Alexey Gopachenko [Fri, 15 Feb 2013 23:58:01 +0000 (00:58 +0100)]
avoid using reflection based instanceof

9 years agonew inference: subtyping constraint (IDEA-101166)
anna [Fri, 15 Feb 2013 20:37:29 +0000 (21:37 +0100)]
new inference: subtyping constraint (IDEA-101166)

9 years agograph inference: avoid empty map cache when processor throws exception
anna [Fri, 15 Feb 2013 20:28:25 +0000 (21:28 +0100)]
graph inference: avoid empty map cache when processor throws exception

9 years agoRUBY-13086: performance improvement
Oleg Sukhodolsky [Fri, 15 Feb 2013 11:32:40 +0000 (15:32 +0400)]
RUBY-13086: performance improvement
We have to add all text we've got at once to avoid overhead Document provides for every insertion (it fires document events and update UI)

9 years agoIDEA-101201 (awful GitHub login dialog fixed)
Roman Shevchenko [Fri, 15 Feb 2013 19:08:24 +0000 (20:08 +0100)]
IDEA-101201 (awful GitHub login dialog fixed)

9 years agofix path to spellchecker iml phpstorm/126.274
Dmitry Jemerov [Fri, 15 Feb 2013 17:34:15 +0000 (18:34 +0100)]
fix path to spellchecker iml

9 years agospellchecker is no longer a plugin, move it out of the plugins directory
Dmitry Jemerov [Fri, 15 Feb 2013 17:33:18 +0000 (18:33 +0100)]
spellchecker is no longer a plugin, move it out of the plugins directory

9 years agoOC-5530 Extract variable adds const to variable name
Alexander Kirillin [Fri, 15 Feb 2013 17:53:04 +0000 (21:53 +0400)]
OC-5530 Extract variable adds const to variable name

9 years agodisable jdk detection on every startup on Win
anna [Fri, 15 Feb 2013 17:57:27 +0000 (18:57 +0100)]
disable jdk detection on every startup on Win

9 years agoFix NPE in dispose.
Nadya.Zabrodina [Fri, 15 Feb 2013 17:53:08 +0000 (21:53 +0400)]
Fix NPE in dispose.

*Deactivate before dispose.
*Shouldn't deactivate status widget if already disposed.(checking added)

9 years agofix method hierarchy with default methods: mark method to implement if it abstract...
anna [Fri, 15 Feb 2013 17:27:13 +0000 (18:27 +0100)]
fix method hierarchy with default methods: mark method to implement if it abstract and overrides default method (IDEA-101167)

9 years agomake file structure popup matching use common matchingDegree heuristics
peter [Fri, 15 Feb 2013 17:13:31 +0000 (18:13 +0100)]
make file structure popup matching use common matchingDegree heuristics

9 years agocamel hump start shouldn't matter for matching degree, its index should (IDEA-93469)
peter [Fri, 15 Feb 2013 17:03:55 +0000 (18:03 +0100)]
camel hump start shouldn't matter for matching degree, its index should (IDEA-93469)

9 years agoexplicitly save disabled live template contexts when no default is provided (IDEA...
peter [Fri, 15 Feb 2013 16:08:32 +0000 (17:08 +0100)]
explicitly save disabled live template contexts when no default is provided (IDEA-101007)

9 years agolive templates: don't show "Applicable in: Everywhere" when the user has chose "Other"
peter [Fri, 15 Feb 2013 15:39:57 +0000 (16:39 +0100)]
live templates: don't show "Applicable in: Everywhere" when the user has chose "Other"

9 years agoIDEA-100933 "Undefined path variables" message looks too dangerous and is unclear
peter [Fri, 15 Feb 2013 14:21:38 +0000 (15:21 +0100)]
IDEA-100933 "Undefined path variables" message looks too dangerous and is unclear

9 years agoIDEA-101258 WIndows: Suggest installed JDKs in filechooser
Vassiliy Kudryashov [Fri, 15 Feb 2013 17:29:17 +0000 (21:29 +0400)]
IDEA-101258 WIndows: Suggest installed JDKs in filechooser

9 years agoexperimental: using CMS GC for build process by default
Eugene Zhuravlev [Fri, 15 Feb 2013 16:58:40 +0000 (17:58 +0100)]
experimental: using CMS GC for build process by default

9 years agoRestore selection after open another designer
Alexander Lobas [Fri, 15 Feb 2013 17:13:30 +0000 (21:13 +0400)]
Restore selection after open another designer

9 years agoimprove ConfigFilesTreeBuilder.getFileTypeNodeName() presentation
Yann Cébron [Fri, 15 Feb 2013 15:22:05 +0000 (16:22 +0100)]
improve ConfigFilesTreeBuilder.getFileTypeNodeName() presentation