10 months agoMerge Android Studio 4.0 (aosp/studio-master-dev)
Andrei Kuznetsov [Fri, 12 Jun 2020 14:08:38 +0000 (17:08 +0300)]
Merge Android Studio 4.0 (aosp/studio-master-dev)

GitOrigin-RevId: 858408de3e0ab02ce955119c602f5fd1812b4ac1

11 months agoexclude forward index in shared index
Dmitry Batkovich [Tue, 2 Jun 2020 12:51:31 +0000 (15:51 +0300)]
exclude forward index in shared index

GitOrigin-RevId: 9d248859a0335fb6b52099b3f640328ea64fbf71

11 months agoFix IAE - FastUtil HashStrategy#equals should allow null arguments.
Piotr Tomiak [Tue, 2 Jun 2020 12:47:25 +0000 (14:47 +0200)]
Fix IAE - FastUtil HashStrategy#equals should allow null arguments.

GitOrigin-RevId: a03638942831b6e8e1420311afd342103e2d4037

11 months agoIDEA-CR-63232 Properly obtain psiFile for the EditorWindow
Alexandr Evstigneev [Tue, 2 Jun 2020 12:24:27 +0000 (15:24 +0300)]
IDEA-CR-63232 Properly obtain psiFile for the EditorWindow

GitOrigin-RevId: 157c0524d68fac7c8dd3ab851702549ca26c01d4

11 months agoCachedValue: spare an array allocation for the most ubiquitous dependency kind
Peter Gromov [Tue, 2 Jun 2020 12:18:26 +0000 (14:18 +0200)]
CachedValue: spare an array allocation for the most ubiquitous dependency kind

GitOrigin-RevId: e713a6c5c2945aec0cd45793a892a1266fc3e880

11 months agoCachedValuesManagerImpl: save a bit of CPU by not tracking holders which are invalida...
Peter Gromov [Tue, 2 Jun 2020 12:17:37 +0000 (14:17 +0200)]
CachedValuesManagerImpl: save a bit of CPU by not tracking holders which are invalidated on plugin unload anyway

GitOrigin-RevId: c146c589be54753629c8d5e4f11968959ac269a5

11 months agoCachedValueProfiler micro-optimization: don't remove from empty map
Peter Gromov [Tue, 2 Jun 2020 12:16:53 +0000 (14:16 +0200)]
CachedValueProfiler micro-optimization: don't remove from empty map

it still calculates hashcode and traverses some internals

GitOrigin-RevId: 97a376f2c097ed3aa50c1ba517962c568d94ce76

11 months agoEditorPainter: improve SLIGHTLY_WIDER_BOX painting (IDEA-CR-63129, IDEA-64606)
Peter Gromov [Tue, 2 Jun 2020 12:15:22 +0000 (14:15 +0200)]
EditorPainter: improve SLIGHTLY_WIDER_BOX painting (IDEA-CR-63129, IDEA-64606)

GitOrigin-RevId: c6b0f27a5b2e1db17cadd9bd2b0d9111b9f5a023

11 months ago[workspace model] WM-T-52 Set proper module file path for JpsImportedEntitySource
Mikhail Mazurkevich [Tue, 2 Jun 2020 11:50:35 +0000 (14:50 +0300)]
[workspace model] WM-T-52 Set proper module file path for JpsImportedEntitySource

GitOrigin-RevId: 54479335b34196f49e53e439239c9a7e8ed2d6cb

11 months ago[workspace model] Ignore performance tests
Mikhail Mazurkevich [Tue, 2 Jun 2020 11:48:47 +0000 (14:48 +0300)]
[workspace model] Ignore performance tests

GitOrigin-RevId: 45805385f8cf7498121a0562b989ab7a48261594

11 months agoMarked TemplateActionContext#getEditor as internal
Alexandr Evstigneev [Tue, 2 Jun 2020 11:37:05 +0000 (14:37 +0300)]
Marked TemplateActionContext#getEditor as internal

We may have problems with EDT bounding and want to change this

GitOrigin-RevId: a3d0579c48e5e9112b0281ab3004e08a1638fe39

11 months agolive templates: highlight variables likely to be stopped at (IDEA-64606)
Peter Gromov [Tue, 2 Jun 2020 11:38:12 +0000 (13:38 +0200)]
live templates: highlight variables likely to be stopped at (IDEA-64606)

GitOrigin-RevId: adb73e81798da4af8a2664b26ef4c6d4ff0bc55c

11 months agoui: use fallback font in text inlays if needed
Aleksey Pivovarov [Wed, 13 May 2020 17:46:42 +0000 (20:46 +0300)]
ui: use fallback font in text inlays if needed

GitOrigin-RevId: c0de80bee0e0403dc63a3a44b8b82262be20af06

11 months agojavadoc for StubBuilder.skipChildProcessingWhenBuildingStubs
Peter Gromov [Tue, 2 Jun 2020 11:32:22 +0000 (13:32 +0200)]
javadoc for StubBuilder.skipChildProcessingWhenBuildingStubs

GitOrigin-RevId: 9ddb2b5794912bfa33551e45aafc9f396432a4ae

11 months ago[analysis] IDEA-240049 Don't report "foreach not applicable" if type being iterated...
Nikita Eshkeev [Tue, 2 Jun 2020 11:25:16 +0000 (14:25 +0300)]
[analysis] IDEA-240049 Don't report "foreach not applicable" if type being iterated is unresolved

This patch filters out the primitive types from ignoring in reporting of
"foreach not applicable"

Signed-off-by: Nikita Eshkeev <>
GitOrigin-RevId: 0eeff79c39bc3816345b4840da1229f8bc8ef0bf

11 months agomore efficient CodeInsightSettings service implementation (modification tracking...
Vladimir Krivosheev [Tue, 2 Jun 2020 11:04:38 +0000 (13:04 +0200)]
more efficient CodeInsightSettings service implementation (modification tracking, schedule save on quickfix)

GitOrigin-RevId: dc8bbe89b26a61112c7971a257907b96dc71dde0

11 months ago[vcs] use IdeActions.ACTION_CHECKIN_PROJECT constant
Julia Beliaeva [Tue, 2 Jun 2020 10:56:56 +0000 (13:56 +0300)]
[vcs] use IdeActions.ACTION_CHECKIN_PROJECT constant

follow-up: 4aea2e3e24ce0df8d88ab2c8367e75ff950c0d56

GitOrigin-RevId: cde1fc778d1501de7fdc3fc604786dc5f22accc1

11 months ago[git] update only notifications from GitEditorPromo
Julia Beliaeva [Tue, 2 Jun 2020 10:52:48 +0000 (13:52 +0300)]
[git] update only notifications from GitEditorPromo

follow-up: 4aea2e3e24ce0df8d88ab2c8367e75ff950c0d56

GitOrigin-RevId: 380b1cf0ed72648827ea7a9a6875128901da5728

11 months ago[ide] use specific parameter type
Julia Beliaeva [Tue, 2 Jun 2020 10:50:32 +0000 (13:50 +0300)]
[ide] use specific parameter type

follow-up: 4aea2e3e24ce0df8d88ab2c8367e75ff950c0d56

GitOrigin-RevId: cbe42d7b3d963084e835e1a2b6931e84c7288791

11 months agodon't duplicate injected files for one place under memory pressure
Peter Gromov [Tue, 2 Jun 2020 09:58:20 +0000 (11:58 +0200)]
don't duplicate injected files for one place under memory pressure

GitOrigin-RevId: 2bd3f23a62dc3a613b08c3e3fedc340e65f3f3c1

11 months agoLAB-31 move PsiReferenceServiceImpl service to CoreImpl
Sergey Stupin [Tue, 2 Jun 2020 10:52:33 +0000 (12:52 +0200)]
LAB-31 move PsiReferenceServiceImpl service to CoreImpl

GitOrigin-RevId: 548a3a2b11aa3ece6f1f9b7376622f3240fa7022

11 months agoreverted [add dockers "tc-okhttp-stream" to wellKnownOffenders threads]
Andrey Vokin [Tue, 2 Jun 2020 11:12:32 +0000 (13:12 +0200)]
reverted [add dockers "tc-okhttp-stream" to wellKnownOffenders threads]

GitOrigin-RevId: 7b9ed0dce133a504be447efbeb740eb2afa344c0

11 months agofix maven resume from-build
Alexander Bubenchikov [Tue, 2 Jun 2020 11:02:07 +0000 (14:02 +0300)]
fix maven resume from-build

GitOrigin-RevId: a089accd4cd2bd03b94aad226d4ce569452ab7ec

11 months agoRevert "OC-20199 Swift: get back old name"
Max Medvedev [Tue, 2 Jun 2020 11:01:37 +0000 (14:01 +0300)]
Revert "OC-20199 Swift: get back old name"

This reverts commit 8212991a

GitOrigin-RevId: ddb5a3f24defcb21f4afc566fe33aa727e368f38

11 months agoOC-20199 Swift: get back old name
Max Medvedev [Tue, 2 Jun 2020 10:52:08 +0000 (13:52 +0300)]
OC-20199 Swift: get back old name

GitOrigin-RevId: 8212991a1a24d9e5214edc8618a07b81c898bb93

11 months agogit: fix comment typo
Aleksey Pivovarov [Tue, 2 Jun 2020 10:54:29 +0000 (13:54 +0300)]
git: fix comment typo

GitOrigin-RevId: 315121336fe9a42413cb489573f463fad02994ee

11 months agoIDEA-241919 IDEA-172253 git: fix merge for projects under WSL file system
Aleksey Pivovarov [Tue, 2 Jun 2020 10:34:18 +0000 (13:34 +0300)]
IDEA-241919 IDEA-172253 git: fix merge for projects under WSL file system

GitOrigin-RevId: be3eb98d74def34a158fcbf27fda627af5276c14

11 months agoInject XPath into new since 9 javax.xml.xpath.XPath methods (IDEA-211744)
Bas Leijdekkers [Tue, 2 Jun 2020 10:43:28 +0000 (12:43 +0200)]
Inject XPath into new since 9 javax.xml.xpath.XPath methods (IDEA-211744)

GitOrigin-RevId: da36e43b0f2d86cea226bc8fc1c7024e567bc522

11 months agoIG: remove long obsolete "Malformed XPath expression" inspection (IDEA-242274)
Bas Leijdekkers [Tue, 2 Jun 2020 08:22:15 +0000 (10:22 +0200)]
IG: remove long obsolete "Malformed XPath expression" inspection (IDEA-242274)

GitOrigin-RevId: e8d01bb6c6d7a0d6ebfbed087006be6437fa3d75

11 months ago[symbol] add entry point for creating presentation for symbol
Daniil Ovchinnikov [Tue, 2 Jun 2020 10:00:01 +0000 (13:00 +0300)]
[symbol] add entry point for creating presentation for symbol

GitOrigin-RevId: 621bb805d64a68bef0b16e510f761d871d7dc638

11 months agoadd dockers "tc-okhttp-stream" to wellKnownOffenders threads
Andrey Vokin [Tue, 2 Jun 2020 10:39:42 +0000 (12:39 +0200)]
add dockers "tc-okhttp-stream" to wellKnownOffenders threads

GitOrigin-RevId: 97258316955bb5d0352e4189a8d0b5de933f237c

11 months agoFixed NPE when substituting template in the EditorWindow
Alexandr Evstigneev [Tue, 2 Jun 2020 09:00:37 +0000 (12:00 +0300)]
Fixed NPE when substituting template in the EditorWindow

Also - better debugging when can't obtain a file

Caused by fc62a8f7e9947d58ea25576b84bfd7140f0aa782

Prior this change, we substituted in the TemplateState and it's created with topLevelEditor

GitOrigin-RevId: aa478a3b7402961819fe86771efab16c10ae4812

11 months agofix maven ext tests
Alexander Bubenchikov [Tue, 2 Jun 2020 10:27:05 +0000 (13:27 +0300)]
fix maven ext tests

GitOrigin-RevId: 4c191d1d3d95a45ca66dd3b8b093d81795ba4604

11 months agoindexes: support nested index switcher calls 2
Dmitry Batkovich [Tue, 2 Jun 2020 08:22:59 +0000 (11:22 +0300)]
indexes: support nested index switcher calls 2

GitOrigin-RevId: 84dbfade04a1d2b0ea53a7011ef86b3ea04ce55e

11 months agofix unused imports
Sergey Stupin [Tue, 2 Jun 2020 09:46:15 +0000 (11:46 +0200)]
fix unused imports

GitOrigin-RevId: 7d93320dcf7c1436acbf2521b9256a8f1c615a16

11 months ago[workspace model] rename classes from legacyBridge package
Nikolay Chashnikov [Tue, 2 Jun 2020 09:35:26 +0000 (12:35 +0300)]
[workspace model] rename classes from legacyBridge package

Use 'Bridge' suffix instead 'LegacyBridge' prefix to avoid long common prefix which complicates reading and make completion less convenient.

GitOrigin-RevId: 768c1b1c609a66a3c26a083dde9f17e1b159cd6b

11 months ago[workspace model] rearrange classes in intellij.platform.workspaceModel.ide.* modules
Nikolay Chashnikov [Tue, 2 Jun 2020 08:50:07 +0000 (11:50 +0300)]
[workspace model] rearrange classes in intellij.platform.workspaceModel.ide.* modules

Change root package name to be consistent with module name, move impl classes to separate package, move legacyBridge implementations together.

This is the second step, package directives are updated.

GitOrigin-RevId: d09f4e836010d1b4b0147d5f5f1e61c59e022b1d

11 months ago[workspace model] rearrange classes in intellij.platform.workspaceModel.ide.* modules
Nikolay Chashnikov [Tue, 2 Jun 2020 08:32:19 +0000 (11:32 +0300)]
[workspace model] rearrange classes in intellij.platform.workspaceModel.ide.* modules

Change root package name to be consistent with module name, move impl classes to separate package, move legacyBridge implementations together.

This is the first step, files are moved but package directives aren't updated.

GitOrigin-RevId: bad7508720d7e60cae26e044434c819c2b08632d

11 months agoIDEA-236390 Implement new UI for editing run configuration settings
Dmitry Avdeev [Tue, 2 Jun 2020 09:42:50 +0000 (12:42 +0300)]
IDEA-236390 Implement new UI for editing run configuration settings

before run task editing fixed, tooltip added

GitOrigin-RevId: b281f34ab023e3da68cbec24aa6ee06251bc2f8b

11 months agoIDEA-217450 Show indent information in the status bar when using EditorConfig
Rustam Vishnyakov [Mon, 1 Jun 2020 11:48:07 +0000 (14:48 +0300)]
IDEA-217450 Show indent information in the status bar when using EditorConfig

GitOrigin-RevId: 5844c7f0d5b8ae6f3e7721bd77ccac13bc45e426

11 months agoIDEA-236390 Implement new UI for editing run configuration settings
Dmitry Avdeev [Tue, 2 Jun 2020 09:30:54 +0000 (12:30 +0300)]
IDEA-236390 Implement new UI for editing run configuration settings

TagButton refactored to use JLayeredPane

GitOrigin-RevId: c7b0c00a50702d1df92c6e547fcb84eecc34fd8d

11 months ago[analysis] IDEA-240049 Don't report "foreach not applicable" if type being iterated...
Nikita Eshkeev [Tue, 2 Jun 2020 09:14:40 +0000 (12:14 +0300)]
[analysis] IDEA-240049 Don't report "foreach not applicable" if type being iterated is unresolved

This patch converts the static import of NULL to a regular import of PsiType in order to keep the autocompletion dialog clean

Signed-off-by: Nikita Eshkeev <>
GitOrigin-RevId: 5186a9db466b92f2518a93ed0d16e5cc538f44ba

11 months agofix maven ext tests
Alexander Bubenchikov [Tue, 2 Jun 2020 08:52:36 +0000 (11:52 +0300)]
fix maven ext tests

GitOrigin-RevId: dc5106d209b2bd7204ed6fc72b9dd409e323ad8c

11 months agoCleanup: wildcards
Egor Zhdan [Tue, 2 Jun 2020 08:33:04 +0000 (11:33 +0300)]
Cleanup: wildcards

GitOrigin-RevId: 9fd81e6723ab49b457bdbc353734b119d88efa1b

11 months ago[Gradle] ignore testing greeting line in test console output assertion
Vladislav.Soroka [Tue, 2 Jun 2020 08:57:39 +0000 (11:57 +0300)]
[Gradle] ignore testing greeting line in test console output assertion

GitOrigin-RevId: e48f42562b19987e1597e0ffed09f0c3931abfe3

11 months agoQuickFixWrapper: raw types fixed
Tagir Valeev [Tue, 2 Jun 2020 08:54:00 +0000 (15:54 +0700)]
QuickFixWrapper: raw types fixed

GitOrigin-RevId: 63a2f8b8aec60b01bf1acd1f4d175cdbb35c958a

11 months agoisAvailable: use getViewProvider() (IDEA-CR-63223)
Tagir Valeev [Tue, 2 Jun 2020 08:50:06 +0000 (15:50 +0700)]
isAvailable: use getViewProvider() (IDEA-CR-63223)

GitOrigin-RevId: 85c6eb41486e2caa04237fd03fed55ddf23acbe1

11 months ago[analysis] IDEA-240049 Don't report "foreach not applicable" if type being iterated...
Nikita Eshkeev [Tue, 2 Jun 2020 08:01:16 +0000 (11:01 +0300)]
[analysis] IDEA-240049 Don't report "foreach not applicable" if type being iterated is unresolved

This patch uses the standard utility method to resolve the type the value of which is being iterated over as per the code review

Signed-off-by: Nikita Eshkeev <>
GitOrigin-RevId: 420c720689d89148233a3c6eb2ce67b16cdca807

11 months agoRefactor DFA completion
Tagir Valeev [Tue, 2 Jun 2020 08:22:34 +0000 (15:22 +0700)]
Refactor DFA completion

1. Separate visitors for normal and smart completion, as problems are quite different
2. Remove custom memory state (exception assignment filtering) and custom DfaInstanceofValue. Instead, custom variable descriptor is used for complex expressions under instanceof or cast
3. Track TypeConstraint always; move to PsiType only when returning result

Should fix many subtle cases when cast-completion was not available
Fixes IDEA-242322 Dfa cast-completion is missing under boolean flag

GitOrigin-RevId: 1246e6ea84f8c359cc13fc805d32e0eef364ee1b

11 months agoMethodPattern: NonNls annotations
Tagir Valeev [Tue, 2 Jun 2020 08:15:47 +0000 (15:15 +0700)]
MethodPattern: NonNls annotations

GitOrigin-RevId: 227d1f0837dcc0b2af0a3ed5fb6fb96acbe2c786

11 months agoDfaPsiUtil#tryGenerify: add wildcards if generify fails
Tagir Valeev [Tue, 2 Jun 2020 06:14:09 +0000 (13:14 +0700)]
DfaPsiUtil#tryGenerify: add wildcards if generify fails

GitOrigin-RevId: 82a9e01bb6a6fbb3bd785e3bab2d8a3ebb018420

11 months agoDfaExpressionFactory#getExpressionDfaValue package-private
Tagir Valeev [Tue, 2 Jun 2020 05:55:17 +0000 (12:55 +0700)]
DfaExpressionFactory#getExpressionDfaValue package-private

GitOrigin-RevId: d12d38d6b024144c7a5c0522ef296d091cdd7acb

11 months agoAnalysisScope: do cheaper check first
Peter Gromov [Tue, 2 Jun 2020 08:25:43 +0000 (10:25 +0200)]
AnalysisScope: do cheaper check first

Some GeneratedSourcesFilter load AST, and doing this in the whole project isn't nice

GitOrigin-RevId: 40bc6f3cef3ea1537422b602fdbcbde504aa8d8b

11 months ago[Gradle] include exception and try suggestions into Build tw error message IDEA-226613
Vladislav.Soroka [Tue, 2 Jun 2020 08:03:40 +0000 (11:03 +0300)]
[Gradle] include exception and try suggestions into Build tw error message IDEA-226613

GitOrigin-RevId: 6400dab2d419723168541d84e78128803a90fae2

11 months agoindexes: support nested index switcher calls
Dmitry Batkovich [Tue, 2 Jun 2020 06:43:14 +0000 (09:43 +0300)]
indexes: support nested index switcher calls

GitOrigin-RevId: e9e9efc6e5ad28d833e5585cb1ad6bf1595b98d1

11 months agoIDEA-236390 Implement new UI for editing run configuration settings
Dmitry Avdeev [Tue, 2 Jun 2020 07:52:42 +0000 (10:52 +0300)]
IDEA-236390 Implement new UI for editing run configuration settings

setting focus after drag and drop

GitOrigin-RevId: 0e1695af4a4e873a4a87d92b6794d27bfd8c180d

11 months agoIDEA-122181 Add cursor for each line in selection
Dmitry Batrak [Mon, 1 Jun 2020 15:44:23 +0000 (18:44 +0300)]
IDEA-122181 Add cursor for each line in selection

GitOrigin-RevId: 3b15ddc804a5c75abd4925367c4cae7787b231f9

11 months agoIDEA-236390 Implement new UI for editing run configuration settings
Dmitry Avdeev [Tue, 2 Jun 2020 07:40:40 +0000 (10:40 +0300)]
IDEA-236390 Implement new UI for editing run configuration settings

unregistering dnd target

GitOrigin-RevId: 4ff904877ac2cb72da7861e08b52913d68d6a8d7

11 months ago[workspace model] rearrange classes in
Nikolay Chashnikov [Tue, 2 Jun 2020 07:21:03 +0000 (10:21 +0300)]
[workspace model] rearrange classes in* modules

Change root package name to be consistent with module name, move impl classes to separate package, get rid of obsolete 'Typed' and 'P' prefixes in class names, rename TypedEntityStore to VersionedEntityStorage to avoid confusion caused by similarity of 'Store' and 'Storage'

GitOrigin-RevId: 15abb31c42eb243e5f2792e5eee8d748d56401ed

11 months agoProblems view: skip iteration in property test when it is too expensive analyze eleme...
Artemiy Sartakov [Tue, 2 Jun 2020 07:19:24 +0000 (14:19 +0700)]
Problems view: skip iteration in property test when it is too expensive analyze element after change

GitOrigin-RevId: 54559be464407ccb4db98e20ca82feb514bb7d72

11 months agomark api on options for inplace refactorings in inlays experimental
Anna Kozlova [Tue, 2 Jun 2020 07:19:25 +0000 (09:19 +0200)]
mark api on options for inplace refactorings in inlays experimental

GitOrigin-RevId: 17380cb3f4112b02167861567ee9c32eab06b949

11 months agooptions for inplace rename in inlays: `more options` callback
Anna Kozlova [Tue, 2 Jun 2020 07:18:15 +0000 (09:18 +0200)]
options for inplace rename in inlays: `more options` callback


GitOrigin-RevId: 6bbf1fe29210d31d72c09377d89085453fea4088

11 months ago[workspace model] cleanup: delete unused code
Nikolay Chashnikov [Mon, 1 Jun 2020 18:38:17 +0000 (21:38 +0300)]
[workspace model] cleanup: delete unused code

Delete empty classes and old proxy-based implementation of TypedEntityStorage.

GitOrigin-RevId: f4f9888e0ca966c081824d1c4d971f9de6b1d0fc

11 months ago[workspace model] rearrange modules
Nikolay Chashnikov [Mon, 1 Jun 2020 18:07:31 +0000 (21:07 +0300)]
[workspace model] rearrange modules

Move 4 modules related to workspaceModel to a common directory platform/workspaceModel to simplify directory layout, rename intellij.platform.workspaceModel.core to for clarity, move test utils to tests module to simplify project configuration.

GitOrigin-RevId: 932a5cd8bbd19a52324f336a158cdfeee9a81ee4

11 months ago[workspace model] add link to an issue
Nikolay Chashnikov [Mon, 1 Jun 2020 11:14:15 +0000 (14:14 +0300)]
[workspace model] add link to an issue

GitOrigin-RevId: 3b4c3ec6166aec64b03bd8611157e1e41512fbab

11 months agoCheck the type via common dataflow to avoid some false-positives
Tagir Valeev [Tue, 2 Jun 2020 04:34:44 +0000 (11:34 +0700)]
Check the type via common dataflow to avoid some false-positives

Fixes IDEA-242313 Cast conflicts with instanceof false-positive in ternary with boolean flag

GitOrigin-RevId: b12bec92b0d1a8afa0c46ae11e7d1b5130a6bf7c

11 months agoSet caret
Tagir Valeev [Tue, 2 Jun 2020 03:31:44 +0000 (10:31 +0700)]
Set caret

Quick-fix as intention action should be applied at caret position; otherwise injected file cannot be found

GitOrigin-RevId: 70ece164fe7fbae4f8dfadf288f06b66479bd2b3

11 months agoSuppress/fix warnings in test injections
Tagir Valeev [Tue, 2 Jun 2020 03:08:19 +0000 (10:08 +0700)]
Suppress/fix warnings in test injections

GitOrigin-RevId: acbdb38f5527c76362debaed0c467e47d87ca8ed

11 months agoisAvailable: do not return true on the wrong file (e.g. injection)
Tagir Valeev [Mon, 1 Jun 2020 10:24:39 +0000 (17:24 +0700)]
isAvailable: do not return true on the wrong file (e.g. injection)

Looks like it's not enough just to compare PsiFiles, because for JSP there could be a Jspx DummyHolder (JspXmlFile) while editor file is JspxFile. So we need to compare virtual files as well.

GitOrigin-RevId: 784c9c02dd9e14e0dfa7a4e6e4fddabe3998e9f0

11 months agoIndexing: track number of running workers and add new workers if necessary.
Sergey Patrikeev [Tue, 2 Jun 2020 03:09:50 +0000 (06:09 +0300)]
Indexing: track number of running workers and add new workers if necessary.

If worker threads die for whatever reason, we don't want indexing to stop (we used to have some bugs when indexing worker would finish with an exception and indexing wouldn't make progress). Let's guarantee there are enough workers running.

GitOrigin-RevId: 9e99abb3e51838e5bd4c624239aa336963de4b0c

11 months agoIndexing: rethrow errors happened inside IndexingJob.
Sergey Patrikeev [Tue, 2 Jun 2020 02:57:51 +0000 (05:57 +0300)]
Indexing: rethrow errors happened inside IndexingJob.

GitOrigin-RevId: a90d84bdaed08b27dfb414ac088d44cb1bb3c5b7

11 months agoZSTD as project level dependency
Ilya.Kazakevich [Mon, 1 Jun 2020 19:03:55 +0000 (22:03 +0300)]
ZSTD as project level dependency

GitOrigin-RevId: 750085fb37243be1086f65f61539c2d9d1dfea8d

11 months agoIDEA-CR-62371 use client class as cache id because it's dangerous to rely on identity...
Vladimir Krivosheev [Mon, 1 Jun 2020 18:34:58 +0000 (20:34 +0200)]
IDEA-CR-62371 use client class as cache id because it's dangerous to rely on identity of functional expressions.

GitOrigin-RevId: 41d38ae5da583af0ed4520cb2e06b9def7fb871b

11 months agoUpdate title/message and actions text.
Alexander Lobas [Mon, 1 Jun 2020 17:50:20 +0000 (20:50 +0300)]
Update title/message and actions text.

GitOrigin-RevId: 1a24d6a2f8d2a6d7c5ab21c07126f475c846ed56

11 months agoLAB-29: add custom executor for next file prediction
Svetlana.Zemlyanskaya [Mon, 1 Jun 2020 16:40:56 +0000 (18:40 +0200)]
LAB-29: add custom executor for next file prediction

GitOrigin-RevId: 3c93a055049d9c1d981302903a850bed4930bf89

11 months agoIDEA-92196 Event Log tool window shows indication of new message, but can't show...
Vladimir Krivosheev [Mon, 1 Jun 2020 15:44:19 +0000 (17:44 +0200)]
IDEA-92196 Event Log tool window shows indication of new message, but can't show the message before indexing completion

GitOrigin-RevId: a806b411d8c57675930971e4a95d0521141a2f96

11 months agoIndexing: re-implement waiting for indexing jobs to complete.
Sergey Patrikeev [Mon, 1 Jun 2020 15:59:56 +0000 (18:59 +0300)]
Indexing: re-implement waiting for indexing jobs to complete.

Use "numberOfProcessedFiles" to check whether a job has finished processing all files.
Decouple poor worker threads (the ones that index jobs one by one fairly) and the initial thread (the one that waits for the job to complete), do not wait for a specific job in the worker thread.

It fixes the following problem: a file from a job might have been stolen by worker thread from another instance of IndexUpdateRunner. Then all worker threads from the current IndexUpdateRunner would finish because there are no files left in the queue. Then the main waiting thread joins all the workers and finishes, despite there is some file being processed in the stealer thread. But we don't want to return from "indexFiles" before all the files are 100% indexed.

GitOrigin-RevId: 233181826752c0daaa663a6b376428d3235d6b4c

11 months agoIndexing: inline method CachedFileContent.isDirectory.
Sergey Patrikeev [Mon, 1 Jun 2020 13:38:25 +0000 (16:38 +0300)]
Indexing: inline method CachedFileContent.isDirectory.

GitOrigin-RevId: 89a3b4b68605f26531adc163500e354076f602ab

11 months agoIndexing: inline method in IndexUpdateRunner.
Sergey Patrikeev [Mon, 1 Jun 2020 13:36:08 +0000 (16:36 +0300)]
Indexing: inline method in IndexUpdateRunner.

GitOrigin-RevId: 037ee4c724f77c09fef7e385b32f359a25752a24

11 months agoIndexing: push file back to the queue on PCE happened while waiting for free memory...
Sergey Patrikeev [Mon, 1 Jun 2020 13:33:49 +0000 (16:33 +0300)]
Indexing: push file back to the queue on PCE happened while waiting for free memory or loading file content.

It does not affect correctness but makes the code fair.

GitOrigin-RevId: 00be03c7e3285e513aafe5c3608343de3d0c9794

11 months agoIndexing diagnostic: report number of too-large/failed-to-load/failed-to-index files.
Sergey Patrikeev [Mon, 1 Jun 2020 13:14:31 +0000 (16:14 +0300)]
Indexing diagnostic: report number of too-large/failed-to-load/failed-to-index files.

GitOrigin-RevId: 8682ebb12f88206dd816f9e1f55e2a4b89057fff

11 months agoIndexing: simplify exception handling in IndexUpdateRunner.
Sergey Patrikeev [Mon, 1 Jun 2020 12:48:27 +0000 (15:48 +0300)]
Indexing: simplify exception handling in IndexUpdateRunner.

1) No reason to catch Throwable in two methods.
2) Inline one of "indexOneFileOfJob" methods.
3) No reason to set FAILED_TO_INDEX for CachedFileContent: indexing of failed files is skipped immediately.

GitOrigin-RevId: 573527d71277baa414dcf7d518646d4b732a53f5

11 months agoIDEA-CR-63212: fix a deadlock on `invokeAndWait` in startup activities in tests
Dmitry Kozhevnikov [Mon, 1 Jun 2020 15:50:05 +0000 (18:50 +0300)]
IDEA-CR-63212: fix a deadlock on `invokeAndWait` in startup activities in tests

(cherry picked from commit f2368d2c63add812dc17c4bea07aac3c67731dab)

GitOrigin-RevId: a04470f1172d2731e90431f8e995491af2c95816

11 months agoPut forgotten argument (PY-42285)
Semyon Proshev [Mon, 1 Jun 2020 16:11:00 +0000 (19:11 +0300)]
Put forgotten argument (PY-42285)

GitOrigin-RevId: 35e102e4bc781be8d4009d3cc3be16b4422fb197

11 months agofix CME
Alexander Bubenchikov [Mon, 1 Jun 2020 15:47:00 +0000 (18:47 +0300)]
fix CME

GitOrigin-RevId: a3b534fbeee05572535499ecddea774b3082b345

11 months agoDisable suggested refactorings for unsupported identifiers since their usages will...
Semyon Proshev [Wed, 27 May 2020 00:07:23 +0000 (03:07 +0300)]
Disable suggested refactorings for unsupported identifiers since their usages will not be updated (PY-42285)

See PyReferenceImpl.handleElementRename.

GitOrigin-RevId: 58f1a504a0fe13582950b59d28949a5f2a484b2a

11 months agoFix parameter re-appearing with a different name (PY-42285)
Semyon Proshev [Tue, 26 May 2020 22:46:18 +0000 (01:46 +0300)]
Fix parameter re-appearing with a different name (PY-42285)

GitOrigin-RevId: cc1eb9e77e0e3e3c82c30ba39b80010f1cdcb292

11 months agoAdd an ability to specify value placeholder to be more clear to a user (PY-40278)
Semyon Proshev [Fri, 22 May 2020 15:54:40 +0000 (18:54 +0300)]
Add an ability to specify value placeholder to be more clear to a user (PY-40278)

GitOrigin-RevId: 22cb6c723f28e3a4b55773d818c7435f6f71d383

11 months agoSuggested change signature refactoring (PY-42285)
Semyon Proshev [Tue, 12 May 2020 20:14:26 +0000 (23:14 +0300)]
Suggested change signature refactoring (PY-42285)

Skip overloads, properties and type hinted functions.
Validate parameters that should have default value.

GitOrigin-RevId: 302a64798c7489566a6d7f0d7463c6514be6ee8a

11 months agoIntroduce ability to validate values for new parameters (PY-42285)
Semyon Proshev [Tue, 19 May 2020 22:12:29 +0000 (01:12 +0300)]
Introduce ability to validate values for new parameters (PY-42285)

GitOrigin-RevId: 149f91eabae1c2abbb155e825baa051573f0b299

11 months agoIntroduce util method to determine if a parameter could have default value based...
Semyon Proshev [Tue, 19 May 2020 13:35:28 +0000 (16:35 +0300)]
Introduce util method to determine if a parameter could have default value based on its name

GitOrigin-RevId: df66321a30f2e61f360c07ea4e9e758f65fad9a3

11 months agoIntroduce util method to get parameter default value part in signature
Semyon Proshev [Mon, 18 May 2020 21:29:38 +0000 (00:29 +0300)]
Introduce util method to get parameter default value part in signature

GitOrigin-RevId: 2639b26aee780ac1ef06bcc13f90cdb252faab1e

11 months agoIntroduce util method to get parameter name in signature
Semyon Proshev [Thu, 14 May 2020 18:28:04 +0000 (21:28 +0300)]
Introduce util method to get parameter name in signature

GitOrigin-RevId: 628cfba28e92fdd6c336cb144bc80e1766053e79

11 months agoReplace single star and slash parameter literals with constants usages
Semyon Proshev [Thu, 14 May 2020 18:14:42 +0000 (21:14 +0300)]
Replace single star and slash parameter literals with constants usages

GitOrigin-RevId: 747d8eefbaa8efccd62b4b77e5e926e984882184

11 months agovcs: Refactor "ChangesViewCommitPanel" - use single commit action instance with 2...
Konstantin Kolosovsky [Mon, 1 Jun 2020 14:52:24 +0000 (17:52 +0300)]
vcs: Refactor "ChangesViewCommitPanel" - use single commit action instance with 2 shortcuts for Mac

Instead of 2 action instances with single shortcut each

6dc28a5ae617520f89c576a439f3091bcd5b1079 follow-up

GitOrigin-RevId: 2732d337af0dbe8ed1ce8fa7c155a5ed68278b76

11 months agovcs: Use "Alt/Meta + 0" shortcut for "Commit" tool window (IDEA-236817)
Konstantin Kolosovsky [Thu, 28 May 2020 17:11:30 +0000 (20:11 +0300)]
vcs: Use "Alt/Meta + 0" shortcut for "Commit" tool window (IDEA-236817)

Previously this shortcut was used for "Messages" tool window and "Favorites" tool window in "XCode" keymap. But number of usages is small.

GitOrigin-RevId: 6ba65daea39ddf857d362dac2403f95ff1379410

11 months agovcs: Refactor "RemoteRevisionsCache" - remove unnecessary "RemoteDifferenceStrategy...
Konstantin Kolosovsky [Thu, 28 May 2020 20:40:39 +0000 (23:40 +0300)]
vcs: Refactor "RemoteRevisionsCache" - remove unnecessary "RemoteDifferenceStrategy" caching

GitOrigin-RevId: 6fc5bf34c31c72db4e637a9bd34d67a1c904cec7

11 months agoIDEA-238301 Subpixel(LCD) text is slow with UI font in 2020.1, switching to greyscale...
Vassiliy.Kudryashov [Mon, 1 Jun 2020 15:38:59 +0000 (18:38 +0300)]
IDEA-238301 Subpixel(LCD) text is slow with UI font in 2020.1, switching to greyscale antialiasing helps

GitOrigin-RevId: 0c65ec910ec88f8974960f269c6c2af0eb338b96

11 months ago[github] Fix infinite cycle during PR timeline creation
Ivan Semenov [Mon, 1 Jun 2020 15:27:07 +0000 (18:27 +0300)]
[github] Fix infinite cycle during PR timeline creation

GitOrigin-RevId: 04085ec295ff05c343614dd5ab54eb25702e5c49

11 months ago[groovy] on macOS use default homebrew location when selecting SDK path
Daniil Ovchinnikov [Mon, 1 Jun 2020 15:18:55 +0000 (18:18 +0300)]
[groovy] on macOS use default homebrew location when selecting SDK path

GitOrigin-RevId: 6531f3f4a14ab257535db40e4f3db96132c011b4