idea/community.git
2 years agorewrite ImageInfoIndex as gist
Dmitry Batkovich [Fri, 1 May 2020 15:10:58 +0000 (18:10 +0300)]
rewrite ImageInfoIndex as gist

GitOrigin-RevId: 180fb3991c7fc4de6a27dd855a1346a485d82002

2 years agoremove unused parameter
Dmitry Batkovich [Fri, 1 May 2020 13:49:30 +0000 (16:49 +0300)]
remove unused parameter

GitOrigin-RevId: 271c1368c9c35c1b242addc4f5375c3afab3938c

2 years agoconvert java.simple.property index to gist
Dmitry Batkovich [Fri, 1 May 2020 07:45:39 +0000 (10:45 +0300)]
convert java.simple.property index to gist

GitOrigin-RevId: e39bb32046076a4b82ce5f1ff075cdade0ad9a94

2 years agoprebuilt stubs should use generated serialization manager
Dmitry Batkovich [Fri, 1 May 2020 07:18:09 +0000 (10:18 +0300)]
prebuilt stubs should use generated serialization manager

GitOrigin-RevId: 5c633cc0b81f4137ef3972b33594171d5dfbbe72

2 years agostubs: do not duplicate serializers while stub tree re-serialization, retrieve actual...
Dmitry Batkovich [Fri, 1 May 2020 07:11:03 +0000 (10:11 +0300)]
stubs: do not duplicate serializers while stub tree re-serialization, retrieve actual serializers from SerializedStubTree

GitOrigin-RevId: b4a8a28cdc0c566955ccc13cec8c585cc924f300

2 years agoprebuilt index: extract registry value to constant
Dmitry Batkovich [Fri, 1 May 2020 06:19:18 +0000 (09:19 +0300)]
prebuilt index: extract registry value to constant

GitOrigin-RevId: 87396f3b5e5ffa7d47fa47e92e79d5614ac0d187

2 years agoindexes: refactor PersistentHashMapValueStorage to resolve most of code duplicates
Dmitry Batkovich [Fri, 1 May 2020 05:14:40 +0000 (08:14 +0300)]
indexes: refactor PersistentHashMapValueStorage to resolve most of code duplicates

GitOrigin-RevId: bcb5928ab9528262aeb4180bb27b84d5f2d886a4

2 years agouse dedicated getter to retrieve incomplete chunk length file
Dmitry Batkovich [Thu, 30 Apr 2020 18:33:46 +0000 (21:33 +0300)]
use dedicated getter to retrieve incomplete chunk length file

GitOrigin-RevId: cdd4e83930436cc3889b7d165b36cf0c6cb525bc

2 years agopersistent map forward index should initialize persistent map with passed arguments...
Dmitry Batkovich [Thu, 30 Apr 2020 09:40:41 +0000 (12:40 +0300)]
persistent map forward index should initialize persistent map with passed arguments, not with default

GitOrigin-RevId: 5e6484f552f396c2900dfd0f9f592679fa52121d

2 years agoRemove JBCefBrowser.MyComponent
Anton Tarasov [Fri, 1 May 2020 10:07:05 +0000 (13:07 +0300)]
Remove JBCefBrowser.MyComponent

GitOrigin-RevId: b5bfdb8f67fd34300dc476f05302806af3636e95

2 years ago[followup] IDEA-237780 address JBR-2282 [jcef] update
Anton Tarasov [Thu, 30 Apr 2020 10:55:32 +0000 (13:55 +0300)]
[followup] IDEA-237780 address JBR-2282 [jcef] update

CEF allows for loading local resources via "file" only from inside another "file" request. Thus {@link JBCefBrowser#loadHTML(String)} should not use a custom scheme (this does not work), but "file" instead. So, now both the requests are proxied via the "file" scheme handler in order to allow for loading resource files from an html string.

GitOrigin-RevId: b8edaadbe3b59ef296ee5165156ff02a0b159f91

2 years agoAddress JBR-2344 move JCEF settings to a shared class
Anton Tarasov [Wed, 29 Apr 2020 10:25:36 +0000 (13:25 +0300)]
Address JBR-2344 move JCEF settings to a shared class

GitOrigin-RevId: 78720ef47884820d2f248303b0781dcf41076a54

2 years agoIDEA-237780 address JBR-2282 [jcef] update to JCEF/80.0.4+g74f7b0c+chromium-80.0...
Anton Tarasov [Wed, 15 Apr 2020 16:11:34 +0000 (19:11 +0300)]
IDEA-237780 address JBR-2282 [jcef] update to JCEF/80.0.4+g74f7b0c+chromium-80.0.3987.122

GitOrigin-RevId: 3c21bc5d20d3b6a0eb5585a418160b2e1564181e

2 years ago[codeInsight] IDEA-113640 Provide intention to combine System.out.println(String...
Nikita Eshkeev [Fri, 1 May 2020 14:21:00 +0000 (17:21 +0300)]
[codeInsight] IDEA-113640 Provide intention to combine System.out.println(String.format(...)) into System.out.printf

Remove unused RedundantStringFormatCall.html

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>
GitOrigin-RevId: a9cf7e2c4d5cac223701579d8763e26f69f38f3a

2 years ago[codeInsight] IDEA-113640 Provide intention to combine System.out.println(String...
Nikita Eshkeev [Thu, 30 Apr 2020 23:19:06 +0000 (02:19 +0300)]
[codeInsight] IDEA-113640 Provide intention to combine System.out.println(String.format(...)) into System.out.printf

The RedundantStringFormatCallInspection inspection used to be able to
detect excessive String.format calls and get rid of them not changing
the callsite at all. This patch enhances the inspection's capabilities
with changing the callsite if it is either PrintStream#print or
PrintStream#println and converting it to PrintStream#printf adding "%n"
if necessary.

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>
GitOrigin-RevId: 7edc5b0a84fb6c7b9caf504b1afb8905c5684985

2 years agocorrect reference check
Eugene Zhuravlev [Fri, 1 May 2020 13:32:26 +0000 (15:32 +0200)]
correct reference check

GitOrigin-RevId: a0be6d4d6d3d9c217ac1d3b477c29b951318273f

2 years agoEqualsBetweenInconvertibleTypes: fix message (avoid printing '==()'); fix handling...
Tagir Valeev [Fri, 1 May 2020 13:25:48 +0000 (20:25 +0700)]
EqualsBetweenInconvertibleTypes: fix message (avoid printing '==()'); fix handling several capture types

GitOrigin-RevId: be1d5c5be5613b9b00546ee217de6f9f0ab1eb6d

2 years agofix tests: correct initial value for cached file types (IDEA-CR-62197)
Eugene Zhuravlev [Fri, 1 May 2020 13:22:41 +0000 (15:22 +0200)]
fix tests: correct initial value for cached file types (IDEA-CR-62197)

GitOrigin-RevId: eb975766823a327869cfa6eb08dcb83d71f11c72

2 years agoIDEA-238541 Honor CamelHumps selection when selecting on double click is not respecte...
Dmitry Batrak [Fri, 1 May 2020 12:00:43 +0000 (15:00 +0300)]
IDEA-238541 Honor CamelHumps selection when selecting on double click is not respected on mouse drag

GitOrigin-RevId: 5ca4d1a189590388c657d533ffcde2a3c942493c

2 years agoIDEA-239850 "Collect Logs and Diagnostic Data" doesn't accept "No" as an answer
Maxim.Kolmakov [Fri, 1 May 2020 11:51:57 +0000 (13:51 +0200)]
IDEA-239850 "Collect Logs and Diagnostic Data" doesn't accept "No" as an answer

GitOrigin-RevId: dbdc521b51cb01aec9f041c550e2b33833ea093a

2 years agoIDEA-238725 Log the values of _JAVA_OPTIONS and JAVA_TOOL_OPTIONS environment variabl...
Maxim.Kolmakov [Fri, 1 May 2020 11:43:19 +0000 (13:43 +0200)]
IDEA-238725 Log the values of _JAVA_OPTIONS and JAVA_TOOL_OPTIONS environment variables on startup

Add to troubleshooting info

GitOrigin-RevId: 7366d7247d7a80d9a93b8b51e01a4d6bf181d447

2 years agoshared-indexes tests: dump file property pusher values.
Sergey Patrikeev [Fri, 1 May 2020 10:43:59 +0000 (13:43 +0300)]
shared-indexes tests: dump file property pusher values.

GitOrigin-RevId: cb61d1f7a65f7cbc6e4cf72dc2db98f973493d55

2 years agoshared-indexes tests: extract and rename classes needed to dump index content diagnostic.
Sergey Patrikeev [Fri, 1 May 2020 09:59:25 +0000 (12:59 +0300)]
shared-indexes tests: extract and rename classes needed to dump index content diagnostic.

GitOrigin-RevId: c323d84a4272fe5e01d5d6b063d2d5d396551f17

2 years agoIndexDataComparer: simplify comparisons.
Sergey Patrikeev [Fri, 1 May 2020 08:21:31 +0000 (11:21 +0300)]
IndexDataComparer: simplify comparisons.

GitOrigin-RevId: de9eb46f5bd583683f5d8a8435b29eb46afa5626

2 years agoID<K, V>: make it clear that equals() compares objects by identity.
Sergey Patrikeev [Fri, 1 May 2020 07:54:23 +0000 (10:54 +0300)]
ID<K, V>: make it clear that equals() compares objects by identity.

GitOrigin-RevId: a8cae0ba06709e79b26c45028bd10584284fa1b7

2 years agoIDEA-239005 EditorLastActionTracker leaks reference to PsiFile via EditorWindowImpl...
Dmitry Batrak [Fri, 1 May 2020 09:46:01 +0000 (12:46 +0300)]
IDEA-239005 EditorLastActionTracker leaks reference to PsiFile via EditorWindowImpl on plugin unload

GitOrigin-RevId: 1bfff082221fca804d2ee4dab68da1e2d88133ff

2 years agoIDEA-235535 make <editorActionHandler> dynamic
Dmitry Batrak [Fri, 1 May 2020 08:38:44 +0000 (11:38 +0300)]
IDEA-235535 make <editorActionHandler> dynamic

fix typo

GitOrigin-RevId: 778962c52fb8048680e8502924b8af25602dd8dd

2 years agoIDEA-235535 make <editorActionHandler> dynamic
Dmitry Batrak [Fri, 1 May 2020 08:30:37 +0000 (11:30 +0300)]
IDEA-235535 make <editorActionHandler> dynamic

fix a mistake - make sure handlers are initialized in EditorAction.getHandlerOfType

GitOrigin-RevId: c8a535bc0d03c1cb54828a4a04d3d3fa4e4e986c

2 years agoIDEA-235535 make <editorActionHandler> dynamic
Dmitry Batrak [Thu, 30 Apr 2020 15:12:21 +0000 (18:12 +0300)]
IDEA-235535 make <editorActionHandler> dynamic

GitOrigin-RevId: 1046057fb3f82dce2793154a26dfe78cbf9f3d3a

2 years agoUpdating versions of project dependencies: jdkBuild->11_0_7b903.3
Vitaly Provodin [Fri, 1 May 2020 06:27:55 +0000 (09:27 +0300)]
Updating versions of project dependencies: jdkBuild->11_0_7b903.3

Vitaly Provodin

GitOrigin-RevId: 706eb62ce4e4df4183ff1840dc9b0cbefb01f6bf

2 years agoIDEA-229494 Compilation fails in debugger when invoking Evaluate Expression with...
Vitaliy.Bibaev [Tue, 28 Apr 2020 22:59:28 +0000 (01:59 +0300)]
IDEA-229494 Compilation fails in debugger when invoking Evaluate Expression with static import

GitOrigin-RevId: 52210e29a5322c8394341e7d7c514a37905df368

2 years agoIDEA-218906 Compiling evaluator does not work for decompiled files
Vitaliy.Bibaev [Tue, 28 Apr 2020 20:44:27 +0000 (23:44 +0300)]
IDEA-218906 Compiling evaluator does not work for decompiled files

GitOrigin-RevId: 868d4b77366e5d80b77fe077b6dd09dd8bfc04fe

2 years agoIDEA-229590 Compiling evaluator fails (5/5)
Vitaliy.Bibaev [Thu, 30 Apr 2020 22:11:13 +0000 (01:11 +0300)]
IDEA-229590 Compiling evaluator fails (5/5)

Access using reflection to methods invoked on implicit 'this'

GitOrigin-RevId: ff40287b1e3f5d871f6a36e76879d80a2b384637

2 years agoIDEA-229590 Compiling evaluator fails (4/5)
Vitaliy.Bibaev [Thu, 30 Apr 2020 22:10:06 +0000 (01:10 +0300)]
IDEA-229590 Compiling evaluator fails (4/5)

Access to available 'this' is can't resolve a proper one

GitOrigin-RevId: 4ddb71a268b0a71b4129560d8cc02c1805a697d8

2 years agoIDEA-229590 Compiling evaluator fails (3/5)
Vitaliy.Bibaev [Thu, 30 Apr 2020 22:09:13 +0000 (01:09 +0300)]
IDEA-229590 Compiling evaluator fails (3/5)

Access with reflection to every usage of 'this'

GitOrigin-RevId: 23dd7303b55360dd8baeed1202a6024bc876b06e

2 years agoIDEA-229590 Compiling evaluator fails (2/5)
Vitaliy.Bibaev [Thu, 30 Apr 2020 22:07:35 +0000 (01:07 +0300)]
IDEA-229590 Compiling evaluator fails (2/5)

Use simple class names to quality 'this'

GitOrigin-RevId: 78d7141d10e1d71e577b778303cb0f05eadcd018

2 years agoCleanup (dead code; warnings; typos; formatting)
Roman Shevchenko [Thu, 30 Apr 2020 21:58:33 +0000 (23:58 +0200)]
Cleanup (dead code; warnings; typos; formatting)

GitOrigin-RevId: 0fe510c32b91456b64a1d76998225161cd182576

2 years ago[platform] notifying about JVM-affecting environment variables (IDEA-206209)
Roman Shevchenko [Thu, 30 Apr 2020 21:47:31 +0000 (23:47 +0200)]
[platform] notifying about JVM-affecting environment variables (IDEA-206209)

GitOrigin-RevId: d066f5761ddc5d586160b7109af39e2fb7a9c60c

2 years agoGet rid of using highlighting iterator in java completion to make it work with imagin...
Alexander Zolotov [Thu, 30 Apr 2020 19:40:14 +0000 (22:40 +0300)]
Get rid of using highlighting iterator in java completion to make it work with imaginary editor

GitOrigin-RevId: dde211a2756587c8d4c963dd3a28cd7a3cc20150

2 years agodon't create python soft file references when searching for Java methods
Peter Gromov [Thu, 30 Apr 2020 20:19:17 +0000 (22:19 +0200)]
don't create python soft file references when searching for Java methods

GitOrigin-RevId: 25c35182c9af038fe2e00ef606163080b3db74d2

2 years agoreview follow-up: deprecate CompilerManager.addCompilableFileType();, introduce Compi...
Eugene Zhuravlev [Thu, 30 Apr 2020 19:58:27 +0000 (21:58 +0200)]
review follow-up: deprecate CompilerManager.addCompilableFileType();, introduce CompilableFileTypesProvider EP (IDEA-CR-62197)

GitOrigin-RevId: 529066d6c5ca6e796b71e23c71fe404f9c9e2de7

2 years agoCachedValueStabilityChecker: don't swear on WeakReferences with the same content
Peter Gromov [Thu, 30 Apr 2020 19:42:02 +0000 (21:42 +0200)]
CachedValueStabilityChecker: don't swear on WeakReferences with the same content

GitOrigin-RevId: 3ff24d6017a23132358c0bf5452a5024b4dc968b

2 years ago[platform] logging JVM-affecting environment variables (IDEA-238725)
Roman Shevchenko [Thu, 30 Apr 2020 19:34:51 +0000 (21:34 +0200)]
[platform] logging JVM-affecting environment variables (IDEA-238725)

GitOrigin-RevId: 8d11810b4c72d9757b2227cb7622bcf68e12342f

2 years ago[platform] logging both configured and real IDE paths when they differ
Roman Shevchenko [Thu, 30 Apr 2020 19:31:38 +0000 (21:31 +0200)]
[platform] logging both configured and real IDE paths when they differ

GitOrigin-RevId: 8ca85dc23b7b1060153d4e0819ce16da3be19ee0

2 years agoCheck whether editor is backed by text field using user data
Alexander Zolotov [Thu, 30 Apr 2020 19:04:03 +0000 (22:04 +0300)]
Check whether editor is backed by text field using user data

otherwise, the check requires editorComponent which is unavailable on imaginary editor

GitOrigin-RevId: 9c30d5907b4c40c1ca5725381d7bc9d361bf65d8

2 years agoIDEA-235191 UAST: fix usages cache for references
Yuriy Artamonov [Thu, 30 Apr 2020 19:01:52 +0000 (22:01 +0300)]
IDEA-235191 UAST: fix usages cache for references

GitOrigin-RevId: c568b51ac875ae67f66dd7d880786f4f90699449

2 years agoIDEA-235191 UAST: use specialization for expected UElement types instead of Map in...
Yuriy Artamonov [Thu, 30 Apr 2020 14:46:51 +0000 (17:46 +0300)]
IDEA-235191 UAST: use specialization for expected UElement types instead of Map in sharedContext

GitOrigin-RevId: 0a1bfb90759d3a4809c07253dd58040fbe1b86eb

2 years agodynamic plugins: pass parentDisposable=null to let it be inferred from context
Sergey Simonchik [Thu, 30 Apr 2020 18:40:48 +0000 (21:40 +0300)]
dynamic plugins: pass parentDisposable=null to let it be inferred from context

Parent disposable is inferred in com.intellij.util.ui.update.LazyUiDisposable.showNotify

GitOrigin-RevId: aef892ced5f704e160461b3e5604d646ae5799d7

2 years agojava sibling super search: delay getNavigationElement until we're sure it's a matchin...
Peter Gromov [Thu, 30 Apr 2020 18:38:13 +0000 (20:38 +0200)]
java sibling super search: delay getNavigationElement until we're sure it's a matching result

it can be expensive: in compiled PSI it finds source, parses it and finds a similar method by signature

GitOrigin-RevId: f59a8749b1a511809d9bcf47ab99c032747b3571

2 years ago[symbol] impl: go to declaration with ctrl+mouse highlighting
Daniil Ovchinnikov [Thu, 30 May 2019 18:12:38 +0000 (21:12 +0300)]
[symbol] impl: go to declaration with ctrl+mouse highlighting

GitOrigin-RevId: d7fc1e250deed0fd3d843b1542eb4d9bca2b0f2a

2 years ago[project model] provide an extension point to register custom library tables
Nikolay Chashnikov [Thu, 30 Apr 2020 17:33:36 +0000 (20:33 +0300)]
[project model] provide an extension point to register custom library tables

The old way via LibraryTableRegistrar::registerLibraryTable requires to run that code at startup and also doesn't allow to unregister the table when the plugin is unloaded.

GitOrigin-RevId: 34d030559db728c89555e002010a9d63f663cd9f

2 years agoJsonSchemaReferenceContributor: perform cheaper checks first
Peter Gromov [Thu, 30 Apr 2020 17:29:10 +0000 (19:29 +0200)]
JsonSchemaReferenceContributor: perform cheaper checks first

GitOrigin-RevId: 511d7cdd068cd976fdfc84e5a0ccdaa6f8e3e22d

2 years agodon't create PyTestFixture references when searching for Java methods
Peter Gromov [Thu, 30 Apr 2020 17:28:22 +0000 (19:28 +0200)]
don't create PyTestFixture references when searching for Java methods

GitOrigin-RevId: 18ae0903c8c630ae975955ad085b2d04093a5c48

2 years agodon't create JavaFX color references when searching for Java methods
Peter Gromov [Thu, 30 Apr 2020 17:27:44 +0000 (19:27 +0200)]
don't create JavaFX color references when searching for Java methods

GitOrigin-RevId: 758a7fcfddc58b7a53733982a379f5f8b3e2445f

2 years agointelliLang: don't process language references during usage search
Peter Gromov [Thu, 30 Apr 2020 17:27:18 +0000 (19:27 +0200)]
intelliLang: don't process language references during usage search

GitOrigin-RevId: dada3af0bd151a6c758dd05f55d0268c5a1867b9

2 years agodon't create .ignore references when searching for Java methods
Peter Gromov [Thu, 30 Apr 2020 17:26:06 +0000 (19:26 +0200)]
don't create .ignore references when searching for Java methods

GitOrigin-RevId: e4d3e4e1f661787deae3e1ef12a839d0cb9710c1

2 years agodon't create Python doc string references when searching for Java methods
Peter Gromov [Thu, 30 Apr 2020 16:57:06 +0000 (18:57 +0200)]
don't create Python doc string references when searching for Java methods

GitOrigin-RevId: 26b36ed7904fb00e110ec876b69c28e3985f6405

2 years agodon't initialize sem contributors in multiple threads to reduce CPU usage after startup
Peter Gromov [Thu, 30 Apr 2020 16:56:06 +0000 (18:56 +0200)]
don't initialize sem contributors in multiple threads to reduce CPU usage after startup

GitOrigin-RevId: 161376edac0256d9686cc520f52272f1ef8c42c1

2 years ago[ui] "desktop entry created" notification wording (IDEA-238209)
Roman Shevchenko [Thu, 30 Apr 2020 16:35:02 +0000 (18:35 +0200)]
[ui] "desktop entry created" notification wording (IDEA-238209)

GitOrigin-RevId: b1c52a8b571074d058cf5ccb771d3c27ad3c9daa

2 years agocleanup
Alexey Kudravtsev [Thu, 30 Apr 2020 15:01:22 +0000 (18:01 +0300)]
cleanup

GitOrigin-RevId: a7567b02f405b6c3750f557832b347df0bb7a10c

2 years agodo not try to perform complex calculations when the project is suddenly disposed...
Alexey Kudravtsev [Thu, 30 Apr 2020 15:00:48 +0000 (18:00 +0300)]
do not try to perform complex calculations when the project is suddenly disposed to hopefully fix EA-144990 - assert: FileManagerImpl.dispatchPendingEvents

GitOrigin-RevId: 39a23450e54f1ab352a402b9df2b3a181f624ddc

2 years agofix race condition: do not publish myDelegates before filling contents; may explain...
Alexey Kudravtsev [Thu, 30 Apr 2020 11:53:03 +0000 (14:53 +0300)]
fix race condition: do not publish myDelegates before filling contents; may explain EA-226355 - NPE: AbstractProgressIndicatorExBase.delegate

GitOrigin-RevId: 7d91a05145056f98d6d952e524df1369a56dbafd

2 years agoEA-227969 - assert: ComponentManagerImpl.lambda$throwAlreadyDisposed$
Alexey Kudravtsev [Thu, 30 Apr 2020 11:07:45 +0000 (14:07 +0300)]
EA-227969 - assert: ComponentManagerImpl.lambda$throwAlreadyDisposed$

GitOrigin-RevId: 3643ed18d5906f4ce50ddcbcc872c25dcae0f30f

2 years ago[project model] add tests for 'clear' and 'isChanged' methods in ModifiableRootModel...
Nikolay Chashnikov [Thu, 30 Apr 2020 14:46:56 +0000 (17:46 +0300)]
[project model] add tests for 'clear' and 'isChanged' methods in ModifiableRootModel interface

GitOrigin-RevId: b7e46a38b471cf2a914a01ee3b99aabcadc51037

2 years agoBomb test covering code that is not used in the product
Dmitry Jemerov [Thu, 30 Apr 2020 13:44:37 +0000 (15:44 +0200)]
Bomb test covering code that is not used in the product

GitOrigin-RevId: 9026b0d42228e19f7afbef7d33aec75d10c1d5f0

2 years agoIDEA-180474 Cleanup obsolete archives in jbre/jbsdk folders
Ilia Shulgin [Thu, 30 Apr 2020 14:39:26 +0000 (17:39 +0300)]
IDEA-180474 Cleanup obsolete archives in jbre/jbsdk folders

GitOrigin-RevId: b973197c4a2fe8d15591815c82ec7014ab0d9ba4

2 years agoStubUpdatingIndex: use old option PrebuiltIndexProvider.DEBUG_PREBUILT_INDICES to...
Sergey Patrikeev [Thu, 30 Apr 2020 15:15:54 +0000 (18:15 +0300)]
StubUpdatingIndex: use old option PrebuiltIndexProvider.DEBUG_PREBUILT_INDICES to assert that prebuilt are correct.

This option seems to be never enabled in tests. When we turned it on, a lot of stub mismatch exception were thrown.

GitOrigin-RevId: 6bebea1e0afc5cc4a863d148ea1d99dbcec8d2c9

2 years agoIndexDataPresenter: remove unnecessary new line.
Sergey Patrikeev [Thu, 30 Apr 2020 13:44:51 +0000 (16:44 +0300)]
IndexDataPresenter: remove unnecessary new line.

GitOrigin-RevId: d1be9c0f6ee62f2b380930c124c57341d706e2bf

2 years ago[ES] dispose ES manager EP disposable for a project IDEA-238420
Vladislav.Soroka [Thu, 30 Apr 2020 14:51:29 +0000 (17:51 +0300)]
[ES] dispose ES manager EP disposable for a project IDEA-238420

GitOrigin-RevId: 8aa4908f619c19135493fc3ee2eaefd553051531

2 years ago[github] Fix listener
Ivan Semenov [Thu, 30 Apr 2020 14:48:14 +0000 (17:48 +0300)]
[github] Fix listener

GitOrigin-RevId: b7a492f7db61bea1066db458d1700cfe8231027d

2 years agoclean up after de14a4db
Daniil Ovchinnikov [Thu, 30 Apr 2020 14:43:35 +0000 (17:43 +0300)]
clean up after de14a4db

GitOrigin-RevId: 25b9f4ee595a6e32a4ee9e3c016711c84b70a33e

2 years ago[project model] add more tests for ModuleRootModel and ModifiableRootModel interfaces
Nikolay Chashnikov [Thu, 30 Apr 2020 14:24:41 +0000 (17:24 +0300)]
[project model] add more tests for ModuleRootModel and ModifiableRootModel interfaces

Check adding/removing application-level libraries.

GitOrigin-RevId: 3581121a984bbb049cb4031143405770507566e5

2 years ago[github] Cleanup
Ivan Semenov [Wed, 29 Apr 2020 12:32:57 +0000 (15:32 +0300)]
[github] Cleanup

GitOrigin-RevId: b2f246bfa226625a27ec59361821c4dca8d3de9b

2 years agoToolwindows: do not ignore doNotActivateOnStart attribute in com.intellij.[facet...
Andrei Kuznetsov [Thu, 30 Apr 2020 13:55:30 +0000 (16:55 +0300)]
Toolwindows: do not ignore doNotActivateOnStart attribute in com.intellij.[facet.toolWindow,library.toolWindow] EPs

GitOrigin-RevId: f9db726fc43156a40d0944d00ff7c4ed6d2537cf

2 years ago[Workspace Model] Fix indexing after entity removal
Alex Plate [Thu, 30 Apr 2020 14:09:35 +0000 (17:09 +0300)]
[Workspace Model] Fix indexing after entity removal

GitOrigin-RevId: de73902f188fc3d00f349e55952c5d40d2a14174

2 years agoRevert "[Workspace Model] Fix indexing after entity removal"
Alex Plate [Thu, 30 Apr 2020 14:04:59 +0000 (17:04 +0300)]
Revert "[Workspace Model] Fix indexing after entity removal"

GitOrigin-RevId: 993be82fefaf3d480b04e8533be584a6351f3089

2 years agodiagnostics for IDEA-236167 XmlTag#getSubTags is not idempotent, also EA-220861
Peter Gromov [Thu, 30 Apr 2020 13:54:18 +0000 (15:54 +0200)]
diagnostics for IDEA-236167 XmlTag#getSubTags is not idempotent, also EA-220861

GitOrigin-RevId: 75e5662f2a416640835a5f1f349f1411e4177fdd

2 years agoToolwindows: do not ignore doNotActivateOnStart attribute in com.intellij.facet.toolW...
Andrei Kuznetsov [Thu, 30 Apr 2020 13:09:44 +0000 (16:09 +0300)]
Toolwindows: do not ignore doNotActivateOnStart attribute in com.intellij.facet.toolWindow EP

GitOrigin-RevId: bb21c6618f24524ebd0d7f9c3e2c75563759e038

2 years ago[Workspace Model] Fix indexing after entity removal
Alex Plate [Thu, 30 Apr 2020 13:33:24 +0000 (16:33 +0300)]
[Workspace Model] Fix indexing after entity removal

GitOrigin-RevId: 1d580b5ecfcd9d501beeeebde5d8992d9a3828ca

2 years agoIndex data comparison: compare keys for null values separately.
Sergey Patrikeev [Thu, 30 Apr 2020 13:26:26 +0000 (16:26 +0300)]
Index data comparison: compare keys for null values separately.

GitOrigin-RevId: 231e3e890af4714e1cecc20d75f9825d4b8ce057

2 years ago[fleet] add very initial find usages, thanks to @daniil
Sergey Ignatov [Thu, 30 Apr 2020 13:11:13 +0000 (16:11 +0300)]
[fleet] add very initial find usages, thanks to @daniil

GitOrigin-RevId: de14a4db56223d5955a52172dd15e21278f2f63d

2 years agoreview follow-up: deprecate CompilerFactory (IDEA-CR-62203)
Eugene Zhuravlev [Thu, 30 Apr 2020 13:03:44 +0000 (15:03 +0200)]
review follow-up: deprecate CompilerFactory (IDEA-CR-62203)

GitOrigin-RevId: 64bc9b407ca59ded7a012140d4a4ad96c2455d88

2 years ago[ES] remove project from autoimport tracker on plugin unload IDEA-238420
Vladislav.Soroka [Thu, 30 Apr 2020 13:00:51 +0000 (16:00 +0300)]
[ES] remove project from autoimport tracker on plugin unload IDEA-238420

GitOrigin-RevId: 58b04ea7adef6315bf208e8c4426215dc70e1f7c

2 years agoIDEA-239124 PathMacrosImpl state is not persisted
Vladimir Krivosheev [Thu, 30 Apr 2020 12:26:41 +0000 (14:26 +0200)]
IDEA-239124 PathMacrosImpl state is not persisted

GitOrigin-RevId: f10a14db5f8e4b316ef93f49f002ffc60363f91e

2 years agoreport wrong PsiReference<->PsiElement link only once per reference class (IDEA-236508)
Peter Gromov [Thu, 30 Apr 2020 12:21:45 +0000 (14:21 +0200)]
report wrong PsiReference<->PsiElement link only once per reference class (IDEA-236508)

GitOrigin-RevId: 42d84445ffbcc3ad7aa0c51679b8d2aeee0be2e0

2 years agoIDEA-209622 vcs: show "Filtered Out" changes in log
Aleksey Pivovarov [Thu, 30 Apr 2020 11:53:29 +0000 (14:53 +0300)]
IDEA-209622 vcs: show "Filtered Out" changes in log

GitOrigin-RevId: 58858d98b3288bc1accf48035bada2434b0ad514

2 years agoIDEA-238538 rework message bus to truly support lazy declarative listeners
Vladimir Krivosheev [Wed, 29 Apr 2020 14:06:48 +0000 (16:06 +0200)]
IDEA-238538 rework message bus to truly support lazy declarative listeners

GitOrigin-RevId: a11a89e9e25165f0f5085f26afccb443da96aa44

2 years agoreduce broadcasting - broadcasting is not cheap, better to avoid it if not needed
Vladimir Krivosheev [Wed, 29 Apr 2020 15:44:25 +0000 (17:44 +0200)]
reduce broadcasting - broadcasting is not cheap, better to avoid it if not needed

GitOrigin-RevId: 573686e23beac133c427be8b64e9bdd2b01d59b3

2 years agoIDEA-231568 Declarative listener defined in optional dependency xml does not work
Vladimir Krivosheev [Tue, 28 Apr 2020 06:36:19 +0000 (08:36 +0200)]
IDEA-231568 Declarative listener defined in optional dependency xml does not work

GitOrigin-RevId: 919259cf98a33ef56cefab7e3187118674fcdab8

2 years agoIDEA-235515 EditorConfig plugin requires restart on disabling: Use caching service
Rustam Vishnyakov [Thu, 30 Apr 2020 10:37:07 +0000 (13:37 +0300)]
IDEA-235515 EditorConfig plugin requires restart on disabling: Use caching service

GitOrigin-RevId: ac66c84f14d9d957c7fa1cdaf597376a80808cc0

2 years agoClear code style cache on plugin unload
Rustam Vishnyakov [Thu, 30 Apr 2020 09:36:42 +0000 (12:36 +0300)]
Clear code style cache on plugin unload

GitOrigin-RevId: f51878b4be9ac228d6628d15d77a73021ab905b8

2 years agoCode style caching service
Rustam Vishnyakov [Thu, 30 Apr 2020 08:46:54 +0000 (11:46 +0300)]
Code style caching service

GitOrigin-RevId: 3e56108d432382c3561101159975152221f1f152

2 years ago[symbol] api/impl: navigation targets
Daniil Ovchinnikov [Thu, 27 Jun 2019 19:15:17 +0000 (22:15 +0300)]
[symbol] api/impl: navigation targets

GitOrigin-RevId: 134c04338ded85f56558133b3c9ea2954ed8ea36

2 years agoCPP-18868 IDEA-239724 vcs: utilize FilePathIconProvider in "Show Repository at Revisi...
Aleksey Pivovarov [Thu, 30 Apr 2020 10:54:04 +0000 (13:54 +0300)]
CPP-18868 IDEA-239724 vcs: utilize FilePathIconProvider in "Show Repository at Revision" tree

GitOrigin-RevId: 2dd33e29db8a690f1b9bfbf7c04e4d0252b3e2a1

2 years agoi18n: fix key errors in XML DOM
Dmitry.Krasilschikov [Thu, 30 Apr 2020 11:00:50 +0000 (14:00 +0300)]
i18n: fix key errors in XML DOM

GitOrigin-RevId: 4a7321e21f8a85ba645d0a5d0b93896bd299b6be

2 years agoi18n: fix key errors in Java
Dmitry.Krasilschikov [Thu, 30 Apr 2020 10:59:45 +0000 (13:59 +0300)]
i18n: fix key errors in Java

GitOrigin-RevId: 9dfc50baf92227ca20faad1cd6aaa042ad9d9790

2 years agoi18n: fix key errors in Platform
Dmitry.Krasilschikov [Thu, 30 Apr 2020 10:56:36 +0000 (13:56 +0300)]
i18n: fix key errors in Platform

GitOrigin-RevId: 3212089db4dea6bc0be1df69b1dc0ae793417a1c

2 years agoi18n: fix key errors in Relaxng
Dmitry.Krasilschikov [Thu, 30 Apr 2020 10:55:40 +0000 (13:55 +0300)]
i18n: fix key errors in Relaxng

GitOrigin-RevId: 4822e16ab83d71507d206a5765c1f88014d6e30a

2 years agojavafx: fix filter (IDEA-209569)
Anna Kozlova [Thu, 30 Apr 2020 11:01:58 +0000 (13:01 +0200)]
javafx: fix filter (IDEA-209569)

GitOrigin-RevId: 53e7e3f28fef98969acfc1ca200080e795b56341

2 years agoOptionalToIfInspection: property test
Artemiy Sartakov [Thu, 30 Apr 2020 10:58:59 +0000 (17:58 +0700)]
OptionalToIfInspection: property test

GitOrigin-RevId: 1816b0c0d001f541238b2f21dc6312a3179e7a83