idea/community.git
5 years agouse JBUI utility methods to simplify code (IDEA-CR-10241)
Sergey Simonchik [Wed, 4 May 2016 07:36:26 +0000 (10:36 +0300)]
use JBUI utility methods to simplify code (IDEA-CR-10241)

5 years agocleanup
Dmitry Batkovich [Wed, 4 May 2016 06:39:25 +0000 (09:39 +0300)]
cleanup

5 years agoserialize keys before calling append appcode/146.1675 clion/146.1671 dbe/146.1668 idea/146.1669 phpstorm/146.1670 pycharm/146.1673 pycharm/146.1677 rubymine/146.1672 webstorm/146.1678
Maxim.Mossienko [Tue, 3 May 2016 21:35:41 +0000 (23:35 +0200)]
serialize keys before calling append

5 years agohandle runtime exception same way as ioexception when we reinitialize index storage...
Maxim.Mossienko [Tue, 3 May 2016 21:19:51 +0000 (23:19 +0200)]
handle runtime exception same way as ioexception when we reinitialize index storage with clear (IDEA-152960)

5 years agouse app invokeAndWait in tests by default
peter [Tue, 3 May 2016 21:02:48 +0000 (23:02 +0200)]
use app invokeAndWait in tests by default

5 years agodon't let indexing use meaningless empty editor highlighter
peter [Tue, 3 May 2016 20:52:07 +0000 (22:52 +0200)]
don't let indexing use meaningless empty editor highlighter

5 years agodo lighter checks before calling isChainable that might load AST
peter [Tue, 3 May 2016 20:49:51 +0000 (22:49 +0200)]
do lighter checks before calling isChainable that might load AST

5 years ago- filter out invalid index ids earlier
Maxim.Mossienko [Tue, 3 May 2016 19:55:42 +0000 (21:55 +0200)]
- filter out invalid index ids earlier
- set dirty flag if there is a change in stamps

5 years ago- request for indices during initialization phase should just wait until end of the...
Maxim.Mossienko [Tue, 3 May 2016 19:32:54 +0000 (21:32 +0200)]
- request for indices during initialization phase should just wait until end of the initialization
- add to log names of removed indices

5 years ago - remove absent (in this session) stub indices properly (with logging)
Maxim.Mossienko [Tue, 3 May 2016 19:30:16 +0000 (21:30 +0200)]
 - remove absent (in this session) stub indices properly (with logging)
 - introduce / use static instance of StubIdExternalizer

5 years agofix several hidpi issues with non-scalable insets
Konstantin Bulenkov [Tue, 3 May 2016 19:01:36 +0000 (21:01 +0200)]
fix several hidpi issues with non-scalable insets

5 years agojunit sm runner: restore support for exceptions in before class methods
Anna.Kozlova [Tue, 3 May 2016 18:43:32 +0000 (20:43 +0200)]
junit sm runner: restore support for exceptions in before class methods

5 years agoif provided, search existing tests by location string in order to avoid ambiguity...
Anna.Kozlova [Tue, 3 May 2016 17:08:07 +0000 (19:08 +0200)]
if provided, search existing tests by location string in order to avoid ambiguity caused by same names test methods which come from different tests

5 years agotest presentation: include root comment as qualifier to get root fqName if failed...
Anna.Kozlova [Tue, 3 May 2016 17:07:57 +0000 (19:07 +0200)]
test presentation: include root comment as qualifier to get root fqName if failed with short name

5 years ago[groovy] remove methods that became unused after transformations refactoring
Daniil Ovchinnikov [Tue, 3 May 2016 18:00:03 +0000 (21:00 +0300)]
[groovy] remove methods that became unused after transformations refactoring

5 years agoMerge branch 'dany/groovy-transformations'
Daniil Ovchinnikov [Tue, 3 May 2016 17:34:02 +0000 (20:34 +0300)]
Merge branch 'dany/groovy-transformations'

# Conflicts:
# plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/lang/psi/util/GrClassImplUtil.java

5 years ago[tabs] PanelWithActionsAndCloseButton uses proper close method that disposes individu...
Julia Beliaeva [Fri, 29 Apr 2016 12:49:26 +0000 (15:49 +0300)]
[tabs] PanelWithActionsAndCloseButton uses proper close method that disposes individual tab

5 years ago[tabs] dispose specific tab when closing
Julia Beliaeva [Fri, 29 Apr 2016 12:39:18 +0000 (15:39 +0300)]
[tabs] dispose specific tab when closing

5 years ago[vcs-log] close log tabs on dispose when they are in split mode
Julia Beliaeva [Thu, 28 Apr 2016 21:20:35 +0000 (00:20 +0300)]
[vcs-log] close log tabs on dispose when they are in split mode

5 years ago[vcs-log] close log tab action also works when tabs are in split mode
Julia Beliaeva [Thu, 28 Apr 2016 21:16:15 +0000 (00:16 +0300)]
[vcs-log] close log tab action also works when tabs are in split mode

5 years ago[tabs] merge action disposes old contents after creating new ones
Julia Beliaeva [Thu, 28 Apr 2016 19:22:03 +0000 (22:22 +0300)]
[tabs] merge action disposes old contents after creating new ones

5 years ago[tabs] do not dispose tabs while spliting them
Julia Beliaeva [Thu, 28 Apr 2016 18:40:37 +0000 (21:40 +0300)]
[tabs] do not dispose tabs while spliting them

5 years agoSimplify
Konstantin Bulenkov [Tue, 3 May 2016 16:05:43 +0000 (18:05 +0200)]
Simplify

5 years agocleanup
Konstantin Bulenkov [Tue, 3 May 2016 15:28:34 +0000 (17:28 +0200)]
cleanup

5 years agoadditional constructor for custom line border
Konstantin Bulenkov [Tue, 3 May 2016 15:27:46 +0000 (17:27 +0200)]
additional constructor for custom line border

5 years agofix startOffset used for constructing FindResultUsageInfo
Maxim.Mossienko [Tue, 3 May 2016 15:16:30 +0000 (17:16 +0200)]
fix startOffset used for constructing FindResultUsageInfo

5 years agoMake VcsDirtyScopeVfsListener a service, not a component
Kirill Likhodedov [Tue, 3 May 2016 15:09:43 +0000 (18:09 +0300)]
Make VcsDirtyScopeVfsListener a service, not a component

There is no need to be a component: no sense in listening VFS until
ChangeListManager & VcsDirtyScopeManager are ready anyway.
On the other hand, being a component makes impossible to depend on
the VDSM as a parent component.

5 years agowrong colors when switching from/to Darcula appcode/146.1667 clion/146.1666
Konstantin Bulenkov [Tue, 3 May 2016 14:39:50 +0000 (16:39 +0200)]
wrong colors when switching from/to Darcula

5 years agointroduce JBColor.isBright() for better use with lambdas
Konstantin Bulenkov [Tue, 3 May 2016 14:39:04 +0000 (16:39 +0200)]
introduce JBColor.isBright() for better use with lambdas

5 years agovcs test: use getComponent to get component instead of calling ServiceManager
Kirill Likhodedov [Tue, 3 May 2016 14:07:51 +0000 (17:07 +0300)]
vcs test: use getComponent to get component instead of calling ServiceManager

5 years agonew colors for Info balloons in Darcula
Konstantin Bulenkov [Tue, 3 May 2016 13:25:50 +0000 (15:25 +0200)]
new colors for Info balloons in Darcula

5 years agochange balloon border for Darcula
Konstantin Bulenkov [Tue, 3 May 2016 13:20:23 +0000 (15:20 +0200)]
change balloon border for Darcula

5 years agosm junit: parallel execution for tests (IDEA-148602)
Anna.Kozlova [Tue, 3 May 2016 11:51:38 +0000 (13:51 +0200)]
sm junit: parallel execution for tests (IDEA-148602)

5 years agoremove wrong capture treatment: the completion result is incorrect (IDEA-155188)
peter [Tue, 3 May 2016 12:20:26 +0000 (14:20 +0200)]
remove wrong capture treatment: the completion result is incorrect (IDEA-155188)

5 years agoexcessive logging commented
Eugene Zhuravlev [Tue, 3 May 2016 12:07:56 +0000 (14:07 +0200)]
excessive logging commented

5 years agouse loopback address explicitly when forking external javac
Eugene Zhuravlev [Tue, 3 May 2016 12:02:54 +0000 (14:02 +0200)]
use loopback address explicitly when forking external javac

5 years agosupport JBColor preview in gutter
Konstantin Bulenkov [Tue, 3 May 2016 11:58:42 +0000 (13:58 +0200)]
support JBColor preview in gutter

5 years agoColor Picker: return color with alpha
Konstantin Bulenkov [Tue, 3 May 2016 11:56:38 +0000 (13:56 +0200)]
Color Picker: return color with alpha

5 years agoFile Chooser: Can't set opacity to 255
Konstantin Bulenkov [Tue, 3 May 2016 11:53:13 +0000 (13:53 +0200)]
File Chooser: Can't set opacity to 255

5 years agoPY-19399 Prohibit intention "Convert collection to set" for empty collections appcode/146.1665 clion/146.1664
Mikhail Golubev [Mon, 2 May 2016 19:08:51 +0000 (22:08 +0300)]
PY-19399 Prohibit intention "Convert collection to set" for empty collections

since there is no literal for empty set in Python.

5 years agoPY-16553 Remove comma from one element tuple when converting it to another collection
Mikhail Golubev [Mon, 2 May 2016 18:10:01 +0000 (21:10 +0300)]
PY-16553 Remove comma from one element tuple when converting it to another collection

5 years agoPY-16553 Simpler solution - add missing comma through PSI
Mikhail Golubev [Mon, 2 May 2016 17:32:55 +0000 (20:32 +0300)]
PY-16553 Simpler solution - add missing comma through PSI

5 years agoPY-16553 Add trailing comma when converting single element collection to tuple
Mikhail Golubev [Mon, 2 May 2016 16:55:31 +0000 (19:55 +0300)]
PY-16553 Add trailing comma when converting single element collection to tuple

5 years agohonor the fact that write-unsafe modality nesting doesn't necessarily correspond...
peter [Tue, 3 May 2016 11:32:59 +0000 (13:32 +0200)]
honor the fact that write-unsafe modality nesting doesn't necessarily correspond to transaction nesting

5 years agoallow for cleanup to run later in NormalCompletionTest
peter [Tue, 3 May 2016 11:27:58 +0000 (13:27 +0200)]
allow for cleanup to run later in NormalCompletionTest

5 years agoprohibit sync transactions from swing invokeLater appcode/146.1662 phpstorm/146.1663
peter [Tue, 3 May 2016 08:59:36 +0000 (10:59 +0200)]
prohibit sync transactions from swing invokeLater

5 years agointroduce variable: correct check for cast type clion/146.1661
Anna.Kozlova [Tue, 3 May 2016 08:45:48 +0000 (10:45 +0200)]
introduce variable: correct check for cast type

5 years agofix for output file by short name inside working dir (IDEA-153832)
Anna.Kozlova [Mon, 2 May 2016 17:01:36 +0000 (19:01 +0200)]
fix for output file by short name inside working dir (IDEA-153832)

5 years agorefactorings: collapse same named elements together (IDEA-155284)
Anna.Kozlova [Mon, 2 May 2016 16:38:19 +0000 (18:38 +0200)]
refactorings: collapse same named elements together (IDEA-155284)

5 years agoIDEA-155319 "Run inspection by name" should not reuse "Find Action" search pattern
peter [Tue, 3 May 2016 08:38:43 +0000 (10:38 +0200)]
IDEA-155319 "Run inspection by name" should not reuse "Find Action" search pattern

5 years agovcs: Enabled unversioned files in commit dialog by default appcode/146.1654 clion/146.1656 dbe/146.1650 idea/146.1660 phpstorm/146.1653 pycharm/146.1651 pycharm/146.1658 rubymine/146.1655 webstorm/146.1659
Konstantin Kolosovsky [Mon, 2 May 2016 23:50:47 +0000 (02:50 +0300)]
vcs: Enabled unversioned files in commit dialog by default

5 years agovcs: Added "Show Unversioned Files" toggle button to commit dialog
Konstantin Kolosovsky [Mon, 2 May 2016 23:44:04 +0000 (02:44 +0300)]
vcs: Added "Show Unversioned Files" toggle button to commit dialog

Removed previously used "Show/Hide unversioned files" link.

5 years agoavoid recursive super class reference resolve
peter [Mon, 2 May 2016 20:03:38 +0000 (22:03 +0200)]
avoid recursive super class reference resolve

5 years agokeep lookup element matchers in LookupArranger to distinguish different prefixes...
peter [Mon, 2 May 2016 18:52:36 +0000 (20:52 +0200)]
keep lookup element matchers in LookupArranger to distinguish different prefixes for the same items in subsequent sessions (as Rider produces)

5 years agouse async commit in DocumentationManager
peter [Mon, 2 May 2016 18:39:54 +0000 (20:39 +0200)]
use async commit in DocumentationManager

5 years agoconsider ItemEvent a user activity and allow write actions from it (EA-81912)
peter [Mon, 2 May 2016 18:23:25 +0000 (20:23 +0200)]
consider ItemEvent a user activity and allow write actions from it (EA-81912)

5 years agoPythonSdkDetailsStep: remove seemingly unnecessary invokeLater
peter [Mon, 2 May 2016 18:17:12 +0000 (20:17 +0200)]
PythonSdkDetailsStep: remove seemingly unnecessary invokeLater

5 years agolst: release LST when last editor is closed
Aleksey Pivovarov [Mon, 2 May 2016 18:23:25 +0000 (21:23 +0300)]
lst: release LST when last editor is closed

it was broken in 85108ac - `getEditors` now returns currently releasing editor, if called from `EditorFactoryListener.editorReleased`

5 years agomove transaction write action assertions to a single place, add diagnostics for flaky...
peter [Mon, 2 May 2016 17:05:03 +0000 (19:05 +0200)]
move transaction write action assertions to a single place, add diagnostics for flaky tests

5 years agouse VfsUtilCore.toVirtualFileArray in LocalSearchScope constructor
peter [Mon, 2 May 2016 16:10:38 +0000 (18:10 +0200)]
use VfsUtilCore.toVirtualFileArray in LocalSearchScope constructor

5 years agoread action
Anna.Kozlova [Mon, 2 May 2016 14:30:25 +0000 (16:30 +0200)]
read action

5 years agocleanup — reduce usage of getChildren
Vladimir Krivosheev [Mon, 2 May 2016 15:14:08 +0000 (17:14 +0200)]
cleanup — reduce usage of getChildren

5 years agocleanup — getRootElement
Vladimir Krivosheev [Mon, 2 May 2016 13:14:19 +0000 (15:14 +0200)]
cleanup — getRootElement

5 years agoCurrently, we call getState after loadState immediately on init component persistence...
Vladimir Krivosheev [Mon, 2 May 2016 12:15:38 +0000 (14:15 +0200)]
Currently, we call getState after loadState immediately on init component persistence state.

As a side effect, it also checks that you implement loadState correctly. Because if not — you will get error "Content equals, but it must be handled not on this level: misc.xml" (only in test mode). Yeah — this assertion error is not clear and it is not easy to understand on which level the error is.

5 years agodon't leak stuff via myPreferredFocusedComponent after dialog closing appcode/146.1649 clion/146.1648
peter [Mon, 2 May 2016 14:27:09 +0000 (16:27 +0200)]
don't leak stuff via myPreferredFocusedComponent after dialog closing

5 years agoremove SmartPointerElementInfoFactory extension
peter [Mon, 2 May 2016 11:59:37 +0000 (13:59 +0200)]
remove SmartPointerElementInfoFactory extension

5 years agovcs: detect hasAnyMappings() correctly
Kirill Likhodedov [Mon, 2 May 2016 13:38:12 +0000 (16:38 +0300)]
vcs: detect hasAnyMappings() correctly

By default there is one mapping "" -> <Project>

5 years agoimport tests: multiple selection according to the stored configuration (IDEA-155464)
Anna.Kozlova [Mon, 2 May 2016 09:02:11 +0000 (11:02 +0200)]
import tests: multiple selection according to the stored configuration (IDEA-155464)

5 years agoinvokeAndWait via ApplicationImpl
Kirill Likhodedov [Mon, 2 May 2016 13:15:05 +0000 (16:15 +0300)]
invokeAndWait via ApplicationImpl

5 years agogit: get rid of GitPlatformFacade as not valuable anymore
Kirill Likhodedov [Mon, 2 May 2016 12:31:30 +0000 (15:31 +0300)]
git: get rid of GitPlatformFacade as not valuable anymore

The interface was introduce as an attempt to separate git (dvcs) module
from the rest of the platform, to be able to write module tests
(faster and more reliable than the full-platform one).

However, the idea didn't proove itself: it appeared to be too tedious
to substitute all platform references by the facade methods, while
the platform tests became faster and used now pretty well.

Substitute the usages by actual calls to the platform methods.
Remove GPF usages and methods, or deprecate those which are called
by 3-party plugins.

5 years agomore accurate work with same jar files with different timestamps, we don't need to...
Maxim.Mossienko [Mon, 2 May 2016 12:24:50 +0000 (14:24 +0200)]
more accurate work with same jar files with different timestamps, we don't need to delete such file since it can be used (IDEA-152960)

5 years agosimplify code
Kirill Likhodedov [Mon, 2 May 2016 12:06:30 +0000 (15:06 +0300)]
simplify code

5 years agovcs: use Application#invokeAndWait/Later instead of transactions
Kirill Likhodedov [Mon, 2 May 2016 12:05:35 +0000 (15:05 +0300)]
vcs: use Application#invokeAndWait/Later instead of transactions

invokeAndWait/Later should be enough here.
The runnable code either doesn't care about possible model changes
(e.g. push dialog), or is prepared to them (merge dialog).

5 years agoDon't process VFS events if there are no VCS roots in the project appcode/146.1646 clion/146.1647
Kirill Likhodedov [Wed, 27 Apr 2016 18:39:46 +0000 (21:39 +0300)]
Don't process VFS events if there are no VCS roots in the project

Primarily needed in non-vcs tests.

5 years agorefactor: convert VcsDirtyScopeVfsListener to project component
Kirill Likhodedov [Mon, 18 Apr 2016 18:20:46 +0000 (21:20 +0300)]
refactor: convert VcsDirtyScopeVfsListener to project component

The listener needs the per-project VcsDirtyScopeManager instance
to mark files dirty, so just refer to it instead of identifying
projects for each file and keeping maps of VDSM -> DirtyFiles.

5 years agoextract MethodReferenceResolver.canBeConstructed and use it in completion clion/146.1644 phpstorm/146.1645
peter [Mon, 2 May 2016 09:00:00 +0000 (11:00 +0200)]
extract MethodReferenceResolver.canBeConstructed and use it in completion

5 years agodon't search for stubbed elements inside javadoc comments
peter [Mon, 2 May 2016 08:50:57 +0000 (10:50 +0200)]
don't search for stubbed elements inside javadoc comments

5 years agoensure utf-8 encoding appcode/146.1643
Eugene Zhuravlev [Mon, 2 May 2016 08:23:42 +0000 (10:23 +0200)]
ensure utf-8 encoding

5 years agoredundant write action in tests
Anna.Kozlova [Mon, 2 May 2016 07:52:09 +0000 (09:52 +0200)]
redundant write action in tests

5 years agoIDEA-154276 Suggest method references to constructors of implementing classes when...
peter [Sun, 1 May 2016 19:45:56 +0000 (21:45 +0200)]
IDEA-154276 Suggest method references to constructors of implementing classes when Supplier<AnAbstractClass> is expected

5 years agoIDEA-154336 Missing space after completed @annotation
peter [Sun, 1 May 2016 16:38:31 +0000 (18:38 +0200)]
IDEA-154336 Missing space after completed @annotation

5 years agoIDEA-154816 Do not show "Select classes to import" when "Add imports on the fly"...
peter [Sun, 1 May 2016 16:28:21 +0000 (18:28 +0200)]
IDEA-154816 Do not show "Select classes to import" when "Add imports on the fly" is enabled

5 years ago"too generic method" completion sorting criteria shouldn't be applied in void context...
peter [Sun, 1 May 2016 16:04:18 +0000 (18:04 +0200)]
"too generic method" completion sorting criteria shouldn't be applied in void context (IDEA-154635)

5 years agoIDEA-89222 Navigate file shall accept files names/path starting with ./
peter [Sun, 1 May 2016 15:14:57 +0000 (17:14 +0200)]
IDEA-89222 Navigate file shall accept files names/path starting with ./

5 years agoIDEA-155205 Do not show "Use static import if possible" for live templates in all...
peter [Sun, 1 May 2016 15:03:14 +0000 (17:03 +0200)]
IDEA-155205 Do not show "Use static import if possible" for live templates in all languages

5 years agoIDEA-155309 Complete statement does not work for `default` in `switch`
peter [Sun, 1 May 2016 14:37:31 +0000 (16:37 +0200)]
IDEA-155309 Complete statement does not work for `default` in `switch`

5 years agoIG: do not write default values to settings appcode/146.1633 appcode/146.1641 clion/146.1632 clion/146.1639 dbe/146.1634 idea/146.1636 phpstorm/146.1635 pycharm/146.1637 pycharm/146.1638 rubymine/146.1640 webstorm/146.1642
Bas Leijdekkers [Sun, 1 May 2016 10:18:31 +0000 (12:18 +0200)]
IG: do not write default values to settings

5 years agoSSR: no duplicate results when searching for symbols
Bas Leijdekkers [Fri, 29 Apr 2016 14:31:18 +0000 (16:31 +0200)]
SSR: no duplicate results when searching for symbols

5 years ago[groovy] fix blinking test appcode/146.1629 clion/146.1626 dbe/146.1623 idea/146.1624 phpstorm/146.1627 pycharm/146.1622 pycharm/146.1625 rubymine/146.1628 webstorm/146.1630
Daniil Ovchinnikov [Fri, 29 Apr 2016 18:52:17 +0000 (21:52 +0300)]
[groovy] fix blinking test

5 years agounified exclude/include actions for inspection & find usages tool windows IDEA-154536 appcode/146.1620 clion/146.1619 phpstorm/146.1621
Dmitry Batkovich [Sat, 30 Apr 2016 08:07:56 +0000 (11:07 +0300)]
unified exclude/include actions for inspection & find usages tool windows IDEA-154536

5 years agoinspection tool window: align bottom indent when has no fixes
Dmitry Batkovich [Fri, 29 Apr 2016 12:40:21 +0000 (15:40 +0300)]
inspection tool window: align bottom indent when has no fixes

5 years agoinspection tool window: sync right panel on update action finish fixed
Dmitry Batkovich [Fri, 29 Apr 2016 12:34:32 +0000 (15:34 +0300)]
inspection tool window: sync right panel on update action finish fixed

5 years agoCommit document when necessary
Rustam Vishnyakov [Sat, 30 Apr 2016 07:50:03 +0000 (10:50 +0300)]
Commit document when necessary

5 years agoTestOnlyInspection cleanup
peter [Sat, 30 Apr 2016 07:28:43 +0000 (09:28 +0200)]
TestOnlyInspection cleanup

5 years agoinspection toolwindow: first add view the update view (npes in suppressable nodes)
Dmitry Batkovich [Sat, 30 Apr 2016 05:33:36 +0000 (08:33 +0300)]
inspection toolwindow: first add view the update view (npes in suppressable nodes)

5 years agoWallpaper: always recreate scaled image (esp. on contentLost) appcode/146.1608 clion/146.1609 dbe/146.1606 idea/146.1615 phpstorm/146.1607 pycharm/146.1611 pycharm/146.1617 rubymine/146.1613 webstorm/146.1618
Gregory.Shrago [Fri, 29 Apr 2016 17:19:16 +0000 (20:19 +0300)]
Wallpaper: always recreate scaled image (esp. on contentLost)

5 years agoIDEA-155183 Class autocomplete in META-INF.services duplicate packages
peter [Fri, 29 Apr 2016 20:29:24 +0000 (22:29 +0200)]
IDEA-155183 Class autocomplete in META-INF.services duplicate packages

5 years agoIDEA-154891 IDEA adds unnecessary space/colon on switch case autocompletion
peter [Fri, 29 Apr 2016 18:52:29 +0000 (20:52 +0200)]
IDEA-154891 IDEA adds unnecessary space/colon on switch case autocompletion

5 years agoIDEA-155323 Bogus "Test-only method is called" inspection
peter [Fri, 29 Apr 2016 18:27:39 +0000 (20:27 +0200)]
IDEA-155323 Bogus "Test-only method is called" inspection

5 years agosmart enter during completion inside synchronized expression should put the caret...
peter [Fri, 29 Apr 2016 18:01:16 +0000 (20:01 +0200)]
smart enter during completion inside synchronized expression should put the caret inside the synchronized block