idea/community.git
16 months agoMerge branch 'slava/plugin-incompatible-with'
Vyacheslav Karpukhin [Tue, 12 May 2020 18:09:41 +0000 (20:09 +0200)]
Merge branch 'slava/plugin-incompatible-with'

# Conflicts:
# community/platform/core-impl/src/com/intellij/ide/plugins/IdeaPluginDescriptorImpl.java
# community/platform/core-impl/src/com/intellij/ide/plugins/PluginManagerCore.java
# community/platform/extensions/src/com/intellij/openapi/extensions/PluginDescriptor.java
# community/platform/platform-tests/testData/plugins/sort/simplePluginSort.txt

GitOrigin-RevId: 4ad7f001037c5c3c30e3f185971d3075702bfc41

16 months agoDumbModeTask - replace deprecated usages
Eugene Petrenko [Tue, 12 May 2020 17:13:46 +0000 (19:13 +0200)]
DumbModeTask - replace deprecated usages

GitOrigin-RevId: 9071e5f2e3f5fe5e4d4e1131633045220b9d65d8

16 months ago[workspace model storage] ignore internal 'snapshot' reference when checking 'hasEqua...
Nikolay Chashnikov [Tue, 12 May 2020 15:50:00 +0000 (18:50 +0300)]
[workspace model storage] ignore internal 'snapshot' reference when checking 'hasEqualProperties'

Otherwise it returns false when called for entities with the same properties in different storages, and 'Library.ModifiableModel.isChanged' always returns true.

GitOrigin-RevId: 8e6405773a32403c55a684561d2c0d3bcbacb3a8

16 months ago[project model tests] check return value of Library.ModifiableModel.removeRoot method
Nikolay Chashnikov [Tue, 12 May 2020 14:12:18 +0000 (17:12 +0300)]
[project model tests] check return value of Library.ModifiableModel.removeRoot method

GitOrigin-RevId: 59bcc4a956e56606915cd596ca856f8bca95946e

16 months ago[project model tests] check LibraryEx::getSource for modifiable library model
Nikolay Chashnikov [Tue, 12 May 2020 14:11:38 +0000 (17:11 +0300)]
[project model tests] check LibraryEx::getSource for modifiable library model

In some places in platform code (e.g. StructureConfigurableContext.findLibraryModel) may cast Library.ModifiableModel to Library and later invoke LibraryEx::getSource on it, so we need to check it.

GitOrigin-RevId: adafbf059b872b69fb512518811869da3e3e605b

16 months ago[workspace model] Add base test case for store
Mikhail Mazurkevich [Tue, 12 May 2020 16:39:03 +0000 (19:39 +0300)]
[workspace model] Add base test case for store

GitOrigin-RevId: f20f5791d36ede394a551ae168dde804bc3aa0dc

16 months ago[workspace model] External index returns not nullable element
Mikhail Mazurkevich [Tue, 12 May 2020 12:55:59 +0000 (15:55 +0300)]
[workspace model] External index returns not nullable element

GitOrigin-RevId: 57da3448dcaa831255d5eb95eced791148249d49

16 months agoDumbModeTask - update documentation, deprecate, force getEquivalenceObject to be...
Eugene Petrenko [Tue, 12 May 2020 17:06:14 +0000 (19:06 +0200)]
DumbModeTask - update documentation, deprecate, force getEquivalenceObject to be used

We deprecate default constructor of the object to enforce every task to
implement the getEquivalenceObject() clearly. For example to avoid IDEA-240591
scenario from happening.

It is too easy to mistakenly pass a too generic object as the EquivalenceObject
and have two different tasks merged. To overcome that,
we change the implementation to return a pair a given EquivalenceObject and getClass()

GitOrigin-RevId: 73e5716a1296243a5077647fd6982531fe3e33d5

16 months agosettings-repository: fix package name
Kirill Likhodedov [Sat, 9 May 2020 19:03:53 +0000 (22:03 +0300)]
settings-repository: fix package name

GitOrigin-RevId: e92b5e08535b94b4e7bfcce6311b955c71021d33

16 months agono need to sort twice, fields are sorted already inside the XValueContainerNode
Egor Ushakov [Tue, 12 May 2020 16:48:28 +0000 (19:48 +0300)]
no need to sort twice, fields are sorted already inside the XValueContainerNode

GitOrigin-RevId: f29b539a4e746da453ba77ebed6691cf59b998bd

16 months agorename "Groovy" library to "org.codehaus.groovy:groovy" for consistency
Daniil Ovchinnikov [Tue, 12 May 2020 15:56:56 +0000 (18:56 +0300)]
rename "Groovy" library to "org.codehaus.groovy:groovy" for consistency

GitOrigin-RevId: 515c9c93fba3c6104c7c42b75373c7867321843b

16 months agoavoid excessive memory usage by editor scrollbar hover popup in presence of block...
Dmitry Batrak [Tue, 12 May 2020 16:28:49 +0000 (19:28 +0300)]
avoid excessive memory usage by editor scrollbar hover popup in presence of block inlays

GitOrigin-RevId: 47e7e5146b53d6717c805d53c0c1dd8fd36e4fa4

16 months agoIndex diagnostic: calculate time statistics for all threads at once.
Sergey Patrikeev [Tue, 12 May 2020 12:54:06 +0000 (15:54 +0300)]
Index diagnostic: calculate time statistics for all threads at once.

GitOrigin-RevId: 12702c35ba728a2d9f750a053c873ccd69e6203d

16 months agoIndex diagnostic: fix calculation of per-indexer spent time.
Sergey Patrikeev [Tue, 12 May 2020 12:25:10 +0000 (15:25 +0300)]
Index diagnostic: fix calculation of per-indexer spent time.

GitOrigin-RevId: 335d1bfcbb431762cb3aa5ef5cdf5163d3acee6a

16 months agoIDEA-240647: Indexes must stop iterating files when project (or even application...
Sergey Patrikeev [Tue, 12 May 2020 10:13:52 +0000 (13:13 +0300)]
IDEA-240647: Indexes must stop iterating files when project (or even application) is disposed.

GitOrigin-RevId: 18ac7d92a71f01535b5ea2cc383108eedee3b786

16 months agoinspections: drop JavaCommandLineInspectionProjectConfigurator
Eugene Petrenko [Mon, 11 May 2020 15:04:41 +0000 (17:04 +0200)]
inspections: drop JavaCommandLineInspectionProjectConfigurator

The UnknownSdkInspectionCommandLineConfigurator does a bit more advanced configuration

GitOrigin-RevId: 5a6a3e96eba6702c5cbbcdd2e7f0d5862c7a511f

16 months agoPY-40431 i18n: Add non-python UI strings to bundles
Lada Gagina [Wed, 6 May 2020 11:27:35 +0000 (14:27 +0300)]
PY-40431 i18n: Add non-python UI strings to bundles

GitOrigin-RevId: 90b88f80e0c8d1cb1c2ae3a016024c817d74271e

16 months agoadd equivalence object for UnindexedFilesUpdater
Dmitry Batkovich [Tue, 12 May 2020 15:09:49 +0000 (18:09 +0300)]
add equivalence object for UnindexedFilesUpdater

GitOrigin-RevId: 8fe4701c1f07ab58eee3392c30e61429dc605ebd

16 months agofix UnknownSdkInspectionCommandLineConfigurator & shared-indexes import
Eugene Petrenko [Mon, 11 May 2020 15:54:29 +0000 (17:54 +0200)]
fix UnknownSdkInspectionCommandLineConfigurator & shared-indexes import

GitOrigin-RevId: a4f5c7a9f89253313f02553b04f721da9f611682

16 months agoinspections: change API to allow configuring projects without AnalysisScope
Eugene Petrenko [Mon, 11 May 2020 14:59:11 +0000 (16:59 +0200)]
inspections: change API to allow configuring projects without AnalysisScope

GitOrigin-RevId: f58e7de590feaec177bba97905dba8169c2c09fb

16 months agosimplify doc rendering code a bit
Dmitry Batrak [Tue, 12 May 2020 14:50:21 +0000 (17:50 +0300)]
simplify doc rendering code a bit

there's no need to restore scrolling position twice

GitOrigin-RevId: f4396d572f0b2ea2b90e22a6b0105de84567d7cf

16 months agoIDEA-238114 IntelliJ Idea 2020.1 memory runaway and crash
Dmitry Batrak [Tue, 12 May 2020 14:21:52 +0000 (17:21 +0300)]
IDEA-238114 IntelliJ Idea 2020.1 memory runaway and crash

minor fix

GitOrigin-RevId: 301029bbf6bf789e5d1f431a208944dea2c34315

16 months agofind in path: add api to use other search engines than built-in trigram index based one
Dmitry Batkovich [Tue, 12 May 2020 10:55:04 +0000 (13:55 +0300)]
find in path: add api to use other search engines than built-in trigram index based one

GitOrigin-RevId: 41c0bec0c34f010a78d3c722bf7346a35f6f2b69

16 months agoignore reparse events in file type detection service (fix to use requestor instead...
Dmitry Batkovich [Tue, 12 May 2020 07:06:56 +0000 (10:06 +0300)]
ignore reparse events in file type detection service (fix to use requestor instead of property name)

GitOrigin-RevId: af65295fac8596de0c27698720f0c26e7f6d1f8b

16 months agoindexes: extract corruption marker logic to separate class
Dmitry Batkovich [Sat, 9 May 2020 05:58:57 +0000 (08:58 +0300)]
indexes: extract corruption marker logic to separate class

GitOrigin-RevId: 04703580c46e207a91b801aaf322bd8e766734cd

16 months agoCleanup (formatting)
Roman Shevchenko [Tue, 12 May 2020 14:23:34 +0000 (16:23 +0200)]
Cleanup (formatting)

GitOrigin-RevId: 885ab8974896099984e0d89f78af36bf45bf7f38

16 months ago[tests] releasing .jar file in `ClsResolveTest` to allow temp. directory cleanup...
Roman Shevchenko [Tue, 12 May 2020 14:22:28 +0000 (16:22 +0200)]
[tests] releasing .jar file in `ClsResolveTest` to allow temp. directory cleanup on Windows

GitOrigin-RevId: 6797ab463bd4f08e97375c34a7fd7c23b6db5bb5

16 months agoIDEA-238114 IntelliJ Idea 2020.1 memory runaway and crash
Dmitry Batrak [Tue, 12 May 2020 14:09:49 +0000 (17:09 +0300)]
IDEA-238114 IntelliJ Idea 2020.1 memory runaway and crash

GitOrigin-RevId: 0a14acc00e9675cba64c2e676062606de1fddd00

16 months ago[jps-cache] don't write source urls to log by default
Kirill Timofeev [Tue, 12 May 2020 14:09:27 +0000 (17:09 +0300)]
[jps-cache] don't write source urls to log by default

GitOrigin-RevId: a474eb714317c20bfd82aa50a42e425b898de19b

16 months ago[jps-cache] `SegmentedProgressIndicatorManager`: setIndeterminate(false) to suppress...
Kirill Timofeev [Tue, 12 May 2020 14:05:03 +0000 (17:05 +0300)]
[jps-cache] `SegmentedProgressIndicatorManager`: setIndeterminate(false) to suppress warnings in idea.log

GitOrigin-RevId: a9de2a9af0c353c13766ebb5dbe4c0e14c95b0e3

16 months ago[codeInsight] Cleanup the equals expression
Nikita Eshkeev [Tue, 12 May 2020 13:22:09 +0000 (16:22 +0300)]
[codeInsight] Cleanup the equals expression

This patch cleans up the equals expression as per IDEA's suggestion

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>
GitOrigin-RevId: 7751ec5007983369f70b4f8b50a9b35721dec74e

16 months ago[codeInsight] IDEA-240288 Inspection for StringBuilder.toString().substring()
Nikita Eshkeev [Tue, 12 May 2020 13:19:44 +0000 (16:19 +0300)]
[codeInsight] IDEA-240288 Inspection for StringBuilder.toString().substring()

This patch simplifies the `RedundantStringOperationInspection#isOperandOfStringType` method for operands of the `PsiReferenceExpression` type by checking if its type is `java.lang.String`

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>
GitOrigin-RevId: 75aeb2af005f38e57e1570ed12beaf499023fd04

16 months ago[jps-cache] show notification when can't doGetRequest
Kirill Timofeev [Tue, 12 May 2020 13:50:27 +0000 (16:50 +0300)]
[jps-cache] show notification when can't doGetRequest

GitOrigin-RevId: 4c1ac2a92e6822068e63b71b5eb6af47b0984f4a

16 months ago[workspace model] cleanup: remove obsolete todos
Nikolay Chashnikov [Tue, 12 May 2020 13:48:06 +0000 (16:48 +0300)]
[workspace model] cleanup: remove obsolete todos

GitOrigin-RevId: a49c3a9d37a05488f117544def4779b6c3b15306

16 months ago[project model] mark first parameter of ModifiableArtifact::setProperties as @NotNull
Nikolay Chashnikov [Tue, 12 May 2020 13:46:32 +0000 (16:46 +0300)]
[project model] mark first parameter of ModifiableArtifact::setProperties as @NotNull

Otherwise 'null' key in myProperties map will cause exceptions later (see IDEA-240496).

GitOrigin-RevId: 742258b412fce199fbb278fcf61a6d3f30a787b8

16 months agoShow full list of components in Analyze Unloadable Plugins
Dmitry Jemerov [Tue, 12 May 2020 13:43:25 +0000 (15:43 +0200)]
Show full list of components in Analyze Unloadable Plugins

GitOrigin-RevId: 76c2b29082f6da6906205e2f9af43f57bf036525

16 months agoAvoid calling saveDisabledPlugins() directly
Dmitry Jemerov [Mon, 11 May 2020 18:13:54 +0000 (20:13 +0200)]
Avoid calling saveDisabledPlugins() directly

GitOrigin-RevId: 2afba09e4e8edf7a906db3004f5256398b137bf8

16 months agoExtract code dealing with disabled_plugins.txt to a separate class
Dmitry Jemerov [Mon, 11 May 2020 17:57:53 +0000 (19:57 +0200)]
Extract code dealing with disabled_plugins.txt to a separate class

GitOrigin-RevId: d510996d6664ff39daec39762b8060b31e5659e6

16 months agoDon't unload plugins if the user is closing the application
Dmitry Jemerov [Mon, 11 May 2020 17:30:10 +0000 (19:30 +0200)]
Don't unload plugins if the user is closing the application

GitOrigin-RevId: ca851b29e3aec0b4e085a0d6d560646f976138ee

16 months agoChange to non-dumb-aware activity so that plugin enabling interferes less with startu...
Dmitry Jemerov [Mon, 11 May 2020 17:22:13 +0000 (19:22 +0200)]
Change to non-dumb-aware activity so that plugin enabling interferes less with startup activities

GitOrigin-RevId: e85b823d8dd3eff825124f7d6c0e1bf9b5d3df41

16 months agoCommand line option to disable reopening projects (IDEA-235494)
Dmitry Jemerov [Mon, 11 May 2020 17:09:34 +0000 (19:09 +0200)]
Command line option to disable reopening projects (IDEA-235494)

GitOrigin-RevId: 8050c5b2a343d1833ae245d1b0d338cca33832e2

16 months agoWait for project view to finish updating only when removing extensions, not when...
Dmitry Jemerov [Mon, 11 May 2020 16:16:02 +0000 (18:16 +0200)]
Wait for project view to finish updating only when removing extensions, not when adding them

GitOrigin-RevId: c0567173fd07d5e3fee37286084a0eadc3691189

16 months agoInitial support for loading required plugins without restart
Dmitry Jemerov [Mon, 11 May 2020 15:47:33 +0000 (17:47 +0200)]
Initial support for loading required plugins without restart

GitOrigin-RevId: 56fc657ed7636dfbb3e1f09093f5c732669ccd30

16 months agoMove loadFullDescriptor() to PluginDescriptorLoader (better cohesion)
Dmitry Jemerov [Mon, 11 May 2020 12:30:16 +0000 (14:30 +0200)]
Move loadFullDescriptor() to PluginDescriptorLoader (better cohesion)

GitOrigin-RevId: e86763ec72a82bab9b1c5af323cada97d94aa352

16 months agoIDEA-182563 EditorConfig: support "utf-8-bom" charset
Rustam Vishnyakov [Tue, 12 May 2020 12:40:49 +0000 (15:40 +0300)]
IDEA-182563 EditorConfig: support "utf-8-bom" charset

GitOrigin-RevId: 2fd00d1c46e5050ccfc6a2920db96f23e6d2e920

16 months ago[i18n] restore line breaks which were removed from some error messages by mistake...
Nikolay Chashnikov [Tue, 12 May 2020 12:41:49 +0000 (15:41 +0300)]
[i18n] restore line breaks which were removed from some error messages by mistake (IDEA-240549)

Before IDEA-234115 is fixed "I18nize hardcoded string literal" quick fix removed line breaks while extracting string to a property file.

GitOrigin-RevId: 79a54a2eae106e9f94bbee5b88c13e6eeb7ab7f2

16 months ago[git-index] init stage tracker and toolwindow tab on registry option changes
Julia Beliaeva [Mon, 11 May 2020 19:54:43 +0000 (22:54 +0300)]
[git-index] init stage tracker and toolwindow tab on registry option changes

GitOrigin-RevId: 2a59a489520cd2babba0edb4313d4a06bc9e32b0

16 months agoDon't suggest rename refactoring for overload name changes by now (PY-42285)
Semyon Proshev [Tue, 12 May 2020 12:18:50 +0000 (15:18 +0300)]
Don't suggest rename refactoring for overload name changes by now (PY-42285)

Should be revised later.

GitOrigin-RevId: 1b17b4c630bf0e90fcbc337340e04b886de30391

16 months agoSuggested rename refactoring for Python (PY-42285)
Semyon Proshev [Wed, 6 May 2020 23:24:43 +0000 (02:24 +0300)]
Suggested rename refactoring for Python (PY-42285)

GitOrigin-RevId: 73a699111b968abae93dbfa802b568f734c9a1e8

16 months agoIDEA-CR-62520: PY-41889 #1347 Fix Python Console focus
Daniel Schmidt [Thu, 30 Apr 2020 08:15:46 +0000 (11:15 +0300)]
IDEA-CR-62520: PY-41889 #1347 Fix Python Console focus

Signed-off-by: Elizaveta Shashkova <Elizaveta.Shashkova@jetbrains.com>
GitOrigin-RevId: 0af296ba68285e03bac44d5113c842851cd15452

16 months ago[workspace model] Add API to work with external index
Mikhail Mazurkevich [Tue, 12 May 2020 12:15:11 +0000 (15:15 +0300)]
[workspace model] Add API to work with external index

GitOrigin-RevId: be4a9ac9e6f83312284d6d7580fd01b2f3ce7099

16 months ago[vcs] improve error messages for add, reset and revert operations
Julia Beliaeva [Tue, 12 May 2020 11:55:31 +0000 (14:55 +0300)]
[vcs] improve error messages for add, reset and revert operations

GitOrigin-RevId: 4a0e21a77b6a0d1c3efbed5b5bc6f98681b8fec5

16 months ago[project model] add more tests for project model classes
Nikolay Chashnikov [Tue, 12 May 2020 11:13:47 +0000 (14:13 +0300)]
[project model] add more tests for project model classes

Check ModifiableModuleModel methods and test renaming of modules.

GitOrigin-RevId: 33d834c8e73493c9e3d458dd6020ef1a1f962648

16 months ago[groovy] IDEA-209501 bundle groovy jar instead of groovy-all jar
Daniil Ovchinnikov [Tue, 12 May 2020 11:44:37 +0000 (14:44 +0300)]
[groovy] IDEA-209501 bundle groovy jar instead of groovy-all jar

GitOrigin-RevId: a5555084649a91a879811680daf001a49809f8c9

16 months agoWEB-31198 Webstorm throws error because of not knowing Angular's '&ngsp;' html entity
Piotr Tomiak [Tue, 12 May 2020 09:18:40 +0000 (11:18 +0200)]
WEB-31198 Webstorm throws error because of not knowing Angular's '&ngsp;' html entity

GitOrigin-RevId: 8a761dad86fba45899bfe2b4fd6be21d6a30ec67

16 months agoTarget API for Java: when instantiating debugger, connect to `localhost` instead...
Vladimir Lagunov [Tue, 12 May 2020 07:33:16 +0000 (14:33 +0700)]
Target API for Java: when instantiating debugger, connect to `localhost` instead of `0.0.0.0`.

Forcing targets to bind sockets to 0.0.0.0 is insecure.

GitOrigin-RevId: 00bf21c18322fab0675b69379133e658f5cf4c37

16 months agoSpace plugin merged
Dmitriy.Panov [Tue, 12 May 2020 11:10:53 +0000 (14:10 +0300)]
Space plugin merged

GitOrigin-RevId: 340aa1bbe3cf22cac94336d667de107c05e599d2

16 months agoIDEA-CR-62464: SSH: New SshPasswordProvider.
Vladimir Lagunov [Wed, 6 May 2020 07:17:31 +0000 (14:17 +0700)]
IDEA-CR-62464: SSH: New SshPasswordProvider.

The main goal is to prepare SshPasswordProvider interface for password dialogs.

Brief changes:
* Prompts about host key verification moved out of the class.
* Removed methods `askPassphrase` and `askPassword` that expected to show to user hard-coded text messages.
* `getPassword` renamed to `getUnixPassword`.
* `getPassphrase` renamed to `getKeyPassphrase`, path to the key passes as an argument.
* Removed all other ways to specify password or passphrase, all password requests passes through SshPasswordProvider.

(cherry picked from commit d39f42767c5f7cbc1c7a18695ab7c7d2c3eecd06)

GitOrigin-RevId: 58c7f2d41302f98064b472e214586168be54c218

16 months ago[java] IDEA-209501 use library from the repo instead of bundled library in ResolveInL...
Daniil Ovchinnikov [Tue, 12 May 2020 10:52:42 +0000 (13:52 +0300)]
[java] IDEA-209501 use library from the repo instead of bundled library in ResolveInLibrariesTest

GitOrigin-RevId: dbac28a24ad008f127ed13d4e083af62c49220c6

16 months ago[vcs] simplify BaseSingleTaskController names
Julia Beliaeva [Tue, 12 May 2020 10:27:30 +0000 (13:27 +0300)]
[vcs] simplify BaseSingleTaskController names

They are used only for logging, so fancy names aren't needed.

GitOrigin-RevId: 5df20952a7a9584bb1bb497e97c579f79a408fe3

16 months agoPsiClassType#getPsiContext: (hopefully) better JavaDoc
Tagir Valeev [Tue, 12 May 2020 10:32:17 +0000 (17:32 +0700)]
PsiClassType#getPsiContext: (hopefully) better JavaDoc

Review ID: IDEA-CR-62110

GitOrigin-RevId: 2967565a486b01b5ec9d4588cf6f00890a6dd127

16 months agoAndroid: ignore tests in `com.android.tools.idea.common.analytics.CommonUsageTrackerI...
Andrei Kuznetsov [Fri, 8 May 2020 16:34:21 +0000 (19:34 +0300)]
Android: ignore tests in `com.android.tools.idea.common.analytics.CommonUsageTrackerImplTest`

Incorrect mock configuration in AOSP. Ignore for now.

GitOrigin-RevId: 48583841067f828b409730d3868788c82c22f8bb

16 months agoAndroid: Fix leaking MergingUpdateQueue in NlModel; fix & enable most of naveditor...
Andrei Kuznetsov [Thu, 7 May 2020 17:21:21 +0000 (20:21 +0300)]
Android: Fix leaking MergingUpdateQueue in NlModel; fix & enable most of naveditor tests

Also (temporarily) exclude tests from `com.android.tools.idea.uibuilder.*` which haven't run prior to this commit, because corresponding classes were missing in test class path.

GitOrigin-RevId: c641396509340db3a23bd4df14521b82a0030f14

16 months agoIDEA-240641 diff: fix synchronized scrolling with inlays of any height
Aleksey Pivovarov [Tue, 12 May 2020 10:13:28 +0000 (13:13 +0300)]
IDEA-240641 diff: fix synchronized scrolling with inlays of any height

We can't assume that heights of all inlays is a multiple of lineHeight.

GitOrigin-RevId: f4a68cc50da0b8673ee72d92df92f2a371aa1b39

16 months agoIDEA-CR-62370: normalize primitive if with yield statement
Alexandr Suhinin [Tue, 12 May 2020 10:20:46 +0000 (13:20 +0300)]
IDEA-CR-62370: normalize primitive if with yield statement

GitOrigin-RevId: 8b8b1c6be766589d7dbff6e08ceaccfe51140d12

16 months agoFix name in commment
Dmitry Trofimov [Tue, 12 May 2020 10:17:16 +0000 (12:17 +0200)]
Fix name in commment

GitOrigin-RevId: e2dfc53e4cf77212fc240682e9050fae911c36bb

16 months ago[github] Acquire service once to avoid recreating it during dispose
Ivan Semenov [Fri, 8 May 2020 14:41:56 +0000 (17:41 +0300)]
[github] Acquire service once to avoid recreating it during dispose

GitOrigin-RevId: e2378116569a72338b7a4728085252953cfab07b

16 months ago[github] Cleanup
Ivan Semenov [Fri, 8 May 2020 14:41:21 +0000 (17:41 +0300)]
[github] Cleanup

GitOrigin-RevId: 261248777304f695664682a34b02b033734872ed

16 months ago[debugger] fixed navigation to several available classes when run with alternative jre
Egor Ushakov [Tue, 12 May 2020 10:15:43 +0000 (13:15 +0300)]
[debugger] fixed navigation to several available classes when run with alternative jre

GitOrigin-RevId: 2882ce9d663fbf5ecf68b950bd4b4413b2956203

16 months agoDisable SetupJavaProjectFromSourcesActivity in headless mode
alexey.afanasiev [Tue, 12 May 2020 10:09:08 +0000 (13:09 +0300)]
Disable SetupJavaProjectFromSourcesActivity in headless mode

GitOrigin-RevId: 4fa972946abcb0a782e53d3e119ad4a0efdd64ec

16 months agoContainerUtil#mapNotNull: mark lambda return value as Nullable to prevent nullability...
Tagir Valeev [Tue, 12 May 2020 10:07:31 +0000 (17:07 +0700)]
ContainerUtil#mapNotNull: mark lambda return value as Nullable to prevent nullability inference

GitOrigin-RevId: 974e6dc4ebcad8bf8b0ce085e3dd4aca54470df1

16 months agoreplace duplicates: add test logging
Anna Kozlova [Tue, 12 May 2020 09:38:45 +0000 (11:38 +0200)]
replace duplicates: add test logging

GitOrigin-RevId: 6739380f8544bc42b0181e241a0e250ac865b7a8

16 months agodrop run configuration templates on unload (WEB-45459)
Sergey Simonchik [Tue, 12 May 2020 09:22:01 +0000 (12:22 +0300)]
drop run configuration templates on unload (WEB-45459)

GitOrigin-RevId: 357d31dcb9db1be72abd08b33a30bd5b02afbbd3

16 months ago[groovy] IDEA-209501 use library from the repo instead of bundled library for compile...
Daniil Ovchinnikov [Tue, 12 May 2020 09:19:08 +0000 (12:19 +0300)]
[groovy] IDEA-209501 use library from the repo instead of bundled library for compiler tests

GitOrigin-RevId: be31e52f5c284f8fea431c271d8ce5abe932e8c7

16 months agodynamic: deleted CachedDomModel/CachedDomModelFactory(s)
sergey.vasiliev [Tue, 12 May 2020 08:38:52 +0000 (10:38 +0200)]
dynamic: deleted CachedDomModel/CachedDomModelFactory(s)

GitOrigin-RevId: e68942dc10d60217ad2be24d485f02330f5be45c

16 months agodynamic: deleted CachedDomModel/CachedDomModelFactory(s)
sergey.vasiliev [Mon, 11 May 2020 19:22:55 +0000 (21:22 +0200)]
dynamic: deleted CachedDomModel/CachedDomModelFactory(s)

GitOrigin-RevId: d15b617c58da71c3e5d7d6d5ff902e9dd0565a8e

16 months agoCWM-94 Code with me action control
graann [Mon, 11 May 2020 07:56:43 +0000 (10:56 +0300)]
CWM-94 Code with me action control

GitOrigin-RevId: d86d08f36d2832fc8de3a4668dd232e4de9be26d

16 months agoEA-231560: fix npe in vcs features calculation
Alexey Kalina [Tue, 12 May 2020 09:02:57 +0000 (12:02 +0300)]
EA-231560: fix npe in vcs features calculation

GitOrigin-RevId: 1819762a3007b4bce09d756bca12e5b1e7914adf

16 months agoIDEA-239695: fix not valid file in recent places listener
Alexey Kalina [Tue, 12 May 2020 08:53:25 +0000 (11:53 +0300)]
IDEA-239695: fix not valid file in recent places listener

GitOrigin-RevId: cac371a057003bcafb921cb1c0bafdc9a8743677

16 months agoIDEA-239776 Add Inspection warning for AssertJ assertThat(x).isEqualTo(y) when x...
Tagir Valeev [Tue, 12 May 2020 09:00:14 +0000 (16:00 +0700)]
IDEA-239776 Add Inspection warning for AssertJ assertThat(x).isEqualTo(y) when x and y are inconvertible.

GitOrigin-RevId: 71c8a3cd6b80b89c2f67531083844b092d3a2a53

16 months agoUIDefaults class NonNls
Tagir Valeev [Tue, 12 May 2020 08:46:09 +0000 (15:46 +0700)]
UIDefaults class NonNls

GitOrigin-RevId: ca975bf73516d8fa0fcabde6c3c2d70f6ed9512c

16 months agoWarnings fixed
Tagir Valeev [Tue, 12 May 2020 08:39:38 +0000 (15:39 +0700)]
Warnings fixed

GitOrigin-RevId: 7c6de64a4329ab627ba142a31c738d4601a76515

16 months agocoverage: update asm to 8.0.1 with support for java 14 (IDEA-240028)
Anna Kozlova [Tue, 12 May 2020 08:59:56 +0000 (10:59 +0200)]
coverage: update asm to 8.0.1 with support for java 14 (IDEA-240028)

GitOrigin-RevId: 1b836a31da762c86ac48f441e191b2e08d25ac5e

16 months agojava redundant cast: cleanup assertions
Anna Kozlova [Tue, 12 May 2020 08:57:30 +0000 (10:57 +0200)]
java redundant cast: cleanup assertions

GitOrigin-RevId: 04457ca9d4afcb1e1309149476ddbf49319f250f

16 months ago[jps-caches] Always update metadata
Ilia Shulgin [Tue, 12 May 2020 08:51:29 +0000 (11:51 +0300)]
[jps-caches] Always update metadata

GitOrigin-RevId: 755c2761ec1af925f875d113d6d2a7635820a28c

16 months agocoverage: use self as parent disposable to enable plugin unloading
Anna Kozlova [Tue, 12 May 2020 08:14:04 +0000 (10:14 +0200)]
coverage: use self as parent disposable to enable plugin unloading

GitOrigin-RevId: 9d4e5668a8a91a2d94d67c36e103b636cb421370

16 months agocopyright: register listener on appService of the same plugin
Anna Kozlova [Tue, 12 May 2020 08:10:15 +0000 (10:10 +0200)]
copyright: register listener on appService of the same plugin

GitOrigin-RevId: bcaea0f9208439732cf317f7278bc55db834c087

16 months agojava redundant cast: allow casts to same type as expected only
Anna Kozlova [Tue, 12 May 2020 08:03:22 +0000 (10:03 +0200)]
java redundant cast: allow casts to same type as expected only

require isAssignable check as otherwise it may lead to error

GitOrigin-RevId: 79ac8a4b7e2b8c2ff4be97ad005fd8e26ce5ec20

16 months agoIDEA-240285 ConstantConditions: improve detection of pointless 'Math.min' and 'Math...
Tagir Valeev [Tue, 12 May 2020 05:36:52 +0000 (12:36 +0700)]
IDEA-240285 ConstantConditions: improve detection of pointless 'Math.min' and 'Math.max' operations

+Quick-fix

GitOrigin-RevId: 9f01fac2ecd4faf7ff76101a956cc30582ad421b

16 months agoWEB-45429 SVG: Attributes are shown as invalid when using `svg:` prefix
Piotr Tomiak [Tue, 12 May 2020 07:42:16 +0000 (09:42 +0200)]
WEB-45429 SVG: Attributes are shown as invalid when using `svg:` prefix

IDEA-CR-62489

GitOrigin-RevId: 0e3e5266b197f03b374f833aa175cb5fb11f6292

16 months ago[platform] updating to ASM 8.0.1
Roman Shevchenko [Tue, 12 May 2020 05:57:42 +0000 (07:57 +0200)]
[platform] updating to ASM 8.0.1

GitOrigin-RevId: 66a752d22274adb0690a1f9b446d75e825592b2b

16 months ago[java] ASM 8 forward compatibility fix for debugger utils (IDEA-208372)
Roman Shevchenko [Tue, 12 May 2020 05:35:00 +0000 (07:35 +0200)]
[java] ASM 8 forward compatibility fix for debugger utils (IDEA-208372)

GitOrigin-RevId: 3471bf284fea3d09625af7cd1771ba479bcf6054

16 months agoCondition.getValueComparedTo: remove incorrect recursive call
Tagir Valeev [Tue, 12 May 2020 04:59:43 +0000 (11:59 +0700)]
Condition.getValueComparedTo: remove incorrect recursive call

GitOrigin-RevId: d7cb08f88167a19755c92c869a19db582d8b4d2a

16 months agoSuspiciousDateFormatInspection: revert to hasNeighbor and add negative tests (IDEA...
Tagir Valeev [Tue, 12 May 2020 04:26:33 +0000 (11:26 +0700)]
SuspiciousDateFormatInspection: revert to hasNeighbor and add negative tests (IDEA-CR-62389)

GitOrigin-RevId: 57e403967c7c3012baffc5b11ea9a4184d71a99f

16 months agocharLiteralForCharString more clear JavaDoc
Tagir Valeev [Tue, 12 May 2020 04:21:30 +0000 (11:21 +0700)]
charLiteralForCharString more clear JavaDoc

GitOrigin-RevId: 6a9ee4432d366c579aceb61649394875c3257375

16 months agoAvoid inlining lambdas not from local scope
Tagir Valeev [Tue, 12 May 2020 04:17:49 +0000 (11:17 +0700)]
Avoid inlining lambdas not from local scope

When lambda is defined in the outer scope a number of problems may appear during the analysis. First, it actually could be analyzed twice producing different warnings (in inlining context, and as standalone expression). Second, trap-handling assumes that all exited expressions should appear within the current codeFragment. This could be violated when lambda comes from the outer scope, resulting in incorrect jumps.

Fixes IDEA-240328 Condition always false inspection is wrong if using switch expressions

GitOrigin-RevId: 11794502d2e661044fa2105402955aa54e3c1245

16 months agoExceptionWorker: support proxies
Tagir Valeev [Mon, 11 May 2020 03:46:29 +0000 (10:46 +0700)]
ExceptionWorker: support proxies

GitOrigin-RevId: 6b4641114a31a0d963544cbb684da983f0eade02

16 months ago[codeInsight] IDEA-240288 Inspection for StringBuilder.toString().substring()
Nikita Eshkeev [Mon, 11 May 2020 23:15:19 +0000 (02:15 +0300)]
[codeInsight] IDEA-240288 Inspection for StringBuilder.toString().substring()

This patch alters the `getRedundantStringBuilderToStringProblem` method with more sophisticated algorithm to detect unnecessary freestanding `StringBuilder#toString` calls. If the call is a part of a polyadic expression it checks if there is at least one string operand (either a constant literal or a local variable or a constant variable or a method call) and based on that information it detects redundant `StringBuilder#toString` calls.

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>
GitOrigin-RevId: e09ea8b8829ad9e28e8ff1bcfad34cf6b191aa6b

16 months agoTuned "incompatible-with" diagnostic message
Vyacheslav Karpukhin [Mon, 11 May 2020 23:23:55 +0000 (01:23 +0200)]
Tuned "incompatible-with" diagnostic message

GitOrigin-RevId: 847fb3247bce68da73f03bba6f08f503ea2e0151

16 months agoInclude "incompatible-with" relationship into topological sorting of the plugins
Vyacheslav Karpukhin [Mon, 11 May 2020 23:13:18 +0000 (01:13 +0200)]
Include "incompatible-with" relationship into topological sorting of the plugins

GitOrigin-RevId: de15b7754040541012589df919562452189808fb