immutable map instance can be safely passed outside

diff --git a/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesTextFieldWithBrowseButton.java b/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesTextFieldWithBrowseButton.java
index 186aa88ceb6ecbebf3c5881ceacc53bdfc594581..c5d443f5a039964ef1c4de8d5fed38d76270ef74 100644 (file)
--- a/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesTextFieldWithBrowseButton.java
+++ b/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesTextFieldWithBrowseButton.java
@@ -43,6 +43,7 @@ import java.util.List;
 
 public class EnvironmentVariablesTextFieldWithBrowseButton extends TextFieldWithBrowseButton implements UserActivityProviderComponent {
 
+  // immutable map instance with reliable user-specified iteration order
   private Map<String, String> myEnvs = Collections.emptyMap();
   private boolean myPassParentEnvs;
   private final List<ChangeListener> myListeners = ContainerUtil.createLockFreeCopyOnWriteList();
@@ -63,7 +64,7 @@ public class EnvironmentVariablesTextFieldWithBrowseButton extends TextFieldWith
    */
   @NotNull
   public Map<String, String> getEnvs() {
-    return Collections.unmodifiableMap(myEnvs);
+    return myEnvs;
   }
 
   /**