IDEA-51865 (Failed Subversion authentication usability problem)
authorirengrig <Irina.Chernushina@jetbrains.com>
Mon, 1 Feb 2010 18:54:57 +0000 (21:54 +0300)
committerirengrig <Irina.Chernushina@jetbrains.com>
Mon, 1 Feb 2010 18:54:57 +0000 (21:54 +0300)
platform/vcs-impl/src/com/intellij/openapi/vcs/impl/GenericNotifierImpl.java
plugins/svn4idea/src/org/jetbrains/idea/svn/SvnAuthenticationNotifier.java

index b359ca0232ab456ea4825114c59f9ba0b17e7df9..49c7be92abe3961344688b378f01f54c60531102 100644 (file)
  */
 package com.intellij.openapi.vcs.impl;
 
-import com.intellij.notification.Notification;
-import com.intellij.notification.NotificationListener;
-import com.intellij.notification.NotificationType;
-import com.intellij.notification.Notifications;
+import com.intellij.notification.*;
 import com.intellij.openapi.application.Application;
 import com.intellij.openapi.application.ApplicationManager;
 import com.intellij.openapi.diagnostic.Logger;
@@ -97,11 +94,11 @@ public abstract class GenericNotifierImpl<T, Key> {
     }
     final Application application = ApplicationManager.getApplication();
     if (application.isDispatchThread()) {
-      Notifications.Bus.notify(notification, myProject);
+      Notifications.Bus.notify(notification, NotificationDisplayType.STICKY_BALLOON, myProject);
     } else {
       application.invokeLater(new Runnable() {
         public void run() {
-          Notifications.Bus.notify(notification, myProject);
+          Notifications.Bus.notify(notification, NotificationDisplayType.STICKY_BALLOON, myProject);
         }
       });
     }
index 8002b0b2ce55a4a920658903c780b249e16bbfcf..4e6b3b5431a2bad1ccf903c24b56e14cb92c751e 100644 (file)
@@ -19,9 +19,7 @@ import com.intellij.notification.NotificationType;
 import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.progress.ProgressManager;
 import com.intellij.openapi.project.Project;
-import com.intellij.openapi.ui.MessageType;
 import com.intellij.openapi.util.Ref;
-import com.intellij.openapi.vcs.changes.ui.ChangesViewBalloonProblemNotifier;
 import com.intellij.openapi.vcs.impl.GenericNotifierImpl;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.util.ThreeState;
@@ -40,7 +38,7 @@ import org.tmatesoft.svn.core.wc.SVNWCClient;
 public class SvnAuthenticationNotifier extends GenericNotifierImpl<SvnAuthenticationNotifier.AuthenticationRequest, SVNURL> {
   private static final Logger LOG = Logger.getInstance("#org.jetbrains.idea.svn.SvnAuthenticationNotifier");
 
-  private static final String ourGroupId = "Subversion";
+  private static final String ourGroupId = "SubversionId";
   private final SvnVcs myVcs;
   private final RootsToWorkingCopies myRootsToWorkingCopies;
 
@@ -97,8 +95,8 @@ public class SvnAuthenticationNotifier extends GenericNotifierImpl<SvnAuthentica
 
   @Override
   public void ensureNotify(AuthenticationRequest obj) {
-    ChangesViewBalloonProblemNotifier.showMe(myVcs.getProject(), "You are not authenticated to '" + obj.getRealm() + "'." +
-      "To login, see pending notifications.", MessageType.ERROR);
+    /*ChangesViewBalloonProblemNotifier.showMe(myVcs.getProject(), "You are not authenticated to '" + obj.getRealm() + "'." +
+      "To login, see pending notifications.", MessageType.ERROR);*/
     super.ensureNotify(obj);
   }