Cleanup (warnings; formatting)

diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/DefaultQuickFixProvider.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/DefaultQuickFixProvider.java
index a2fbb5359fe4da1094c66ad83c7669f03747a1d1..079d24b23d4c5a219cc34c013abbc6fc5cdaaa0e 100644 (file)
--- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/DefaultQuickFixProvider.java
+++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/DefaultQuickFixProvider.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2013 JetBrains s.r.o.
+ * Copyright 2000-2016 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -37,10 +37,9 @@ import java.util.Map;
 public class DefaultQuickFixProvider extends UnresolvedReferenceQuickFixProvider<PsiJavaCodeReferenceElement> {
   @Override
   public void registerFixes(@NotNull PsiJavaCodeReferenceElement ref, @NotNull QuickFixActionRegistrar registrar) {
-    QuickFixFactory factory = QuickFixFactory.getInstance();
     registrar.register(new ImportClassFix(ref));
     registrar.register(new StaticImportConstantFix(ref));
-    registrar.register(factory.createSetupJDKFix());
+    registrar.register(QuickFixFactory.getInstance().createSetupJDKFix());
 
     OrderEntryFix.registerFixes(registrar, ref);
 
@@ -107,7 +106,11 @@ public class DefaultQuickFixProvider extends UnresolvedReferenceQuickFixProvider
   private static VariableKind getKind(@NotNull JavaCodeStyleManager styleManager, @NotNull PsiReferenceExpression refExpr) {
     final String reference = refExpr.getText();
 
-    if (reference.toUpperCase().equals(reference)){
+    boolean upperCase = true;
+    for (int i = 0; i < reference.length(); i++) {
+      if (!Character.isUpperCase(reference.charAt(i))) { upperCase = false; break; }
+    }
+    if (upperCase) {
       return VariableKind.STATIC_FINAL_FIELD;
     }