PackagingTreeNodeFactory.addNodes(element.getChildren(), this, element, myContext, mySubstitutionParameters, getNodeSource(element), children,
myArtifactType, new HashSet<PackagingElement<?>>());
}
- return children.toArray(new SimpleNode[children.size()]);
+ return children.isEmpty() ? NO_CHILDREN : children.toArray(new SimpleNode[children.size()]);
}
@Override
}
}
}
- return children.toArray(new SimpleNode[children.size()]);
+ return children.isEmpty() ? NO_CHILDREN : children.toArray(new SimpleNode[children.size()]);
}
@Nullable
public abstract class SimpleMutableNode extends CachingSimpleNode {
- private final List myChildren = new ArrayList();
+ private final List<SimpleNode> myChildren = new ArrayList<SimpleNode>();
public SimpleMutableNode() {
}
}
protected final SimpleNode[] buildChildren() {
- return (SimpleNode[]) myChildren.toArray(new SimpleNode[myChildren.size()]);
+ return myChildren.isEmpty() ? NO_CHILDREN : myChildren.toArray(new SimpleNode[myChildren.size()]);
}
public final SimpleNode add(SimpleNode child) {
public final SimpleNode[] addAll(SimpleNode[] children) {
- for (int i = 0; i < children.length; i++) {
- add(children[i]);
+ for (SimpleNode aChildren : children) {
+ add(aChildren);
}
return children;
}
protected SimpleNode[] buildChildren() {
- return myChildren.toArray(new SimpleNode[myChildren.size()]);
+ return myChildren.isEmpty() ? NO_CHILDREN : myChildren.toArray(new SimpleNode[myChildren.size()]);
}
public Object[] getEqualityObjects() {
}
protected SimpleNode[] buildChildren() {
- ArrayList<SimpleNode> result = new ArrayList<SimpleNode>();
- for (int i = 0; i < myGroups.size(); i++) {
- ConfigurableGroup eachGroup = myGroups.get(i);
+ List<SimpleNode> result = new ArrayList<SimpleNode>();
+ for (ConfigurableGroup eachGroup : myGroups) {
result.addAll(buildGroup(eachGroup));
}
- return result.toArray(new SimpleNode[result.size()]);
+ return result.isEmpty() ? NO_CHILDREN : result.toArray(new SimpleNode[result.size()]);
}
private List<EditorNode> buildGroup(final ConfigurableGroup eachGroup) {
}
}
- private boolean isInvisibleNode(final Configurable child) {
+ private static boolean isInvisibleNode(final Configurable child) {
return child instanceof SearchableConfigurable.Parent && !((SearchableConfigurable.Parent)child).isVisible();
}
}
}
+ private static final EditorNode[] EMPTY_EN_ARRAY = new EditorNode[0];
class EditorNode extends Base {
-
Configurable myConfigurable;
ConfigurableGroup myGroup;
protected EditorNode[] buildChildren() {
List<EditorNode> list = OptionsTree.this.buildChildren(myConfigurable, this, null);
- return list.toArray(new EditorNode[list.size()]);
+ return list.isEmpty() ? EMPTY_EN_ARRAY : list.toArray(new EditorNode[list.size()]);
}
@Override
}
protected SimpleNode[] buildChildren() {
- return myKids.values().toArray(new Node[myKids.size()]);
+ return myKids.isEmpty() ? NO_CHILDREN : myKids.values().toArray(new Node[myKids.size()]);
}
@Override
class IoFile implements IFile {
private final File myFile;
- private final IFile[] EMPTY_ARRAY = new IFile[0];
+ private static final IFile[] EMPTY_ARRAY = new IFile[0];
public IoFile(@NotNull final File file) {
myFile = file;