cleanup yellow code, add toString for easier debugging, javadoc

diff --git a/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesComponent.java b/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesComponent.java
index adbb73406e86255402af53bd5c365e6dbe18f3e9..9f05946926fcc80cd9237584ce5751bb6c19669d 100644 (file)
--- a/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesComponent.java
+++ b/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesComponent.java
@@ -75,6 +75,9 @@ public class EnvironmentVariablesComponent extends LabeledComponent<TextFieldWit
     myEnvVars.setData(envData);
   }
 
+  /**
+   * Consider using {@link EnvironmentVariablesData#readExternal(Element)} instead for simplicity and better performance.
+   */
   public static void readExternal(Element element, Map<String, String> envs) {
     final Element envsElement = element.getChild(ENVS);
     if (envsElement != null) {
@@ -108,6 +111,9 @@ public class EnvironmentVariablesComponent extends LabeledComponent<TextFieldWit
     }
   }
 
+  /**
+   * Consider using {@link EnvironmentVariablesData#writeExternal(Element)} instead for simplicity and better performance.
+   */
   public static void writeExternal(@NotNull Element element, @NotNull Map<String, String> envs) {
     final Element envsElement = new Element(ENVS);
     for (String envName : envs.keySet()) {

diff --git a/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesData.java b/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesData.java
index b52e1046487c539eeb755a6b5503ff1abc164708..690567281961610a764a95331f6d7be9a55a8689 100644 (file)
--- a/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesData.java
+++ b/platform/lang-impl/src/com/intellij/execution/configuration/EnvironmentVariablesData.java
@@ -35,7 +35,7 @@ import java.util.Map;
  */
 public class EnvironmentVariablesData {
 
-  public static final EnvironmentVariablesData DEFAULT = new EnvironmentVariablesData(ImmutableMap.<String, String>of(), true);
+  public static final EnvironmentVariablesData DEFAULT = new EnvironmentVariablesData(ImmutableMap.of(), true);
   @NonNls private static final String ENVS = "envs";
   @NonNls private static final String PASS_PARENT_ENVS = "pass-parent-envs";
   @NonNls private static final String ENV = EnvironmentVariablesComponent.ENV;
@@ -77,6 +77,11 @@ public class EnvironmentVariablesData {
     return result;
   }
 
+  @Override
+  public String toString() {
+    return "envs=" + myEnvs + ", passParentEnvs=" + myPassParentEnvs;
+  }
+
   @NotNull
   public static EnvironmentVariablesData readExternal(@NotNull Element element) {
     Element envsElement = element.getChild(ENVS);