git: get rid of GitPlatformFacade as not valuable anymore
authorKirill Likhodedov <Kirill.Likhodedov@jetbrains.com>
Mon, 2 May 2016 12:31:30 +0000 (15:31 +0300)
committerKirill Likhodedov <Kirill.Likhodedov@jetbrains.com>
Mon, 2 May 2016 13:16:11 +0000 (16:16 +0300)
commitd5223f0f78ff4279e2582965627d6373cbd9ce95
tree5f3596326bc08ff040c9f09a54ba1b1844ff323d
parente7fed368e5d4daf96c495cbe502cb5775539759b
git: get rid of GitPlatformFacade as not valuable anymore

The interface was introduce as an attempt to separate git (dvcs) module
from the rest of the platform, to be able to write module tests
(faster and more reliable than the full-platform one).

However, the idea didn't proove itself: it appeared to be too tedious
to substitute all platform references by the facade methods, while
the platform tests became faster and used now pretty well.

Substitute the usages by actual calls to the platform methods.
Remove GPF usages and methods, or deprecate those which are called
by 3-party plugins.
57 files changed:
platform/dvcs-impl/src/com/intellij/dvcs/DvcsPlatformFacade.java [deleted file]
platform/dvcs-impl/src/com/intellij/dvcs/DvcsPlatformFacadeImpl.java [deleted file]
plugins/git4idea/remote-servers-git/src/com/intellij/remoteServer/util/CloudGitDeploymentRuntime.java
plugins/git4idea/src/git4idea/GitPlatformFacade.java
plugins/git4idea/src/git4idea/GitPlatformFacadeImpl.java
plugins/git4idea/src/git4idea/actions/GitStash.java
plugins/git4idea/src/git4idea/branch/GitBranchIsNotFullyMergedDialog.java
plugins/git4idea/src/git4idea/branch/GitBranchOperation.java
plugins/git4idea/src/git4idea/branch/GitBranchUiHandlerImpl.java
plugins/git4idea/src/git4idea/branch/GitBranchWorker.java
plugins/git4idea/src/git4idea/branch/GitBrancherImpl.java
plugins/git4idea/src/git4idea/branch/GitCheckoutNewBranchOperation.java
plugins/git4idea/src/git4idea/branch/GitCheckoutOperation.java
plugins/git4idea/src/git4idea/branch/GitDeleteBranchOperation.java
plugins/git4idea/src/git4idea/branch/GitDeleteRemoteBranchOperation.java
plugins/git4idea/src/git4idea/branch/GitMergeOperation.java
plugins/git4idea/src/git4idea/branch/GitRenameBranchOperation.java
plugins/git4idea/src/git4idea/branch/GitSmartOperationDialog.java
plugins/git4idea/src/git4idea/checkin/GitCheckinHandlerFactory.java
plugins/git4idea/src/git4idea/cherrypick/GitCherryPicker.java
plugins/git4idea/src/git4idea/crlf/GitCrlfProblemsDetector.java
plugins/git4idea/src/git4idea/log/GitShowExternalLogAction.java
plugins/git4idea/src/git4idea/merge/GitConflictResolver.java
plugins/git4idea/src/git4idea/merge/GitMergeCommittingConflictResolver.java
plugins/git4idea/src/git4idea/push/GitPushOperation.java
plugins/git4idea/src/git4idea/rebase/GitAbortRebaseProcess.java
plugins/git4idea/src/git4idea/rebase/GitRebaseProcess.java
plugins/git4idea/src/git4idea/rebase/GitRebaseSpec.java
plugins/git4idea/src/git4idea/rebase/GitRebaser.java
plugins/git4idea/src/git4idea/repo/GitConfig.java
plugins/git4idea/src/git4idea/repo/GitRemote.java
plugins/git4idea/src/git4idea/repo/GitRepositoryCreator.java
plugins/git4idea/src/git4idea/repo/GitRepositoryImpl.java
plugins/git4idea/src/git4idea/repo/GitRepositoryManager.java
plugins/git4idea/src/git4idea/reset/GitResetOperation.java
plugins/git4idea/src/git4idea/stash/GitChangesSaver.java
plugins/git4idea/src/git4idea/stash/GitShelveChangesSaver.java
plugins/git4idea/src/git4idea/stash/GitStashChangesSaver.java
plugins/git4idea/src/git4idea/ui/GitUnstashDialog.java
plugins/git4idea/src/git4idea/ui/branch/GitLogBranchOperationsActionGroup.java
plugins/git4idea/src/git4idea/update/GitMergeUpdater.java
plugins/git4idea/src/git4idea/update/GitUpdateEnvironment.java
plugins/git4idea/src/git4idea/update/GitUpdateProcess.java
plugins/git4idea/src/git4idea/util/GitFreezingProcess.java
plugins/git4idea/src/git4idea/util/GitPreservingProcess.java
plugins/git4idea/test-stepdefs/git4idea/GitAddSteps.java
plugins/git4idea/test-stepdefs/git4idea/GitCherryPickStepdefs.java
plugins/git4idea/test-stepdefs/git4idea/GitCucumberWorld.java
plugins/git4idea/tests/git4idea/branch/GitBranchWorkerTest.java
plugins/git4idea/tests/git4idea/crlf/GitCrlfProblemsDetectorTest.java
plugins/git4idea/tests/git4idea/rebase/GitMultiRepoRebaseTest.kt
plugins/git4idea/tests/git4idea/rebase/GitSingleRepoRebaseTest.kt
plugins/git4idea/tests/git4idea/repo/GitConfigTest.java
plugins/git4idea/tests/git4idea/repo/GitRepositoryReaderNewTest.kt
plugins/git4idea/tests/git4idea/repo/GitRepositoryReaderTest.java
plugins/git4idea/tests/git4idea/test/GitPlatformTest.kt
plugins/github/src/org/jetbrains/plugins/github/GithubRebaseAction.java