settings-sync: move saving all settings before initializing the setting sync to a...
authorKirill Likhodedov <Kirill.Likhodedov@jetbrains.com>
Wed, 5 Oct 2022 10:05:06 +0000 (12:05 +0200)
committerintellij-monorepo-bot <intellij-monorepo-bot-no-reply@jetbrains.com>
Thu, 6 Oct 2022 09:21:29 +0000 (09:21 +0000)
commit7120508e6ec6a799e55f54117b91020cdf7c228b
treee02484aa608da5d285a3c9fb6bae5a0f9c4cfec5
parente756bfcb4e84c377084c2d6add59a90549e86fcb
settings-sync: move saving all settings before initializing the setting sync to a better place

This should fix IDEA-301776 when current settings were saved during the initialization, and that led to overwriting of settings applied by the settings sync.

This is an improvement of 53aa0fce: we need to save in all scenarios. Especially, the case IDEA-301776 was not covered in 53aa0fce because enabling settings doesn't invoke the initialize method from SettingsSynchronizer.

GitOrigin-RevId: 726ccf7eb783a2f388f37379fc919ce562387b5e
plugins/settings-sync/src/com/intellij/settingsSync/SettingsSyncBridge.kt
plugins/settings-sync/src/com/intellij/settingsSync/SettingsSynchronizer.kt