2 months agoIJI-375 drop legacy usages 192
Dmitriy.Panov [Tue, 14 Jul 2020 12:27:37 +0000 (15:27 +0300)]
IJI-375 drop legacy usages

GitOrigin-RevId: aefe3bd568054eba7f0fa1debb98b4e06c1fa857

6 months ago[vcs] Use max date instead of hardcoded to detect firstCachedDate properly
Nikolay Rykunov [Mon, 3 Feb 2020 09:24:13 +0000 (12:24 +0300)]
[vcs] Use max date instead of hardcoded to detect firstCachedDate properly

(cherry picked from commit e4a62904cbec4988a7c05c6b5497c8d6ab8e0817)

GitOrigin-RevId: 7fbcfcdaabd8a7774bfd5a6347bee471cd4a9b3e

6 months agoIDEA-CR-58167: IDEA-230845 Apple Notarization issues: dbus-java in credential-store
Dmitriy.Panov [Fri, 17 Jan 2020 08:34:50 +0000 (11:34 +0300)]
IDEA-CR-58167: IDEA-230845 Apple Notarization issues: dbus-java in credential-store

(cherry picked from commit 23e93813e0b359e05e4b988e617340b41f7695c8)

GitOrigin-RevId: a5e9e7cd2ad31d75ee1ecb14a3fa22de02f3f63f

6 months agoFix compilation (PY-37589)
Semyon Proshev [Thu, 6 Feb 2020 12:43:22 +0000 (15:43 +0300)]
Fix compilation (PY-37589)

GitOrigin-RevId: 024c693ad7739a3e5d0d57ac68e216e2b5869885

6 months agoFix unresolved reference to `findPackage` method that has been moved after extracting...
Semyon Proshev [Mon, 16 Sep 2019 16:01:56 +0000 (19:01 +0300)]
Fix unresolved reference to `findPackage` method that has been moved after extracting `python-psi-impl` module (PY-37589)

(cherry picked from commit bd182d6d7237a1de3988e4ffbd878fea8094d118)

GitOrigin-RevId: a977d5f46d39a3d71fbc6394acec8170586aa8bc

6 months agoMade tensorflow resolve more complex as its internal paths had been changed in 1...
Semyon Proshev [Thu, 12 Sep 2019 14:45:43 +0000 (17:45 +0300)]
Made tensorflow resolve more complex as its internal paths had been changed in 1.15.0rc0 and 2.0.0rc0 (PY-37589)

(cherry picked from commit 39e18cf4ca56eb2379d2664e5ad07647985943cb)

GitOrigin-RevId: ce34e8fcd9201dafb3ab13f714c8275e765eca6b

6 months agoPyCharm: update python versions for Stubs
Aleksey Rostovskiy [Tue, 4 Feb 2020 12:15:40 +0000 (15:15 +0300)]
PyCharm: update python versions for Stubs

(cherry picked from commit c08cd59cb72a479c65f29505370922f5c7da4370)

GitOrigin-RevId: d382db6481840f43932512e5ed6b158044d17f28

6 months agoIDEA-CR-58083: IDEA-232217 Skip "environ" attribute value in Python skeletons for...
Mikhail Golubev [Wed, 5 Feb 2020 11:04:02 +0000 (14:04 +0300)]
IDEA-CR-58083: IDEA-232217 Skip "environ" attribute value in Python skeletons for "nt" module

GitOrigin-RevId: 605dd58d183ff66724ed485ad3768ba291c636a9

6 months agoIDEA-CR-56903: IDEA-228500 NPE when open IDEA 2019.2.4 with plugin that defines regis...
Svetlana.Zemlyanskaya [Mon, 23 Dec 2019 12:46:59 +0000 (13:46 +0100)]
IDEA-CR-56903: IDEA-228500 NPE when open IDEA 2019.2.4 with plugin that defines registry key

(cherry picked from commit 19dad12973f607d888075e5725e387953b7508bc)

GitOrigin-RevId: 9c402485737f17884a2c1df339eda6e8cb7740e7

6 months agoIDEA-CR-56667: LongRangeSet#modRange: avoid possible overflow in loop condition
Tagir Valeev [Tue, 17 Dec 2019 02:32:18 +0000 (09:32 +0700)]
IDEA-CR-56667: LongRangeSet#modRange: avoid possible overflow in loop condition

(cherry picked from commit 99cfa7ec2aebe38bf21e350ad5f85413167b0986)

GitOrigin-RevId: f4f5923147ea5d3f1c862455fd7648ada2dcc900

6 months agoIDEA-CR-56510: git: use more correct way to check if the external process failed...
Kirill Likhodedov [Thu, 12 Dec 2019 10:13:44 +0000 (13:13 +0300)]
IDEA-CR-56510: git: use more correct way to check if the external process failed: IDEA-199553

(cherry picked from commit f17ed1cb6b0ed675c14fa44b6a24e5827a83377f)

GitOrigin-RevId: 05e06574f829b1af8a481ec97d0f79a71289ff3d

6 months agoIDEA-CR-56510: git: fix active developer path error for Catalina: IDEA-199553
Kirill Likhodedov [Thu, 12 Dec 2019 09:39:49 +0000 (12:39 +0300)]
IDEA-CR-56510: git: fix active developer path error for Catalina: IDEA-199553

It appears that calling `sudo xcode-select --install` on Catalina does nothing, while it works on Mojave. On the other hand, sudo is not needed for this command.

(cherry picked from commit 1697cbf3e823546f7540f215f13a589cd5eac975)

GitOrigin-RevId: 15613860662b6e3cc00035a40c161782ebc4d2a8

6 months agoIDEA-CR-56106: [Build tw] forbid pushing back lines count more than reader's `pushBac...
Vladislav.Soroka [Tue, 3 Dec 2019 08:31:07 +0000 (11:31 +0300)]
IDEA-CR-56106: [Build tw] forbid pushing back lines count more than reader's `pushBackBufferSize` IDEA-228098

(cherry picked from commit 1ef8b4d00aa88cc069190a308983d56868d3e942)

GitOrigin-RevId: 0743495bb4ca8fba3dd71f70813803396d2bbc9a

6 months agoIDEA-CR-56031: IDEA-227376 The "File Structure" popup no longer correctly locates...
Dmitry Batrak [Fri, 29 Nov 2019 15:25:56 +0000 (18:25 +0300)]
IDEA-CR-56031: IDEA-227376 The "File Structure" popup no longer correctly locates the function you select when dealing with collapsed areas

(cherry picked from commit 52ffe999cb6566fd27e0438bc42fc51459a7cc4f)

GitOrigin-RevId: c9ca8aaa17851d3722495038f737755c0ffb95aa

6 months ago[Cucumber Java] fix test tree building for v1
Andrey Vokin [Thu, 28 Nov 2019 13:19:31 +0000 (14:19 +0100)]
[Cucumber Java] fix test tree building for v1

IDEA-222922 Running cucumber-groovy project fails with #teamcity[... details = '' message = 'Undefined step: ..." after update to IDEA 2019.2.x

[this is part of IDEA-CR-55691]

GitOrigin-RevId: b24ed527ed7f6c0a2f30c4d6796c0abb4846dfbc

6 months agoIDEA-223086 ImportClassFixBase.fixSilently affects performance even if UnambiguousImp...
peter [Mon, 30 Sep 2019 09:18:44 +0000 (11:18 +0200)]
IDEA-223086 ImportClassFixBase.fixSilently affects performance even if UnambiguousImportsOnTheFly settings is disabled

(cherry picked from commit 93ada9904a45a1dfc497678e5f79c87c9245bde9)

GitOrigin-RevId: ef6539d6b260d05eaea3448a30bd2c3a8daeda66

6 months agoPY-38378 PY-38424 Fix updating variables in debugger console (IDEA-CR-55426)
Andrey Lisin [Fri, 22 Nov 2019 08:18:32 +0000 (11:18 +0300)]
PY-38378 PY-38424 Fix updating variables in debugger console (IDEA-CR-55426)

We now access the `frame.f_locals` attribute only once. Multiple access leads to the loss of the changes we have made. We also alter the second argument of the `PyFrame_LocalsToFast()` to 1 to ensure that all the deleted variables will be wiped out from the frame locals.

(cherry picked from commit 28abff39b2c37f30651db220e8700032a629ce73)

(cherry picked from commit 8514da7ec187c1192ea9cdf851f89f008242fc30)

GitOrigin-RevId: acd727880192b160123be8d08731471b08843838

6 months agoupdate jet-sign to 42.48
Leonid Shalupov [Thu, 21 Nov 2019 17:13:04 +0000 (19:13 +0200)]
update jet-sign to 42.48

GitOrigin-RevId: b76225df961cc26f87e69a130b73dd5af391f7b4

6 months agoIDEA-CR-55611: IDEA-223505 Critical Error in IDEA Async Stacktraces (IndexOutOfBOunds...
Egor Ushakov [Thu, 21 Nov 2019 09:38:59 +0000 (12:38 +0300)]
IDEA-CR-55611: IDEA-223505 Critical Error in IDEA Async Stacktraces (IndexOutOfBOundsException) - more logging

(cherry picked from commit f846d48e944013da203adaefeb90b7bb7149afcf)

GitOrigin-RevId: 252778fcb58d1fc6423d8f421bc4e25e9c033cc6

6 months agoIDEA-CR-55390: PY-37530 Don't pack inside itself
Mikhail Golubev [Mon, 18 Nov 2019 10:28:07 +0000 (13:28 +0300)]
IDEA-CR-55390: PY-37530 Don't pack inside itself

It leads to indefinitely large ZIP archive and hangs up initialization
of a remote interpreter.

Ideally, we should create it in a temporary directory in the first place.

GitOrigin-RevId: b718d9a8003fa361e7162d7c1508acd5ffcc87b4

6 months agoIDEA-CR-55034: enable freeze reporter in internal mode
Egor Ushakov [Mon, 11 Nov 2019 12:37:09 +0000 (15:37 +0300)]
IDEA-CR-55034: enable freeze reporter in internal mode

(cherry picked from commit 68f88779643d7ba1ca39608e759a90c1b289b812)

(cherry picked from commit 5cd2bb7a852530ededd63fd1b4d4751cacc51ba7)

GitOrigin-RevId: 968e6edb072282cfdcf0fce79844710b513fd7ff

6 months agono sense in reporting smaller freezes without sampling
Egor Ushakov [Thu, 14 Nov 2019 16:12:17 +0000 (19:12 +0300)]
no sense in reporting smaller freezes without sampling

GitOrigin-RevId: 4237f043152b465ae741993efbc7396fa888f164

6 months agotypo
Gregory.Shrago [Thu, 7 Nov 2019 16:15:02 +0000 (19:15 +0300)]

(cherry picked from commit b55fde81af20716ab50ede3af379453393f6c429)

GitOrigin-RevId: 3b471856adb9d4e035c115e871f6d19dc88fd0c2

6 months agoDBus library throws runtime exceptions in case of resolve issues IDEA-226364
Alexander Kass [Thu, 7 Nov 2019 09:44:19 +0000 (12:44 +0300)]
DBus library throws runtime exceptions in case of resolve issues IDEA-226364

(cherry picked from commit 564b63515ff0b08d6b3d6a8446c5804179848da9)
(cherry picked from commit 6006c0f9dadb7e34d7a5b32c358c7a7c17ec9726)

GitOrigin-RevId: e235ac46a57e54223777c48b4e435413be2e753e

6 months agofix unclickable checkbox tree
Alexander Kass [Thu, 31 Oct 2019 12:00:33 +0000 (15:00 +0300)]
fix unclickable checkbox tree

(cherry picked from commit 4c4674e205ef89750fd334810e5df0765215c378)
(cherry picked from commit b694b382e552765272ac1890c6bfd208cdf0b5be)

GitOrigin-RevId: d50030cb1545a1ab448a4cdfe5032c792922c42a

6 months agocr-IDEA-918: [Gradle] build script error parser description: add empty line after...
Vladislav.Soroka [Tue, 12 Nov 2019 13:08:18 +0000 (16:08 +0300)]
cr-IDEA-918: [Gradle] build script error parser description: add empty line after location info IDEA-209457

(cherry picked from commit 165e58a19193312759892b6e46d5da0491f69269)

GitOrigin-RevId: 89ecdc9145c9e075902c1aaca86588945c0dda78

6 months agocr-IDEA-919: [Gradle] parse exception stacktrace info if present in the build script...
Vladislav.Soroka [Wed, 9 Oct 2019 09:52:39 +0000 (12:52 +0300)]
cr-IDEA-919: [Gradle] parse exception stacktrace info if present in the build script error output IDEA-209457

(cherry picked from commit 3eb6e615a0af4158ba942abc9ff088b88c46f104)

GitOrigin-RevId: 10433b9723e75433fbfdab5e922fb75a033fece7

6 months agocr-IDEA-917: [Build tw] fix output lines processing on windows IDEA-209457
Vladislav.Soroka [Wed, 9 Oct 2019 10:16:31 +0000 (13:16 +0300)]
cr-IDEA-917: [Build tw] fix output lines processing on windows IDEA-209457

(cherry picked from commit 33f39e07a872994bcbf66128efad86e640c0d687)

GitOrigin-RevId: c81f9a26be09d65ae656207711ca7eb2ae3db525

6 months agocr-IDEA-917: [Build tw] fix output lines processing on windows IDEA-209457
Vladislav.Soroka [Wed, 9 Oct 2019 09:18:59 +0000 (12:18 +0300)]
cr-IDEA-917: [Build tw] fix output lines processing on windows IDEA-209457

(cherry picked from commit 9f7a367327992a31c4455379eefa4d7f62ce136f)

GitOrigin-RevId: 8dc2f0d31d760dddd72c8fcc3999fd67dde825c2

6 months agocr-IDEA-916: [Gradle] avoid build tw duplicating messages related to build script...
Vladislav.Soroka [Tue, 8 Oct 2019 15:32:28 +0000 (18:32 +0300)]
cr-IDEA-916: [Gradle] avoid build tw duplicating messages related to build script errors

Gradle build script errors are better described by the build output and should be handled by GradleBuildScriptErrorParser

(cherry picked from commit ba558390b5f6bb6bac8b7a5099e8405404ed33ce)

GitOrigin-RevId: efdadaecddf32c9eab28f3adab97395f95274726

6 months agoIDEA-CR-53251: [Gradle] navigate to the right column from the console file link IDEA...
Vladislav.Soroka [Tue, 8 Oct 2019 05:51:34 +0000 (08:51 +0300)]
IDEA-CR-53251: [Gradle] navigate to the right column from the console file link IDEA-217932

(cherry picked from commit abe72f480db9c2b46e514c75440378e7be3022a2)

GitOrigin-RevId: 89143f6c13cad26704fa30926d8ee3724ae28edb

6 months agoIDEA-CR-53251: [Gradle] highlight settings file link IDEA-217932
Vladislav.Soroka [Tue, 8 Oct 2019 05:50:05 +0000 (08:50 +0300)]
IDEA-CR-53251: [Gradle] highlight settings file link IDEA-217932

(cherry picked from commit c7b8c6848e7ab4a143f38222c74fc3848ee65391)

GitOrigin-RevId: 9223f0cd64ad53ef3e248b39344183c974c49e68

6 months agoIDEA-CR-53251: [Gradle] handling of startup build script errors w/o column info IDEA...
Vladislav.Soroka [Mon, 7 Oct 2019 13:36:52 +0000 (16:36 +0300)]
IDEA-CR-53251: [Gradle] handling of startup build script errors w/o column info IDEA-217932

(cherry picked from commit b4dfaec6cd14c628d285a12ea842dc9a9abe1d9c)

GitOrigin-RevId: c0af4bc7efecc0be599eec2fdc7e76570b5e545f

6 months agoIDEA-CR-53251: [Gradle] more specific handling of startup build script errors IDEA...
Vladislav.Soroka [Mon, 7 Oct 2019 12:14:00 +0000 (15:14 +0300)]
IDEA-CR-53251: [Gradle] more specific handling of startup build script errors IDEA-217932

(cherry picked from commit bf4df986cedabb6eb9d5bf182c9ea84df4b1cc4c)

GitOrigin-RevId: ffb3562fda7a8c089497bf992e1dff308156635a

10 months agoEasier API for creating expiring notifications
Dmitry Jemerov [Tue, 8 Oct 2019 16:30:50 +0000 (18:30 +0200)]
Easier API for creating expiring notifications

Partial cherry-pick of 2bd83563c9b8910e78851d0443336d7255e874dd

GitOrigin-RevId: 56c90f32b82c7751b92e85b16526c0f2948d78e2

10 months ago[util] extract ellipsis symbol
Julia Beliaeva [Fri, 14 Jun 2019 17:22:55 +0000 (20:22 +0300)]
[util] extract ellipsis symbol

Partial cherry-pick of 3c808b49f634e0dfd579f02d4046af8d3156f8b0

GitOrigin-RevId: 5a4da56f79db9930ac564d8c6850b1f797a41f70

10 months agogit: cleanup: don't pass service to the constructor
Kirill Likhodedov [Sun, 3 Nov 2019 15:29:47 +0000 (18:29 +0300)]
git: cleanup: don't pass service to the constructor

(cherry picked from commit 2584cf90609bab2e51f6c506a11067c1044fd5b1)

GitOrigin-RevId: 97d009a46f870ff5cef5ba642ac2ad53a6a7cf0e

10 months agogit: don't cache the error of git version check
Kirill Likhodedov [Sun, 3 Nov 2019 15:21:44 +0000 (18:21 +0300)]
git: don't cache the error of git version check

Cache the valid version result, but don't cache the error, to handle the situation when Git is installed to the location which used to produce the error.
This can happen, for example, when Git is resolved to /usr/bin/git on Mac, but the Command Line Tools are not installed: we display an error to the user, they install the Tools, and the path to Git becomes correct.

(cherry picked from commit 41281fce464d0cf8eeff6595e31418f9891f2ee6)

GitOrigin-RevId: 724481dcf0957a90277ab83059a817ff2ff3d9a3

10 months agogit: handle the Git executable error "invalid active developer path" on Mac: IDEA...
Kirill Likhodedov [Sat, 2 Nov 2019 15:54:35 +0000 (18:54 +0300)]
git: handle the Git executable error "invalid active developer path" on Mac: IDEA-199553

Display a specific message, and propose to invoke `xcode-select --install` which shows a native dialog that allows to fix command line developers tools installation.

(cherry picked from commit cb2300cd0f8fec544f19ab9ecfd80e440b13d9be)

GitOrigin-RevId: b69621e58ca9d06d2108c102a8110db6e18ebb3a

10 months agogit: cleanup: improve readability a bit
Kirill Likhodedov [Sun, 3 Nov 2019 14:37:30 +0000 (17:37 +0300)]
git: cleanup: improve readability a bit

(cherry picked from commit 0e30982a94027b35159bfd8dba6f514843ee8120)

GitOrigin-RevId: e822d6f5840c7722a839803232537cee34a38813

10 months agogit: if Git is not found, propose to Download it only on Windows
Kirill Likhodedov [Sat, 2 Nov 2019 11:25:06 +0000 (14:25 +0300)]
git: if Git is not found, propose to Download it only on Windows

It doesn't make much sense on Mac (where Git is either preinstalled, or is proposed to install via the system dialog) and on Linux (where package managers are the preferred way to install software).

(cherry picked from commit 9e308c75d9c39c010396de97b35d91cf93915e33)

GitOrigin-RevId: 8171cb306e96d37199aa4877b5d13b0ca4826b6b

10 months agogit: cleanup: don't pass service to the constructor
Kirill Likhodedov [Sat, 2 Nov 2019 11:20:49 +0000 (14:20 +0300)]
git: cleanup: don't pass service to the constructor

(cherry picked from commit 9d4d5f54fb5ca24c721c1ac78c22244780bf801c)

GitOrigin-RevId: 9292b8add39df902c75a1458705be2c3ee7f1660

10 months agoUpdating versions of project dependencies: jdkBuild->11_0_4b304.78
Elena Sayapina [Wed, 6 Nov 2019 07:57:00 +0000 (10:57 +0300)]
Updating versions of project dependencies: jdkBuild->11_0_4b304.78

Elena Sayapina

GitOrigin-RevId: 1c5688fb51ae9aed574acfe744d30b9d9f632f25

10 months agoIDEA-CR-54353: IDEA-217314 - fixed issue when parent pom file was not resolved if...
Alexander Bubenchikov [Fri, 23 Aug 2019 14:28:14 +0000 (17:28 +0300)]
IDEA-CR-54353: IDEA-217314 - fixed issue when parent pom file was not resolved if located in sibling folder outside of the project

(cherry picked from commit d73f09eed1994bb590d17243fc95fe44fd6388ec)

GitOrigin-RevId: 854832bf4fc8da8c79dad5a94a2ef202aad207b7

10 months agoIDEA-CR-54659: EA-144192 - NPE: ColorPalette.getColor
Sergey Simonchik [Tue, 17 Sep 2019 09:54:14 +0000 (12:54 +0300)]
IDEA-CR-54659: EA-144192 - NPE: ColorPalette.getColor

(cherry picked from commit eaa299358f9a147c22a989508bb09c5983dc8995)

GitOrigin-RevId: 14170d2480d09758e9d7e0491963db242fa75a2c

10 months agoIDEA-CR-54654: Terminal: do not IFS for splitting environment variables (GO-8303)
Alexander Zolotov [Sun, 3 Nov 2019 20:16:46 +0000 (23:16 +0300)]
IDEA-CR-54654: Terminal: do not IFS for splitting environment variables (GO-8303)

IFS may behave unexpectedly when equals sign is the last one on the line
See details:

(cherry picked from commit 1ad4476f8d55d74ea4db2af5e1058f3dccf37061)

GitOrigin-RevId: 7897eed102dd46dd0434f30b4680b4deadb6839f

10 months agoIDEA-CR-54505: PY-38707 Simplify TypedDict type inference in case of complex class...
Lada Gagina [Fri, 18 Oct 2019 13:55:23 +0000 (16:55 +0300)]
IDEA-CR-54505: PY-38707 Simplify TypedDict type inference in case of complex class hierarchies

GitOrigin-RevId: 919be8c05e2bcc7906ea94b5984043f2c4a2ee2c

10 months agoIDEA-CR-54458: [Gradle] generated tasks missed eol fix
Vladislav.Soroka [Wed, 30 Oct 2019 11:02:15 +0000 (14:02 +0300)]
IDEA-CR-54458: [Gradle] generated tasks missed eol fix

(cherry picked from commit bf737f898f9b317ed01a441724bb2a10f8155e65)

GitOrigin-RevId: d387037de922fb26c488f25c7b9d0d37638322ab

10 months agoIDEA-CR-54426: IDEA-222570 Recent files toggles between 3 files, not 2 as it was...
Vassiliy.Kudryashov [Fri, 20 Sep 2019 18:04:20 +0000 (21:04 +0300)]
IDEA-CR-54426: IDEA-222570 Recent files toggles between 3 files, not 2 as it was previously

(cherry picked from commit 906baa9f92365058c9ac3ae829c12b07d909dd93)

GitOrigin-RevId: 346cfe3069ff23cb4d47c16bd791b6640e5f205c

10 months agoIDEA-221058 UI Designer preview doesn't work when project uses java 9+
Alexander Lobas [Fri, 11 Oct 2019 11:48:41 +0000 (14:48 +0300)]
IDEA-221058 UI Designer preview doesn't work when project uses java 9+

(cherry picked from commit ead52abf2254a5d94515673e0557856e92a94041)

GitOrigin-RevId: b592b129b1ab209b93b0441f56a82a08027dcc70

10 months agoIDEA-221058 UI Designer preview doesn't work when project uses java 9+
Alexander Lobas [Wed, 2 Oct 2019 15:58:29 +0000 (18:58 +0300)]
IDEA-221058 UI Designer preview doesn't work when project uses java 9+

(cherry picked from commit cd8d88baf20d60b05e3b4b361f9d4cd209292038)

GitOrigin-RevId: 8d470fa9004a42172b2c082f674db0ba12c4d7a1

10 months agoIDEA-220010 - fix for maven 3.0.*
Alexander Bubenchikov [Tue, 27 Aug 2019 12:03:24 +0000 (15:03 +0300)]
IDEA-220010 - fix for maven 3.0.*

(cherry picked from commit 3125e38f7707d015abbe1011f193c147afd82f7a)

GitOrigin-RevId: 56b656b975b461463165e4a936e971f83a6df392

10 months agoIDEA-223275 - mix interpolator for maven 3.6.2
Alexander Bubenchikov [Wed, 23 Oct 2019 12:58:51 +0000 (15:58 +0300)]
IDEA-223275 - mix interpolator for maven 3.6.2

(cherry picked from commit 2b5fa7f84878e49e3e87805ca295a72efb817bff)

GitOrigin-RevId: 4c06f9d4cf204601f153a8bf0b34f154d789135e

10 months agoIDEA-218015 Attempt to export any diagram to svg image fails with NPE
Alexander Lobas [Tue, 27 Aug 2019 15:45:28 +0000 (18:45 +0300)]
IDEA-218015 Attempt to export any diagram to svg image fails with NPE

(cherry picked from commit 016d018128423a6a1508b6d083c4e4be474acd70)

GitOrigin-RevId: ac28eae2f69a6efac5017a8edbf70fc3276408fa

10 months agobackport fixes for IDEA-225189 IDEA-224720
Nikita Skvortsov [Tue, 29 Oct 2019 09:00:50 +0000 (12:00 +0300)]
backport fixes for IDEA-225189 IDEA-224720

reviews: IDEA-CR-53925 IDEA-CR-54140

GitOrigin-RevId: ccf67d346fb4726ba20272fb8bb8f293275c8674

10 months agoreport startup metrics using FUS
Vladimir Krivosheev [Mon, 28 Oct 2019 14:55:15 +0000 (15:55 +0100)]
report startup metrics using FUS

GitOrigin-RevId: baeabfcffd008ac8702a4cb140b74914245268c8

10 months agoDevKit: restore the old vendor validation logic
Alexander Zolotov [Mon, 16 Sep 2019 18:15:26 +0000 (21:15 +0300)]
DevKit: restore the old vendor validation logic

from IDEA-CR-52434:
This method is called not only for bundled plugins, but also for custom plugins. We cannot be sure that plugin.xml for all such plugins are updated? E.g. there is JsTestDriver plugin ( that specifies "Google, JetBrains".

(cherry picked from commit d6764300b9c9d5842cda56e0c2df862415e54110)

GitOrigin-RevId: b9dfbc0086fbc729f0fb1afa540c4d0333d7524a

10 months agoGet rid of abnormal vendor names
Alexander Zolotov [Wed, 11 Sep 2019 17:44:55 +0000 (20:44 +0300)]
Get rid of abnormal vendor names

(cherry picked from commit 08b5fc0ac47a36ae2562875c0d65f5176681a329)

GitOrigin-RevId: 752366d1e14379fe3ca1beeaf9e491a0ebfec087

10 months agoIDEA-CR-53634: [gradle] cache found virtual files to avoid unnecessary write actions...
Nikita Skvortsov [Wed, 16 Oct 2019 15:07:02 +0000 (18:07 +0300)]
IDEA-CR-53634: [gradle] cache found virtual files to avoid unnecessary write actions IDEA-224835 IDEA-160489 IDEA-183944

(cherry picked from commit 58fcde562d1c59311cd9595dc1962aaefd62ff03)

GitOrigin-RevId: 6082e6e0f4e02f40d44781184e34034748eb6032

10 months agoIDEA-CR-54147: fix fallback font name for Catalina (IDEA-224471)
Dennis Ushakov [Thu, 24 Oct 2019 14:55:15 +0000 (17:55 +0300)]
IDEA-CR-54147: fix fallback font name for Catalina (IDEA-224471)

GitOrigin-RevId: 30a88a2fa0a8c17dd2cc230a30d6274f6bd4a676

10 months agoSync pycodestyle @ d219c684f117be77927d33146e76a5364161e518 (PY-37196)
Semyon Proshev [Thu, 24 Oct 2019 16:18:24 +0000 (19:18 +0300)]
Sync pycodestyle @ d219c684f117be77927d33146e76a5364161e518 (PY-37196)

GitOrigin-RevId: b841024c0457915191249a9f108707f55e65e23b

10 months agoTextMate: fix after cherry-picking
Alexander Zolotov [Wed, 23 Oct 2019 15:57:51 +0000 (18:57 +0300)]
TextMate: fix after cherry-picking

GitOrigin-RevId: 334186cc458ede21eb978ff87754b967bb7e9ab8

10 months agoTextMate: do not search braces on empty elements
Alexander Zolotov [Tue, 22 Oct 2019 14:54:23 +0000 (17:54 +0300)]
TextMate: do not search braces on empty elements

(cherry picked from commit 9ad51ddafb66dfdbbfd004b1f841d21c37e35c03)

GitOrigin-RevId: 4370a0753500c79c413bc77821489b230367364b

10 months agoTextMate: use loading cache to avoid creating many lambdas
Alexander Zolotov [Tue, 22 Oct 2019 14:15:48 +0000 (17:15 +0300)]
TextMate: use loading cache to avoid creating many lambdas

(cherry picked from commit a1b4f9f54c3ffa4eeb9fa153ee14a39950a2adf0)

GitOrigin-RevId: 0287a084d643bc7e7e6bcd2c640eb1c69b65b2ad

10 months agoTextMate: look for R-brace at the end of the token
Alexander Zolotov [Tue, 22 Oct 2019 13:44:51 +0000 (15:44 +0200)]
TextMate: look for R-brace at the end of the token

that reduces amount of unneeded checks in log files (IDEA-223395, IDEA-222408)

(cherry picked from commit cf7d7298fdb869b7d0632249d79de618c5787ead)

GitOrigin-RevId: a6c2a11ff90ec46e91fe31e771308a793063f84e

10 months agoTextMate: add log lexing test
Alexander Zolotov [Tue, 22 Oct 2019 13:30:22 +0000 (15:30 +0200)]
TextMate: add log lexing test

(cherry picked from commit 9877ae918f6005c37f88e9863a06bff3389615e4)

GitOrigin-RevId: f98aa891818bd6ca495ceb2b08d6c3c37dc8c094

10 months agoTextMate: fail fast while brace matching (IDEA-223395, IDEA-222408)
Alexander Zolotov [Sat, 19 Oct 2019 09:13:49 +0000 (12:13 +0300)]
TextMate: fail fast while brace matching (IDEA-223395, IDEA-222408)

if char is not any known brace – skip it before retrieving the actual preferences

(cherry picked from commit bd7c668832b600e8d265868c3964b04a17c8ba08)

GitOrigin-RevId: 21af89d895fb8f6f01d4d350365a939f02bd096a

10 months agoTextMate: use array of ints instead of TextRanges
Alexander Zolotov [Fri, 18 Oct 2019 15:18:46 +0000 (18:18 +0300)]
TextMate: use array of ints instead of TextRanges

(cherry picked from commit 7975a59ff4d10c53a9a780fc37e254dd29b99e86)

GitOrigin-RevId: bc1a44d5fb481c7c0fce92151923d0118c25630f

10 months agoTextMate: convert list to array
Alexander Zolotov [Fri, 18 Oct 2019 14:47:27 +0000 (17:47 +0300)]
TextMate: convert list to array

It will save us some memory + save some time on hashCode computation

(cherry picked from commit 25100b250f3b2d3f2212a20af86d6f5a14796488)

GitOrigin-RevId: 8c76de64c1a11b19a96d87536b12dd372f691744

10 months agogit: cleanup: make 'static'
Aleksandr Krasilnikov [Tue, 22 Oct 2019 10:01:05 +0000 (13:01 +0300)]
git: cleanup: make 'static'

GitOrigin-RevId: 4a995085e77a52d01cbd4015f9e1ff7d208f75b2

10 months agogit: don't reset credential helper for 'git config' command
Aleksandr Krasilnikov [Tue, 22 Oct 2019 09:57:58 +0000 (12:57 +0300)]
git: don't reset credential helper for 'git config' command

Starting from af4757b2 authentication requests are set for all commands, including the 'git config' command.
This leads to a problem: credential.helper will never be read correctly because it is overridden:

    git -c credential.helper = config credential.helper

Solution: just do not reset credential helper for 'git config'

GitOrigin-RevId: c0a58816bc914e98c751f1ca282a2717d9851896

11 months agoPyCharm: update python versions in build.gradle files for tests and other utilities
Aleksey Rostovskiy [Thu, 17 Oct 2019 10:26:36 +0000 (13:26 +0300)]
PyCharm: update python versions in build.gradle files for tests and other utilities

(cherry picked from commit 6ff375bac39e6c4d3bca05b52734ca55449f454c)

(cherry picked from commit dabc4fbe61260943587a17306d5c90989dab915b)

GitOrigin-RevId: ffa89103f753fc82e896aa3a3aacfe32cf09dcab

11 months agoIDEA-CR-53805: [Gradle] release task output reading thread after the task finish...
Vladislav.Soroka [Fri, 18 Oct 2019 15:38:47 +0000 (18:38 +0300)]
IDEA-CR-53805: [Gradle] release task output reading thread after the task finish tooling event IDEA-225007

(cherry picked from commit 8a70c88214f6fe35ecf2382d343e31c09e161005)

GitOrigin-RevId: beb0a7b6b070fac23cc6919e6254e9030ea9c03f

11 months agodo not report exceptions to EA on timeout
Alexander Kass [Mon, 21 Oct 2019 08:14:34 +0000 (11:14 +0300)]
do not report exceptions to EA on timeout

(cherry picked from commit 7daa695137539ed0d44a6d55cda7c7959f78770e)
(cherry picked from commit 336bae1117506b05680a04e3a1878c4adcec135e)

GitOrigin-RevId: 3b5029e7672ddedfe299ad6ce4992fcb6816b2dd

11 months agoUse unicode-compatible encoding as default for in-memory files DBE-8776
Alexander Kass [Mon, 21 Oct 2019 07:13:40 +0000 (10:13 +0300)]
Use unicode-compatible encoding as default for in-memory files DBE-8776

Setting global encoding to single-byte non-unicode compliant should not affect in-memory operations with strings.

(cherry picked from commit 3a6434ca039a1c4c51fb5ed1045f1cf3acfcb171)
(cherry picked from commit 45b3b6c19e19aefd8526dc2515dcc959579a9add)

GitOrigin-RevId: acfd9665b98734c54af64970809555569337ff6d

11 months agoabort write on serialisation failure
Alexander Kass [Fri, 18 Oct 2019 10:05:16 +0000 (13:05 +0300)]
abort write on serialisation failure

(cherry picked from commit cd1defb673e1142bcf5aedd550b59f034d8d9e24)

(cherry picked from commit 74c422ff166560452e6475e78bde799b19a117fb)

GitOrigin-RevId: 596ed6f0526594016262da8da62804705c127585

11 months agoCleanup (docs for IDEA-CR-51479)
Roman Shevchenko [Wed, 21 Aug 2019 15:19:10 +0000 (17:19 +0200)]
Cleanup (docs for IDEA-CR-51479)

(cherry picked from commit 52e1ff052160444b0dfbc1518edc73a38743d46c)

GitOrigin-RevId: 2fd2c069d353a21019736a36faf66beabf58acb1

11 months ago[platform] non-destructive fast SafeFileOutputStream (IDEA-152607/IDEA-155415/IDEA...
Roman Shevchenko [Fri, 16 Aug 2019 09:41:42 +0000 (11:41 +0200)]
[platform] non-destructive fast SafeFileOutputStream (IDEA-152607/IDEA-155415/IDEA-161663/EA-210021)

(cherry picked from commit 73a19c7511079313d21fa9353b9a98473c5a1121)

GitOrigin-RevId: 7499d912cbbdbfa71f34045b25bb2f20a69a6fdf

11 months agoIDEA-CR-53701: [groovy] compiler: use UTF-8 instead of platform encoding to encode...
Daniil Ovchinnikov [Thu, 17 Oct 2019 14:29:04 +0000 (17:29 +0300)]
IDEA-CR-53701: [groovy] compiler: use UTF-8 instead of platform encoding to encode/decode file names (in process) (IDEA-224869)

(cherry picked from commit 3fe9ec5c554e40728e2eb3aeaaf76af0468728eb)

GitOrigin-RevId: cb0096ef21888497c8ce453cf4ac60ce4a94c3af

11 months agoPY-36008 Add support of TypedDict
Lada Gagina [Thu, 17 Oct 2019 15:29:47 +0000 (18:29 +0300)]
PY-36008 Add support of TypedDict

TypedDict was introduced in

GitOrigin-RevId: e0a2a68453b205b7b30f7626f046bd2e10a18268

11 months agoIDEA-CR-53490: [groovy] reference expression: move checking code outside of caching...
Daniil Ovchinnikov [Thu, 3 Oct 2019 14:44:28 +0000 (17:44 +0300)]
IDEA-CR-53490: [groovy] reference expression: move checking code outside of caching in references since it relies on element parent

... which may cause various PIEAE later

(cherry picked from commit 619e38783dde9f2e9c6e235ecc6313b41c21bdb1)

GitOrigin-RevId: 4dd46a9f556e08583c11902e7e6c003e7050b69f

11 months ago[dbe] enable services autoscroll from source by default in DataGrip
dmitriy.tseyler [Mon, 14 Oct 2019 22:01:42 +0000 (01:01 +0300)]
[dbe] enable services autoscroll from source by default in DataGrip

(cherry picked from commit 5c6680e3a686ed3d2880d7aa00cbfe7c2ce6f8fb)
(cherry picked from commit 6e94ad0a8997fd90c416c206efdf28b008f0e842)

GitOrigin-RevId: bdad4d95edce27c1cd40fc4c9a2c8e1067c58c54

11 months ago[IDEA-222118] Update process of config migration
Alex Plate [Fri, 6 Sep 2019 13:20:16 +0000 (16:20 +0300)]
[IDEA-222118] Update process of config migration

The current implementation of configs migration doesn't check
if plugins folder already contains any plugins.
This situation may occur if idea.plugins.path variable is set to some
Since the toolbox app sets idea.plugins.path variable during the update process,
it leads to the problem described in IDEA-222118.

(cherry picked from commit 1d138b3f8125cc951e6d764f95f1f14b2eb9bbdb)

GitOrigin-RevId: 8d8f825d01d6edff81b31dbc638262ff2cef194c

11 months agoIDEA-CR-50922: PY-35961 Report missing parentheses in return/yield depending on langu...
Mikhail Golubev [Fri, 26 Jul 2019 16:15:01 +0000 (19:15 +0300)]
IDEA-CR-50922: PY-35961 Report missing parentheses in return/yield depending on language version

Previously it was done unconditionally for all Python versions in StarAnnotator.
I moved the corresponding checks from there to CompatibilityVisitor so that
it was clear in which particular versions it's mandatory.

GitOrigin-RevId: d74d2c36cc91fda9f99d87ecb44bb2185c00ae77

11 months agoIDEA-CR-50922: PY-35961 Report redundant parentheses in yield statements with tuple...
Mikhail Golubev [Mon, 29 Jul 2019 17:02:08 +0000 (20:02 +0300)]
IDEA-CR-50922: PY-35961 Report redundant parentheses in yield statements with tuple unpacking

Unless it's a "yield from" syntax, where parentheses remain mandatory in Python 3.8.
Additionally, properly suggest removing parentheses in yield statements with
ordinary parenthesized tuples -- previously we ignored them because of a too
broad exclusion.

GitOrigin-RevId: e8bbb059437bea98a32d562c72fc67b156df2aa5

11 months agoIDEA-CR-50922: PY-35961 Consider returns with tuple unpacking in "Redundant parenthes...
Mikhail Golubev [Mon, 29 Jul 2019 16:34:34 +0000 (19:34 +0300)]
IDEA-CR-50922: PY-35961 Consider returns with tuple unpacking in "Redundant parentheses" inspection

Namely, it report parentheses in such return statements as redundant staring
from Python 3.8.

GitOrigin-RevId: bfcf08ec7fc96ed85a2a49d13553eac440881cb9

11 months agoImprove `Literal`s for string expressions (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 15:06:17 +0000 (18:06 +0300)]
Improve `Literal`s for string expressions (PY-35235)

Only plain strings are allowed as `Literal` index.
Only plain strings and f-strings with plain string inside are allowed as `Literal` value.

GitOrigin-RevId: a6bef259557a589adf6a5300ffe055e451731339

11 months agoReduce possible types to be matched as numeric types (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 15:05:57 +0000 (18:05 +0300)]
Reduce possible types to be matched as numeric types (PY-35235)

Use their class names for matching instead of type names, that are more like presentable names (e.g. `Literal[1]`).
Extract separate branches for matching `PyNoneType`'s and `PyModuleType`'s.

GitOrigin-RevId: 6241f086c8d1e3e0a7f483ca69a3befb453a31e3

11 months agoDisable injection for `Literal` arguments (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 15:05:32 +0000 (18:05 +0300)]
Disable injection for `Literal` arguments (PY-35235)

They could not be references to any named elements.

GitOrigin-RevId: 7c87fb13615d3597063d59bc0ce43ccb2de25381

11 months agoFallback for enum member as a `Literal` type (PEP 586) (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 15:03:53 +0000 (18:03 +0300)]
Fallback for enum member as a `Literal` type (PEP 586) (PY-35235)

GitOrigin-RevId: 391a55b2af89953cb4e8a0eb72b0ad14f4a77584

11 months agoUpdate type hints inspection for `Literal` (PEP 586) (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 15:03:22 +0000 (18:03 +0300)]
Update type hints inspection for `Literal` (PEP 586) (PY-35235)

GitOrigin-RevId: d2437264ddd64b210751ef1ec7f8d45f76924762

11 months agoFix promoting type to `Literal` if actual expression is keyword argument (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 15:02:48 +0000 (18:02 +0300)]
Fix promoting type to `Literal` if actual expression is keyword argument (PY-35235)

GitOrigin-RevId: 23941843acbc257ad268d1f3862a24748ee9ed21

11 months agoFix promoting type to `Literal` if expected type is TypeVar bounded with `Literal...
Semyon Proshev [Tue, 15 Oct 2019 15:02:01 +0000 (18:02 +0300)]
Fix promoting type to `Literal` if expected type is TypeVar bounded with `Literal`s (PY-35235)

GitOrigin-RevId: f732fc65fe76c7aba16651df725ea785f22e74e3

11 months agoFix promoting type to `Literal` if expected type is union of `Literal`s (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 15:01:25 +0000 (18:01 +0300)]
Fix promoting type to `Literal` if expected type is union of `Literal`s (PY-35235)

GitOrigin-RevId: e17debc32e3aeb6500d44d1fb6cad68cfa26679f

11 months agoFix matching literal arguments with overloads type hinted with `Literal` (PEP 586...
Semyon Proshev [Tue, 15 Oct 2019 15:00:59 +0000 (18:00 +0300)]
Fix matching literal arguments with overloads type hinted with `Literal` (PEP 586) (PY-35235)

GitOrigin-RevId: f4f3bf7e4de4ef9dd62591379e4af881ce95aab4

11 months agoFix matching for `Literal`s (PEP 586) (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 15:00:17 +0000 (18:00 +0300)]
Fix matching for `Literal`s (PEP 586) (PY-35235)

Add negating expressions support to PyEvaluator
Fix inferring type for strings used in injected fragments (e.g. annotations)

GitOrigin-RevId: e0d365d7458ac8834310ad42688959f60eb706c8

11 months agoType inference for variables explicitly type hinted as `Literal`s (PEP 586) (PY-35235)
Semyon Proshev [Tue, 15 Oct 2019 14:57:33 +0000 (17:57 +0300)]
Type inference for variables explicitly type hinted as `Literal`s (PEP 586) (PY-35235)

GitOrigin-RevId: 986b355a1fdffb56109f768995cc659cf2cde535

11 months agoIDEA-220577 Menu icons in Presentation mode are large
Anton Tarasov [Tue, 10 Sep 2019 12:42:33 +0000 (15:42 +0300)]
IDEA-220577 Menu icons in Presentation mode are large

(cherry picked from commit a924f63637a613d84aed122fbe3cea9fef36557b)

GitOrigin-RevId: e1203979871317d76d9e581b497cbb8c4f3e2f32

11 months agoIJ in 192 now targets 2019.2.5
Vladimir.Orlov [Tue, 15 Oct 2019 05:59:29 +0000 (08:59 +0300)]
IJ in 192 now targets 2019.2.5

GitOrigin-RevId: 6e1dd352d08238daef15909ba0750df48a9c97ec

11 months agoReverted IDEA-222937: disabled native file chooser for macOS Catalina
Alexey Ushakov [Thu, 3 Oct 2019 13:18:18 +0000 (16:18 +0300)]
Reverted IDEA-222937: disabled native file chooser for macOS Catalina

The problem has been fixed in macOS 10.15 Beta (19A578c)

(cherry picked from commit d54cfbcd8004251f03af985cb41df09d8e5bc30f)

GitOrigin-RevId: 6997d7da5ae4dc63bd92a0c74ccf6754f17361cf