idea/community.git
4 years agofix checkbox togging with mouse (do not access `checkbox.getX()` as these components...
Sergey Simonchik [Mon, 21 Dec 2015 16:58:15 +0000 (19:58 +0300)]
fix checkbox togging with mouse (do not access `checkbox.getX()` as these components are not layouted and the return value is unreliable)

4 years agoIDEA-149499 Editor gutter: reduce "jumping" on intermediate indexing
Dmitry Batrak [Mon, 21 Dec 2015 16:42:20 +0000 (19:42 +0300)]
IDEA-149499 Editor gutter: reduce "jumping" on intermediate indexing

4 years agoremote interpreters, loading remote sdk connection credentials: extract common code
irengrig [Fri, 11 Dec 2015 13:46:41 +0000 (14:46 +0100)]
remote interpreters, loading remote sdk connection credentials: extract common code

4 years agoremote interpreters, return old methods for compatibility
irengrig [Fri, 11 Dec 2015 11:03:00 +0000 (12:03 +0100)]
remote interpreters, return old methods for compatibility

4 years agoremote interpreters, do not delegate calls of connection wrapper through RemoteSdkAdd...
irengrig [Thu, 10 Dec 2015 09:40:37 +0000 (10:40 +0100)]
remote interpreters, do not delegate calls of connection wrapper through RemoteSdkAdditionalData: it adds more methods that do nothing. rather expose connection wrapper from additional data

4 years agoremote interpreters, extract code for detecting connection type into platform
irengrig [Wed, 9 Dec 2015 14:02:00 +0000 (15:02 +0100)]
remote interpreters, extract code for detecting connection type into platform

4 years agoJavaAutoPopupTest: added explicit cast to get rid of dynamic usage for 'getPresentabl...
nik [Mon, 21 Dec 2015 16:17:28 +0000 (19:17 +0300)]
JavaAutoPopupTest: added explicit cast to get rid of dynamic usage for 'getPresentableText()'

4 years agonew "AtomicFieldUpdater field not declared 'static final'" inspection
Bas Leijdekkers [Mon, 21 Dec 2015 16:13:15 +0000 (17:13 +0100)]
new "AtomicFieldUpdater field not declared 'static final'" inspection

4 years agoDeprecate obsolete classes
Sergey Malenkov [Mon, 21 Dec 2015 15:40:19 +0000 (18:40 +0300)]
Deprecate obsolete classes

4 years agoPY-16397 Invert option: use "ignoreConstantInTheMiddle" instead of "simplifyWithCons... appcode/144.2377
Valentina Kiryushkina [Mon, 21 Dec 2015 15:42:05 +0000 (18:42 +0300)]
PY-16397 Invert option: use "ignoreConstantInTheMiddle" instead of  "simplifyWithConstantInTheMiddle"

4 years agoPY-17824 Fix according to review: remove checking if containing class is a unit test...
Valentina Kiryushkina [Mon, 21 Dec 2015 14:37:01 +0000 (17:37 +0300)]
PY-17824 Fix according to review: remove checking if containing class is a unit test class, use PyFunction method to get  containing class

4 years agomerge: fix by-word differences
Aleksey Pivovarov [Wed, 16 Dec 2015 17:35:08 +0000 (20:35 +0300)]
merge: fix by-word differences

fix case with "modified - deleted" conflict with equal content of "modified" and "base" sides
It is possible, if modification was manually applied, but change was not resolved

4 years agodiff: cleanup
Aleksey Pivovarov [Mon, 21 Dec 2015 15:19:44 +0000 (18:19 +0300)]
diff: cleanup

4 years agodiff: fix change types in threeside diff with "ignore whitespaces" option
Aleksey Pivovarov [Mon, 21 Dec 2015 14:48:41 +0000 (17:48 +0300)]
diff: fix change types in threeside diff with "ignore whitespaces" option

* compare separate lines instead of whole chunks at once
* compare BASE - LEFT/RIGHT and LEFT - RIGHT in the same manner

ex: "123 X" - "123" - "   123" - old: conflict - new: modified

4 years agomake method 'decodeUrl' public for Upsource
pasynkov [Mon, 21 Dec 2015 15:44:34 +0000 (16:44 +0100)]
make method 'decodeUrl' public for Upsource

4 years agoEP "dom.extender": fix attribute "extendClassName" -> "extenderClass"
Yann Cébron [Mon, 21 Dec 2015 15:30:33 +0000 (16:30 +0100)]
EP "dom.extender": fix attribute "extendClassName" -> "extenderClass"

4 years agoDo not detect indent for big files
Yaroslav Lepenkin [Mon, 21 Dec 2015 14:46:34 +0000 (17:46 +0300)]
Do not detect indent for big files

4 years agoIDEA-141467 "Reformat according to Style"-Checkbox resets on IDE restart appcode/144.2372 clion/144.2373
Dmitry Avdeev [Mon, 21 Dec 2015 14:33:47 +0000 (17:33 +0300)]
IDEA-141467 "Reformat according to Style"-Checkbox resets on IDE restart

saving template options at the project level

4 years agoIDEA-149441 rename the action class to a more explicit name
Kirill Likhodedov [Mon, 21 Dec 2015 13:34:07 +0000 (16:34 +0300)]
IDEA-149441 rename the action class to a more explicit name

4 years agoIDEA-149441 Add update() for consistency
Kirill Likhodedov [Mon, 21 Dec 2015 13:33:32 +0000 (16:33 +0300)]
IDEA-149441 Add update() for consistency

Even though this action is available only if GitVcs is available,
it might theoretically be used somewhere else.

4 years agoRemove obsolete registry properties
Sergey Malenkov [Mon, 21 Dec 2015 13:09:47 +0000 (16:09 +0300)]
Remove obsolete registry properties

4 years agoIDEA-149558 Add an option to show parameter types in debug call stacks
Egor.Ushakov [Mon, 21 Dec 2015 12:14:29 +0000 (15:14 +0300)]
IDEA-149558 Add an option to show parameter types in debug call stacks

4 years agoguava type migration: nested Predicates.not/or/and migrate correctly
Dmitry Batkovich [Mon, 21 Dec 2015 12:04:55 +0000 (15:04 +0300)]
guava type migration: nested Predicates.not/or/and migrate correctly

4 years agoNettythreadDeathWatcher is too slow to exit, ignore appcode/144.2363 clion/144.2364
Alexey Kudravtsev [Mon, 21 Dec 2015 11:37:27 +0000 (14:37 +0300)]
NettythreadDeathWatcher is too slow to exit, ignore

4 years agorunwriteaction
Alexey Kudravtsev [Fri, 18 Dec 2015 18:34:25 +0000 (21:34 +0300)]
runwriteaction

4 years agosimplify invokeAndWait usages
Alexey Kudravtsev [Fri, 18 Dec 2015 18:29:29 +0000 (21:29 +0300)]
simplify invokeAndWait usages

4 years agoDo not detect indent for single line files (WEB-19403)
Yaroslav Lepenkin [Mon, 21 Dec 2015 11:28:12 +0000 (14:28 +0300)]
Do not detect indent for single line files (WEB-19403)

4 years agoFix NPE. EA-76976
Alexander Zolotov [Mon, 21 Dec 2015 11:18:27 +0000 (14:18 +0300)]
Fix NPE. EA-76976

4 years agoguava type migration: do Predicates migration more pretty
Dmitry Batkovich [Mon, 21 Dec 2015 11:15:08 +0000 (14:15 +0300)]
guava type migration: do Predicates migration more pretty

4 years agotype migration: long adder tests are included to suite phpstorm/144.2361
Dmitry Batkovich [Mon, 21 Dec 2015 10:25:43 +0000 (13:25 +0300)]
type migration: long adder tests are included to suite

4 years agotype migration: unused parameter "from" deleted from all tests 2
Dmitry Batkovich [Mon, 21 Dec 2015 10:24:14 +0000 (13:24 +0300)]
type migration: unused parameter "from" deleted from all tests 2

4 years agotype migration: unused parameter "from" deleted from all tests
Dmitry Batkovich [Mon, 21 Dec 2015 10:18:32 +0000 (13:18 +0300)]
type migration: unused parameter "from" deleted from all tests

4 years agotype migration: allow to migrate from "getXXX" to "isXXX" if field migrates to boolea...
Dmitry Batkovich [Mon, 21 Dec 2015 10:12:49 +0000 (13:12 +0300)]
type migration: allow to migrate from "getXXX" to "isXXX" if field migrates to boolean and vice versa. IDEA-127312

4 years agoPY-18034 Handle quoted types prefixed with ":class:" and ":py:class:"
Mikhail Golubev [Fri, 18 Dec 2015 14:50:42 +0000 (17:50 +0300)]
PY-18034 Handle quoted types prefixed with ":class:" and ":py:class:"

4 years agoPY-18034 Fix TypeError that occurs when parameter type is surrounded with backticks
Mikhail Golubev [Fri, 18 Dec 2015 14:05:08 +0000 (17:05 +0300)]
PY-18034 Fix TypeError that occurs when parameter type is surrounded with backticks

4 years agoIDEA-CR-6940 Don't use hardcoded string lengths in the docstring rendering script
Mikhail Golubev [Fri, 18 Dec 2015 13:01:14 +0000 (16:01 +0300)]
IDEA-CR-6940 Don't use hardcoded string lengths in the docstring rendering script

4 years agoAdd @Deprecated to runRemoteProcess() interface and implementation methods
Alexander Koshevoy [Fri, 18 Dec 2015 15:46:49 +0000 (18:46 +0300)]
Add @Deprecated to runRemoteProcess() interface and implementation methods

4 years agoIDEA-84414 Reporting a problem to plugin vendor in "IDE Fatal Errors" doesn't work...
Yann Cébron [Mon, 21 Dec 2015 09:07:22 +0000 (10:07 +0100)]
IDEA-84414 Reporting a problem to plugin vendor in "IDE Fatal Errors" doesn't work ("mailto" link)

4 years agoIG: cleanup and add test
Bas Leijdekkers [Mon, 21 Dec 2015 09:00:51 +0000 (10:00 +0100)]
IG: cleanup and add test

4 years agoXPath: access swing from event dispatch thread in inspection's options
Bas Leijdekkers [Sun, 20 Dec 2015 21:48:07 +0000 (22:48 +0100)]
XPath: access swing from event dispatch thread in inspection's options

4 years agocleanup inspection description
Bas Leijdekkers [Sun, 20 Dec 2015 21:32:35 +0000 (22:32 +0100)]
cleanup inspection description

4 years agoIG: improve description
Bas Leijdekkers [Sun, 20 Dec 2015 21:31:56 +0000 (22:31 +0100)]
IG: improve description

4 years agomake inspection description look better
Bas Leijdekkers [Sun, 20 Dec 2015 15:55:39 +0000 (16:55 +0100)]
make inspection description look better

4 years agoremove formatting from inspection description to match other descriptions
Bas Leijdekkers [Sun, 20 Dec 2015 14:30:03 +0000 (15:30 +0100)]
remove formatting from inspection description to match other descriptions

4 years agoIDEA-149558 Add an option to show parameter types in debug call stacks appcode/144.2357 clion/144.2358
Egor.Ushakov [Mon, 21 Dec 2015 08:32:51 +0000 (11:32 +0300)]
IDEA-149558 Add an option to show parameter types in debug call stacks

4 years agodevkit: corrected required JDK version check, it should use class from platform-api...
nik [Mon, 21 Dec 2015 07:14:46 +0000 (10:14 +0300)]
devkit: corrected required JDK version check, it should use class from platform-api module (IDEA-149598)

4 years agoPY-9727:Test added
Ilya.Kazakevich [Mon, 21 Dec 2015 05:00:29 +0000 (08:00 +0300)]
PY-9727:Test added

4 years agosupport inverse ANSI command (IDEA-149450) appcode/144.2348 clion/144.2345 dbe/144.2344 idea/144.2347 phpstorm/144.2349 pycharm/144.2346 pycharm/144.2351 webstorm/144.2352
Sergey Simonchik [Sun, 20 Dec 2015 23:43:23 +0000 (02:43 +0300)]
support inverse ANSI command (IDEA-149450)

4 years agosupport underline effect with default foreground (IDEA-149450)
Sergey Simonchik [Sun, 20 Dec 2015 23:25:23 +0000 (02:25 +0300)]
support underline effect with default foreground (IDEA-149450)

4 years ago[sql folding] fix DBE-1762, skip dummy blocks in custom surrounders appcode/144.2336 appcode/144.2339 clion/144.2337 clion/144.2338 idea/144.2342 phpstorm/144.2335
Sergey Ignatov [Fri, 18 Dec 2015 21:42:38 +0000 (00:42 +0300)]
[sql folding] fix DBE-1762, skip dummy blocks in custom surrounders

4 years agoIG: recognize javax.annotation.CheckReturnValue (IDEA-19564) appcode/144.2333 clion/144.2332
Bas Leijdekkers [Fri, 18 Dec 2015 16:17:10 +0000 (17:17 +0100)]
IG: recognize javax.annotation.CheckReturnValue (IDEA-19564)

4 years agoIDEA-149450 ANSI escapes not interpreted as expected appcode/144.2326 clion/144.2323 dbe/144.2322 idea/144.2324 phpstorm/144.2329 pycharm/144.2325 pycharm/144.2328 rubymine/144.2327 webstorm/144.2330
Sergey Simonchik [Sat, 19 Dec 2015 19:48:20 +0000 (22:48 +0300)]
IDEA-149450 ANSI escapes not interpreted as expected

4 years agoIDEA-149590 Open File dialog should display icons for registered directory types...
Anton Makeev [Sat, 19 Dec 2015 16:05:30 +0000 (17:05 +0100)]
IDEA-149590 Open File dialog should display icons for registered directory types (e.g. bundles on OS X)

4 years agogit: deprecate appcode/144.2320 clion/144.2321
Kirill Likhodedov [Sat, 19 Dec 2015 14:53:31 +0000 (17:53 +0300)]
git: deprecate

4 years agogit: cleanup: remove unused methods
Kirill Likhodedov [Sat, 19 Dec 2015 14:50:51 +0000 (17:50 +0300)]
git: cleanup: remove unused methods

4 years agoIDEA-55508 show history for file/revision: better enabled/visible state
Kirill Likhodedov [Wed, 16 Dec 2015 12:25:46 +0000 (15:25 +0300)]
IDEA-55508 show history for file/revision: better enabled/visible state

* Support several commits selection (Changes are zipped).
  NB: modify-modify-delete commit sequence for a file
  will show history for this file beginning from the first modification,
  not from the deletion. Fixing that is possible but harder.
* Don't get invisible if no commits are selected.
* Don't get enabled if there is 1 file in the ChangesBrowser,
  but no files are selected.

To implement this, get List<Change> from the data context,
which is enough to find the path + revision, and get
VcsKey from the data context to get the correct HistoryProvider.

4 years agoIDEA-149441 Add "Clone" action to Git group
Kirill Likhodedov [Fri, 18 Dec 2015 15:44:06 +0000 (18:44 +0300)]
IDEA-149441 Add "Clone" action to Git group

4 years agovcs: remove "edit global message" internal action, since it was never used since...
Kirill Likhodedov [Fri, 18 Dec 2015 15:14:28 +0000 (18:14 +0300)]
vcs: remove "edit global message" internal action, since it was never used since introduced

4 years agoArrayUtil.isEmpty: too often we write if (arr == null || arr.length == 0)
Kirill Likhodedov [Wed, 16 Dec 2015 12:48:44 +0000 (15:48 +0300)]
ArrayUtil.isEmpty: too often we write if (arr == null || arr.length == 0)

4 years agoguava type migration: batch execution with multiple roots fixed. Now conversion is...
Dmitry Batkovich [Sat, 19 Dec 2015 14:08:33 +0000 (17:08 +0300)]
guava type migration: batch execution with multiple roots fixed. Now conversion is aware about TypeEvaluator and could decide about actions to do if around context is changed by other root

4 years agoemploy instrumentation optimization (reuse constant pool & unchanged methods bytecode...
Eugene Zhuravlev [Sat, 19 Dec 2015 12:34:54 +0000 (13:34 +0100)]
employ instrumentation optimization (reuse constant pool & unchanged methods bytecode if possible)

4 years agoDirectoryBasedStorageTest bombed appcode/144.2318 clion/144.2317 phpstorm/144.2319
Vladimir Krivosheev [Sat, 19 Dec 2015 07:35:43 +0000 (08:35 +0100)]
DirectoryBasedStorageTest bombed

4 years agoio.netty.serviceThreadPrefix requires explicit postix — " " space in our case
Vladimir Krivosheev [Sat, 19 Dec 2015 07:33:57 +0000 (08:33 +0100)]
io.netty.serviceThreadPrefix requires explicit postix — " " space in our case

4 years agoIDEA-149366 The error message that is shown on attempt to download library if connect... appcode/144.2312 clion/144.2309 dbe/144.2308 idea/144.2311 phpstorm/144.2313 pycharm/144.2307 rubymine/144.2314 webstorm/144.2315
Yann Cébron [Fri, 18 Dec 2015 20:22:49 +0000 (21:22 +0100)]
IDEA-149366 The error message that is shown on attempt to download library if connection fails should be wrapped

4 years agoif vm is not bootstrapped and no jb debugger support, so, script added from initial... clion/144.2304
Vladimir Krivosheev [Fri, 18 Dec 2015 17:46:25 +0000 (18:46 +0100)]
if vm is not bootstrapped and no jb debugger support, so, script added from initial Scripts message,
only jb debugger support reports sourceMapUrl and any breakpoint is not yet in action (we just connected and scripts were already parsed and executed),
so, we must invoke doFindSourceMap explicitly

updated netty (actually, we already use b8 version)

4 years agoApplicationImpl.isRunningFromSources() to determine if IDE is running from sources... clion/144.2303
Anton Makeev [Fri, 18 Dec 2015 17:35:11 +0000 (18:35 +0100)]
ApplicationImpl.isRunningFromSources() to determine if IDE is running from sources, not from a distribution bundle

4 years agobetter diagnostics for stub roots mismatch
Konstantin Ulitin [Fri, 18 Dec 2015 17:19:07 +0000 (20:19 +0300)]
better diagnostics for stub roots mismatch

4 years agoguava type migration: test data fixed
Dmitry Batkovich [Fri, 18 Dec 2015 16:59:04 +0000 (19:59 +0300)]
guava type migration: test data fixed

4 years agoguava type migration: little regression fixed
Dmitry Batkovich [Fri, 18 Dec 2015 16:56:54 +0000 (19:56 +0300)]
guava type migration: little regression fixed

4 years agoincorrect breakpoint gutter icon when stepping (if another thread was on a breakpoint)
Egor.Ushakov [Fri, 18 Dec 2015 16:44:16 +0000 (19:44 +0300)]
incorrect breakpoint gutter icon when stepping (if another thread was on a breakpoint)

4 years agodiff: add usage triggers
Aleksey Pivovarov [Fri, 18 Dec 2015 16:43:37 +0000 (19:43 +0300)]
diff: add usage triggers

4 years agotype migration: adjust generic array creation to valid code (IDEA-147662)
Dmitry Batkovich [Fri, 18 Dec 2015 16:43:58 +0000 (19:43 +0300)]
type migration: adjust generic array creation to valid code (IDEA-147662)

4 years agodiff: remove duplication - extract DiffRequestProcessor caching logic webstorm/144.2302
Aleksey Pivovarov [Fri, 18 Dec 2015 15:50:54 +0000 (18:50 +0300)]
diff: remove duplication - extract DiffRequestProcessor caching logic

4 years agodisable old sencha plugins due to API changes pycharm/144.2301
Dennis Ushakov [Fri, 18 Dec 2015 15:18:32 +0000 (18:18 +0300)]
disable old sencha plugins due to API changes

4 years agoguava inspection: simplify expression after Predicates.XXX conversion
Dmitry Batkovich [Fri, 18 Dec 2015 15:01:50 +0000 (18:01 +0300)]
guava inspection: simplify expression after Predicates.XXX conversion

4 years agoIDEA-149538 (redundant field initialization in the presence of class initializers) appcode/144.2300 clion/144.2299
Bas Leijdekkers [Fri, 18 Dec 2015 13:25:57 +0000 (14:25 +0100)]
IDEA-149538 (redundant field initialization in the presence of class initializers)

4 years agolog details when sending Unix signals (investigating WEB-19212)
Sergey Simonchik [Fri, 18 Dec 2015 14:35:25 +0000 (17:35 +0300)]
log details when sending Unix signals (investigating WEB-19212)

4 years agodiff: add gaps in content titles
Aleksey Pivovarov [Fri, 18 Dec 2015 11:42:41 +0000 (14:42 +0300)]
diff: add gaps in content titles

4 years agoTemplate debugging with Django 1.9 (PY-17923)
Elizaveta Shashkova [Fri, 18 Dec 2015 14:28:48 +0000 (17:28 +0300)]
Template debugging with Django 1.9 (PY-17923)

The template debug setting was changed in Django 1.8. Also the 'source' field of the Node was removed in Django 1.9, so we should get template filename and line in a different way.

4 years agogradle: task execution view context menu support added
Vladislav.Soroka [Fri, 18 Dec 2015 14:25:48 +0000 (17:25 +0300)]
gradle: task execution view context menu support added

4 years agosilence eval exceptions for return values
Egor.Ushakov [Fri, 18 Dec 2015 14:00:58 +0000 (17:00 +0300)]
silence eval exceptions for return values

4 years agoIDEA-149184 diff: change binary file state synchroniously
Aleksey Pivovarov [Thu, 10 Dec 2015 14:50:37 +0000 (17:50 +0300)]
IDEA-149184 diff: change binary file state synchroniously

* remember state on navigating between viewed files

4 years agoinherit from defaults, not code insight attributes
Dennis Ushakov [Fri, 18 Dec 2015 13:46:09 +0000 (16:46 +0300)]
inherit from defaults, not code insight attributes
#WEB-19527 fixed

4 years agoimplemented go to source for method return value node
Egor.Ushakov [Fri, 18 Dec 2015 13:29:54 +0000 (16:29 +0300)]
implemented go to source for method return value node

4 years agoguava inspection: added Predicates.not/and/or support in cases of unnested methods phpstorm/144.2297
Dmitry Batkovich [Fri, 18 Dec 2015 12:16:49 +0000 (15:16 +0300)]
guava inspection: added Predicates.not/and/or support in cases of unnested methods

4 years agoupdate web inspector protocol appcode/144.2296 clion/144.2295
Konstantin Ulitin [Fri, 18 Dec 2015 11:02:54 +0000 (12:02 +0100)]
update web inspector protocol

4 years agoIG: fix inspection serialization
Bas Leijdekkers [Fri, 18 Dec 2015 10:43:40 +0000 (11:43 +0100)]
IG: fix inspection serialization

4 years agoMerge remote-tracking branch 'origin/master'
Dmitry Avdeev [Fri, 18 Dec 2015 10:27:42 +0000 (13:27 +0300)]
Merge remote-tracking branch 'origin/master'

4 years agoMerge branch 'merge-android-15'
Dmitry Avdeev [Fri, 18 Dec 2015 10:18:26 +0000 (13:18 +0300)]
Merge branch 'merge-android-15'

4 years agowas too optimistic for heavily loaded agent
Alexey Kudravtsev [Fri, 18 Dec 2015 10:13:20 +0000 (13:13 +0300)]
was too optimistic for heavily loaded agent

4 years agoadjust test constants
Alexey Kudravtsev [Fri, 18 Dec 2015 09:51:59 +0000 (12:51 +0300)]
adjust test constants

4 years agomerging android studio 1.5: test fixes
Dmitry Avdeev [Fri, 18 Dec 2015 09:41:22 +0000 (12:41 +0300)]
merging android studio 1.5: test fixes

4 years agoMerge branches 'master' and 'pycharm/folding' of git.labs.intellij.net:idea/community appcode/144.2283 appcode/144.2294 clion/144.2284 clion/144.2293 dbe/144.2282 idea/144.2285 phpstorm/144.2280 pycharm/144.2289 rubymine/144.2288 webstorm/144.2290
liana.bakradze [Thu, 17 Dec 2015 19:06:06 +0000 (21:06 +0200)]
Merge branches 'master' and 'pycharm/folding' of git.labs.intellij.net:idea/community

# Conflicts:
# python/src/META-INF/python-core.xml

4 years agoupdate graphics for 16 EAPs
Konstantin Bulenkov [Thu, 17 Dec 2015 17:59:30 +0000 (20:59 +0300)]
update graphics for 16 EAPs

4 years agocleanup
Vladimir Krivosheev [Thu, 17 Dec 2015 17:56:00 +0000 (18:56 +0100)]
cleanup

4 years agoES6. client debug: fix is not easy since it is a real situation when we set such...
Vladimir Krivosheev [Thu, 17 Dec 2015 17:55:38 +0000 (18:55 +0100)]
ES6. client debug: fix is not easy since it is a real situation when we set such breakpoint AFTER breakpoint hit. And we will filter out incorrectly, because we inspect old (used for server breakpoint) VM breakpoint (new breakpoint is not used at all since hit was occurred already).

4 years agouse minor version component for system path selector (IDEA-CR-7501) appcode/144.2274
Maxim.Mossienko [Thu, 17 Dec 2015 17:23:47 +0000 (18:23 +0100)]
use minor version component for system path selector (IDEA-CR-7501)

4 years agouse correct suspend context during evaluate
Egor.Ushakov [Thu, 17 Dec 2015 17:16:46 +0000 (20:16 +0300)]
use correct suspend context during evaluate

4 years agoIDEA-145091 Provide option for duplicated code inspection to exclude generated source...
Maxim.Mossienko [Thu, 17 Dec 2015 16:49:30 +0000 (17:49 +0100)]
IDEA-145091 Provide option for duplicated code inspection to exclude generated sources duplicates when processing plain source file

4 years agoES6. client debug:
Vladimir Krivosheev [Thu, 17 Dec 2015 16:30:10 +0000 (17:30 +0100)]
ES6. client debug:

source url is correct on meteor side.
our smart solution works — we don't need to setup mappings, we find script by content.

so... why we stopped at first line in the client/app.js?

Well... because there is a breakpoint in the server/app.js. As we set breakpoints only by file name, not but by file path, one VM breakpoint serves _2_ IDE breakpoints.
And there is a clear comment in the LineBreakpointManager — "we must not remove vm breakpoint - it is used for another ide breakpoints".
So, we just not remove VM breakpoint and it hit. And we stop.

Solution — fix "hasBreakProblem" and filter it out on suspended.

Well, we can implement specific solution for meteor, but... I am not going to fix debug for each tool on the planet. Generic solution is a bit complex, is a bit slower, but it is generic. Save our time and time of our users.