idea/community.git
39 min agoIdeModifiableModelsProviderImpl: resolve library order entries into current modifiabl... master
Leonid Shalupov [Fri, 15 Nov 2019 13:35:04 +0000 (15:35 +0200)]
IdeModifiableModelsProviderImpl: resolve library order entries into current modifiable project library table

Clients of IdeModifiableModelsProviderImpl used explicit instances of created libraries to pass them via order entries (e.g. FlexMojo3Configurator).
Workspace model resolves every order entry via library table by name.

GitOrigin-RevId: 4fb0b01b0a8c9cb0c91e8b433e40c6ec6364d2ee

39 min agoworkspace model: same values for OrderEntry.isSynthetic as old model
Leonid Shalupov [Fri, 15 Nov 2019 13:25:46 +0000 (15:25 +0200)]
workspace model: same values for OrderEntry.isSynthetic as old model

GitOrigin-RevId: 541ad5c1df7725b18a19762e422c90b1e2a4cfbb

104 min agoIdeaTestUtil: add back getWebMockJdk17 and addWebJarsTo to provide possible plugin...
Leonid Shalupov [Fri, 15 Nov 2019 12:30:12 +0000 (14:30 +0200)]
IdeaTestUtil: add back getWebMockJdk17 and addWebJarsTo to provide possible plugin compatibility

IDEA-CR-55323

GitOrigin-RevId: c3140b6919b97c6a613d5b0db7585417cbb56d89

104 min agosearch everywhere: show dumb mode notification in advertiser when only part of contri...
Dmitry Batkovich [Fri, 15 Nov 2019 10:29:47 +0000 (13:29 +0300)]
search everywhere: show dumb mode notification in advertiser when only part of contributors can be accessed in dumb mode

GitOrigin-RevId: c187415294a02622dd8bd432e80f2c70a9db001c

104 min agoBigPopupUI.mySearchField is always ExtendableTextField
Dmitry Batkovich [Fri, 15 Nov 2019 10:11:56 +0000 (13:11 +0300)]
BigPopupUI.mySearchField is always ExtendableTextField

GitOrigin-RevId: 1be5bce5d5a66a005a7d76c0618711b363ccddc0

2 hours agointroduce a better metric for editors reopening time
Dmitry Batrak [Fri, 15 Nov 2019 12:04:52 +0000 (15:04 +0300)]
introduce a better metric for editors reopening time

existing one ('editor restoring') doesn't include asynchronous loading time

updates following IDEA-CR-55321

GitOrigin-RevId: 63d62ea9263ac199dfe19ad26b3bc9bd4754a340

2 hours ago[icons sync] filter non-existent repos
Dmitriy.Panov [Fri, 15 Nov 2019 11:55:35 +0000 (14:55 +0300)]
[icons sync] filter non-existent repos

GitOrigin-RevId: bf9f33a0e911a9627ab44e6832a6a660cf5c0b2e

2 hours agovcs: fix deadlock in VcsRepositoryManager
Aleksey Pivovarov [Thu, 14 Nov 2019 16:07:12 +0000 (19:07 +0300)]
vcs: fix deadlock in VcsRepositoryManager

EA-217113 - F: ReadMostlyRWLock.waitABit

GitOrigin-RevId: 1061e8487cff5a7b1fed28700394e29e3c69f5e0

2 hours agoMethodCallInLoopCondition: added Q.poll to iteration methods; ignoring CAS because...
Mike Gorünov [Fri, 15 Nov 2019 11:28:54 +0000 (12:28 +0100)]
MethodCallInLoopCondition: added Q.poll to iteration methods; ignoring CAS because of side-effects

close #1209

GitOrigin-RevId: a62632d42fd52fe9e55d37036247f6886dacaf6e

2 hours agoIG: further "Missorted modifiers" inspection description tweaks (IDEA-CR-55044)
Bas Leijdekkers [Thu, 14 Nov 2019 15:43:06 +0000 (16:43 +0100)]
IG: further "Missorted modifiers" inspection description tweaks (IDEA-CR-55044)

GitOrigin-RevId: 130b7c62282fe03abce371841a8eafbe0e45bc8c

2 hours agoForce to use IntelliJ file chooser to fix IDEA-218720
Rustam Vishnyakov [Fri, 15 Nov 2019 11:22:50 +0000 (14:22 +0300)]
Force to use IntelliJ file chooser to fix IDEA-218720

GitOrigin-RevId: b8522b1112968f9ef71fc8112698a53ac7719907

2 hours agoPY-39090 Move string constant to a variable
Elizaveta Shashkova [Fri, 15 Nov 2019 11:18:18 +0000 (14:18 +0300)]
PY-39090 Move string constant to a variable

GitOrigin-RevId: 6db62403be8d0b064172e729a2cedaf912ca5bff

3 hours ago[jps-cache] Refactoring of loader manager
Mikhail Mazurkevich [Fri, 15 Nov 2019 10:12:22 +0000 (13:12 +0300)]
[jps-cache] Refactoring of loader manager

GitOrigin-RevId: a37f537739a8e1501504e483822b99cc86a388f9

3 hours agodump average load while freeze where available
Egor Ushakov [Fri, 15 Nov 2019 10:12:33 +0000 (13:12 +0300)]
dump average load while freeze where available

GitOrigin-RevId: 8eed195add63d746b00c9cf2519a27e6368b45f9

4 hours agoPsiDiamondTypeImpl: remove harmful recursion guard
Tagir Valeev [Fri, 15 Nov 2019 10:01:06 +0000 (17:01 +0700)]
PsiDiamondTypeImpl: remove harmful recursion guard

GitOrigin-RevId: 02ee4442c243f8fc35788086b8350083cc3ea1d5

4 hours agotestResolveDiamondBeforeOuterCall simplified (TreeSet ctor overloads don't matter...
Tagir Valeev [Fri, 15 Nov 2019 08:29:48 +0000 (15:29 +0700)]
testResolveDiamondBeforeOuterCall simplified (TreeSet ctor overloads don't matter here)

GitOrigin-RevId: 6b303239bed1ffcfd94cbd54f781541e38dc5837

4 hours agoIDEA-225436: fixed text length mismatch
Artem Bochkarev [Fri, 15 Nov 2019 09:44:40 +0000 (12:44 +0300)]
IDEA-225436: fixed text length mismatch

GitOrigin-RevId: d4c1691233f1e714a86d25efce4f55aa0f18ec96

5 hours ago[jps] Avoid memory consumption if source state report unavailable
Mikhail Mazurkevich [Fri, 15 Nov 2019 07:37:33 +0000 (10:37 +0300)]
[jps] Avoid memory consumption if source state report unavailable

GitOrigin-RevId: c25fe40f300c6e83726b5c93cdb64640717668af

5 hours agoFix Windows platform detection for IronPython
Andrey Lisin [Wed, 13 Nov 2019 15:11:22 +0000 (18:11 +0300)]
Fix Windows platform detection for IronPython

(cherry picked from commit f202f6faf37c5f38cba7caf8c2a4d92dfd76c659)

GitOrigin-RevId: b57ae879f9b466c6130e868bab1144831ef46cf6

5 hours agoadd test for unsaved document index access in dumb mode
Dmitry Batkovich [Fri, 15 Nov 2019 08:21:59 +0000 (11:21 +0300)]
add test for unsaved document index access in dumb mode

GitOrigin-RevId: 6310edc88f0465e3af583e0b125e60b2487d2dc7

5 hours agocleanup
Sergey Ignatov [Fri, 15 Nov 2019 08:43:09 +0000 (11:43 +0300)]
cleanup

GitOrigin-RevId: 780c1f153ddbacc39112d126f7344455db5423ad

5 hours agomore dynamic eps
Sergey Ignatov [Fri, 15 Nov 2019 08:42:14 +0000 (11:42 +0300)]
more dynamic eps

GitOrigin-RevId: 0997cbec89b572bd8d368300de0376afea61b9e2

5 hours agounresolved refs: popup with suggested targets
Anna.Kozlova [Fri, 15 Nov 2019 08:23:15 +0000 (09:23 +0100)]
unresolved refs: popup with suggested targets

GitOrigin-RevId: e313de41d3586a57f26df3e1db0299ed5141dafb

6 hours agointroduce a better metric for editors reopening time
Dmitry Batrak [Fri, 15 Nov 2019 07:55:41 +0000 (10:55 +0300)]
introduce a better metric for editors reopening time

existing one ('editor restoring') doesn't include asynchronous loading time

GitOrigin-RevId: 901774e159c13bba89db2e15ce91c239d74e0e0e

6 hours agotestResolveDiamondBeforeOuterCall (fails if new expression type is requested before...
Tagir Valeev [Fri, 15 Nov 2019 07:33:14 +0000 (14:33 +0700)]
testResolveDiamondBeforeOuterCall (fails if new expression type is requested before highlighting)

GitOrigin-RevId: b01abb3fbbebe28e3115aa109005851b62a02e7b

6 hours ago[groovy] remove unused methods from GrStringUtil
Daniil Ovchinnikov [Fri, 15 Nov 2019 07:27:00 +0000 (10:27 +0300)]
[groovy] remove unused methods from GrStringUtil

GitOrigin-RevId: fb85917fecd296a2f567474dfb79ec6240942758

6 hours ago[groovy] fix warnings in StringPartInfo
Daniil Ovchinnikov [Fri, 15 Nov 2019 07:26:36 +0000 (10:26 +0300)]
[groovy] fix warnings in StringPartInfo

GitOrigin-RevId: 0beced554224da4aba320edea8e6289d230e07c6

6 hours agoappend original fragment if it cannot be unescaped properly on copy
Daniil Ovchinnikov [Fri, 15 Nov 2019 07:18:56 +0000 (10:18 +0300)]
append original fragment if it cannot be unescaped properly on copy

GitOrigin-RevId: 8ea24d57849355e4bb56ec2058249af379bc4876

7 hours agolet find in path uses Trigram & IdIndex in dumb mode as is (IDEA-225580): follow...
Dmitry Batkovich [Fri, 15 Nov 2019 06:10:15 +0000 (09:10 +0300)]
let find in path uses Trigram & IdIndex in dumb mode as is (IDEA-225580): follow IDEA-CR-54769 (use non-blocking read action)

GitOrigin-RevId: b974ad3bb86d2688813539b831db435c993f7fc9

8 hours agolet find in path uses Trigram & IdIndex in dumb mode as is (IDEA-225580): follow...
Dmitry Batkovich [Fri, 15 Nov 2019 05:36:51 +0000 (08:36 +0300)]
let find in path uses Trigram & IdIndex in dumb mode as is (IDEA-225580): follow IDEA-CR-54769 (rename method)

GitOrigin-RevId: d00fedefa9db1557a397f6f2ef5bd471bc8d0f65

8 hours agoadd logging for roots changed events in PushedFilePropertiesUpdaterImpl for IDEA...
Dmitry Batkovich [Fri, 15 Nov 2019 05:27:37 +0000 (08:27 +0300)]
add logging for roots changed events in PushedFilePropertiesUpdaterImpl for IDEA-221302

GitOrigin-RevId: 12ccec6cda1e7c26de69877070b5cd1d06ae263a

8 hours agoJavaQuoteHandler: do not auto-insert text block closing quotes if language level...
Artemiy Sartakov [Fri, 15 Nov 2019 05:26:58 +0000 (12:26 +0700)]
JavaQuoteHandler: do not auto-insert text block closing quotes if language level is less than 13 preview (IDEA-226851)

GitOrigin-RevId: a837fe0a691aa01900ec89c18b65e23a4d2d0898

9 hours agoindexOf() -> contains(); other warnings fixed
Tagir Valeev [Fri, 15 Nov 2019 04:30:30 +0000 (11:30 +0700)]
indexOf() -> contains(); other warnings fixed

GitOrigin-RevId: 683a27aa1c5c1bab7d60b62f1d6eb043c9e4a2d2

9 hours agoListIndexOfReplaceableByContains: enabled by default
Tagir Valeev [Fri, 15 Nov 2019 04:29:06 +0000 (11:29 +0700)]
ListIndexOfReplaceableByContains: enabled by default

GitOrigin-RevId: 526889a17b99c91e43e100241ccef07a64729a83

9 hours agoBusyWait enabled by default (experimentally)
Tagir Valeev [Fri, 15 Nov 2019 04:13:25 +0000 (11:13 +0700)]
BusyWait enabled by default (experimentally)

GitOrigin-RevId: 2f8ba10cca008d93f9bb3e92b6861908b7c4bfe4

9 hours agoIteratorHasNextCallsIteratorNext: improved and enabled by default
Tagir Valeev [Fri, 15 Nov 2019 04:01:52 +0000 (11:01 +0700)]
IteratorHasNextCallsIteratorNext: improved and enabled by default

1. Report exactly the name of called method
2. Report at the 'next()' call, rather than at a 'hasNext()' declaration
3. Support List.hasPrevious()
4. Updated description

GitOrigin-RevId: cd2a8042e63ed67f0d70ec3e215173e37a8b6af2

9 hours agoIteratorHasNextCallsIteratorNext: zero-tolerance
Tagir Valeev [Fri, 15 Nov 2019 03:39:47 +0000 (10:39 +0700)]
IteratorHasNextCallsIteratorNext: zero-tolerance

GitOrigin-RevId: a7d48f4953ebf49ebc397a91a830dcff9d28e455

9 hours agoEnable InstantiationOfUtilityClass by default
Tagir Valeev [Fri, 15 Nov 2019 03:37:23 +0000 (10:37 +0700)]
Enable InstantiationOfUtilityClass by default

GitOrigin-RevId: 5b0b21ef61baa08ed8dfd60b5ad2829321b803a5

9 hours agoFieldMayBeFinal: enabled by default
Tagir Valeev [Fri, 15 Nov 2019 03:25:14 +0000 (10:25 +0700)]
FieldMayBeFinal: enabled by default

GitOrigin-RevId: 4170a3f85bfa603f8e5f50800638673e1ba3ecc7

10 hours agoModuleFixtureBuilderImpl: fix zero-tolerance warning
Tagir Valeev [Fri, 15 Nov 2019 03:09:13 +0000 (10:09 +0700)]
ModuleFixtureBuilderImpl: fix zero-tolerance warning

GitOrigin-RevId: 37187cf6780ad293a04860f572288ce260f62020

16 hours agoRemove leading slashes that cause resource loading issues
Kirill Glazyrin [Thu, 14 Nov 2019 21:58:41 +0000 (00:58 +0300)]
Remove leading slashes that cause resource loading issues

GitOrigin-RevId: d8ff5f42141c476d46f5b14da65c0d950a758a2a

16 hours ago[jps-cache] Turn off files truncate on close
Mikhail Mazurkevich [Thu, 14 Nov 2019 21:50:22 +0000 (00:50 +0300)]
[jps-cache] Turn off files truncate on close

GitOrigin-RevId: b1ae2f0c1d08b22426991911ac397f861ae6dc3d

16 hours agodon't use a group with a single item inside
Sergey Ignatov [Thu, 14 Nov 2019 21:17:25 +0000 (00:17 +0300)]
don't use a group with a single item inside

GitOrigin-RevId: 9aec27232a643311daadecd7ac5ce3303fbc43b2

16 hours agoremove preload=true
Sergey Ignatov [Thu, 14 Nov 2019 21:13:31 +0000 (00:13 +0300)]
remove preload=true

GitOrigin-RevId: cc09a2607ff21114c0d1457bdaa32ab2c66d1795

17 hours agouse a preloaded service instead of a component
Sergey Ignatov [Thu, 14 Nov 2019 20:54:27 +0000 (23:54 +0300)]
use a preloaded service instead of a component

GitOrigin-RevId: 8f538d6209403f34e810d5100c277345cc3b4859

17 hours agoTest should be finished even if it was failed
Alexander Zolotov [Fri, 8 Nov 2019 09:49:59 +0000 (12:49 +0300)]
Test should be finished even if it was failed

GitOrigin-RevId: 47702a6f4ab4d689b8ab0a7183cd3cee333b5830

17 hours agosplit language eps a bit: introduce xml files for completion, formatter and refactoring
Sergey Ignatov [Thu, 14 Nov 2019 20:43:41 +0000 (23:43 +0300)]
split language eps a bit: introduce xml files for completion, formatter and refactoring

GitOrigin-RevId: 3009b17a8412abc4d89b061b8c2a1e0ff8a5b57a

18 hours ago[jps-cache] Update readme
Mikhail Mazurkevich [Thu, 14 Nov 2019 19:47:28 +0000 (22:47 +0300)]
[jps-cache] Update readme

GitOrigin-RevId: a2c09c6769d8f8dd0ab42bd38b9bbb4c9a38ffbd

18 hours ago[jps-cache] Fix redundant progress indicator
Mikhail Mazurkevich [Thu, 14 Nov 2019 19:25:47 +0000 (22:25 +0300)]
[jps-cache] Fix redundant progress indicator

GitOrigin-RevId: 42bcfa176ffa404a2e508e590f4f9dd448db0946

18 hours ago[vcs-log] rename "Open Another Log Tab" action to "Open New Vcs Log Tab" and update...
Julia Beliaeva [Thu, 14 Nov 2019 18:45:26 +0000 (21:45 +0300)]
[vcs-log] rename "Open Another Log Tab" action to "Open New Vcs Log Tab" and update description

Since ab5f2b06df58e77bb8fcaa800a3f048e66b4dd4b the action works outside of the log, so some clarifications are necessary.

GitOrigin-RevId: 44e522dbaac9256a9fe893968f956f5cc411cd09

18 hours agoShow excluded files by default because of AppCodeFilesViewTest.testIconsForExcludedFo...
Sergey Malenkov [Thu, 14 Nov 2019 18:33:04 +0000 (21:33 +0300)]
Show excluded files by default because of AppCodeFilesViewTest.testIconsForExcludedFolders

GitOrigin-RevId: 791c40d19850ab4b02af3bdf63559f776c2f4115

20 hours agoRemove obsolete workaround for notifying change change of SDK after adding new interp...
Alexander Koshevoy [Thu, 14 Nov 2019 17:23:29 +0000 (20:23 +0300)]
Remove obsolete workaround for notifying change change of SDK after adding new interpreter

Previously adding new Python interpreter in Project Interpreter settings page implicitly set this interpreter as the current Project interpreter. OK or Apply button were not required to be pressed. This behavior has changed at some point making this workaround unnecessary.

GitOrigin-RevId: 76ce3b831a8bc31dbbbeccf4cacc9b44e8a0ff3d

20 hours ago[vcs-log] correctly handle group name vs references names
Julia Beliaeva [Wed, 13 Nov 2019 18:15:30 +0000 (21:15 +0300)]
[vcs-log] correctly handle group name vs references names

Group name should be used as an action name, but references names should be used as filter values.

GitOrigin-RevId: 900bf1de8b499f233d525421b175c6aa7fc54d55

21 hours agofix rebuild start condition (IDEA-226496)
Eugene Zhuravlev [Thu, 14 Nov 2019 16:26:48 +0000 (17:26 +0100)]
fix rebuild start condition (IDEA-226496)

GitOrigin-RevId: e4d4a9dffa8a233fea3d45a67b3ac1d21e037bcc

21 hours agofurther increase threshold in internal mode
Egor Ushakov [Thu, 14 Nov 2019 16:44:57 +0000 (19:44 +0300)]
further increase threshold in internal mode

GitOrigin-RevId: 9846eac06a75684d83ee0ef15926111bbeb8d4e5

21 hours agoIDEA-CR-55281: move EscapeHandling under 'show.log.as.editor.tab'
kirill.skrygan [Thu, 14 Nov 2019 16:19:15 +0000 (18:19 +0200)]
IDEA-CR-55281: move EscapeHandling under 'show.log.as.editor.tab'

(cherry picked from commit 5aab09df7cb09210b46ad4f34ae0da774304b128)

GitOrigin-RevId: 288022cd9b0fabaac584cca853cc3673a67f9de9

21 hours agoIDEA-CR-55281: cleanup + revert fix with preferredFocusComponent due to review
kirill.skrygan [Thu, 14 Nov 2019 16:16:44 +0000 (18:16 +0200)]
IDEA-CR-55281: cleanup + revert fix with preferredFocusComponent due to review

(cherry picked from commit 099fb20282e88cfbd30df837b4f098fee9bbdea6)

GitOrigin-RevId: b20e7d6058c0a71f0f371654c0196e2078d2b616

21 hours agoIDEA-CR-55281: fix RIDER-35074, RIDER-34349
kirill.skrygan [Thu, 14 Nov 2019 14:56:43 +0000 (16:56 +0200)]
IDEA-CR-55281: fix RIDER-35074, RIDER-34349

Close diff preview in editor if there is no active changes

(cherry picked from commit aa1898a05f7d6d8713399c656b1d099c33dbfc03)

GitOrigin-RevId: 6b54c5de9466040c91f5c936012ea85fc10cbcec

21 hours agoIDEA-CR-55281: annotations
kirill.skrygan [Mon, 21 Oct 2019 13:57:48 +0000 (16:57 +0300)]
IDEA-CR-55281: annotations

(cherry picked from commit 5ff8e73b6bf0aa8285f10be66b4f6582c72085af)

GitOrigin-RevId: 5fb707f23e9964a8db3618840523301fc5abe2fc

21 hours agoIDEA-CR-55281: shorten editor tabs names
kirill.skrygan [Wed, 23 Oct 2019 10:15:16 +0000 (13:15 +0300)]
IDEA-CR-55281: shorten editor tabs names

fix tooltip text

(cherry picked from commit 46ba7f579bd1a4cc045debf9ff1f740c1e31d1f2)

GitOrigin-RevId: 62b276bbf252cd8096c7b783573750acade33de9

21 hours agoSpecify return type for public variables and fix checking sdk type class
Semyon Proshev [Thu, 14 Nov 2019 16:36:46 +0000 (19:36 +0300)]
Specify return type for public variables and fix checking sdk type class

GitOrigin-RevId: f469eea226c20b515aee8deea03a7aca9f60b367

21 hours ago[groovy] tests: add TestUtils#runAll
Daniil Ovchinnikov [Thu, 14 Nov 2019 16:29:35 +0000 (19:29 +0300)]
[groovy] tests: add TestUtils#runAll

GitOrigin-RevId: 3bed10e2c84b878c645d53fb215aadfebc685e31

21 hours agoRevert "RunAll: add ability to run action for bunch of different inputs"
Daniil Ovchinnikov [Thu, 14 Nov 2019 16:14:11 +0000 (19:14 +0300)]
Revert "RunAll: add ability to run action for bunch of different inputs"

This reverts commit dfdfcc57

GitOrigin-RevId: 5cdd443d9e9d61c8635ed3b0bf9c28843e1e4bec

21 hours agoworkspace model: fix setting library kind
Leonid Shalupov [Thu, 14 Nov 2019 16:25:11 +0000 (18:25 +0200)]
workspace model: fix setting library kind

GitOrigin-RevId: be804c2127d397c43fe6fc913d618ab500d4540f

21 hours agouse https
Dennis Ushakov [Thu, 14 Nov 2019 16:11:45 +0000 (19:11 +0300)]
use https

GitOrigin-RevId: df616096deaad44aa37e2994fb767cec58bdddc4

21 hours ago[groovy] add test for IDEA-162290
Daniil Ovchinnikov [Thu, 14 Nov 2019 16:05:11 +0000 (19:05 +0300)]
[groovy] add test for IDEA-162290

GitOrigin-RevId: 83257cc7f48bed1999693eddae5671d6750848e7

21 hours agoadd web jars to module instead of sdk
Leonid Shalupov [Thu, 14 Nov 2019 16:01:29 +0000 (18:01 +0200)]
add web jars to module instead of sdk

it works better for workspace model than modifying SDKs

GitOrigin-RevId: 1d1a695de4b0bf12771852a1fe83279297a097fe

21 hours agoRevert "vcs: fix deadlock in VcsRepositoryManager"
Aleksey Pivovarov [Thu, 14 Nov 2019 15:50:18 +0000 (18:50 +0300)]
Revert "vcs: fix deadlock in VcsRepositoryManager"

This reverts commit 22eeec898830224567101939ff1c5eef4630df64.

Do not call synchronous refresh under read lock (except from EDT) - this will cause a deadlock if there are any events to fire.
at com.intellij.openapi.vfs.impl.local.LocalFileSystemBase.refreshAndFindFileByIoFile(LocalFileSystemBase.java:191)
at com.intellij.vcsUtil.VcsUtil.getVirtualFileWithRefresh(VcsUtil.java:214)
at git4idea.GitUtil.findGitDir(GitUtil.java:123)
at git4idea.repo.GitRepositoryCreator.createRepositoryIfValid(GitRepositoryCreator.java:39)
at com.intellij.dvcs.repo.VcsRepositoryManager.findNewRoots(VcsRepositoryManager.java:277)

GitOrigin-RevId: 74cc0164b16fba971e0796749561cd6118c0333a

21 hours agoRevert "To avoid memory leaks on plugin unload, don't store theme references in Appea...
Konstantin Bulenkov [Thu, 14 Nov 2019 15:53:03 +0000 (16:53 +0100)]
Revert "To avoid memory leaks on plugin unload, don't store theme references in Appearance combo box (IDEA-224200)"

This reverts commit c878df71

GitOrigin-RevId: 8735b2578247e2b5a7a7690d9084e59a07b11ab8

22 hours agoSupport more XML settings in EditorConfig
Rustam Vishnyakov [Thu, 14 Nov 2019 14:53:30 +0000 (17:53 +0300)]
Support more XML settings in EditorConfig

GitOrigin-RevId: 7778f124b6c200117dc0d46c91eef07ab6c8ea18

22 hours agoDrop unnecessary XmlCodeStyleSettingsProvider
Rustam Vishnyakov [Thu, 14 Nov 2019 12:19:26 +0000 (15:19 +0300)]
Drop unnecessary XmlCodeStyleSettingsProvider

GitOrigin-RevId: ed0716305cdd21580b2d04246a58660f398679df

22 hours agoRemove unused import
Rustam Vishnyakov [Thu, 14 Nov 2019 11:58:45 +0000 (14:58 +0300)]
Remove unused import

GitOrigin-RevId: a3376b936ea3629ec622c7f180632f442be1c5a5

22 hours agoFire editor selected after every tab creation
Rustam Vishnyakov [Thu, 14 Nov 2019 11:57:10 +0000 (14:57 +0300)]
Fire editor selected after every tab creation

GitOrigin-RevId: fd0221c19bbf591de7f0d39e1fa7bb0d1028ea80

22 hours agogit: IDEA-226783 support create branch without checking it out in "New Branch From...
Nadya Zabrodina [Thu, 14 Nov 2019 15:25:08 +0000 (18:25 +0300)]
git: IDEA-226783 support create branch without checking it out in "New Branch From Selected…" branches popup action

GitOrigin-RevId: 03cfc52962150be1035b78d522ef0f00fe93754a

22 hours agoHides device selection from the configuration menu
Chester Hsieh [Thu, 14 Nov 2019 15:36:00 +0000 (16:36 +0100)]
Hides device selection from the configuration menu

Android Studio externally manages execution targets, so we hide all
execution target information from the configuration combo box.

We do this by adding support for externally managed targets, and filter
out UI elements that match externally managed targets.

GitOrigin-RevId: de66a4e3fac68d021ebe5e4244ba8045b948a745

22 hours agosimplify DocumentCommitThread by using ReadAction.nonBlocking (also helps with GO...
peter [Thu, 14 Nov 2019 15:34:37 +0000 (16:34 +0100)]
simplify DocumentCommitThread by using ReadAction.nonBlocking (also helps with GO-8230)

GitOrigin-RevId: d25c3181daaef3fd45a0663dd985aa220ada81e1

22 hours agostore ASTs loaded during implicit toString search on weak references instead of soft...
peter [Thu, 14 Nov 2019 15:30:06 +0000 (16:30 +0100)]
store ASTs loaded during implicit toString search on weak references instead of soft ones (IDEA-226782)

GitOrigin-RevId: e2c80eef49415de328ecfab65b0d85a208213bf9

22 hours agoheuristic to switch to project rebuild if estimated target recompilation time is...
Eugene Zhuravlev [Thu, 14 Nov 2019 15:23:25 +0000 (16:23 +0100)]
heuristic to switch to project rebuild if estimated target recompilation time is comparable with full rebuild time (IDEA-226496)

GitOrigin-RevId: 7c768ff9491057907bf458bf49b0c0108d870333

22 hours agomemory optimization: do not store raw data unless this data is going to be logged
Eugene Zhuravlev [Thu, 14 Nov 2019 14:16:10 +0000 (15:16 +0100)]
memory optimization: do not store raw data unless this data is going to be logged

GitOrigin-RevId: 1618d8d7c8811065df806b64711c9357f3808e76

22 hours agovcs: fix an empty box if there are no actions in account submenu
Aleksandr Krasilnikov [Thu, 14 Nov 2019 14:28:20 +0000 (17:28 +0300)]
vcs: fix an empty box if there are no actions in account submenu

GitOrigin-RevId: 2999ba9c6ad38078391f045ce756fbdd1564f020

22 hours agogithub: stop disable directory field in clone dialog to avoid problem with focus
Aleksandr Krasilnikov [Mon, 28 Oct 2019 08:30:29 +0000 (11:30 +0300)]
github: stop disable directory field in clone dialog to avoid problem with focus

GitOrigin-RevId: ea2197478c61b3a5db0cef579950a4bf69003040

23 hours agodo not call scheduleBackgroundPostStartupActivities for test light project
Vladimir Krivosheev [Thu, 14 Nov 2019 13:13:34 +0000 (14:13 +0100)]
do not call scheduleBackgroundPostStartupActivities for test light project

GitOrigin-RevId: 7a0d303c32f4f0b5f7a379bca8ee7d22fa0fb6c1

23 hours ago[groovy] don't lose last new line on paste (IDEA-178360)
Daniil Ovchinnikov [Thu, 14 Nov 2019 14:38:50 +0000 (17:38 +0300)]
[groovy] don't lose last new line on paste (IDEA-178360)

GitOrigin-RevId: 0c58203cb266dd85e0267fc416746566fcac8df1

23 hours agoimprove NonBlockingReadAction#cancel performance
peter [Thu, 14 Nov 2019 14:53:24 +0000 (15:53 +0100)]
improve NonBlockingReadAction#cancel performance

GitOrigin-RevId: 82e97e6ff5cc814470fcacbdcb56c25ce35ed3ba

23 hours agoGroovyCompilerTest: do not create duplicate project libraries
Leonid Shalupov [Thu, 14 Nov 2019 14:48:19 +0000 (16:48 +0200)]
GroovyCompilerTest: do not create duplicate project libraries

workspace model expects unique project library names

GitOrigin-RevId: e8b4e067dde7c2e307554aa34b70a0423674f54e

23 hours agofix collision of two methods during search of original method
Konstantin.Nisht [Thu, 14 Nov 2019 14:46:46 +0000 (17:46 +0300)]
fix collision of two methods during search of original method

GitOrigin-RevId: 687833ed7b09d431e644649e78ecc27b898ff12e

23 hours ago[vcs-log] add assertion to ensure that log ids are always distinct
Julia Beliaeva [Tue, 12 Nov 2019 17:40:47 +0000 (20:40 +0300)]
[vcs-log] add assertion to ensure that log ids are always distinct

GitOrigin-RevId: 0251f491c4c11310569fff43e86254878ef0c84d

23 hours agovcs: use more robust check for ContentRevision equality
Aleksey Pivovarov [Thu, 14 Nov 2019 14:24:01 +0000 (17:24 +0300)]
vcs: use more robust check for ContentRevision equality

GitOrigin-RevId: 2005fda69badb85768e71798ba543ba2553c0ae9

23 hours agovcs: add help id for Patch File Settings dialog
Nadya Zabrodina [Thu, 14 Nov 2019 14:34:25 +0000 (17:34 +0300)]
vcs: add help id for Patch File Settings dialog

GitOrigin-RevId: db51f02394a9ea8f3609ae9e1e3d6b59f239c03e

23 hours agoIDEA-226353 added corrected java home to allowed roots
Sergei Vorobyov [Thu, 14 Nov 2019 13:15:22 +0000 (16:15 +0300)]
IDEA-226353 added corrected java home to allowed roots

java home correction provided by commit 4a2361860075246da9f2f4164cad9c587798535b

GitOrigin-RevId: d8ec3f88bc9720265d93bf15c4eb847c3242fb1c

24 hours agoIDEA-CR-53572: PY-38529: Do not create Django facet under write action.
Ilya.Kazakevich [Tue, 15 Oct 2019 19:15:47 +0000 (22:15 +0300)]
IDEA-CR-53572: PY-38529: Do not create Django facet under write action.

You can't run anything under progress when you own write action, and since Django creation involves external process, it should escape write action somehow.

``onFacetCreated`` runs under write action, so we postpone project creation along with facet configuration and submit it to background

(cherry picked from commit 783983dd461e7093bd263909258af3c73a832776)

GitOrigin-RevId: 085e6a4809315e1438ab7958342d59aa3866adec

24 hours agovcs: handle repaint requests while project is being closed
Aleksey Pivovarov [Thu, 14 Nov 2019 13:49:03 +0000 (16:49 +0300)]
vcs: handle repaint requests while project is being closed

EA-216082 - assert: ComponentManagerImpl.lambda$throwAlreadyDisposed$

GitOrigin-RevId: 19dd074b24f83e9a96bcfe082d68c6451a731c68

24 hours agoIDEA-216148: Cannot type character with Opt-L in editor (do not check mnemonics in...
Sergey Malenkov [Thu, 14 Nov 2019 13:23:40 +0000 (16:23 +0300)]
IDEA-216148: Cannot type character with Opt-L in editor (do not check mnemonics in hidden components)

GitOrigin-RevId: 4cefab9040cfbad7f51c2eef9b8a2f267c7b3bdb

24 hours agoIDEA-CR-55199: Disable stacktrace for ParserException, remove synchronized
Ilya.Kazakevich [Thu, 14 Nov 2019 13:43:04 +0000 (16:43 +0300)]
IDEA-CR-55199: Disable stacktrace for ParserException, remove synchronized

GitOrigin-RevId: 7e73b8497943cb560c1f95b12eae06497941fad5

24 hours agoEA-216272 - F: TwoStepCompletionProvider.fillCompletionVariants
Aleksey Pivovarov [Thu, 14 Nov 2019 13:38:26 +0000 (16:38 +0300)]
EA-216272 - F: TwoStepCompletionProvider.fillCompletionVariants

TimeoutException was thrown, so 'checkCanceled' was not called in wait loop.

Fix regression after f8bcf567261a07429b09dfa5dc51e4ade37640a8

GitOrigin-RevId: 9aadb178e40903c4594c993901f3e5d6e1f6d5ba

24 hours agocleanup
Alexey Kudravtsev [Thu, 14 Nov 2019 13:20:54 +0000 (16:20 +0300)]
cleanup

GitOrigin-RevId: 8062dd6572e849bfed3ff7754ccd49bc8d48ccb7

24 hours agoavoid data races when the invokeConcurrently() returns false while some workers are...
Alexey Kudravtsev [Thu, 14 Nov 2019 13:20:31 +0000 (16:20 +0300)]
avoid data races when the invokeConcurrently() returns false while some workers are still in flight to completion

GitOrigin-RevId: ed8df01d2396e34ea7715e1fb09fe3d925b1fed9

24 hours agocleanup
Alexey Kudravtsev [Wed, 13 Nov 2019 15:33:34 +0000 (18:33 +0300)]
cleanup

GitOrigin-RevId: 3cf11cc35299e5306315fa5bd15ccab21428680f

24 hours agoadd javadoc with hints about detector performance and exceptions
Alexey Kudravtsev [Wed, 13 Nov 2019 15:01:11 +0000 (18:01 +0300)]
add javadoc with hints about detector performance and exceptions

GitOrigin-RevId: 69e0f53bb58b3ab71d109d7443e31107dec1d516

24 hours agoIDEA-CR-55259 Removed RubyMine obsolete hack
Alexandr Evstigneev [Thu, 14 Nov 2019 13:10:05 +0000 (16:10 +0300)]
IDEA-CR-55259 Removed RubyMine obsolete hack

GitOrigin-RevId: 4fa5592246b0c4ce7de2cadfcf93e4c520c45902