replace constructor with factory method

diff --git a/platform/lang-impl/src/com/intellij/diagnostic/logging/EditLogPatternDialog.java b/platform/lang-impl/src/com/intellij/diagnostic/logging/EditLogPatternDialog.java
index f1756e4159b73474563279aaa016bcc9d253e6da..ea083b0719b2b2aba721d5657323809f3dbdad2f 100644 (file)
--- a/platform/lang-impl/src/com/intellij/diagnostic/logging/EditLogPatternDialog.java
+++ b/platform/lang-impl/src/com/intellij/diagnostic/logging/EditLogPatternDialog.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2009 JetBrains s.r.o.
+ * Copyright 2000-2011 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,7 +17,7 @@
 package com.intellij.diagnostic.logging;
 
 import com.intellij.diagnostic.DiagnosticBundle;
-import com.intellij.openapi.fileChooser.FileChooserDescriptor;
+import com.intellij.openapi.fileChooser.FileChooserDescriptorFactory;
 import com.intellij.openapi.ui.DialogWrapper;
 import com.intellij.openapi.ui.TextComponentAccessor;
 import com.intellij.openapi.ui.TextFieldWithBrowseButton;
@@ -52,7 +52,7 @@ public class EditLogPatternDialog extends DialogWrapper {
   }
 
   protected JComponent createCenterPanel() {
-    myFilePattern.addBrowseFolderListener(UIBundle.message("file.chooser.default.title"), null, null, new FileChooserDescriptor(true, true, false, false, false, false), TextComponentAccessor.TEXT_FIELD_WHOLE_TEXT);
+    myFilePattern.addBrowseFolderListener(UIBundle.message("file.chooser.default.title"), null, null, FileChooserDescriptorFactory.createSingleFileOrFolderDescriptor(), TextComponentAccessor.TEXT_FIELD_WHOLE_TEXT);
     myFilePattern.getTextField().getDocument().addDocumentListener(new DocumentAdapter() {
       protected void textChanged(DocumentEvent e) {
         setOKActionEnabled(myFilePattern.getText() != null && myFilePattern.getText().length() > 0);

diff --git a/platform/platform-api/src/com/intellij/openapi/fileChooser/FileChooserDescriptorFactory.java b/platform/platform-api/src/com/intellij/openapi/fileChooser/FileChooserDescriptorFactory.java
index 91500c2713b20c1fed123f7126cd8f12bef97391..2696d8904cebb2092433e06f358c4d35a0a135bf 100644 (file)
--- a/platform/platform-api/src/com/intellij/openapi/fileChooser/FileChooserDescriptorFactory.java
+++ b/platform/platform-api/src/com/intellij/openapi/fileChooser/FileChooserDescriptorFactory.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2009 JetBrains s.r.o.
+ * Copyright 2000-2011 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -51,6 +51,10 @@ public class FileChooserDescriptorFactory {
     return new FileChooserDescriptor(false, true, true, false, true, true);
   }
 
+  public static FileChooserDescriptor createSingleFileOrFolderDescriptor() {
+    return new FileChooserDescriptor(true, true, false, false, false, false);
+  }
+
   public static FileChooserDescriptor getDirectoryChooserDescriptor(String aSearchedObjectName) {
     final FileChooserDescriptor singleFolderDescriptor = createSingleFolderDescriptor();
     singleFolderDescriptor.setTitle(UIBundle.message("file.chooser.select.object.title", aSearchedObjectName));

diff --git a/plugins/relaxng/src/org/intellij/plugins/relaxNG/convert/ConvertSchemaSettingsImpl.java b/plugins/relaxng/src/org/intellij/plugins/relaxNG/convert/ConvertSchemaSettingsImpl.java
index ed0533583ff651ee7bfcf50768a8a48b4f0dd2e6..893c1ad0baf6fc542acd95b4cab94c11e44e5579 100644 (file)
--- a/plugins/relaxng/src/org/intellij/plugins/relaxNG/convert/ConvertSchemaSettingsImpl.java
+++ b/plugins/relaxng/src/org/intellij/plugins/relaxNG/convert/ConvertSchemaSettingsImpl.java
@@ -18,6 +18,7 @@ package org.intellij.plugins.relaxNG.convert;
 
 import com.intellij.openapi.actionSystem.LangDataKeys;
 import com.intellij.openapi.fileChooser.FileChooserDescriptor;
+import com.intellij.openapi.fileChooser.FileChooserDescriptorFactory;
 import com.intellij.openapi.fileTypes.FileType;
 import com.intellij.openapi.fileTypes.StdFileTypes;
 import com.intellij.openapi.module.Module;
@@ -134,7 +135,7 @@ public class ConvertSchemaSettingsImpl implements ConvertSchemaSettings {
     final SchemaType outputType = getOutputType();
     myLineLength.setEnabled(outputType == SchemaType.DTD || outputType == SchemaType.RNC);
 
-    final FileChooserDescriptor descriptor = new FileChooserDescriptor(true, true, false, false, false, false);
+    final FileChooserDescriptor descriptor = FileChooserDescriptorFactory.createSingleFileOrFolderDescriptor();
     final Module module = ProjectRootManager.getInstance(project).getFileIndex().getModuleForFile(firstFile);
     descriptor.putUserData(LangDataKeys.MODULE_CONTEXT, module);
 

diff --git a/plugins/svn4idea/src/org/jetbrains/idea/svn/dialogs/browser/DiffOptionsDialog.java b/plugins/svn4idea/src/org/jetbrains/idea/svn/dialogs/browser/DiffOptionsDialog.java
index 60e58e4f5da74002dfb948e1e85e47f464b32908..e332bf53c10efe2fdd3ded4b4e780bd9f146df25 100644 (file)
--- a/plugins/svn4idea/src/org/jetbrains/idea/svn/dialogs/browser/DiffOptionsDialog.java
+++ b/plugins/svn4idea/src/org/jetbrains/idea/svn/dialogs/browser/DiffOptionsDialog.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2009 JetBrains s.r.o.
+ * Copyright 2000-2011 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@ package org.jetbrains.idea.svn.dialogs.browser;
 
 import com.intellij.openapi.fileChooser.FileChooser;
 import com.intellij.openapi.fileChooser.FileChooserDescriptor;
+import com.intellij.openapi.fileChooser.FileChooserDescriptorFactory;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.ui.DialogWrapper;
 import com.intellij.openapi.ui.TextFieldWithBrowseButton;
@@ -168,7 +169,7 @@ public class DiffOptionsDialog extends DialogWrapper implements ActionListener {
 
   @Nullable
   private File selectFile(String title, String description) {
-    FileChooserDescriptor fcd = new FileChooserDescriptor(true, true, false, false, false, false);
+    FileChooserDescriptor fcd = FileChooserDescriptorFactory.createSingleFileOrFolderDescriptor();
     fcd.setShowFileSystemRoots(true);
     fcd.setTitle(title);
     fcd.setDescription(description);

diff --git a/plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/run/XsltRunSettingsEditor.java b/plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/run/XsltRunSettingsEditor.java
index 4b02edbf74fbfce261483c8f7b5c903dd0cc5791..a90e2a5cb26dcc6ed3f6a91bb04db442d96e0227 100644 (file)
--- a/plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/run/XsltRunSettingsEditor.java
+++ b/plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/run/XsltRunSettingsEditor.java
@@ -221,7 +221,7 @@ class XsltRunSettingsEditor extends SettingsEditor<XsltRunConfiguration> {
             });
 
             myOutputFile.addBrowseFolderListener("Choose Output File", "The selected file will be overwritten during execution.",
-                    project, new FileChooserDescriptor(true, true, false, false, false, false));
+                    project, FileChooserDescriptorFactory.createSingleFileOrFolderDescriptor());
 
             final ItemListener outputStateListener = new ItemListener() {
                 public void itemStateChanged(ItemEvent e) {