util: get rid of ArrayUtil#reverse(char[]) as it is unused (no external usages as...

diff --git a/platform/util/src/com/intellij/util/ArrayUtil.java b/platform/util/src/com/intellij/util/ArrayUtil.java
index f0abaedc7a9443fa3c49e0cbb4b6b4abdb12d2a4..6051af112ec114dec17146ec982b473c438fa7af 100644 (file)
--- a/platform/util/src/com/intellij/util/ArrayUtil.java
+++ b/platform/util/src/com/intellij/util/ArrayUtil.java
@@ -641,12 +641,6 @@ public class ArrayUtil extends ArrayUtilRt {
     return newArray;
   }
 
-  public static void reverse(@NotNull char[] array) {
-    for (int i = 0; i < array.length / 2; i++) {
-      swap(array, array.length - i - 1, i);
-    }
-  }
-
   @Contract(pure=true)
   public static int lexicographicCompare(@NotNull String[] obj1, @NotNull String[] obj2) {
     for (int i = 0; i < Math.max(obj1.length, obj2.length); i++) {

diff --git a/platform/util/testSrc/com/intellij/util/ArrayUtilTest.java b/platform/util/testSrc/com/intellij/util/ArrayUtilTest.java
index 0deb89fdf9c411ee43f089db91acbfe4bf26d5be..af2b93c6a2bc94d4fd9cdeeeee0402c2fe33c66a 100644 (file)
--- a/platform/util/testSrc/com/intellij/util/ArrayUtilTest.java
+++ b/platform/util/testSrc/com/intellij/util/ArrayUtilTest.java
@@ -70,25 +70,19 @@ public class ArrayUtilTest extends TestCase {
     }
   }
 
-  private static void assertArrayEquals(char[] expected, char[] actual) {
+  private static void assertArrayEquals(int[] expected, int[] actual) {
     assertTrue(Arrays.equals(expected, actual));
   }
 
   public void testReverse() throws Exception {
-    char[] a = new char[]{};
-    ArrayUtil.reverse(a);
-    assertArrayEquals(new char[]{}, a);
-
-    a = new char[]{'1'};
-    ArrayUtil.reverse(a);
-    assertArrayEquals(new char[]{'1'}, a);
-
-    a = new char[]{'1', '2', '3', '4'};
-    ArrayUtil.reverse(a);
-    assertArrayEquals(new char[]{'4', '3', '2', '1'}, a);
+    checkArrayReverse(new int[]{}, new int[]{});
+    checkArrayReverse(new int[]{1}, new int[]{1});
+    checkArrayReverse(new int[]{1, 2, 3, 4}, new int[]{4, 3, 2, 1});
+    checkArrayReverse(new int[]{1, 2, 3, 4, 5}, new int[]{5, 4, 3, 2, 1});
+  }
 
-    a = new char[]{'1', '2', '3', '4', '5'};
-    ArrayUtil.reverse(a);
-    assertArrayEquals(new char[]{'5', '4', '3', '2', '1'}, a);
+  private static void checkArrayReverse(int[] array, int[] expectedReversedArray) {
+    int[] reversed = ArrayUtil.reverseArray(array);
+    assertArrayEquals(expectedReversedArray, reversed);
   }
 }