idea/android.git
23 hours agoi18n - CommitStepException # message - fix warnings in android master
Michael Golubev [Sat, 24 Oct 2020 14:38:09 +0000 (16:38 +0200)]
i18n - CommitStepException # message - fix warnings in android

GitOrigin-RevId: 89ef88a82f7c90acb7d25bf54cd136dc6603ba5a

2 days agoIDEA-253347 move kotlin files to another module
Alexander Bubenchikov [Thu, 22 Oct 2020 20:30:47 +0000 (23:30 +0300)]
IDEA-253347 move kotlin files to another module

GitOrigin-RevId: f41746b69145f7c3c06e1a488b02c882dd78343c

2 days agointroduce all plugins identity set as first step to avoid linear search in isFull...
Vladimir Krivosheev [Fri, 23 Oct 2020 08:35:44 +0000 (10:35 +0200)]
introduce all plugins identity set as first step to avoid linear search in isFull method

GitOrigin-RevId: 7aaa7ab07ddc4b03d20a4807ebdc2359f639e3df

3 days ago[android tests] adapt IdeaSyncCachesInvalidatorTest to changes in IdeaSyncCachesInval...
Nikolay Chashnikov [Thu, 22 Oct 2020 08:55:48 +0000 (11:55 +0300)]
[android tests] adapt IdeaSyncCachesInvalidatorTest to changes in IdeaSyncCachesInvalidator (IDEA-CR-67884)

.idea/libraries folder is now deleted in Android Studio only (IDEA-253515).

GitOrigin-RevId: 20f6ac00dfd22937323377c202d1bd940022cddf

3 days ago[android] delete .idea/libraries folder on Invalidate Caches / Restart in Android...
Nikolay Chashnikov [Wed, 21 Oct 2020 15:40:06 +0000 (18:40 +0300)]
[android] delete .idea/libraries folder on Invalidate Caches / Restart in Android Studio only (IDEA-253515)

In IntelliJ IDEA a project may contain some modules linked to Gradle projects and also contain manually created libraries, so removal of .idea/libraries folder may lead to data loss.

GitOrigin-RevId: f112a9fc044aa6c7e956e619177e04270249db46

4 days agoSpecify scope for some templates they interfere actions in string literals
Anton Yalyshev [Wed, 21 Oct 2020 13:14:31 +0000 (16:14 +0300)]
Specify scope for some templates they interfere actions in string literals
^KTIJ-386 Fixed

GitOrigin-RevId: ec7bd840d23ecc34d68bb2de8ffeba188156f08a

4 days agocleanup, reuse PluginStateChecker
Vladimir Krivosheev [Tue, 20 Oct 2020 12:58:45 +0000 (14:58 +0200)]
cleanup, reuse PluginStateChecker

GitOrigin-RevId: 763952172c4edd93d9779af7ca5328093b119b9a

4 days agoKotlinAndroidGradleMPPModuleDataService: prevent dependencies on test-scoped source...
sebastian.sellmair [Thu, 15 Oct 2020 15:49:46 +0000 (17:49 +0200)]
KotlinAndroidGradleMPPModuleDataService: prevent dependencies on test-scoped source sets

#KT-42664 Fixed

GitOrigin-RevId: 4eef84f7f1f454f2f5bf845fd647fe72573c807a

4 days ago[android] use PropertiesComponentMock instead of pure mock in InspectorPanelTest
Nikolay Chashnikov [Tue, 20 Oct 2020 13:38:54 +0000 (16:38 +0300)]
[android] use PropertiesComponentMock instead of pure mock in InspectorPanelTest

The pure mock returns 'null' from 'getValue' method even if default value is passed, and it causes tests to fail with NullPointerException in NlPropertiesPanel.getPropertiesViewModeInitially.

GitOrigin-RevId: 0cd2e84211a51f64c908a5d1724eaecef4186115

5 days agoIDEA-252162 don't hold reference to icon classloader
Vladimir Krivosheev [Tue, 20 Oct 2020 09:46:55 +0000 (11:46 +0200)]
IDEA-252162 don't hold reference to icon classloader

GitOrigin-RevId: 4aec54fca6d1e5462d417b82314bad5c2f685b73

5 days agoIDEA-252162 regenerate icon classes
Vladimir Krivosheev [Tue, 20 Oct 2020 08:40:12 +0000 (10:40 +0200)]
IDEA-252162 regenerate icon classes

GitOrigin-RevId: b20a64c7d0832b0bc7b8a85f3a2c039e63a8e965

5 days agoUX-1356 get rid of usage word in usage types 203.5251
Daniil Ovchinnikov [Mon, 19 Oct 2020 11:15:57 +0000 (14:15 +0300)]
UX-1356 get rid of usage word in usage types

GitOrigin-RevId: aa15fba957692c297b9d2857e44827ffce4d15bd

5 days agodon't use deprecated StringBuilder.isEmpty()
Vladimir Krivosheev [Mon, 19 Oct 2020 19:27:28 +0000 (21:27 +0200)]
don't use deprecated StringBuilder.isEmpty()

GitOrigin-RevId: 0fedba0a3af66832d29becae953467dad2682cd6

5 days agoAndroidComposeAutoDocumentation - get services on demand
Vladimir Krivosheev [Mon, 19 Oct 2020 15:06:24 +0000 (17:06 +0200)]
AndroidComposeAutoDocumentation - get services on demand

GitOrigin-RevId: 5d9884c06517d37da1c59baab85f7707af8963a2

6 days ago[Gradle] build environment model should be obtained with correct java home option
Vladislav.Soroka [Mon, 19 Oct 2020 10:45:05 +0000 (13:45 +0300)]
[Gradle] build environment model should be obtained with correct java home option

GitOrigin-RevId: bbf936cf70f8c2e3cb4886793c2350fd3d5d2dd1

9 days agoIJ-CR-3416: Get default value for parallel compilation flag from intellij.yaml
Leonid Shalupov [Thu, 15 Oct 2020 15:15:23 +0000 (18:15 +0300)]
IJ-CR-3416: Get default value for parallel compilation flag from intellij.yaml

this feature removes one more item from intellij project development guide

GitOrigin-RevId: 735ba26397abb7d3a8956afb52f24027dfa10b28

9 days agocleanup (get rid of ServiceManager.get)
Vladimir Krivosheev [Fri, 16 Oct 2020 10:05:45 +0000 (12:05 +0200)]
cleanup (get rid of ServiceManager.get)

GitOrigin-RevId: 7f6a905353889c9795e5d40a8aa60f6251000f05

10 days agoHMPP support for Android targets
sebastian.sellmair [Fri, 25 Sep 2020 15:16:35 +0000 (17:16 +0200)]
HMPP support for Android targets

KT-42664 Fixed

GitOrigin-RevId: 1ead469a1566e97e4e3af2ef64058d23d9d72fd9

12 days agocleanup 203.4818 idea/203.4818.26 pycharm/203.4341.25
Vladimir Krivosheev [Mon, 12 Oct 2020 10:08:27 +0000 (12:08 +0200)]
cleanup

GitOrigin-RevId: 63d29224e00603b91b985bb10bffda9d87695f66

12 days agocleanup: annotate action event parameter NotNull to avoid yellow code
Alexey Kudravtsev [Mon, 12 Oct 2020 10:47:51 +0000 (13:47 +0300)]
cleanup: annotate action event parameter NotNull to avoid yellow code

GitOrigin-RevId: b105d069b2e306bf5fb0f0af56dae803ea1456cd

13 days agoMake SpeedSearchSupply.isObjectFilteredOut not abstract
Elena.Korotkova [Mon, 12 Oct 2020 11:11:05 +0000 (14:11 +0300)]
Make SpeedSearchSupply.isObjectFilteredOut not abstract

GitOrigin-RevId: 90305b8a44d17e437d3176f8047af16cca907ca1

2 weeks agoavoid concrete classes *OpenHashMap, use interface instead
Alexey Kudravtsev [Wed, 7 Oct 2020 13:33:02 +0000 (15:33 +0200)]
avoid concrete classes *OpenHashMap, use interface instead

GitOrigin-RevId: 6ff337729564d9ce1227231125d4fef83f49d69f

2 weeks agoFix speed search filter
Elena.Korotkova [Wed, 7 Oct 2020 08:31:44 +0000 (11:31 +0300)]
Fix speed search filter

GitOrigin-RevId: 72c77c1f6508891aea7702b165acabb3ef2aedb1

2 weeks agofix GotoDatabaseFolder icon reference
Vladimir Krivosheev [Wed, 7 Oct 2020 09:03:56 +0000 (11:03 +0200)]
fix GotoDatabaseFolder icon reference

GitOrigin-RevId: 3a26cc7a4d261f5c7ef5d339f4fbe17ff5301407

2 weeks agocleanup - final, move runInAllowSaveMode to appropriate package (to reduce number...
Vladimir Krivosheev [Tue, 6 Oct 2020 12:33:45 +0000 (14:33 +0200)]
cleanup - final, move runInAllowSaveMode to appropriate package (to reduce number of top-level kotlin functions)

GitOrigin-RevId: 67b9004e51912336330830abc01cc1f8be291761

2 weeks agodo not create ActionManager without a reason
Vladimir Krivosheev [Tue, 6 Oct 2020 19:23:36 +0000 (21:23 +0200)]
do not create ActionManager without a reason

GitOrigin-RevId: e80a047dbcdfd2e5f3a77502fe12d54459ee1957

2 weeks agoby default treat FileType as not read-only to reduce number of unnecessarily hidden...
Alexey Kudravtsev [Tue, 6 Oct 2020 14:04:44 +0000 (17:04 +0300)]
by default treat FileType as not read-only to reduce number of unnecessarily hidden file types by mistake

GitOrigin-RevId: 5c4b3b7f6bf53c6e5ad639feeaef0d204ef64291

2 weeks agoRemove deprecated method 203.4449 idea/203.4449.2 pycharm/203.4449.8
Sergey Malenkov [Mon, 5 Oct 2020 15:10:24 +0000 (18:10 +0300)]
Remove deprecated method

GitOrigin-RevId: 213a9ec8a57dbd2582795671bf377232dc561ff3

3 weeks agoIDEA-CR-67306 [profiler] move magic to field and use in desired content prefix length 203.4341
maksim.pelevin [Thu, 1 Oct 2020 19:26:59 +0000 (22:26 +0300)]
IDEA-CR-67306 [profiler] move magic to field and use in desired content prefix length

GitOrigin-RevId: 08c3ee02a1a8bc81e0dad2aa6d76f0089d792685

3 weeks agoIDEA-196499 Run Configurations not viewable while indexing
Elena Shaverdova [Tue, 4 Aug 2020 19:00:15 +0000 (22:00 +0300)]
IDEA-196499 Run Configurations not viewable while indexing

GitOrigin-RevId: 24680273eeb5b98baf41d5ef766c6efc2e425328

3 weeks ago[profiler] accept only Android CPU and Memory dumps in AndroidProfilerCaptureEditorPr...
maksim.pelevin [Thu, 1 Oct 2020 14:24:19 +0000 (17:24 +0300)]
[profiler] accept only Android CPU and Memory dumps in AndroidProfilerCaptureEditorProvider

GitOrigin-RevId: c211a4d13d8776506cff1158b246d997546abaaf

3 weeks ago[profiler] check Android HPROF only file with magic "JAVA PROFILE 1.0.3"
maksim.pelevin [Thu, 1 Oct 2020 08:29:08 +0000 (11:29 +0300)]
[profiler] check Android HPROF only file with magic "JAVA PROFILE 1.0.3"

Ignore all other Java HPROF files (with magics "JAVA PROFILE 1.0.1" and "JAVA PROFILE 1.0.2").

GitOrigin-RevId: e55cabbf381a1af45a610cf4b4b4293407fa5c5b

3 weeks ago[profiler] let MemoryCaptureFileType and CpuCaptureFileType be visible in "File Types...
maksim.pelevin [Thu, 1 Oct 2020 08:15:40 +0000 (11:15 +0300)]
[profiler] let MemoryCaptureFileType and CpuCaptureFileType be visible in "File Types" in settings

GitOrigin-RevId: 107a06ed5d3bf6bea6d5ae72f238f3b69f23c8ca

3 weeks agocleanup
Vladimir Krivosheev [Wed, 30 Sep 2020 11:26:01 +0000 (13:26 +0200)]
cleanup

GitOrigin-RevId: c2aabc41203d348c12947946b639b6ed4c70760b

3 weeks agorewrite BindingXmlIndex as SingleEntryFileBasedIndexExtension to make it shareable...
Dmitry Batkovich [Wed, 30 Sep 2020 08:06:10 +0000 (11:06 +0300)]
rewrite BindingXmlIndex as SingleEntryFileBasedIndexExtension to make it shareable IDEA-251695

GitOrigin-RevId: bb14feda3f4d2a40c8306b75023e6b78bce336c1

3 weeks agoremove redundant toString()
Dmitry Batkovich [Wed, 30 Sep 2020 07:17:17 +0000 (10:17 +0300)]
remove redundant toString()

GitOrigin-RevId: c0f4277d9ed058cd12bb79c694bc8d8ba227929e

4 weeks agotest for FileType constructor to be non-public to avoid duplicates and double instant... 203.4203 idea/203.4203.26
Alexey Kudravtsev [Fri, 25 Sep 2020 13:10:42 +0000 (15:10 +0200)]
test for FileType constructor to be non-public to avoid duplicates and double instantiation because file types must be singletons

GitOrigin-RevId: d448ee007d87edbaf095f8fbe7e1b51ce8c7d9bc

4 weeks agofix NCDFE
Alexander Bubenchikov [Fri, 25 Sep 2020 20:26:48 +0000 (23:26 +0300)]
fix NCDFE

GitOrigin-RevId: b5f277a469a0b2aacb7d3fa26b87c0928a808b8a

4 weeks agoIDEA-251219 fix rasterized prebuilt cache for dark theme
Vladimir Krivosheev [Fri, 25 Sep 2020 12:55:01 +0000 (14:55 +0200)]
IDEA-251219 fix rasterized prebuilt cache for dark theme

GitOrigin-RevId: 0228a057302b1d952da4870eb76d157e746c1366

4 weeks agoIDEA-247486 - review fixes
Alexander Bubenchikov [Thu, 24 Sep 2020 14:10:27 +0000 (17:10 +0300)]
IDEA-247486 - review fixes

GitOrigin-RevId: 1662e75a457bfd0d15697c3da61e18770792ad46

4 weeks agoIDEA-247486 move crash reporting about DSL issues into service
Alexander Bubenchikov [Mon, 21 Sep 2020 15:12:01 +0000 (18:12 +0300)]
IDEA-247486 move  crash reporting about DSL issues into service

GitOrigin-RevId: 25676d92678b89bc6edf3b7e75775d26ef01d7f9

4 weeks agoIDEA-247486 move addGoogleMavenRepository to extension method
Alexander Bubenchikov [Mon, 21 Sep 2020 13:08:18 +0000 (16:08 +0300)]
IDEA-247486 move addGoogleMavenRepository to extension method

GitOrigin-RevId: 1cbb5e1bb9a0d95fafc994dfae20b187defc0b10

4 weeks agoIDEA-247486 move testData to gradle.dsl.impl plugin
Alexander Bubenchikov [Wed, 16 Sep 2020 10:27:55 +0000 (13:27 +0300)]
IDEA-247486 move testData to gradle.dsl.impl plugin

GitOrigin-RevId: 517c77731ff3f2ed30a1c7f9427b8a38725a32db

4 weeks agoIDEA-247486 ProjectBuildModelHandlerTest fixed
Alexander Bubenchikov [Tue, 8 Sep 2020 09:28:52 +0000 (12:28 +0300)]
IDEA-247486 ProjectBuildModelHandlerTest fixed

GitOrigin-RevId: ab64e489fed51c3487eec66f07fd1febaadeb051

4 weeks agoIDEA-247486 gradle dsl - remove dependency on gradle-common
Alexander Bubenchikov [Mon, 7 Sep 2020 14:46:36 +0000 (17:46 +0300)]
IDEA-247486 gradle dsl - remove dependency on gradle-common

GitOrigin-RevId: dee5c17da3b9bcd658941620750724709c6a9f5c

4 weeks agoIDEA-247486 move gradle-dsl out of android
Alexander Bubenchikov [Fri, 4 Sep 2020 13:18:12 +0000 (16:18 +0300)]
IDEA-247486 move gradle-dsl out of android

GitOrigin-RevId: 4c7deb2ef967e3ee8ab58655e31e6e920252f298

4 weeks agoIDEA-247486 rename android-dsl modules to gradle-dsl
Alexander Bubenchikov [Thu, 3 Sep 2020 12:12:01 +0000 (15:12 +0300)]
IDEA-247486 rename android-dsl modules to gradle-dsl

GitOrigin-RevId: 856697c76884b758b8f31a1a9f27446e27f92c2d

4 weeks agoIDEA-247486 gradle dsl - fix service implementation
Alexander Bubenchikov [Tue, 1 Sep 2020 09:49:52 +0000 (12:49 +0300)]
IDEA-247486 gradle dsl - fix service implementation

GitOrigin-RevId: d14ed4be6deca4f3eb1c72bdd0d3ac5ac85deabc

4 weeks agoIDEA-247486 gradle dsl - fix test compilation errors
Alexander Bubenchikov [Mon, 31 Aug 2020 17:13:34 +0000 (20:13 +0300)]
IDEA-247486 gradle dsl - fix test compilation errors

GitOrigin-RevId: 1e92ac9e3e54474a31debf0a0d56e13332fde344

4 weeks agoIDEA-247486 gradle-dsl classpath fixes
Alexander Bubenchikov [Tue, 25 Aug 2020 15:48:21 +0000 (18:48 +0300)]
IDEA-247486 gradle-dsl classpath fixes

GitOrigin-RevId: 0fc76020f7933cfc3183145ae8398c3d609e03cf

4 weeks agoIDEA-247486 gradle-dsl-refactoring
Alexander Bubenchikov [Mon, 24 Aug 2020 17:25:31 +0000 (20:25 +0300)]
IDEA-247486 gradle-dsl-refactoring

GitOrigin-RevId: f0e1d91c63336eca1969fcbd15746164d3696f81

4 weeks agoIDEA-251207 Set of plugins cannot be unloaded because of IconLoader
Vladimir Krivosheev [Tue, 22 Sep 2020 18:07:48 +0000 (20:07 +0200)]
IDEA-251207 Set of plugins cannot be unloaded because of IconLoader

GitOrigin-RevId: 441b875462f12fe0d20d3830181e6280e3b829ba

4 weeks agoregenerate android icons
Vladimir Krivosheev [Wed, 23 Sep 2020 14:05:34 +0000 (16:05 +0200)]
regenerate android icons

GitOrigin-RevId: 399cb69d219f9e2ba18ca6b9fc964e8e27d31aa6

4 weeks agoremove outdated android@2x.png file
Vladimir Krivosheev [Wed, 23 Sep 2020 05:59:20 +0000 (07:59 +0200)]
remove outdated android@2x.png file

GitOrigin-RevId: af0e0e2376d4f917907a1a1c7ec1e861da5d74c6

4 weeks agocleanup (don't use deprecated method: scale -> scaleIcon)
Vladimir Krivosheev [Wed, 23 Sep 2020 05:21:20 +0000 (07:21 +0200)]
cleanup (don't use deprecated method: scale -> scaleIcon)

GitOrigin-RevId: d67bf091a1fbf601d7dfa3df376815f7821bbbe3

4 weeks agounify some "Results might be incomplete during indexing" messages, fix grammar in...
Peter Gromov [Thu, 24 Sep 2020 14:03:38 +0000 (16:03 +0200)]
unify some "Results might be incomplete during indexing" messages, fix grammar in related places

GitOrigin-RevId: f4f31dcadaf1945f950fe267e3def63ca623464c

4 weeks agoIDEA-249422: Android: make descriptors non-empty to enable dynamic unloading of layou...
Andrei Kuznetsov [Wed, 23 Sep 2020 15:37:08 +0000 (18:37 +0300)]
IDEA-249422: Android: make descriptors non-empty to enable dynamic unloading of layoutlib-native/standard plugins

When descriptor is empty, com.intellij.ide.plugins.cl.PluginClassLoader.detachParent never invoked for android plugin, and classloader for layoutlib-xxx leaks, preventing layoutlib-xxx plugin from being unloaded

GitOrigin-RevId: ae5361439c1c1335ae9682b5ddfef2b39092495f

4 weeks agoremove incorrect icon file `tutorialIndiator_dark@2x.png` — not used (typo in the...
Vladimir Krivosheev [Tue, 22 Sep 2020 08:36:48 +0000 (10:36 +0200)]
remove incorrect icon file `tutorialIndiator_dark@2x.png` — not used (typo in the name), do not use file name convention `_dark@2x` — use IJ convention instead (should be `@2x_dark`)

GitOrigin-RevId: 93cc27abf51709e2d178036da330f2308f9dc8fd

4 weeks agoicon cache using db instead of using module jar
Vladimir Krivosheev [Sat, 8 Aug 2020 07:37:27 +0000 (09:37 +0200)]
icon cache using db instead of using module jar

GitOrigin-RevId: 98995cafb9f72017dd71715052c685ba70c01646

4 weeks agoplatform.core.impl — remove dependency on intellij.platform.util.ui and intellij...
Vladimir Krivosheev [Tue, 15 Sep 2020 14:41:21 +0000 (16:41 +0200)]
platform.core.impl — remove dependency on intellij.platform.util.ui and intellij.platform.core.ui
java.psi.iml — remove dependency on intellij.platform.core.ui

GitOrigin-RevId: c1d4feb04c0471c7d17b5331b86738ee54a97f80

5 weeks agoWorkaround for java.lang.IllegalAccessError: class XXX tried to access protected...
Andrei Kuznetsov [Thu, 17 Sep 2020 15:04:25 +0000 (18:04 +0300)]
Workaround for java.lang.IllegalAccessError: class XXX tried to access protected field YYY

com.android.tools.idea.gradle.structure.configurables.variables.VariablesTable$NameCellEditor tried to access protected field javax.swing.JTable.selectionBackground

GitOrigin-RevId: 2442484e46a9ec44194760a8d2021dc99ae6b2e9

5 weeks agofix the new Kotlin NPE exception in test (it's now normalized in 1.4)
Eugene Petrenko [Wed, 16 Sep 2020 15:12:35 +0000 (17:12 +0200)]
fix the new Kotlin NPE exception in test (it's now normalized in 1.4)

GitOrigin-RevId: ffe28dd702db6017404b283621bed351e00720c3

5 weeks agofix type inference shange to Kotlin 1.4.0 (works ok without the change with Kotlin...
Eugene Petrenko [Wed, 16 Sep 2020 12:40:56 +0000 (14:40 +0200)]
fix type inference shange to Kotlin 1.4.0 (works ok without the change with Kotlin 1.4.10)

GitOrigin-RevId: 18987f1079ba12dd82e88de29127e52fdeff2d92

5 weeks agoThere is no difference in the generated Kotlin bytecode for 1.8 and 11
Eugene Petrenko [Tue, 15 Sep 2020 16:22:15 +0000 (18:22 +0200)]
There is no difference in the generated Kotlin bytecode for 1.8 and 11

also Revert "switch fleet Kotlin settings to yield JVM 11 bytecode"

This reverts commit 19bef8401ed6d6e2e55e52b3c6322fc10ba7385a.

GitOrigin-RevId: 73e0aa08ce5a4dfd55ff2fc716bddaff71d0e431

5 weeks agomake project compile with Kotlin 1.4
Eugene Petrenko [Tue, 15 Sep 2020 15:23:15 +0000 (17:23 +0200)]
make project compile with Kotlin 1.4

GitOrigin-RevId: d2ded397381541d8967535608c49b6cd00e8c9f4

5 weeks agoallow Kotlin 1.4 language version, target to 11 version of bytecode
Eugene Petrenko [Tue, 15 Sep 2020 12:59:46 +0000 (14:59 +0200)]
allow Kotlin 1.4 language version, target to 11 version of bytecode

GitOrigin-RevId: c04b9a30772988ffeb84f4c53b9610fe17cc33a5

5 weeks agodeprecate useless constructor
Sergey Malenkov [Fri, 18 Sep 2020 13:29:35 +0000 (16:29 +0300)]
deprecate useless constructor

GitOrigin-RevId: e8f5bd648db008b5c6a1c39f719212c23d624895

5 weeks agoAndroid: Fix race condition in NelePropertiesModelTest.testPropertyValuesChangedEvent...
Andrei Kuznetsov [Thu, 17 Sep 2020 21:43:41 +0000 (00:43 +0300)]
Android: Fix race condition in NelePropertiesModelTest.testPropertyValuesChangedEventAfterModelChange

GitOrigin-RevId: 4946997bb2f412683e0dc0dfe6e48aef27392cca

5 weeks agoAndroid: Fix expected type in test: ArrayIndexOutOfBoundsException > IndexOutOfBounds...
Andrei Kuznetsov [Thu, 17 Sep 2020 20:42:40 +0000 (23:42 +0300)]
Android: Fix expected type in test: ArrayIndexOutOfBoundsException > IndexOutOfBoundsException

GitOrigin-RevId: a6d035bd87e975a5c2984818cb2b98764ad6c219

5 weeks agoIDEA-250924: Android: Make ProjectLightResourceClassService lazy (don't do heavy...
Andrei Kuznetsov [Fri, 18 Sep 2020 11:09:26 +0000 (14:09 +0300)]
IDEA-250924: Android: Make ProjectLightResourceClassService lazy (don't do heavy operations in rootsChanged event)

GitOrigin-RevId: 18113160ca8dbb0cde7513ccaeb5bad2965f174a

5 weeks agoAndroid: remove PerformanceWatcher - make log more clean
Andrei Kuznetsov [Tue, 15 Sep 2020 08:34:54 +0000 (11:34 +0300)]
Android: remove PerformanceWatcher - make log more clean

PerformanceWatcher was introduced in IDEA-216052 (25-seconds freeze) to check with the user how fast this method works for their project (we could not reproduce the problem on our side). Now the problem seems to be resolved, and the watcher is not needed anymore.

GitOrigin-RevId: 3535a7f575b6ff001ed261e721b6a58cc37eb085

5 weeks agoAndroid: replace `ExecutorService.submit()` with `Executor.execute()` when execution...
Andrei Kuznetsov [Thu, 10 Sep 2020 19:29:19 +0000 (22:29 +0300)]
Android: replace `ExecutorService.submit()` with `Executor.execute()` when execution result is not needed

This is mostly to make sure that exceptions are not swallowed and logged properly. E.g. see IDEA-248474: using `submit` instead of `execute` resulted in `AssertionError` (method should be executed from EDT) not to be logged (future result containing an exception has been ignored).

GitOrigin-RevId: 6e8f2038ac53b1218575b4a2f3fb574307d4b75b

5 weeks agointroduce utility methods to show popup menus
Sergey Malenkov [Fri, 18 Sep 2020 09:21:45 +0000 (12:21 +0300)]
introduce utility methods to show popup menus

GitOrigin-RevId: 06cb1c574143ccf431307e3f23366d7e8ac239b5

5 weeks agorm CodeStyleSettings dependency on platform.ide
Petr Golubev [Mon, 14 Sep 2020 14:43:56 +0000 (17:43 +0300)]
rm CodeStyleSettings dependency on platform.ide

GitOrigin-RevId: f318a3337f54760e31053fa003fd7cacd192c740

5 weeks ago[external system] move ExternalStorageConfigurationManagerImpl to externalSystem... 203.3645 idea/203.3645.34 pycharm/203.3645.40
Nikolay Chashnikov [Mon, 14 Sep 2020 16:03:52 +0000 (19:03 +0300)]
[external system] move ExternalStorageConfigurationManagerImpl to externalSystem.impl module

GitOrigin-RevId: e0184e3defb69950ce21922539b883f2607436b6

5 weeks agocleanup: notnull and fix Processor type parameter types
Alexey Kudravtsev [Fri, 11 Sep 2020 14:39:04 +0000 (16:39 +0200)]
cleanup: notnull and fix Processor type parameter types

GitOrigin-RevId: 694f1cf4f8b2602e5a0e199c92490e68ec303c1b

6 weeks agoi18n: JUnit (fix consequences in mocha) (IDEA-249456)
Vitaliy.Bibaev [Fri, 11 Sep 2020 07:07:33 +0000 (14:07 +0700)]
i18n: JUnit (fix consequences in mocha) (IDEA-249456)

GitOrigin-RevId: 42b4e49faa74efdd77f0010446b68a552d0baf25

6 weeks agosupport dynamic message bundles inside JPS build process (IDEA-240279)
Eugene Zhuravlev [Fri, 11 Sep 2020 06:16:08 +0000 (08:16 +0200)]
support dynamic message bundles inside JPS build process (IDEA-240279)

GitOrigin-RevId: 13b9d19489baf62c4e8f921d7c7077583a302db4

6 weeks agoIDEA-246051: enable android tools menu in non-android projects if android SDK is...
Andrei Kuznetsov [Thu, 10 Sep 2020 13:14:25 +0000 (16:14 +0300)]
IDEA-246051: enable android tools menu in non-android projects if android SDK is configured

For example, to enable react-native developers to use AVD Manager

GitOrigin-RevId: a1cc238bff57fae5b07ba701a5b09f345d9502fb

6 weeks agoAndroid: Fix leaking project in tests (KeystoreStepTest, Android Plugin Tests / 8)
Andrei Kuznetsov [Wed, 9 Sep 2020 20:20:12 +0000 (23:20 +0300)]
Android: Fix leaking project in tests (KeystoreStepTest, Android Plugin Tests / 8)

GitOrigin-RevId: a4a17719bc1aa09e76ffc67bd8f363ef410349d2

6 weeks agoAndroid: Fix leaking project in tests (KeystoreStepTest, Android Plugin Tests / 8)
Andrei Kuznetsov [Wed, 9 Sep 2020 18:20:05 +0000 (21:20 +0300)]
Android: Fix leaking project in tests (KeystoreStepTest, Android Plugin Tests / 8)

GitOrigin-RevId: 06f51d3e2ad9affdae54bda277abc9d3736bd198

6 weeks ago[android] Fixed bombed test because of the change implementation of `IdeModifiableMod...
Mikhail Mazurkevich [Wed, 9 Sep 2020 14:14:20 +0000 (17:14 +0300)]
[android] Fixed bombed test because of the change implementation of `IdeModifiableModelsProviderImpl`

New implementation of `IdeModifiableModelsProviderImpl` relates to the new project model. To avoid a huge memory
footprint it uses a single instance of `WorkspaceEntityStorageBuilder`. In this test, the storage builder was
created right after the module "app" creation (before `ModifiableFacetModel` object instantiation). Thus
`IdeModifiableModelsProviderImpl` didn't contain any information about any further created modules and facets.
To fix it modules and facets creation were split into the two independent steps. Facets create right after all
modules created.

GitOrigin-RevId: 950c316fc70a87f557d389621cf21a8666929f4d

6 weeks agooptimize imports
Dmitry Batkovich [Tue, 8 Sep 2020 07:57:00 +0000 (10:57 +0300)]
optimize imports

GitOrigin-RevId: 2cb4f65b83b4fd77162821599bc3fb3e9e102cb3

6 weeks agoFormatting
Elena.Korotkova [Mon, 7 Sep 2020 13:49:13 +0000 (16:49 +0300)]
Formatting
IDEA-CR-66607

GitOrigin-RevId: 82713acec2c13155e1fb9d649c0c811d2d46cf0d

6 weeks agoNotNulls
Elena.Korotkova [Mon, 7 Sep 2020 08:20:16 +0000 (11:20 +0300)]
NotNulls
Simplifying vcs status bar widget default enablement condition
Hiding action when there is no project or repo available. Renaming VcsQuickActionsToolbarPopup,cleaning string properties
IDEA-CR-66607

GitOrigin-RevId: 660bd7828d814103c8e1f36ea26f63e9376a47ff

7 weeks agoIDEA-249742 internalization. Mark DocumentationProvider methods as @NlsSafe.
alexey.afanasiev [Fri, 4 Sep 2020 20:16:17 +0000 (23:16 +0300)]
IDEA-249742 internalization. Mark DocumentationProvider methods as @NlsSafe.

GitOrigin-RevId: f69bff5c9da899e8848a8dadde0c79c8fb4eda69

7 weeks ago[ui] show paths with system-dependent separators in UI
Nikolay Chashnikov [Fri, 4 Sep 2020 09:06:10 +0000 (12:06 +0300)]
[ui] show paths with system-dependent separators in UI

GitOrigin-RevId: 350b39309f85d1912e31e80064a9b8919f3e89b4

7 weeks ago[android] use Java 6 as target platform for Kotlin classes in gradle tooling modules
Nikolay Chashnikov [Thu, 3 Sep 2020 13:19:54 +0000 (16:19 +0300)]
[android] use Java 6 as target platform for Kotlin classes in gradle tooling modules

Since d8e82276d7 these modules use language level Java 7 to be compatible with JVM 7, but Kotlin classes were compiled with default project JVM target Java 8 so their class-files were incompatible with Java 7. Now we have Kotlin facets in these modules and specify target platform "JVM 1.6" in them (there is no option to use JVM 1.7).

GitOrigin-RevId: 404a97b7d21cf0463553a7d1a18b13495c2e1bef

7 weeks ago[openapi] IDEA-248714 - html link in Project Structure -> Problems
Nikita Eshkeev [Tue, 1 Sep 2020 19:53:57 +0000 (22:53 +0300)]
[openapi] IDEA-248714 - html link in Project Structure -> Problems

Both ProjectStructureProblemDescription#getDescription and ConfigurationError#getDescription used to return a string with caused problems with escaped html characters that can be converted multiple times and hence appear not as html tags on panes but as strings with extra symbols. In order to overcome these problems this patch changed the return type of the methods to HtmlChunk to provide the type safety when working with html tags.

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>
GitOrigin-RevId: 277c8b44606159db7dc9e5101f3638eeb3bab541

7 weeks agoIDEA-247946: Android: add `intellij.android.jps.model` to JPS build process instead...
Andrei Kuznetsov [Tue, 1 Sep 2020 20:25:55 +0000 (23:25 +0300)]
IDEA-247946: Android: add `intellij.android.jps.model` to JPS build process instead of `intellij.android.common`

GitOrigin-RevId: ae67d4ef7fca5dfffdbc559c19882e67bb0e4cc8

7 weeks agoIDEA-247946:Android: move classes shared between the IDE and JPS build process to...
Andrei Kuznetsov [Tue, 1 Sep 2020 16:27:39 +0000 (19:27 +0300)]
IDEA-247946:Android: move classes shared between the IDE and JPS build process to new module intellij.android.jps.model

GitOrigin-RevId: 2a90a5566bf703b8a2e76043b444940515306e2c

7 weeks agoIDEA-247946: remove dependency `intellij.android.buildCommon` > `intellij.android...
Andrei Kuznetsov [Tue, 11 Aug 2020 15:39:59 +0000 (18:39 +0300)]
IDEA-247946: remove dependency `intellij.android.buildCommon` > `intellij.android.common`

`android.buildCommon` is used in the JPS build process. `android.common` has a lot of dependencies which are not available in JPS (available in the IDE only). In order to avoid potential NoClassDefFoundError, just replace `BufferingFileWrapper` with `FileWrapper` and remove the dependency. There is no performance penalty for this change, because `ProjectProperties.parsePropertyFile` will wrap the `InputStream` with the `BufferedReader`, so we just removed double-buffering (which is good in 3D games, but often useless when reading files)

GitOrigin-RevId: 3367e4ff689e5422f37fcacf0f22e5dddfd03983

7 weeks ago[jps model] cleanup: remove code which implements save for JPS model
Nikolay Chashnikov [Tue, 1 Sep 2020 17:42:21 +0000 (20:42 +0300)]
[jps model] cleanup: remove code which implements save for JPS model

JpsModel is used inside the build process (except small part related to custom source root types which is also used inside IDE) and the build process doesn't save the project configuration. And we don't have plans to use JpsModel inside the IDE process anymore (the new workspace model is used instead), so it makes no sense to maintain that code.

GitOrigin-RevId: 9cfa7ccc86756550ccf8d54d03e3e267fdd5933f

7 weeks agoMove annotations to com.intellij.util.concurrency.annotations package (LAB-50)
Marat Khabibullin [Tue, 1 Sep 2020 10:40:12 +0000 (13:40 +0300)]
Move annotations to com.intellij.util.concurrency.annotations package (LAB-50)

GitOrigin-RevId: 3b357a605a45d3d15a148aca2ce7bcf1d560590d

7 weeks agoRename threading annotations (LAB-50)
Marat Khabibullin [Fri, 21 Aug 2020 15:30:24 +0000 (18:30 +0300)]
Rename threading annotations (LAB-50)

GitOrigin-RevId: 3c73092f1880b8518804a62ebe3f150a9380add2

7 weeks ago[i18n] idea-ui - use messagePointer for fields
Nikita Eshkeev [Mon, 31 Aug 2020 15:03:30 +0000 (18:03 +0300)]
[i18n] idea-ui - use messagePointer for fields

Since application level services are singletons and live forever their nls fields cannot have constants, because if a user switches the locale these values don't get updated. This patch makes such fields messagePointers so every getter call will read the message from the active localization bundle regardless if the user changed locale or not

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>
GitOrigin-RevId: 5a015adc891dfa86283aec1f7975d3fcb46fd043

7 weeks agomake android tests green on windows
Alexander Bubenchikov [Mon, 31 Aug 2020 14:13:07 +0000 (17:13 +0300)]
make android tests green on windows

GitOrigin-RevId: d5854c6ffff507d807293bb43d984abe1e00a643

8 weeks agoIDEA-248474: Android: revert diamond (need to cherry-pick to 202)
Andrei Kuznetsov [Fri, 28 Aug 2020 15:27:03 +0000 (18:27 +0300)]
IDEA-248474: Android: revert diamond (need to cherry-pick to 202)

Java8 can't infer type arguments: '<>' with anonymous inner classes is not supported

GitOrigin-RevId: 4ea70e55c603b7660397fdcfa4fc33c7843f55b1

8 weeks agoIDEA-248474: Debug Window Unavailable via Run > Attach Debugger to Android Process 203.2986
Andrei Kuznetsov [Thu, 27 Aug 2020 22:02:51 +0000 (01:02 +0300)]
IDEA-248474: Debug Window Unavailable via Run > Attach Debugger to Android Process

`ProgramRunnerUtil.executeConfiguration[Async]` should be invoked on EDT with IW lock, because it will open debug toolwindow. ToolwindowManager needs EDT to perform manipulations with toolwindows.

Also make sure that `ExecutorService#execute` is used instead of `ExecutorService#submit` when possible, because `execute` will log exceptions, `submit` will not (client should  handle future result be it some value or an exception).

GitOrigin-RevId: 7c993cb587db00aab1ada1003dbaf2c3e102496f

8 weeks agoAdd LICENSE.txt to android-plugin repository (Apache License version 2.0)
Andrei Kuznetsov [Thu, 27 Aug 2020 19:26:11 +0000 (22:26 +0300)]
Add LICENSE.txt to android-plugin repository (Apache License version 2.0)

The code has already been distributed under Apache 2.0 license. With the explicit LICENSE.txt this fact is made more evident.

GitOrigin-RevId: 913a6c5a0294bf6b21f13a33bfcd4e144a1aead5