idea/android.git
2 days agoIDEA-CR-68974 unambiguous names when imported statically master
Vladimir Krivosheev [Thu, 26 Nov 2020 07:27:18 +0000 (08:27 +0100)]
IDEA-CR-68974 unambiguous names when imported statically

GitOrigin-RevId: beed01f4c6a533fa694ec0b4f36e5d305b80874b

2 days agoIDEA-256187: Update big spinner appearance
Sergey Malenkov [Thu, 26 Nov 2020 09:55:13 +0000 (12:55 +0300)]
IDEA-256187: Update big spinner appearance

GitOrigin-RevId: bbf51744fdf6934b0448b0fa7c7012d01017110c

3 days ago[platform] dropping obsolete non-thread-safe code (IDEA-254409)
Roman Shevchenko [Wed, 25 Nov 2020 22:31:27 +0000 (23:31 +0100)]
[platform] dropping obsolete non-thread-safe code (IDEA-254409)

GitOrigin-RevId: 6d6057c11fca7efb4c4fdec82deda84e815e50c0

3 days agoavoid calling BuildManager's operations for default project
Eugene Zhuravlev [Wed, 25 Nov 2020 14:59:22 +0000 (15:59 +0100)]
avoid calling BuildManager's operations for default project

GitOrigin-RevId: c71c6fd5080f4bf3b6d3e2912d042d101ff9cbc7

3 days agoget rid of `div` operator functions for File and Path. If you still want to use it...
Vladimir Krivosheev [Wed, 25 Nov 2020 10:56:18 +0000 (11:56 +0100)]
get rid of `div` operator functions for File and Path. If you still want to use it — use Kotlin stdlib functions (`-Xopt-in=kotlin.io.path.ExperimentalPathApi` is added to project compilation options)

GitOrigin-RevId: bfbf8077982d86e9bce60b498835055b788aaed3

4 days agoArtifactsByConfigurationModuleSetupStepTest: Remove unnecessary "testDoSetUpModuleWit...
sebastian.sellmair [Tue, 24 Nov 2020 22:00:33 +0000 (23:00 +0100)]
ArtifactsByConfigurationModuleSetupStepTest: Remove unnecessary "testDoSetUpModuleWithCompiledJar"; AS: 2e71589

GitOrigin-RevId: 44325174da3f5467bd17f8b9ec208e74cc88b063

4 days agoArtifactsByConfigurationModuleSetupStep: Apply final patch from Yuriy Solodkyy; AS...
sebastian.sellmair [Wed, 11 Nov 2020 14:31:45 +0000 (15:31 +0100)]
ArtifactsByConfigurationModuleSetupStep: Apply final patch from Yuriy Solodkyy; AS: 2e71589

^KT-34618 fixed

GitOrigin-RevId: 9c594e6edade8959cd4ce650f8363aef951fcb3c

4 days agoreduce trove usages
Vladimir Krivosheev [Tue, 24 Nov 2020 11:12:29 +0000 (12:12 +0100)]
reduce trove usages

GitOrigin-RevId: 5a7389960f35d680592dcbb8a468fef5a90b8b32

5 days agoIDEA-254580: "AVD Manger" is not found while search in All Actions panel
Andrei Kuznetsov [Fri, 13 Nov 2020 19:35:34 +0000 (22:35 +0300)]
IDEA-254580: "AVD Manger" is not found while search in All Actions panel

For action to be searchable it should either provide default text (i.e. via super constructor) or text override for `ActionPlaces.ACTION_SEARCH` place.
Actual root cause is that there was a change in regexp (in WordPrefixMatcher::splitToWords) that splits action description text into words. Before the change one of the extracted words was "AVD", after the change it became "(AVD)", which does not match "AVD" search word anymore. Action was only searchable thanks to its description. This commit makes it searchable by its default title.

This commit adds default action name to presentation template (via `super`). Text for other places now added via `addTextOverride`, which is more declarative and compact. Action text itself moved to localization bundle. Also IDE now reports `ActionPlaces.POPUP` as a place for "run target" menu (instead of `ActionPlaces.UNKNOWN`). Fix this part also.

GitOrigin-RevId: 97f613e1f7a4a9be6d8cfbbc0df7bc6b9b690f0c

5 days agoremove unnecessary override
Alexey Kudravtsev [Mon, 23 Nov 2020 14:58:22 +0000 (17:58 +0300)]
remove unnecessary override

GitOrigin-RevId: a65a00689a5374dda90d9c8e9292974a27958d55

5 days agodo not export intellij.platform.codeStyle.impl from lang-impl, reduce trove library...
Vladimir Krivosheev [Fri, 20 Nov 2020 11:32:20 +0000 (12:32 +0100)]
do not export intellij.platform.codeStyle.impl from lang-impl, reduce trove library usage

GitOrigin-RevId: 8d1b8100f8c3e2144da8a9057273805469da4454

10 days agoreduce usages of deprecated NotNullFactory
Vladimir Krivosheev [Wed, 18 Nov 2020 10:44:07 +0000 (11:44 +0100)]
reduce usages of deprecated NotNullFactory

GitOrigin-RevId: 13aded593835b3a88e8fde8f27ea6120670279b9

10 days agofix project leak in light tests
Alexey Kudravtsev [Wed, 18 Nov 2020 16:49:40 +0000 (17:49 +0100)]
fix project leak in light tests

GitOrigin-RevId: 55251f17c86427cdeafb373eaefc841740b2768b

10 days agomove test connection to the bottom
Alexander.Kass [Tue, 17 Nov 2020 11:04:28 +0000 (14:04 +0300)]
move test connection to the bottom

GitOrigin-RevId: 4cdd890422f07da03913472af5069c6b7959bb5b

11 days agodon't use trove library
Vladimir Krivosheev [Tue, 17 Nov 2020 16:34:03 +0000 (17:34 +0100)]
don't use trove library

GitOrigin-RevId: 681dce7fd67c1c4087d160abc341bb31d0a3f1c3

11 days agocleanup - IDEA requires Java 11+
Vladimir Krivosheev [Tue, 17 Nov 2020 13:27:59 +0000 (14:27 +0100)]
cleanup - IDEA requires Java 11+

GitOrigin-RevId: badb81bc0633ca60b1ea43e9a7fde4b6b3d6be94

2 weeks agoFormat intellij.android.core.iml file correctly
Ivan Kylchik [Thu, 12 Nov 2020 20:35:20 +0000 (23:35 +0300)]
Format intellij.android.core.iml file correctly

GitOrigin-RevId: 722739b0a38c3a3fc70f8239ba6f5a002bcbdd8f

2 weeks agoCreate new module that will keep all necessary android compile dependencies
Ivan Kylchik [Thu, 5 Nov 2020 11:48:53 +0000 (14:48 +0300)]
Create new module that will keep all necessary android compile dependencies

This is a replacement for kotlin_plugin_android_compile_deps.xml

GitOrigin-RevId: 77bc180c71895b4eed8569b260f8bff7a5b4795a

2 weeks ago[workspace model] IDEA-254450 Fix backward compatibility
Mikhail Mazurkevich [Wed, 11 Nov 2020 13:36:53 +0000 (16:36 +0300)]
[workspace model] IDEA-254450 Fix backward compatibility

GitOrigin-RevId: 68e02af66feba2bbf0b3013051544076e29a81f3

2 weeks ago[workspace model] IDEA-254450 Speed up Gradle project sync at RootIndex initialization
Mikhail Mazurkevich [Tue, 10 Nov 2020 14:19:59 +0000 (17:19 +0300)]
[workspace model] IDEA-254450 Speed up Gradle project sync at RootIndex initialization

The root cause of this problem was in constant initialization of RootIndex (`RootIndex#initLibraryClassSourceRoots`)
which was canceled by started `WriteAction`.
The Main scenario which leads to the problem:
During the Gradle project synchronization `ExternalSystemModulePropertyManager#setExternalOptions` code executed and in
New Project Model it requires WriteAction. At the same time, `RootIndex` tried to be initialized under the ReadAction
(`ProgressIndicatorUtils#runActionAndCancelBeforeWrite`) and canceled due to started WriteAction. Due to the execution of
`ExternalSystemModulePropertyManager#setExternalOptions` with each module during the project synchronization, initialization of `RootIndex`
constantly failed. Incomplete initialization leads to WriteAction waiting and thus slow down project synchronization because of the long,
constant ReadAction.
This fix tries to avoid WriteAction at `ExternalSystemModulePropertyManager#setExternalOptions` by reusing existing
`IdeModifiableModelsProviderImpl#getActualStorageBuilder` instead of writing to the main store directly.
Why it was not produced with the old project model?
The old implementation didn't require WriteAction at `ExternalSystemModulePropertyManager#setExternalOptions` and theoretically,
it could lead to some sort of inconsistency.

GitOrigin-RevId: f69442f19109bccaffa82aeaf81dfbd8d1aecdad

2 weeks agoadd default implementation for FileType#getCharset
Dmitry Batkovich [Wed, 11 Nov 2020 08:01:02 +0000 (11:01 +0300)]
add default implementation for FileType#getCharset

GitOrigin-RevId: 4c83aa0b51eb1c4b28d410d101f2a771621d33fe

2 weeks agoCPP-22344: android: Move studio-grpc and friends upper in dependencies
Eldar Abusalimov [Tue, 10 Nov 2020 13:52:18 +0000 (16:52 +0300)]
CPP-22344: android: Move studio-grpc and friends upper in dependencies

Make them appear in the classpath before the platform modules bringing
the newer versions of grpc and protobuf libraries.

GitOrigin-RevId: 28f529ef9fc7cb37b1894e8364833a5509195916

2 weeks agooptional information about module context for compiler messages (IDEA-254756)
Eugene Zhuravlev [Mon, 9 Nov 2020 12:46:11 +0000 (13:46 +0100)]
optional information about module context for compiler messages (IDEA-254756)

GitOrigin-RevId: 0385f29cd062c2808371288b95af72bc82a5e480

2 weeks agoIDEA-253753: Run Targets: Turn off run targets functionality for the sub-run-configs...
Michael Golubev [Sun, 8 Nov 2020 16:56:03 +0000 (17:56 +0100)]
IDEA-253753: Run Targets: Turn off run targets functionality for the sub-run-configs of Application

- disable run targets for all configurations without `getDefaultLanguageRuntimeType`
- pull `getDefaultLanguageRuntimeType` down to JUnitConfiguration with less unintended subtypes
- explicitly disable for existing subtypes of JUnitConfiguration
- explicitly disable for quarkus (as subtype of maven run configuration)

GitOrigin-RevId: 4a88651c44576c6241cf2236c31a6edc28eeb397

3 weeks agoIDEA-250250 deprecate ImplicitPropertyUsageProvider in old package
Vladimir Krivosheev [Sat, 7 Nov 2020 07:31:20 +0000 (08:31 +0100)]
IDEA-250250 deprecate ImplicitPropertyUsageProvider in old package

GitOrigin-RevId: be5be75f80df844e82073c91c522b3e8c0c95171

3 weeks agoproperties - don't use trove and do not export impl module
Vladimir Krivosheev [Fri, 6 Nov 2020 15:04:36 +0000 (16:04 +0100)]
properties - don't use trove and do not export impl module

GitOrigin-RevId: e15d93794b4bc4f3bd9790c476679973d2ccf97a

3 weeks agoIDEA-250250 introduce package prefix for plugin to speed-up class loading and prepare...
Vladimir Krivosheev [Fri, 6 Nov 2020 13:03:22 +0000 (14:03 +0100)]
IDEA-250250 introduce package prefix for plugin to speed-up class loading and prepare migration to Java Platform Module System (split packages issue)

GitOrigin-RevId: 5a2d6d768bf784f565c49d80b989482d406e57cb

3 weeks agoremove unused trove dependency
Vladimir Krivosheev [Fri, 6 Nov 2020 07:25:24 +0000 (08:25 +0100)]
remove unused trove dependency

GitOrigin-RevId: 3bfa847a0093a3204091d2a571de2fc000c90472

3 weeks agomove "test connection" up
Alexander.Kass [Thu, 5 Nov 2020 05:19:56 +0000 (08:19 +0300)]
move "test connection" up

GitOrigin-RevId: c896f4f49249f4d7c5d7c3d38dbeff2b094ec971

3 weeks agouse `findExtension` API instead of generic find
Vladimir Krivosheev [Wed, 4 Nov 2020 10:16:58 +0000 (11:16 +0100)]
use `findExtension` API instead of generic find

GitOrigin-RevId: 191751475febc4bc889c504ae6a928b44f9e4159

3 weeks agominor grammar fixes
Gregory.Shrago [Tue, 3 Nov 2020 23:45:05 +0000 (02:45 +0300)]
minor grammar fixes

GitOrigin-RevId: c0a574ff99d09ab014d3960fe5a03cc8f79ecf7f

3 weeks agoMerge of phpstorm-stubs/master into master
intellij-monorepo-bot [Mon, 2 Nov 2020 10:54:44 +0000 (10:54 +0000)]
Merge of phpstorm-stubs/master into master

GitOrigin-RevId: b332fc7dcf8185dc064da4ae2f211b6af37e1fb5

3 weeks agoIDEA-250250 on type mismatch, report thread dump not as part of message, but as an...
Vladimir Krivosheev [Mon, 2 Nov 2020 06:41:53 +0000 (07:41 +0100)]
IDEA-250250 on type mismatch, report thread dump not as part of message, but as an attachment

GitOrigin-RevId: 587eda6c482f8223b12cc340c2de11a78e0b43e6

3 weeks agoIDEA-250250 assert that correct classloader is used for extension instance, fix class...
Vladimir Krivosheev [Sun, 1 Nov 2020 09:35:38 +0000 (10:35 +0100)]
IDEA-250250 assert that correct classloader is used for extension instance, fix classloader configuration for dynamic load (IDEA-245031)

GitOrigin-RevId: 4b5f185d5ad657df0f943dd54b0f78226113389b

4 weeks agoIDEA-245031 Extension class org.jetbrains.plugins.slim.psi.SlimRubyOuterLanguageProvi...
Vladimir Krivosheev [Wed, 28 Oct 2020 19:15:56 +0000 (20:15 +0100)]
IDEA-245031 Extension class org.jetbrains.plugins.slim.psi.SlimRubyOuterLanguageProvider does not implement class org.jetbrains.plugins.slim.SlimOuterLanguageProvider after loading plugin slim

GitOrigin-RevId: 52aaa5fc08c894d91cc71bf59ffa7a77fd22d762

4 weeks agoRevert "[platform] "what's new" page in an editor (IDEA-252636)"
Roman Shevchenko [Thu, 29 Oct 2020 10:39:52 +0000 (11:39 +0100)]
Revert "[platform] "what's new" page in an editor (IDEA-252636)"

This reverts commit 8c43ed0d

GitOrigin-RevId: da356e76fea03d39dfad4fee521dcdd05264c3a2

4 weeks ago[platform] "what's new" page in an editor (IDEA-252636)
Roman Shevchenko [Thu, 29 Oct 2020 10:34:49 +0000 (11:34 +0100)]
[platform] "what's new" page in an editor (IDEA-252636)

GitOrigin-RevId: 8c43ed0d6bf9dea45d0aa1568475a1ad24134122

4 weeks ago[i18n] don't depend on usage word in tests
Daniil Ovchinnikov [Tue, 27 Oct 2020 13:47:51 +0000 (16:47 +0300)]
[i18n] don't depend on usage word in tests

GitOrigin-RevId: de8eab61c4745ebfbdbf16ebb93323167f3327bc

4 weeks ago[platform] improving "what's new" action API
Roman Shevchenko [Tue, 27 Oct 2020 13:55:12 +0000 (14:55 +0100)]
[platform] improving "what's new" action API

(better coupling; i18n)

GitOrigin-RevId: 311aca50448b573dc02eb75fbd9c64fc79ec5bde

4 weeks agoChange default garbage collector to G1
Konstantin Bulenkov [Mon, 26 Oct 2020 18:46:53 +0000 (19:46 +0100)]
Change default garbage collector to G1

GitOrigin-RevId: 10e5e34c496725646cd402f9b036723c4aedf8b9

5 weeks agoi18n - CommitStepException # message - fix warnings in android
Michael Golubev [Sat, 24 Oct 2020 14:38:09 +0000 (16:38 +0200)]
i18n - CommitStepException # message - fix warnings in android

GitOrigin-RevId: 89ef88a82f7c90acb7d25bf54cd136dc6603ba5a

5 weeks agoIDEA-253347 move kotlin files to another module
Alexander Bubenchikov [Thu, 22 Oct 2020 20:30:47 +0000 (23:30 +0300)]
IDEA-253347 move kotlin files to another module

GitOrigin-RevId: f41746b69145f7c3c06e1a488b02c882dd78343c

5 weeks agointroduce all plugins identity set as first step to avoid linear search in isFull...
Vladimir Krivosheev [Fri, 23 Oct 2020 08:35:44 +0000 (10:35 +0200)]
introduce all plugins identity set as first step to avoid linear search in isFull method

GitOrigin-RevId: 7aaa7ab07ddc4b03d20a4807ebdc2359f639e3df

5 weeks ago[android tests] adapt IdeaSyncCachesInvalidatorTest to changes in IdeaSyncCachesInval...
Nikolay Chashnikov [Thu, 22 Oct 2020 08:55:48 +0000 (11:55 +0300)]
[android tests] adapt IdeaSyncCachesInvalidatorTest to changes in IdeaSyncCachesInvalidator (IDEA-CR-67884)

.idea/libraries folder is now deleted in Android Studio only (IDEA-253515).

GitOrigin-RevId: 20f6ac00dfd22937323377c202d1bd940022cddf

5 weeks ago[android] delete .idea/libraries folder on Invalidate Caches / Restart in Android...
Nikolay Chashnikov [Wed, 21 Oct 2020 15:40:06 +0000 (18:40 +0300)]
[android] delete .idea/libraries folder on Invalidate Caches / Restart in Android Studio only (IDEA-253515)

In IntelliJ IDEA a project may contain some modules linked to Gradle projects and also contain manually created libraries, so removal of .idea/libraries folder may lead to data loss.

GitOrigin-RevId: f112a9fc044aa6c7e956e619177e04270249db46

5 weeks agoSpecify scope for some templates they interfere actions in string literals
Anton Yalyshev [Wed, 21 Oct 2020 13:14:31 +0000 (16:14 +0300)]
Specify scope for some templates they interfere actions in string literals
^KTIJ-386 Fixed

GitOrigin-RevId: ec7bd840d23ecc34d68bb2de8ffeba188156f08a

5 weeks agocleanup, reuse PluginStateChecker
Vladimir Krivosheev [Tue, 20 Oct 2020 12:58:45 +0000 (14:58 +0200)]
cleanup, reuse PluginStateChecker

GitOrigin-RevId: 763952172c4edd93d9779af7ca5328093b119b9a

5 weeks agoKotlinAndroidGradleMPPModuleDataService: prevent dependencies on test-scoped source...
sebastian.sellmair [Thu, 15 Oct 2020 15:49:46 +0000 (17:49 +0200)]
KotlinAndroidGradleMPPModuleDataService: prevent dependencies on test-scoped source sets

#KT-42664 Fixed

GitOrigin-RevId: 4eef84f7f1f454f2f5bf845fd647fe72573c807a

5 weeks ago[android] use PropertiesComponentMock instead of pure mock in InspectorPanelTest
Nikolay Chashnikov [Tue, 20 Oct 2020 13:38:54 +0000 (16:38 +0300)]
[android] use PropertiesComponentMock instead of pure mock in InspectorPanelTest

The pure mock returns 'null' from 'getValue' method even if default value is passed, and it causes tests to fail with NullPointerException in NlPropertiesPanel.getPropertiesViewModeInitially.

GitOrigin-RevId: 0cd2e84211a51f64c908a5d1724eaecef4186115

5 weeks agoIDEA-252162 don't hold reference to icon classloader
Vladimir Krivosheev [Tue, 20 Oct 2020 09:46:55 +0000 (11:46 +0200)]
IDEA-252162 don't hold reference to icon classloader

GitOrigin-RevId: 4aec54fca6d1e5462d417b82314bad5c2f685b73

5 weeks agoIDEA-252162 regenerate icon classes
Vladimir Krivosheev [Tue, 20 Oct 2020 08:40:12 +0000 (10:40 +0200)]
IDEA-252162 regenerate icon classes

GitOrigin-RevId: b20a64c7d0832b0bc7b8a85f3a2c039e63a8e965

5 weeks agoUX-1356 get rid of usage word in usage types 203.5251 idea/203.5251.39
Daniil Ovchinnikov [Mon, 19 Oct 2020 11:15:57 +0000 (14:15 +0300)]
UX-1356 get rid of usage word in usage types

GitOrigin-RevId: aa15fba957692c297b9d2857e44827ffce4d15bd

5 weeks agodon't use deprecated StringBuilder.isEmpty()
Vladimir Krivosheev [Mon, 19 Oct 2020 19:27:28 +0000 (21:27 +0200)]
don't use deprecated StringBuilder.isEmpty()

GitOrigin-RevId: 0fedba0a3af66832d29becae953467dad2682cd6

5 weeks agoAndroidComposeAutoDocumentation - get services on demand
Vladimir Krivosheev [Mon, 19 Oct 2020 15:06:24 +0000 (17:06 +0200)]
AndroidComposeAutoDocumentation - get services on demand

GitOrigin-RevId: 5d9884c06517d37da1c59baab85f7707af8963a2

5 weeks ago[Gradle] build environment model should be obtained with correct java home option
Vladislav.Soroka [Mon, 19 Oct 2020 10:45:05 +0000 (13:45 +0300)]
[Gradle] build environment model should be obtained with correct java home option

GitOrigin-RevId: bbf936cf70f8c2e3cb4886793c2350fd3d5d2dd1

6 weeks agoIJ-CR-3416: Get default value for parallel compilation flag from intellij.yaml
Leonid Shalupov [Thu, 15 Oct 2020 15:15:23 +0000 (18:15 +0300)]
IJ-CR-3416: Get default value for parallel compilation flag from intellij.yaml

this feature removes one more item from intellij project development guide

GitOrigin-RevId: 735ba26397abb7d3a8956afb52f24027dfa10b28

6 weeks agocleanup (get rid of ServiceManager.get)
Vladimir Krivosheev [Fri, 16 Oct 2020 10:05:45 +0000 (12:05 +0200)]
cleanup (get rid of ServiceManager.get)

GitOrigin-RevId: 7f6a905353889c9795e5d40a8aa60f6251000f05

6 weeks agoHMPP support for Android targets
sebastian.sellmair [Fri, 25 Sep 2020 15:16:35 +0000 (17:16 +0200)]
HMPP support for Android targets

KT-42664 Fixed

GitOrigin-RevId: 1ead469a1566e97e4e3af2ef64058d23d9d72fd9

6 weeks agocleanup 203.4818 idea/203.4818.26 pycharm/203.4341.25
Vladimir Krivosheev [Mon, 12 Oct 2020 10:08:27 +0000 (12:08 +0200)]
cleanup

GitOrigin-RevId: 63d29224e00603b91b985bb10bffda9d87695f66

6 weeks agocleanup: annotate action event parameter NotNull to avoid yellow code
Alexey Kudravtsev [Mon, 12 Oct 2020 10:47:51 +0000 (13:47 +0300)]
cleanup: annotate action event parameter NotNull to avoid yellow code

GitOrigin-RevId: b105d069b2e306bf5fb0f0af56dae803ea1456cd

6 weeks agoMake SpeedSearchSupply.isObjectFilteredOut not abstract
Elena.Korotkova [Mon, 12 Oct 2020 11:11:05 +0000 (14:11 +0300)]
Make SpeedSearchSupply.isObjectFilteredOut not abstract

GitOrigin-RevId: 90305b8a44d17e437d3176f8047af16cca907ca1

7 weeks agoavoid concrete classes *OpenHashMap, use interface instead
Alexey Kudravtsev [Wed, 7 Oct 2020 13:33:02 +0000 (15:33 +0200)]
avoid concrete classes *OpenHashMap, use interface instead

GitOrigin-RevId: 6ff337729564d9ce1227231125d4fef83f49d69f

7 weeks agoFix speed search filter
Elena.Korotkova [Wed, 7 Oct 2020 08:31:44 +0000 (11:31 +0300)]
Fix speed search filter

GitOrigin-RevId: 72c77c1f6508891aea7702b165acabb3ef2aedb1

7 weeks agofix GotoDatabaseFolder icon reference
Vladimir Krivosheev [Wed, 7 Oct 2020 09:03:56 +0000 (11:03 +0200)]
fix GotoDatabaseFolder icon reference

GitOrigin-RevId: 3a26cc7a4d261f5c7ef5d339f4fbe17ff5301407

7 weeks agocleanup - final, move runInAllowSaveMode to appropriate package (to reduce number...
Vladimir Krivosheev [Tue, 6 Oct 2020 12:33:45 +0000 (14:33 +0200)]
cleanup - final, move runInAllowSaveMode to appropriate package (to reduce number of top-level kotlin functions)

GitOrigin-RevId: 67b9004e51912336330830abc01cc1f8be291761

7 weeks agodo not create ActionManager without a reason
Vladimir Krivosheev [Tue, 6 Oct 2020 19:23:36 +0000 (21:23 +0200)]
do not create ActionManager without a reason

GitOrigin-RevId: e80a047dbcdfd2e5f3a77502fe12d54459ee1957

7 weeks agoby default treat FileType as not read-only to reduce number of unnecessarily hidden...
Alexey Kudravtsev [Tue, 6 Oct 2020 14:04:44 +0000 (17:04 +0300)]
by default treat FileType as not read-only to reduce number of unnecessarily hidden file types by mistake

GitOrigin-RevId: 5c4b3b7f6bf53c6e5ad639feeaef0d204ef64291

7 weeks agoRemove deprecated method 203.4449 idea/203.4449.2 pycharm/203.4449.8
Sergey Malenkov [Mon, 5 Oct 2020 15:10:24 +0000 (18:10 +0300)]
Remove deprecated method

GitOrigin-RevId: 213a9ec8a57dbd2582795671bf377232dc561ff3

8 weeks agoIDEA-CR-67306 [profiler] move magic to field and use in desired content prefix length 203.4341
maksim.pelevin [Thu, 1 Oct 2020 19:26:59 +0000 (22:26 +0300)]
IDEA-CR-67306 [profiler] move magic to field and use in desired content prefix length

GitOrigin-RevId: 08c3ee02a1a8bc81e0dad2aa6d76f0089d792685

8 weeks agoIDEA-196499 Run Configurations not viewable while indexing
Elena Shaverdova [Tue, 4 Aug 2020 19:00:15 +0000 (22:00 +0300)]
IDEA-196499 Run Configurations not viewable while indexing

GitOrigin-RevId: 24680273eeb5b98baf41d5ef766c6efc2e425328

8 weeks ago[profiler] accept only Android CPU and Memory dumps in AndroidProfilerCaptureEditorPr...
maksim.pelevin [Thu, 1 Oct 2020 14:24:19 +0000 (17:24 +0300)]
[profiler] accept only Android CPU and Memory dumps in AndroidProfilerCaptureEditorProvider

GitOrigin-RevId: c211a4d13d8776506cff1158b246d997546abaaf

8 weeks ago[profiler] check Android HPROF only file with magic "JAVA PROFILE 1.0.3"
maksim.pelevin [Thu, 1 Oct 2020 08:29:08 +0000 (11:29 +0300)]
[profiler] check Android HPROF only file with magic "JAVA PROFILE 1.0.3"

Ignore all other Java HPROF files (with magics "JAVA PROFILE 1.0.1" and "JAVA PROFILE 1.0.2").

GitOrigin-RevId: e55cabbf381a1af45a610cf4b4b4293407fa5c5b

8 weeks ago[profiler] let MemoryCaptureFileType and CpuCaptureFileType be visible in "File Types...
maksim.pelevin [Thu, 1 Oct 2020 08:15:40 +0000 (11:15 +0300)]
[profiler] let MemoryCaptureFileType and CpuCaptureFileType be visible in "File Types" in settings

GitOrigin-RevId: 107a06ed5d3bf6bea6d5ae72f238f3b69f23c8ca

8 weeks agocleanup
Vladimir Krivosheev [Wed, 30 Sep 2020 11:26:01 +0000 (13:26 +0200)]
cleanup

GitOrigin-RevId: c2aabc41203d348c12947946b639b6ed4c70760b

8 weeks agorewrite BindingXmlIndex as SingleEntryFileBasedIndexExtension to make it shareable...
Dmitry Batkovich [Wed, 30 Sep 2020 08:06:10 +0000 (11:06 +0300)]
rewrite BindingXmlIndex as SingleEntryFileBasedIndexExtension to make it shareable IDEA-251695

GitOrigin-RevId: bb14feda3f4d2a40c8306b75023e6b78bce336c1

8 weeks agoremove redundant toString()
Dmitry Batkovich [Wed, 30 Sep 2020 07:17:17 +0000 (10:17 +0300)]
remove redundant toString()

GitOrigin-RevId: c0f4277d9ed058cd12bb79c694bc8d8ba227929e

2 months agotest for FileType constructor to be non-public to avoid duplicates and double instant... 203.4203 idea/203.4203.26
Alexey Kudravtsev [Fri, 25 Sep 2020 13:10:42 +0000 (15:10 +0200)]
test for FileType constructor to be non-public to avoid duplicates and double instantiation because file types must be singletons

GitOrigin-RevId: d448ee007d87edbaf095f8fbe7e1b51ce8c7d9bc

2 months agofix NCDFE
Alexander Bubenchikov [Fri, 25 Sep 2020 20:26:48 +0000 (23:26 +0300)]
fix NCDFE

GitOrigin-RevId: b5f277a469a0b2aacb7d3fa26b87c0928a808b8a

2 months agoIDEA-251219 fix rasterized prebuilt cache for dark theme
Vladimir Krivosheev [Fri, 25 Sep 2020 12:55:01 +0000 (14:55 +0200)]
IDEA-251219 fix rasterized prebuilt cache for dark theme

GitOrigin-RevId: 0228a057302b1d952da4870eb76d157e746c1366

2 months agoIDEA-247486 - review fixes
Alexander Bubenchikov [Thu, 24 Sep 2020 14:10:27 +0000 (17:10 +0300)]
IDEA-247486 - review fixes

GitOrigin-RevId: 1662e75a457bfd0d15697c3da61e18770792ad46

2 months agoIDEA-247486 move crash reporting about DSL issues into service
Alexander Bubenchikov [Mon, 21 Sep 2020 15:12:01 +0000 (18:12 +0300)]
IDEA-247486 move  crash reporting about DSL issues into service

GitOrigin-RevId: 25676d92678b89bc6edf3b7e75775d26ef01d7f9

2 months agoIDEA-247486 move addGoogleMavenRepository to extension method
Alexander Bubenchikov [Mon, 21 Sep 2020 13:08:18 +0000 (16:08 +0300)]
IDEA-247486 move addGoogleMavenRepository to extension method

GitOrigin-RevId: 1cbb5e1bb9a0d95fafc994dfae20b187defc0b10

2 months agoIDEA-247486 move testData to gradle.dsl.impl plugin
Alexander Bubenchikov [Wed, 16 Sep 2020 10:27:55 +0000 (13:27 +0300)]
IDEA-247486 move testData to gradle.dsl.impl plugin

GitOrigin-RevId: 517c77731ff3f2ed30a1c7f9427b8a38725a32db

2 months agoIDEA-247486 ProjectBuildModelHandlerTest fixed
Alexander Bubenchikov [Tue, 8 Sep 2020 09:28:52 +0000 (12:28 +0300)]
IDEA-247486 ProjectBuildModelHandlerTest fixed

GitOrigin-RevId: ab64e489fed51c3487eec66f07fd1febaadeb051

2 months agoIDEA-247486 gradle dsl - remove dependency on gradle-common
Alexander Bubenchikov [Mon, 7 Sep 2020 14:46:36 +0000 (17:46 +0300)]
IDEA-247486 gradle dsl - remove dependency on gradle-common

GitOrigin-RevId: dee5c17da3b9bcd658941620750724709c6a9f5c

2 months agoIDEA-247486 move gradle-dsl out of android
Alexander Bubenchikov [Fri, 4 Sep 2020 13:18:12 +0000 (16:18 +0300)]
IDEA-247486 move gradle-dsl out of android

GitOrigin-RevId: 4c7deb2ef967e3ee8ab58655e31e6e920252f298

2 months agoIDEA-247486 rename android-dsl modules to gradle-dsl
Alexander Bubenchikov [Thu, 3 Sep 2020 12:12:01 +0000 (15:12 +0300)]
IDEA-247486 rename android-dsl modules to gradle-dsl

GitOrigin-RevId: 856697c76884b758b8f31a1a9f27446e27f92c2d

2 months agoIDEA-247486 gradle dsl - fix service implementation
Alexander Bubenchikov [Tue, 1 Sep 2020 09:49:52 +0000 (12:49 +0300)]
IDEA-247486 gradle dsl - fix service implementation

GitOrigin-RevId: d14ed4be6deca4f3eb1c72bdd0d3ac5ac85deabc

2 months agoIDEA-247486 gradle dsl - fix test compilation errors
Alexander Bubenchikov [Mon, 31 Aug 2020 17:13:34 +0000 (20:13 +0300)]
IDEA-247486 gradle dsl - fix test compilation errors

GitOrigin-RevId: 1e92ac9e3e54474a31debf0a0d56e13332fde344

2 months agoIDEA-247486 gradle-dsl classpath fixes
Alexander Bubenchikov [Tue, 25 Aug 2020 15:48:21 +0000 (18:48 +0300)]
IDEA-247486 gradle-dsl classpath fixes

GitOrigin-RevId: 0fc76020f7933cfc3183145ae8398c3d609e03cf

2 months agoIDEA-247486 gradle-dsl-refactoring
Alexander Bubenchikov [Mon, 24 Aug 2020 17:25:31 +0000 (20:25 +0300)]
IDEA-247486 gradle-dsl-refactoring

GitOrigin-RevId: f0e1d91c63336eca1969fcbd15746164d3696f81

2 months agoIDEA-251207 Set of plugins cannot be unloaded because of IconLoader
Vladimir Krivosheev [Tue, 22 Sep 2020 18:07:48 +0000 (20:07 +0200)]
IDEA-251207 Set of plugins cannot be unloaded because of IconLoader

GitOrigin-RevId: 441b875462f12fe0d20d3830181e6280e3b829ba

2 months agoregenerate android icons
Vladimir Krivosheev [Wed, 23 Sep 2020 14:05:34 +0000 (16:05 +0200)]
regenerate android icons

GitOrigin-RevId: 399cb69d219f9e2ba18ca6b9fc964e8e27d31aa6

2 months agoremove outdated android@2x.png file
Vladimir Krivosheev [Wed, 23 Sep 2020 05:59:20 +0000 (07:59 +0200)]
remove outdated android@2x.png file

GitOrigin-RevId: af0e0e2376d4f917907a1a1c7ec1e861da5d74c6

2 months agocleanup (don't use deprecated method: scale -> scaleIcon)
Vladimir Krivosheev [Wed, 23 Sep 2020 05:21:20 +0000 (07:21 +0200)]
cleanup (don't use deprecated method: scale -> scaleIcon)

GitOrigin-RevId: d67bf091a1fbf601d7dfa3df376815f7821bbbe3

2 months agounify some "Results might be incomplete during indexing" messages, fix grammar in...
Peter Gromov [Thu, 24 Sep 2020 14:03:38 +0000 (16:03 +0200)]
unify some "Results might be incomplete during indexing" messages, fix grammar in related places

GitOrigin-RevId: f4f31dcadaf1945f950fe267e3def63ca623464c

2 months agoIDEA-249422: Android: make descriptors non-empty to enable dynamic unloading of layou...
Andrei Kuznetsov [Wed, 23 Sep 2020 15:37:08 +0000 (18:37 +0300)]
IDEA-249422: Android: make descriptors non-empty to enable dynamic unloading of layoutlib-native/standard plugins

When descriptor is empty, com.intellij.ide.plugins.cl.PluginClassLoader.detachParent never invoked for android plugin, and classloader for layoutlib-xxx leaks, preventing layoutlib-xxx plugin from being unloaded

GitOrigin-RevId: ae5361439c1c1335ae9682b5ddfef2b39092495f

2 months agoremove incorrect icon file `tutorialIndiator_dark@2x.png` — not used (typo in the...
Vladimir Krivosheev [Tue, 22 Sep 2020 08:36:48 +0000 (10:36 +0200)]
remove incorrect icon file `tutorialIndiator_dark@2x.png` — not used (typo in the name), do not use file name convention `_dark@2x` — use IJ convention instead (should be `@2x_dark`)

GitOrigin-RevId: 93cc27abf51709e2d178036da330f2308f9dc8fd

2 months agoicon cache using db instead of using module jar
Vladimir Krivosheev [Sat, 8 Aug 2020 07:37:27 +0000 (09:37 +0200)]
icon cache using db instead of using module jar

GitOrigin-RevId: 98995cafb9f72017dd71715052c685ba70c01646

2 months agoplatform.core.impl — remove dependency on intellij.platform.util.ui and intellij...
Vladimir Krivosheev [Tue, 15 Sep 2020 14:41:21 +0000 (16:41 +0200)]
platform.core.impl — remove dependency on intellij.platform.util.ui and intellij.platform.core.ui
java.psi.iml — remove dependency on intellij.platform.core.ui

GitOrigin-RevId: c1d4feb04c0471c7d17b5331b86738ee54a97f80